paperchalice added a comment.
Could you help me commit this change? Because I don't have permission. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116853/new/
https://reviews.llvm.org/D116853
___
lldb-commits mailing list
kastiglione added inline comments.
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:128
+ // __cc is a field of __hash_value_type, which is a typedef.
+ if (name == "__cc")
+m_element_type =
kastiglione updated this revision to Diff 400234.
kastiglione added a comment.
Herald added a subscriber: JDevlieghere.
some tabs snuck in
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117383/new/
https://reviews.llvm.org/D117383
Files:
kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Change the behavior of the libc++ `unordered_map` synthetic provider to present
children as `std::pair`
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117074/new/
https://reviews.llvm.org/D117074
mib updated this revision to Diff 400202.
mib marked an inline comment as done.
mib added a comment.
Remove dead-code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117074/new/
https://reviews.llvm.org/D117074
Files:
mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch changes the `ScriptedInterface::ErrorWithMessage` method to
make it `static` which makes it easier to call.
The
mib updated this revision to Diff 400194.
mib edited the summary of this revision.
mib added a reviewer: labath.
mib set the repository for this revision to rG LLVM Github Monorepo.
mib added a comment.
Changed the implementation to defer constructing the `ScriptedThread` until we
have a valid
Author: Med Ismail Bennani
Date: 2022-01-14T16:23:26-08:00
New Revision: 258cd02c6a7aa71945a89b8d0d07e1eac49b5868
URL:
https://github.com/llvm/llvm-project/commit/258cd02c6a7aa71945a89b8d0d07e1eac49b5868
DIFF:
Author: Jonas Devlieghere
Date: 2022-01-14T16:19:16-08:00
New Revision: a10692c734faff9ef28bc725703a0eacea78eeca
URL:
https://github.com/llvm/llvm-project/commit/a10692c734faff9ef28bc725703a0eacea78eeca
DIFF:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8faca2ed6ade: [lldb] Fix platform selection on Apple Silicon
(authored by JDevlieghere).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
Author: Jonas Devlieghere
Date: 2022-01-14T16:03:49-08:00
New Revision: 8faca2ed6adebffa76c6eb506f15dfd38ab512a7
URL:
https://github.com/llvm/llvm-project/commit/8faca2ed6adebffa76c6eb506f15dfd38ab512a7
DIFF:
clayborg added a comment.
Thanks for doing this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117237/new/
https://reviews.llvm.org/D117237
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
mib updated this revision to Diff 400148.
mib marked an inline comment as done.
mib added a comment.
Address @labath feedbacks:
- Pass `StructuredData::Generic *script_object` to
`ScriptedInterface::CreatePluginObject`.
- `IncRef` the borrowed reference to make it an owned reference.
Author: Muhammad Omair Javaid
Date: 2022-01-15T03:24:26+05:00
New Revision: df13239c1177c1c73fcd3422023f9d1224f57545
URL:
https://github.com/llvm/llvm-project/commit/df13239c1177c1c73fcd3422023f9d1224f57545
DIFF:
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:177
lldb::break_id_t break_id;
+lldb::break_id_t break_loc_id;
data_dict->GetValueForKeyAsInteger("break_id", break_id,
This seems unused?
labath added inline comments.
Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:49
+ void *instance_obj = nullptr;
+ if (script_object)
mib wrote:
> labath wrote:
> > This is when things start to get fuzzy, as this function seems to support
ljmf00 added a comment.
Ping @shafik @bulbazord . Can you re-review?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114668/new/
https://reviews.llvm.org/D114668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1dab5f6c83a7: [LLDB][NFC] Fix a typo in comment (authored by
CoelacanthusHex).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117288/new/
Author: Coelacanthus
Date: 2022-01-14T22:01:18+08:00
New Revision: 1dab5f6c83a7745852743a39809ff6115159ed1d
URL:
https://github.com/llvm/llvm-project/commit/1dab5f6c83a7745852743a39809ff6115159ed1d
DIFF:
https://github.com/llvm/llvm-project/commit/1dab5f6c83a7745852743a39809ff6115159ed1d.diff
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117288/new/
https://reviews.llvm.org/D117288
DavidSpickett created this revision.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This removes the non-address bits before we try to use
the addresses.
Meaning that when results are shown, those results won't
show
Author: Muhammad Omair Javaid
Date: 2022-01-14T15:46:54+05:00
New Revision: 3dc858f9847d1c2dc02e92ad703060b1bfa90ad0
URL:
https://github.com/llvm/llvm-project/commit/3dc858f9847d1c2dc02e92ad703060b1bfa90ad0
DIFF:
CoelacanthusHex created this revision.
CoelacanthusHex requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
fix typo in comment: libcstd++ -> libstdc++
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D117288
Files:
24 matches
Mail list logo
