[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib updated this revision to Diff 410449. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284 Files: lldb/test/API/functionalities/progress_reporting/TestProgressReporting.py Index:

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Could you add a little test to exercise the command ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

jasonmolenda added a comment. Nice. tbh when I'm SB API scripting, I am often sitting in include/lldb/API and grepping for keywords, because I can't remember exactly which class provides the API, or what arguments it takes or whatever. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 14101f4 - [LLDB] Remove recursive include of GDBRemoteCommunicationServerCommon.h

Author: Shafik Yaghmour Date: 2022-02-21T18:46:12-08:00 New Revision: 14101f48d205b6cbf65b28c469d898e90e3995d2 URL: https://github.com/llvm/llvm-project/commit/14101f48d205b6cbf65b28c469d898e90e3995d2 DIFF:

[Lldb-commits] [PATCH] D120105: Remove recursive include of GDBRemoteCommunicationServerCommon.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG14101f48d205: [LLDB] Remove recursive include of GDBRemoteCommunicationServerCommon.h (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

kastiglione created this revision. kastiglione added reviewers: mib, JDevlieghere, jasonmolenda. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `lldb.find()`, a function for interactive lookup and discovery of SB API.

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

JDevlieghere added a comment. Assuming all issues have been fixed, can you add this clang-tidy check to the `.clang-tidy` file in the root of the repository? That should make it less likely this regresses again in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib marked 3 inline comments as done. mib added a comment. @labath I addressed your comments in D120284 :) Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t&

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib created this revision. mib added a reviewer: labath. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a follow-up of D120100 to address some

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere updated this revision to Diff 410326. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - Allow using `%0` - Return an error when using an out of range index CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/

[Lldb-commits] [PATCH] D119915: Replace use of double underscore in identifiers

aprantl added a comment. Herald added a subscriber: JDevlieghere. Nice. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:261 if (m_pair_ptr) { - auto __i_(valobj_sp->GetChildMemberWithName(g___i_, true)); + auto

[Lldb-commits] [PATCH] D120105: Remove recursive include of GDBRemoteCommunicationServerCommon.h

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is funny. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120105/new/ https://reviews.llvm.org/D120105 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

aprantl added a comment. This looks amazing! Thanks, Pavel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119167/new/ https://reviews.llvm.org/D119167 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

labath added inline comments. Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t& INOUT { uint64_t& completed }; +%apply uint64_t& INOUT { uint64_t& total }; +%apply bool& INOUT { bool&

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3334776 , @labath wrote: > Do you need someone to commit this for you? (I can probably do that tomorrow) Yes, that would be nice. I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] ab28488 - [C++20][Modules][1/8] Track valid import state.

Author: Iain Sandoe Date: 2022-02-21T09:09:37Z New Revision: ab28488efe6de6f8fa856a1dfd8c0320d41d7608 URL: https://github.com/llvm/llvm-project/commit/ab28488efe6de6f8fa856a1dfd8c0320d41d7608 DIFF: https://github.com/llvm/llvm-project/commit/ab28488efe6de6f8fa856a1dfd8c0320d41d7608.diff LOG:

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/bindings/interface/SBDebugger.i:126-129 +%apply uint64_t& INOUT { uint64_t& progress_id }; +%apply uint64_t& INOUT { uint64_t& completed }; +%apply uint64_t& INOUT { uint64_t& total };