[Lldb-commits] [lldb] 0aaf480 - [lldb] Cleanup MacOSX platform headers (NFC)

Author: Jonas Devlieghere Date: 2022-03-14T22:01:05-07:00 New Revision: 0aaf480be955718c0be99dc14a71b668bf15def0 URL: https://github.com/llvm/llvm-project/commit/0aaf480be955718c0be99dc14a71b668bf15def0 DIFF:

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415283. JDevlieghere added a comment. Address code review: - Decentralize tracking whether a warning/error has been emitted. - Support diagnostics that are not tied to a single debugger. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere updated this revision to Diff 415272. JDevlieghere added a comment. Update unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121537/new/ https://reviews.llvm.org/D121537 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editline.h

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere updated this revision to Diff 415270. JDevlieghere added a comment. Use the IOHandler's mutex in editline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121537/new/ https://reviews.llvm.org/D121537 Files: lldb/include/lldb/Core/IOHandler.h

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 415252. yinghuitan added a comment. Remove duplicate file and fix wrapping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files:

[Lldb-commits] [lldb] 33f9fc7 - Don't report memory return values on MacOS_arm64 of SysV_arm64 ABI's.

Author: Jim Ingham Date: 2022-03-14T15:25:40-07:00 New Revision: 33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e URL: https://github.com/llvm/llvm-project/commit/33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e DIFF: https://github.com/llvm/llvm-project/commit/33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e.diff

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rG33f9fc77d1ff: Dont report memory return values on MacOS_arm64 of SysV_arm64 ABIs. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

jingham added a comment. This sort of change needs to do a lot more work to help the user understand what they can and can't see if they accept the speed for visibility tradeoff. They (and we) also need to know what operations might trigger a full "hydration" of a symbol table. It isn't

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

clayborg added a comment. I have been working with Jeffrey on this feature and wanted to explain our thoughts a bit. We wanted to solve the issue of having too much debug information in your project and having debugging being slowed down by all of this information. Much of this information is

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1; labath wrote: > Would it be possible to put

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

zequanwu updated this revision to Diff 415213. zequanwu added a comment. Testing with `image lookup -type` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121030/new/ https://reviews.llvm.org/D121030 Files:

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415211. JDevlieghere added a comment. Fix typo(s) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125 def getPlatform(): """Returns the target platform which the tests are

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415204. JDevlieghere added a comment. Herald added a subscriber: mgorny. Add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121481: Applying clang-tidy modernize-use-default-member-init over LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG28c878aeb29a: [LLDB] Applying clang-tidy modernize-use-default-member-init over LLDB (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 28c878a - [LLDB] Applying clang-tidy modernize-use-default-member-init over LLDB

Author: Shafik Yaghmour Date: 2022-03-14T13:32:03-07:00 New Revision: 28c878aeb29a7e7a9ae8f748de6a3c41482b97be URL: https://github.com/llvm/llvm-project/commit/28c878aeb29a7e7a9ae8f748de6a3c41482b97be DIFF:

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde487e54782: [lldb] Plumb process host architecture through platform selection (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] dde487e - [lldb] Plumb process host architecture through platform selection

Author: Jonas Devlieghere Date: 2022-03-14T12:17:01-07:00 New Revision: dde487e54782feb873461e7f8781a098df4f69b0 URL: https://github.com/llvm/llvm-project/commit/dde487e54782feb873461e7f8781a098df4f69b0 DIFF:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 415183. yinghuitan added a comment. Herald added a subscriber: JDevlieghere. Fix tests line number change after formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc63ae42d772: [VFS] Rename `RedirectingFileSystem::dump` to `print` (authored by bnbarham). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] cc63ae4 - [VFS] Rename `RedirectingFileSystem::dump` to `print`

Author: Ben Barham Date: 2022-03-14T11:44:07-07:00 New Revision: cc63ae42d77200ed85dd0d57f1d5c5800a67683c URL: https://github.com/llvm/llvm-project/commit/cc63ae42d77200ed85dd0d57f1d5c5800a67683c DIFF: https://github.com/llvm/llvm-project/commit/cc63ae42d77200ed85dd0d57f1d5c5800a67683c.diff

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan created this revision. yinghuitan added reviewers: clayborg, aadsm, jingham. Herald added subscribers: arphaman, mgorny. Herald added a project: All. yinghuitan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1.

[Lldb-commits] [lldb] b0a76b0 - [lldb] Fix the Windows build after D121536

Author: Jonas Devlieghere Date: 2022-03-14T11:22:21-07:00 New Revision: b0a76b016219fb6ff878eca5a986799506c98053 URL: https://github.com/llvm/llvm-project/commit/b0a76b016219fb6ff878eca5a986799506c98053 DIFF:

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's asynchronous output stream for writing progress events.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc231deb79167: [lldb] Use the debuggers asynchronous output stream for progress events. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] c231deb - [lldb] Use the debugger's asynchronous output stream for progress events.

Author: Jonas Devlieghere Date: 2022-03-14T10:31:22-07:00 New Revision: c231deb791672720cf1935150b99e6deffaf4843 URL: https://github.com/llvm/llvm-project/commit/c231deb791672720cf1935150b99e6deffaf4843 DIFF:

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham marked an inline comment as done. bnbarham added inline comments. Comment at: llvm/include/llvm/Support/Error.h:1284 - StringRef getFileName() { return FileName; } + StringRef getFileName() const { return FileName; } dexonsmith wrote: > bnbarham

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

dexonsmith added a comment. > Includes two test fixes (since chained mappings are no longer allowed) > and adds a new test for multiple overlays. Are we sure no one needs to support chained mappings? Has there been a ~~clang-dev~~ discourse discussion about it already? Just concerned that some

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham added a comment. In D121426#3376442 , @dexonsmith wrote: >> Includes two test fixes (since chained mappings are no longer allowed) >> and adds a new test for multiple overlays. > > Are we sure no one needs to support chained mappings? Has there

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

This revision was automatically updated to reflect the committed changes. Closed by commit rG2436c5703e6a: [lldb] Use the IOHandlers stream instead of the debuggers in PrintAsync (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 2436c57 - [lldb] Use the IOHandler's stream instead of the debugger's in PrintAsync

Author: Jonas Devlieghere Date: 2022-03-14T10:11:50-07:00 New Revision: 2436c5703e6a33be1d002d3acebc6cbc1bfe678e URL: https://github.com/llvm/llvm-project/commit/2436c5703e6a33be1d002d3acebc6cbc1bfe678e DIFF:

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere added a comment. In D121484#3379564 , @labath wrote: > In D121484#3379532 , @JDevlieghere > wrote: > >> In D121484#3378923 , @labath wrote: >> >>> I'm not

[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

labath added a comment. Sorry about the delay. Here's the version which switches to reverse connect everywhere. Please try it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117559/new/ https://reviews.llvm.org/D117559

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

labath updated this revision to Diff 415120. labath added a comment. Herald added a project: All. Remove just the forward-connect logic instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117559/new/ https://reviews.llvm.org/D117559 Files:

[Lldb-commits] [lldb] 8bd1988 - [lldb] Skip Test11588 on Windows

Author: Stella Stamenova Date: 2022-03-14T09:26:41-07:00 New Revision: 8bd1988e74f212f65de21e25c9e44b42a4b97bd9 URL: https://github.com/llvm/llvm-project/commit/8bd1988e74f212f65de21e25c9e44b42a4b97bd9 DIFF:

[Lldb-commits] [PATCH] D121506: [lldb] Move ProgressEventData out of debugger and into its own file (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e65e79bace6: [lldb] Move ProgressEventData out of debugger and into its own file (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [lldb] 5e65e79 - [lldb] Move ProgressEventData out of debugger and into its own file (NFC)

Author: Jonas Devlieghere Date: 2022-03-14T09:24:17-07:00 New Revision: 5e65e79bace6127da493de1445161f1179e4e47f URL: https://github.com/llvm/llvm-project/commit/5e65e79bace6127da493de1445161f1179e4e47f DIFF:

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125 def getPlatform(): """Returns the target platform which the tests are running on.""" I'm not sure if this will work for all apple platforms. Can I

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

labath added a comment. In D121484#3379532 , @JDevlieghere wrote: > In D121484#3378923 , @labath wrote: > >> I'm not sure what would be a good way to denote that the new argument >> represents the architecture

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere added a comment. In D121484#3378923 , @labath wrote: > I'm not sure what would be a good way to denote that the new argument > represents the architecture of the host running the debugged process, and not > the one running lldb. This isn't

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

labath created this revision. labath added reviewers: JDevlieghere, jingham, clayborg. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The decision which categories are relevant for a particular test run happen very early in the test setup

[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd506a9ef2b32: [lldb] Require native for command-thread-siginfo.test (authored by asahay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121487/new/

[Lldb-commits] [lldb] d506a9e - [lldb] Require native for command-thread-siginfo.test

Author: Ayush Sahay Date: 2022-03-14T21:20:21+05:30 New Revision: d506a9ef2b3216879bec182be67590eddac27685 URL: https://github.com/llvm/llvm-project/commit/d506a9ef2b3216879bec182be67590eddac27685 DIFF: https://github.com/llvm/llvm-project/commit/d506a9ef2b3216879bec182be67590eddac27685.diff

[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test

mgorny accepted this revision. mgorny added a comment. Thanks for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121487/new/ https://reviews.llvm.org/D121487 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. I don't suppose we could have a (gdb-client?) test for some of this stuff? Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:158 +// tell them apart and mark the host platform as compatible or not. +if (host_arch.IsValid()) { +

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm not sure what would be a good way to denote that the new argument represents the architecture of the host running the debugged process, and not the one running lldb. This isn't helped by

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

labath added a comment. It seems to me that it would be better to decentralize the warning tracking. Also due to a central list of all possible warnings not being modular, but mainly because I can imagine that some warnings may want to be reported with different "scopes" -- once per target,

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

labath added a comment. In D121500#3377434 , @JDevlieghere wrote: > In D121500#3377321 , @labath wrote: > >> Are you sure we don't want to handle this at a higher level? The way I >> understand it, the main

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

labath added a comment. (I suspect this has something to do with the ability to override the output of a particular iohandler in the stack. The idea may have been that the iohandler prints whereever it prints, but the asynchronous output always goes to the main output. But I don't know if we

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > In that context it didn't make much sense (to me) that this is using the > debugger's output and error stream rather than the one from the IOHandler. I don't know why this is set up the way

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

labath added a comment. That is roughly what I had in mind, *but* if you look inside `Editline` class, you'll see that it already declares a `std::mutex m_output_mutex` variable. It was introduced for the same reason as this mutex here, although it only controls stdout access during command

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

labath accepted this revision. labath added a comment. In D121348#3373396 , @jingham wrote: > In D121348#3373170 , @labath wrote: > >> I don't think this is a peculiarity of the darwin ABI. I'm pretty sure i've

[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, although I would be surprised if this was the only test which suffered from the same problem. Another possibility would be to make the %clang_host substitution smarter and have

[Lldb-commits] [PATCH] D121481: Applying clang-tidy modernize-use-default-member-init over LLDB

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121481/new/ https://reviews.llvm.org/D121481 ___ lldb-commits mailing list