[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test

int3 added a comment. The underlying test is still using just ld64 though. I think a proper fix be to use LLD if it's available as the host linker? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568

[Lldb-commits] [PATCH] D122621: Add missing case `HLSL` to `ParseLangArgs` in `TypeSystemClang.cpp`

frgossen created this revision. frgossen added a reviewer: beanz. Herald added a project: All. frgossen requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122621 Files:

[Lldb-commits] [lldb] 42d3d71 - Silence compiler warning after the addition of HLSL to Clang

Author: Benjamin Kramer Date: 2022-03-29T01:23:20+02:00 New Revision: 42d3d717b8140cb0ef2169d1ac25f0f166cd61bf URL: https://github.com/llvm/llvm-project/commit/42d3d717b8140cb0ef2169d1ac25f0f166cd61bf DIFF:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 418708. yinghuitan added a comment. Fix log channel typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 418680. wallace added a comment. - Bring back the --continue command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:94-96 + auto last_ts = m_instruction_timestamps[m_instruction_timestamps.size() - 1]; + if

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:2201 +// command +if (cmd.find(" repeat") == std::string::npos) + cmd += " repeat"; This " repeat" is pretty hacky here. If we can't get away without adding

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

wallace added a comment. let's better use the word TSC instead of timestamps, which is more accurate Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:124 + /// Append a successfully decoded instruction. + void AppendInstruction(pt_insn instruction); +

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn updated this revision to Diff 418660. zrthxn added a comment. Update cursor timestamp when we have a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files:

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122603 Files:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 418632. yinghuitan added a comment. Add documentation for the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. In D100581#3404624 , @xbolva00 wrote: > @mbenfield found false positive > > void test(void) { > static int counter = 0; > counter += 5; > } posted https://reviews.llvm.org/D122374 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D122461: [lldb] Add a fuzzer for target create

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG61efe14e21b2: [lldb] Add a fuzzer for target creation (authored by JDevlieghere). Herald added projects: LLDB, LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. Herald added subscribers: pcwang-thead, luke957. Herald added a project: All. @mbenfield found false positive void test(void) { static int counter = 0; counter += 5; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3400810 , @SimplyDanny wrote: > @tonic, can you please have another look? If @tonic has any additional feedback, we can handle it post-commit at this point. I've gone ahead and committed this on your behalf in

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. @tonic, can you please have another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

labath added a comment. In D122411#3408204 , @DavidSpickett wrote: > - Corefile down to 24k with some tweaking of coredump_filter 24k is pretty good. At this point, if you wanted to go down further, you'd probably have to ditch libc, which may not be

[Lldb-commits] [PATCH] D121999: [lldb][AArch64] Update disassembler feature list and add tests for all extensions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Wow. It sounds like we should figure out a way to enable all extensions with a single stroke. Otherwise, this will be an endless cat-and-mouse. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 3631b90 - [lldb] Remove some unused functions from PosixApi.h

Author: Pavel Labath Date: 2022-03-28T15:14:19+02:00 New Revision: 3631b9014d4f9289219a0091ea4ebd635d7a517f URL: https://github.com/llvm/llvm-project/commit/3631b9014d4f9289219a0091ea4ebd635d7a517f DIFF: https://github.com/llvm/llvm-project/commit/3631b9014d4f9289219a0091ea4ebd635d7a517f.diff

[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test

fanquake created this revision. fanquake added a reviewer: lld-macho. Herald added a subscriber: mgrang. Herald added a project: All. fanquake requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since https://reviews.llvm.org/D103446, lld now

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. Herald added a project: All. Sorry for the very late response. I looked into using the `CompilerDeclContext()`. This does not work in this case because the context is not set in this specific use case and I'm not sure if it case be set. It is initialized with an

[Lldb-commits] [lldb] 5c6ee13 - [LLDB] Skip TestProcessIOHandlerInterrupt Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2022-03-28T12:32:49+05:00 New Revision: 5c6ee1305e771bd40b523b4de4df8bffaa2e98ad URL: https://github.com/llvm/llvm-project/commit/5c6ee1305e771bd40b523b4de4df8bffaa2e98ad DIFF: