[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 425936. wallace added a comment. I made a mistake and I included the second of two commits. This update contains all the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu added inline comments. Comment at: lldb/include/lldb/Symbol/UnwindPlan.h:266 + int32_t GetRaSearchOffset() const { +return m_type == isRaSearch ? m_value.ra_search.search_offset & ~1 : 0; + } zequanwu wrote: > clayborg wrote: > > Are

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

wallace created this revision. wallace added a reviewer: jj10306. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm refactoring IntelPTThreadTrace into

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu updated this revision to Diff 425930. zequanwu added a comment. Use extra bool variable for is_first_search, because search_offset might be an odd number if parameter byte size in stack is an odd number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu added inline comments. Comment at: lldb/include/lldb/Symbol/UnwindPlan.h:225 + // Not the first search. + m_value.ra_search.search_offset |= 1; +} clayborg wrote: > What is this magic number/bit here? Is it ok to clobber bit

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

zequanwu updated this revision to Diff 425928. zequanwu marked 4 inline comments as done. zequanwu added a comment. Update: address some inline comments. For testing, I don't know how to create minidump in yaml format like the one in

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Few nitpicks inside otherwise I'm happy. Comment at: lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h:50 uint32_t max_depth; + bool max_depth_is_default;

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

dblaikie added inline comments. Comment at: bolt/include/bolt/Core/DebugData.h:375-377 +if (Optional DWOId = Unit.getDWOId()) + return *DWOId; +return Unit.getOffset(); ayermolo wrote: > ayermolo wrote: > > dblaikie wrote: > > > That seems like a

[Lldb-commits] [PATCH] D124370: [lldb/DWARF] Fix linking direction in CopyUniqueClassMethodTypes

dblaikie added a comment. In D124370#3474824 , @labath wrote: > In D124370#3472394 , @clayborg > wrote: > >> So I believe the reason we need to be able to add methods to a class is for >> templates. Templates

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

wallace updated this revision to Diff 425917. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124640/new/ https://reviews.llvm.org/D124640 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [lldb] 02c2b47 - [lldb] Remove ConnectionFileDescriptorTest.Connectv(4|6)

Author: Jonas Devlieghere Date: 2022-04-28T15:40:21-07:00 New Revision: 02c2b472b510ff55679844c087b66e7837e13dc2 URL: https://github.com/llvm/llvm-project/commit/02c2b472b510ff55679844c087b66e7837e13dc2 DIFF:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3480686 , @dblaikie wrote: > In D122974#3424654 , @JDevlieghere > wrote: > >> ... >> struct HashedStringRef { >> const llvm::StringRef str; >> const unsigned

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This updates the documentation of the gdb-remote protocol, as well as the help

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aa6a479738c: [lldb] Fix crash when launching in terminal (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D124535?vs=425542=425910#toc

[Lldb-commits] [lldb] 9aa6a47 - [lldb] Fix crash when launching in terminal

Author: Jonas Devlieghere Date: 2022-04-28T14:39:28-07:00 New Revision: 9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf URL: https://github.com/llvm/llvm-project/commit/9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf DIFF:

[Lldb-commits] [PATCH] D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64

jasonmolenda updated this revision to Diff 425901. jasonmolenda added a comment. cleanup patch to remove an unintended diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124492/new/ https://reviews.llvm.org/D124492 Files:

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:22 +// List of data kinds used by jLLDBGetState and jLLDBGetBinaryData. +struct IntelPTDataKinds { + static const char *kProcFsCpuInfo; jj10306 wrote: > why not

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. In D122974#3424654 , @JDevlieghere wrote: > The ConstString/StringPool is pretty hot so I'm very excited about making it > faster. > > I'm slightly concerned about the two hash values (the "full" hash vs the > single byte

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. (sorry, this slipping through somehow - it's on my radar now) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124604/new/ https://reviews.llvm.org/D124604

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione updated this revision to Diff 425826. kastiglione added a comment. Fixed: comment formatting; bool logic bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 Files:

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:718 + /// been told. + ChildrenOmissionWarningStatus m_truncation_warning; + /// Whether we reached the maximum child nesting depth and whether the user

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:22 +// List of data kinds used by jLLDBGetState and jLLDBGetBinaryData. +struct IntelPTDataKinds { + static const char *kProcFsCpuInfo; why not use an enum here?

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124601/new/ https://reviews.llvm.org/D124601

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425792. siggi-alpheus added a comment. A full diff from origin/main - I hope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files:

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Please take a look. This now passes all tests locally, and adds a test that fails against the current ToT lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425790. siggi-alpheus added a comment. Add a test that fails against the ToT lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files:

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan added a comment. Also, to help diagnostics this kind of issue in future, it may worth to add an extra debug mode check in in `UniqueCStringMap` to ensure they are sorted. For example, in debug mode, add a `m_isSorted` flag which is set by `UniqueCStringMap::Sort()` method. All the

[Lldb-commits] [lldb] f6b7fd2 - [lldb] Remove patch reject file (.rej)

Author: Jonas Devlieghere Date: 2022-04-28T08:16:26-07:00 New Revision: f6b7fd20a52ef83d0462db190eb40800afda2506 URL: https://github.com/llvm/llvm-project/commit/f6b7fd20a52ef83d0462db190eb40800afda2506 DIFF:

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett updated this revision to Diff 425779. DavidSpickett added a comment. Use FixAnyAddress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122411/new/ https://reviews.llvm.org/D122411 Files:

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

DavidSpickett updated this revision to Diff 425778. DavidSpickett added a comment. Use FixAnyAddress instead of FixDataAddress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118794/new/ https://reviews.llvm.org/D118794 Files:

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

StephenTozer added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp.rej:1 +*** +*** 337,343 This file was presumably included by accident? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rGb809c4cdb70a: [lldb] Add FixAnyAddress to ABI plugins (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/

[Lldb-commits] [lldb] b809c4c - [lldb] Add FixAnyAddress to ABI plugins

Author: David Spickett Date: 2022-04-28T14:57:40+01:00 New Revision: b809c4cdb70a100c85524555a14332f22ede1b7a URL: https://github.com/llvm/llvm-project/commit/b809c4cdb70a100c85524555a14332f22ede1b7a DIFF:

[Lldb-commits] [lldb] 0cbad66 - [lldb/DWARF] Fix a typo in 57f99d0dc3

Author: Pavel Labath Date: 2022-04-28T15:11:00+02:00 New Revision: 0cbad6635475952fb432ac2af8b1fce202aaeb6e URL: https://github.com/llvm/llvm-project/commit/0cbad6635475952fb432ac2af8b1fce202aaeb6e DIFF: https://github.com/llvm/llvm-project/commit/0cbad6635475952fb432ac2af8b1fce202aaeb6e.diff

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In build.py we have our own find_executable that looks a lot like the distutils one that I switched to

[Lldb-commits] [PATCH] D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available.

labath added a comment. In D124198#3468039 , @clayborg wrote: > So there is real benefit to doing these checks IMHO as it can help us get > back on track in live debug sessions. Core file sessions results will vary > depending on it we actually have

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath updated this revision to Diff 425727. labath added a comment. Here's the updated version. I'll place my new findings into the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

DavidSpickett added a reviewer: JDevlieghere. DavidSpickett added a comment. https://reviews.llvm.org/D124429 unblocked doing this. The github issue is https://github.com/llvm/llvm-project/issues/54337. Once I know this is ok with the bots I'll see what I can do about our various `which`

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. distutils is deprecated and shutil.which is the suggested replacement for this function.

[Lldb-commits] [lldb] 57f99d0 - [lldb] Reduce duplication in DWARFASTParserClang::CopyUniqueClassMethodTypes

Author: Pavel Labath Date: 2022-04-28T10:58:54+02:00 New Revision: 57f99d0dc387aab4e4af2cd92f97598e8a5df41f URL: https://github.com/llvm/llvm-project/commit/57f99d0dc387aab4e4af2cd92f97598e8a5df41f DIFF: https://github.com/llvm/llvm-project/commit/57f99d0dc387aab4e4af2cd92f97598e8a5df41f.diff

[Lldb-commits] [PATCH] D124535: [lldb] Fix crash when launching in terminal

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. One could add a unit test for the CFD overload, though, as this appears to be the only callsite (or other callsites were equally untested and broken), we could also remove it altogether.

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

labath added a comment. Yeah, this was very surprising. The fact that we're still doing substring matches on the context is suspicious, and might cause false positives, but given that we first verify that the context is valid, I was not able to come up with counterexamples.

[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When