[Lldb-commits] [PATCH] D128107: [trace] Add LoadTraceFromFile to SBDebugger and SBTrace

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:403 + /// trace session. + SBTrace LoadTraceFromFile(SBError , const char *trace_file_path); + Can this take a filespec? Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D128107: Add LoadTraceFromFile to SBDebugger and SBTrace

jj10306 created this revision. jj10306 added a reviewer: wallace. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add trace load functionality to SBDebugger via the `LoadTraceFromFile` method. Update

[Lldb-commits] [lldb] 9168871 - [lldb] Fix modernize-use-equals-default warnings (NFC)

Author: Jonas Devlieghere Date: 2022-06-17T15:08:02-07:00 New Revision: 91688716ba49942051dccdf7b9c4f81a7ec8feaf URL: https://github.com/llvm/llvm-project/commit/91688716ba49942051dccdf7b9c4f81a7ec8feaf DIFF:

[Lldb-commits] [lldb] 9916633 - [lldb] Fix modernize-use-override warnings (NFC)

Author: Jonas Devlieghere Date: 2022-06-17T15:08:02-07:00 New Revision: 991663399792d4cc03da6b6c7131a6c213655318 URL: https://github.com/llvm/llvm-project/commit/991663399792d4cc03da6b6c7131a6c213655318 DIFF:

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere added a comment. In D128069#3592733 , @dmlary wrote: > I went through the existing tests for SBSection, and there is only one test > case for all the getters & props, and that is for `target_byte_size`. Based > on that lack, and the

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny updated this revision to Diff 438007. mgorny added a comment. Move tests to a separate file. Rename and reverse `allow_async` into `force_synchronous`. Remove `queue_all_threads` — we now always queue all in async mode. Rework `Handle_stop_reason` not to rely on

[Lldb-commits] [PATCH] D128077: [lldb][tests] Automatically call compute_mydir (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128077/new/ https://reviews.llvm.org/D128077 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. In D50304#3586710 , @jingham wrote: > For some reason I'm not getting mail notifications for review changes, sorry > about that. > > This is certainly better than the original implementation. Among other > things, if we

[Lldb-commits] [PATCH] D128077: [lldb][tests] Automatically call compute_mydir (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Great! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128077/new/ https://reviews.llvm.org/D128077

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. I went through the existing tests for SBSection, and there is only one test case for all the getters & props, and that is for `target_byte_size`. Based on that lack, and the simplicity of the getter, I didn't think a test case was warranted here. If the reviewers feel

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny marked an inline comment as done. mgorny added a comment. Thinking about it more, `?` needs to be special-cased anyway to handle multiprocess, so that's probably the best way forward. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125575/new/ https://reviews.llvm.org/D125575

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere added a comment. Is this something we could add a test for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary created this revision. dmlary added a reviewer: clayborg. dmlary added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. dmlary requested review of this revision. This commit adds SBSection.GetAlignment(), and SBSection.alignment as a python

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny marked an inline comment as done. mgorny added a comment. In D125575#3586534 , @labath wrote: > I think this is a pretty good start. The main thing bugging me is the two > bool flags on the stop reply packet functions. I wonder if it would be

[Lldb-commits] [PATCH] D128063: [LLDB][ExpressionParser] Fix indices inside format-strings passed to LLDB_LOG

This revision was automatically updated to reflect the committed changes. Closed by commit rGf000de8760c1: [LLDB][ExpressionParser] Fix indices inside format-strings passed to LLDB_LOG (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f000de8 - [LLDB][ExpressionParser] Fix indices inside format-strings passed to LLDB_LOG

Author: Adrian Prantl Date: 2022-06-17T09:26:01-07:00 New Revision: f000de8760c112ead0487a020c3849c6280f2a57 URL: https://github.com/llvm/llvm-project/commit/f000de8760c112ead0487a020c3849c6280f2a57 DIFF: https://github.com/llvm/llvm-project/commit/f000de8760c112ead0487a020c3849c6280f2a57.diff

[Lldb-commits] [PATCH] D128063: [LLDB][ExpressionParser] Fix indices inside format-strings passed to LLDB_LOG

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128063/new/ https://reviews.llvm.org/D128063

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

mdaniels added a comment. @JDevlieghere could you confirm my understanding of the issue here is correct? It looks like https://github.com/llvm/llvm-project/issues/54250 is the same issue, and should be fix with this as well. Comment at:

[Lldb-commits] [PATCH] D128063: [LLDB][ExpressionParser] Fix indexing into LLDB_LOG calls

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: arphaman. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `llvm::formatv` expects the parameter

[Lldb-commits] [lldb] 13dfe0f - [lldb] [test] Update baseline test status for FreeBSD

Author: Michał Górny Date: 2022-06-17T14:35:18+02:00 New Revision: 13dfe0f0fc267f3f747a5e0802c0a8b01240d0af URL: https://github.com/llvm/llvm-project/commit/13dfe0f0fc267f3f747a5e0802c0a8b01240d0af DIFF: https://github.com/llvm/llvm-project/commit/13dfe0f0fc267f3f747a5e0802c0a8b01240d0af.diff

[Lldb-commits] [PATCH] D128042: [lldb] [test] Fix test_platform_file_fstat to account for negative ints

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Fix test_platform_file_fstat to correctly truncate/max out the expected value when GDB Remote Serial

[Lldb-commits] [PATCH] D128041: [lldb] [test] Make AVX/MPX register tests more robust and fix on BSD

mgorny created this revision. mgorny added reviewers: emaste, labath, DavidSpickett, krytarowski. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Make the AVX/MPX register tests more robust by checking for the presence of actual

[Lldb-commits] [lldb] 3fd9aeb - [LLDB] XFAIL TestLoadUnload fails on Arm/Ubuntu Jammy

Author: Muhammad Omair Javaid Date: 2022-06-17T12:06:35+04:00 New Revision: 3fd9aebbb75ab0966bd767e15ba6a69cad17f160 URL: https://github.com/llvm/llvm-project/commit/3fd9aebbb75ab0966bd767e15ba6a69cad17f160 DIFF:

[Lldb-commits] [PATCH] D128034: [lldb] [test] Disable gmodules testing on FreeBSD

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. The -gmodule tests currently fail on FreeBSD due to include bugs: