[Lldb-commits] [PATCH] D128878: [lldb] [llgs] Remove not-really-used m_inferior_prev_state

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Remove m_inferior_prev_state that's not suitable for multiprocess debugging and that does not

[Lldb-commits] [lldb] 67854f9 - Use value_or instead of getValueOr. NFC

Author: Fangrui Song Date: 2022-06-29T21:55:02-07:00 New Revision: 67854f9ed0cd512f59736730f4c05de25501ae54 URL: https://github.com/llvm/llvm-project/commit/67854f9ed0cd512f59736730f4c05de25501ae54 DIFF: https://github.com/llvm/llvm-project/commit/67854f9ed0cd512f59736730f4c05de25501ae54.diff

[Lldb-commits] [lldb] a3ec54c - [lldb] Fix unused variable warning in TraceHTR (NFC)

Author: Kevin Cadieux Date: 2022-06-29T21:29:50-07:00 New Revision: a3ec54c660755f9aae5eeb10e662e79f98437670 URL: https://github.com/llvm/llvm-project/commit/a3ec54c660755f9aae5eeb10e662e79f98437670 DIFF: https://github.com/llvm/llvm-project/commit/a3ec54c660755f9aae5eeb10e662e79f98437670.diff

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3ec54c66075: [lldb] Fix unused variable warning in TraceHTR (NFC) (authored by kevcadieux, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

wallace added a comment. i can do it right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128874/new/ https://reviews.llvm.org/D128874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. In D128638#3620751 , @mib wrote: > Not sure if this is related to this patch but `TestGdbRemote_vContThreads.py` > is still timing out on the macOS bot: > > https://green.lab.llvm.org/green/job/lldb-cmake/44958/console I see

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

kevcadieux added a comment. In D128874#3621115 , @wallace wrote: > thanks! You're welcome! Do you happen to have commit privileges to complete this patch? If not, no worries, I can find someone else tomorrow. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128874/new/ https://reviews.llvm.org/D128874

[Lldb-commits] [PATCH] D128874: [lldb] Fix unused variable warning in TraceHTR (NFC)

kevcadieux created this revision. Herald added a project: All. kevcadieux requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A warning was recently introduced in D128576 due to now unused lambda

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

brooksmoses added a comment. We're seeing a number of LLDB test failures from this change. If I'm understanding correctly, that's working by design because we're building the test code with a version of LLVM that's from a revision that's not quite as recent as the LLDB code we're testing.

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441230. persona0220 added a comment. nit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceDumper.h

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441229. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceDumper.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441226. persona0220 marked 26 inline comments as done. persona0220 added a comment. - Modify function name `instruction_decode` into `DecodeInstructionOpcode` - explicit naming for flag `show_kind` -> `show_control_flow_kind` - Convert

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

jingham updated this revision to Diff 441217. jingham added a comment. Use sleep_for instead of usleep. Man, that API isn't winning any beauty contests! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128776/new/ https://reviews.llvm.org/D128776

[Lldb-commits] [lldb] bd2044c - [CodeView] Call llvm::codeview::visitMemberRecordStream with the deserialized CVType whose kind is FieldListRecord.

Author: Zequan Wu Date: 2022-06-29T17:18:56-07:00 New Revision: bd2044c108655dc6409e2c724349219d3971b151 URL: https://github.com/llvm/llvm-project/commit/bd2044c108655dc6409e2c724349219d3971b151 DIFF: https://github.com/llvm/llvm-project/commit/bd2044c108655dc6409e2c724349219d3971b151.diff

[Lldb-commits] [lldb] 1b8c735 - [lldb] Use assertState in even more tests (NFC)

Author: Jonas Devlieghere Date: 2022-06-29T17:05:58-07:00 New Revision: 1b8c73522ebf5b937912ef91c297a5b77ddc95ec URL: https://github.com/llvm/llvm-project/commit/1b8c73522ebf5b937912ef91c297a5b77ddc95ec DIFF:

[Lldb-commits] [lldb] dee672e - [lldb] Skip instead of XFAIL TestGdbRemote_vContThreads on Darwin

Author: Jonas Devlieghere Date: 2022-06-29T16:34:34-07:00 New Revision: dee672ee8505ccf64f0ca38600ef9efb001cf4d1 URL: https://github.com/llvm/llvm-project/commit/dee672ee8505ccf64f0ca38600ef9efb001cf4d1 DIFF:

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mib added a comment. Not sure if this is related to this patch but `TestGdbRemote_vContThreads.py` is still timing out on the macOS bot: https://green.lab.llvm.org/green/job/lldb-cmake/44958/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441195. mib marked an inline comment as done. mib added a comment. Refactor logging code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index:

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " +

[Lldb-commits] [lldb] 3944780 - [lldb] Skip TestAppleSimulatorOSType is simulator isn't available

Author: Jonas Devlieghere Date: 2022-06-29T15:10:16-07:00 New Revision: 3944780dd89018e7e12bf45bb835ac7f54c40181 URL: https://github.com/llvm/llvm-project/commit/3944780dd89018e7e12bf45bb835ac7f54c40181 DIFF:

[Lldb-commits] [lldb] 65a7ebf - [lldb] XFAIL TestVSCode_breakpointEvents.py on Ventura

Author: Jonas Devlieghere Date: 2022-06-29T15:00:57-07:00 New Revision: 65a7ebff33428f1b9941e23fd79167d30d642b7b URL: https://github.com/llvm/llvm-project/commit/65a7ebff33428f1b9941e23fd79167d30d642b7b DIFF:

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " +

[Lldb-commits] [PATCH] D128849: [lldb] [llgs] Send process output asynchronously in non-stop mode

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Introduce a new %Stdio notification category and use it to send process output asynchronously

[Lldb-commits] [lldb] 9c6e043 - [LLDB] Allow API tests to override -gdwarf on Windows

Author: Muhammad Omair Javaid Date: 2022-06-29T23:24:18+04:00 New Revision: 9c6e04359282e9051f7b2744b99266ece32db001 URL: https://github.com/llvm/llvm-project/commit/9c6e04359282e9051f7b2744b99266ece32db001 DIFF:

[Lldb-commits] [lldb] f5ba0a3 - Fix inline-record.test for Arm/Windows

Author: Muhammad Omair Javaid Date: 2022-06-29T23:21:02+04:00 New Revision: f5ba0a3d059380c62dd06cc8091e6aee53f3401f URL: https://github.com/llvm/llvm-project/commit/f5ba0a3d059380c62dd06cc8091e6aee53f3401f DIFF:

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib updated this revision to Diff 441110. mib added a comment. Log only when verbose mode is enabled CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 Files: lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [lldb] 079c8cc - [lldb] Attempt to fix TestStepThroughTrampoline on windows

Author: Pavel Labath Date: 2022-06-29T19:59:24+02:00 New Revision: 079c8ccb33e8f134e1e6751b2ccf21e1f1c37650 URL: https://github.com/llvm/llvm-project/commit/079c8ccb33e8f134e1e6751b2ccf21e1f1c37650 DIFF: https://github.com/llvm/llvm-project/commit/079c8ccb33e8f134e1e6751b2ccf21e1f1c37650.diff

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

mib added a comment. In D128768#3619349 , @JDevlieghere wrote: > The fix looks good but I'm torn about the added logging. On the one hand > it'll make finding issues like this easier in the future, but on the other > hand, while this code isn't "hot",

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441073. dmlary added a comment. updated to include test cases for `SBSection.GetAlignment()` and `SBSection.alignment` property. @labath Thanks for the yaml2obj pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

wallace added a comment. what happens is that the specific failures are triggered by tests that require the cmake flag LIBIPT_INCLUDE_PATH to be configured, but all good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128775/new/

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

jingham added a comment. Thanks for doing this. The test suite was clean after my original changes, which means whatever is using CommandObjectMultipleThreads must not have had any tests where arguments were passed to it? Ditto for the trace command. Might be good to add those as well.

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay marked an inline comment as done. emrekultursay added a comment. PTAL. Comment at: lldb/unittests/Process/Utility/LinuxProcMapsTest.cpp:278 check_regions(params); } DavidSpickett wrote: > I don't see a test for a mapping with "s" for the

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay updated this revision to Diff 441060. emrekultursay added a comment. Removed redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832 Files:

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay updated this revision to Diff 441058. emrekultursay added a comment. Added test that covers shared (s) input Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832 Files:

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20566 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127999/new/ https://reviews.llvm.org/D127999

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/unittests/Process/Utility/LinuxProcMapsTest.cpp:278 check_regions(params); } I don't see a test for a mapping with "s" for the sharing char, did I miss it?

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128832 Files:

[Lldb-commits] [lldb] 4a95861 - [lldb] [test] Avoid relying on signos in other fork tests

Author: Michał Górny Date: 2022-06-29T17:48:36+02:00 New Revision: 4a95861d7394da7e7f33ff325c3b28159cb6aa77 URL: https://github.com/llvm/llvm-project/commit/4a95861d7394da7e7f33ff325c3b28159cb6aa77 DIFF: https://github.com/llvm/llvm-project/commit/4a95861d7394da7e7f33ff325c3b28159cb6aa77.diff

[Lldb-commits] [PATCH] D128541: [WIP][lldb][windows] Handle OutputDebugString from debuggee

alvinhochun created this revision. Herald added a project: All. alvinhochun added reviewers: mstorsjo, DavidSpickett, labath, omjavaid. alvinhochun added a comment. alvinhochun updated this revision to Diff 439961. alvinhochun updated this revision to Diff 441032. alvinhochun edited the summary of

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added a comment. The fix looks good but I'm torn about the added logging. On the one hand it'll make finding issues like this easier in the future, but on the other hand, while this code isn't "hot", it is something where performance matters. My concern is that this will

[Lldb-commits] [lldb] e60ed24 - [lldb] [test] Un-XFAIL fork tests on arm as well

Author: Michał Górny Date: 2022-06-29T16:05:12+02:00 New Revision: e60ed2401b22074e02779081ca16fa93bd4cf244 URL: https://github.com/llvm/llvm-project/commit/e60ed2401b22074e02779081ca16fa93bd4cf244 DIFF: https://github.com/llvm/llvm-project/commit/e60ed2401b22074e02779081ca16fa93bd4cf244.diff

[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG251165b2e482: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 251165b - [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

Author: Michał Górny Date: 2022-06-29T15:37:26+02:00 New Revision: 251165b2e48216f8fbeef1960711219afac406f4 URL: https://github.com/llvm/llvm-project/commit/251165b2e48216f8fbeef1960711219afac406f4 DIFF: https://github.com/llvm/llvm-project/commit/251165b2e48216f8fbeef1960711219afac406f4.diff

[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/main.cpp:357 +#if !defined(_WIN32) +} else if (consume_front(arg, "stop")) { + raise(SIGSTOP); Changing this to `arg == "stop"`, as right

[Lldb-commits] [PATCH] D128576: [trace] Make events first class items in the trace cursor and rework errors

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. This is awesome work - the code is much more understandable, so thanks for doing this! lgtm overall, just left a couple final minor comments. I think we can continue to iterate/improve

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. Ok, it seems that all the relevant bots are green now. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128638/new/ https://reviews.llvm.org/D128638 ___ lldb-commits

[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/fork_testbase.py:155 parent_expect = [ -"T05thread:p{}.{};.*".format(parent_pid, parent_tid), +

[Lldb-commits] [lldb] 5e39198 - [lldb] Replace linux/uio.h with sys/uio.h in NativeRegisterContextLinux_s390x

Author: Pavel Labath Date: 2022-06-29T14:50:06+02:00 New Revision: 5e391985709f0ab585d46ad534b4f3b48c6a68f9 URL: https://github.com/llvm/llvm-project/commit/5e391985709f0ab585d46ad534b4f3b48c6a68f9 DIFF: https://github.com/llvm/llvm-project/commit/5e391985709f0ab585d46ad534b4f3b48c6a68f9.diff

[Lldb-commits] [lldb] 3c16fb3 - [lldb] [test] Fix variable overwrite in non-stop fork tests

Author: Michał Górny Date: 2022-06-29T13:34:50+02:00 New Revision: 3c16fb3ab34d51c0df9512c38093d1c5c8dd6e79 URL: https://github.com/llvm/llvm-project/commit/3c16fb3ab34d51c0df9512c38093d1c5c8dd6e79 DIFF: https://github.com/llvm/llvm-project/commit/3c16fb3ab34d51c0df9512c38093d1c5c8dd6e79.diff

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. In D128638#3618039 , @labath wrote: > This looks like a genuine problem, see > https://lab.llvm.org/buildbot/#/builders/68/builds/34903. If I had to guess, > I'd say the problem is you're overwriting the context object holding

[Lldb-commits] [PATCH] D127999: [lldb] fix stepping through POSIX trampolines

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8ad018869ae: [lldb] fix stepping through POSIX trampolines (authored by mdaniels, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d8ad018 - [lldb] fix stepping through POSIX trampolines

Author: Michael Daniels Date: 2022-06-29T11:06:29+02:00 New Revision: d8ad018869aeb1ffe40e94ee4d6d377121581083 URL: https://github.com/llvm/llvm-project/commit/d8ad018869aeb1ffe40e94ee4d6d377121581083 DIFF:

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG01bc838e4512: [LLDB] Add PDB/calling-conventions.test for Arm/Windows (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/

[Lldb-commits] [lldb] 01bc838 - [LLDB] Add PDB/calling-conventions.test for Arm/Windows

Author: Muhammad Omair Javaid Date: 2022-06-29T12:58:16+04:00 New Revision: 01bc838e4512ad645f72afd1d6b613d12c929aa4 URL: https://github.com/llvm/llvm-project/commit/01bc838e4512ad645f72afd1d6b613d12c929aa4 DIFF:

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18baf16c665: [LLDB] Add Arm64 CodeView to LLDB regnum mapping (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/

[Lldb-commits] [lldb] a18baf1 - [LLDB] Add Arm64 CodeView to LLDB regnum mapping

Author: Muhammad Omair Javaid Date: 2022-06-29T12:50:57+04:00 New Revision: a18baf16c665aab5631faace24a9d0fdc6b071bf URL: https://github.com/llvm/llvm-project/commit/a18baf16c665aab5631faace24a9d0fdc6b071bf DIFF:

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG695c22c84a36: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 695c22c - [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

Author: Muhammad Omair Javaid Date: 2022-06-29T12:47:02+04:00 New Revision: 695c22c84a36daf0ed12b212c2ac9772f45c61f3 URL: https://github.com/llvm/llvm-project/commit/695c22c84a36daf0ed12b212c2ac9772f45c61f3 DIFF:

[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/fork_testbase.py:155 parent_expect = [ -"T05thread:p{}.{};.*".format(parent_pid,

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

labath added a comment. This looks like a genuine problem, see https://lab.llvm.org/buildbot/#/builders/68/builds/34903. If I had to guess, I'd say the problem is you're overwriting the context object holding the first pid (here:

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

labath added a comment. (Other than the inline comment, this seems fine to me) Comment at: lldb/test/API/functionalities/breakpoint/two_hits_one_actual/main.cpp:6 +void usleep_helper(useconds_t usec) { + usleep(usec); // Break here in the helper +} usleep

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid added a comment. @labath @mstorsjo ok to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ https://reviews.llvm.org/D128678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/ https://reviews.llvm.org/D128221 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

labath added a comment. In D128678#3616685 , @mstorsjo wrote: > Thanks, this looks more complete and consistent to me now! > > In D128678#3615531 , @labath wrote: > >> It seems like this is not actually running