[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0702ac07b8e: [PATCH] [lldb-server] Skip shared regions for memory allocation (authored by emrekultursay, committed by kongyi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c0702ac - [PATCH] [lldb-server] Skip shared regions for memory allocation

Author: Emre Kultursay Date: 2022-07-01T13:45:42+08:00 New Revision: c0702ac07b8e206f424930ff0331151954fb821c URL: https://github.com/llvm/llvm-project/commit/c0702ac07b8e206f424930ff0331151954fb821c DIFF:

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1186-1191 + // dyld doesn't think there is a binary at this address, + // but maybe there isn't a binary YET - let's look in memory + // for a proper mach-o header

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. lldb sends the jGetLoadedDynamicLibrariesInfos packet to

[Lldb-commits] [lldb] 8a790e6 - [LLDB][NativePDB] Return LLDB_INVALID_ADDRESS in PdbIndex::MakeVirtualAddress when input is invalid due to missing address info in symbol/public records.

Author: Zequan Wu Date: 2022-06-30T14:34:20-07:00 New Revision: 8a790e65f42b27172c40777b0ef2088d9c6df7bb URL: https://github.com/llvm/llvm-project/commit/8a790e65f42b27172c40777b0ef2088d9c6df7bb DIFF: https://github.com/llvm/llvm-project/commit/8a790e65f42b27172c40777b0ef2088d9c6df7bb.diff

[Lldb-commits] [lldb] 38ca754 - Apparently you need a special makefile flag to use threads on Linux.

Author: Jim Ingham Date: 2022-06-30T12:10:17-07:00 New Revision: 38ca754eb08b0741511c74bbac123e551f54125b URL: https://github.com/llvm/llvm-project/commit/38ca754eb08b0741511c74bbac123e551f54125b DIFF: https://github.com/llvm/llvm-project/commit/38ca754eb08b0741511c74bbac123e551f54125b.diff

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

clayborg accepted this revision. clayborg added a comment. Looks good, thanks for the revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e0b5a07160: Threads which hit a breakpoint but fail the condition are considered (authored by jingham). Repository:

[Lldb-commits] [lldb] b8e0b5a - Threads which hit a breakpoint but fail the condition are considered

Author: Jim Ingham Date: 2022-06-30T11:43:59-07:00 New Revision: b8e0b5a071600cb39d938470bd20d845013384ce URL: https://github.com/llvm/llvm-project/commit/b8e0b5a071600cb39d938470bd20d845013384ce DIFF: https://github.com/llvm/llvm-project/commit/b8e0b5a071600cb39d938470bd20d845013384ce.diff

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py:116 +parent_pid, parent_tid, child_pid, child_tid = ( +self.start_fork_test(["fork", "sleep:2", "print-pid", "sleep:2", +

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Enable stdio forwarding when nonstop mode is enabled, and disable it once it is disabled.

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. The patch itself looks good, however the workaround seems still required on FreeBSD. Comment at:

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. Please commit on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832

[Lldb-commits] [lldb] 3a56858 - [lldb] XFAIL TestObjCXXBridgedPO on macOS Ventura

Author: Jonas Devlieghere Date: 2022-06-30T09:20:56-07:00 New Revision: 3a56858cee5c88a3027492ebe4abecc87fb50ee1 URL: https://github.com/llvm/llvm-project/commit/3a56858cee5c88a3027492ebe4abecc87fb50ee1 DIFF:

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary updated this revision to Diff 441429. dmlary added a comment. merge tests, rename yml to yaml Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 Files: lldb/bindings/interface/SBSection.i

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124155/new/ https://reviews.llvm.org/D124155 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128541: [WIP][lldb][windows] Handle OutputDebugString from debuggee

labath added a subscriber: jasonmolenda. labath added a comment. In D128541#3622433 , @alvinhochun wrote: > In D128541#3621364 , @labath wrote: > >> Well.. most OSes don't have this kind of functionality, so we

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:637 if (location_sp->GetName() == g_size_name) - location_sp = short_sp->GetChildAtIndex(3, true); + location_sp = short_sp->GetChildAtIndex(2, true); if

[Lldb-commits] [lldb] cff509f - [lldb] Fix libc++ string formatter for the "unstable" layout

Author: Pavel Labath Date: 2022-06-30T16:44:54+02:00 New Revision: cff509f33ba44fd1d0d9b579791dad527d50068e URL: https://github.com/llvm/llvm-project/commit/cff509f33ba44fd1d0d9b579791dad527d50068e DIFF: https://github.com/llvm/llvm-project/commit/cff509f33ba44fd1d0d9b579791dad527d50068e.diff

[Lldb-commits] [PATCH] D128541: [WIP][lldb][windows] Handle OutputDebugString from debuggee

alvinhochun added a comment. In D128541#3621364 , @labath wrote: > Well.. most OSes don't have this kind of functionality, so we don't really > have an exact match for this. I suppose the closest thing would be the way we > handle darwin OS logs, so

[Lldb-commits] [lldb] 8e9360d - Fix PDB/func-symbols.test for Arm/Windows

Author: Muhammad Omair Javaid Date: 2022-06-30T17:58:19+04:00 New Revision: 8e9360db1b4128ad4d90a6fe1cf1c20879976f64 URL: https://github.com/llvm/llvm-project/commit/8e9360db1b4128ad4d90a6fe1cf1c20879976f64 DIFF:

[Lldb-commits] [lldb] dd01d9a - Fix TestCommandScript.py for Arm/Windows

Author: Muhammad Omair Javaid Date: 2022-06-30T17:48:28+04:00 New Revision: dd01d9aadb6107075c1c2254a2de0670a4d2f0ed URL: https://github.com/llvm/llvm-project/commit/dd01d9aadb6107075c1c2254a2de0670a4d2f0ed DIFF:

[Lldb-commits] [lldb] 8b7f5ee - [LLDB] Fix TestSTL.py Makefile to remove -gdwarf O0

Author: Muhammad Omair Javaid Date: 2022-06-30T14:06:21+04:00 New Revision: 8b7f5ee5f05a0972802055204a423009d3398a0d URL: https://github.com/llvm/llvm-project/commit/8b7f5ee5f05a0972802055204a423009d3398a0d DIFF:

[Lldb-commits] [lldb] 5fe0da6 - [LLDB] Fix TestSTL.py on Windows

Author: Muhammad Omair Javaid Date: 2022-06-30T13:27:14+04:00 New Revision: 5fe0da6d7bcda22b03c470bef030030fa2d6d6f0 URL: https://github.com/llvm/llvm-project/commit/5fe0da6d7bcda22b03c470bef030030fa2d6d6f0 DIFF:

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. FYI, I don't feel very strongly about this. If you really dislike adding `m_inhibit_stop_reason_processes`, I suppose we could alternatively just declare disabling non-stop as unsupported and error out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Stop all processes and clear notification queues when disabling non-stop mode. Ensure that no

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

labath added a comment. In D128776#3620886 , @jingham wrote: > Use sleep_for instead of usleep. Man, that API isn't winning any beauty > contests! well.. normally one would write that as `sleep_for(std::chrono:microseconds(47))`, or (if he's into

[Lldb-commits] [PATCH] D128849: [lldb] [llgs] Send process output asynchronously in non-stop mode

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3931 +GDBRemoteCommunication::PacketResult GDBRemoteCommunicationServerLLGS::HandleNotificationAck(std::deque ) { +

[Lldb-commits] [PATCH] D128849: [lldb] [llgs] Send process output asynchronously in non-stop mode

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3931 +GDBRemoteCommunication::PacketResult

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D128069#3619736 , @dmlary wrote: > updated to include test cases for `SBSection.GetAlignment()` and > `SBSection.alignment` property. Cool. Looks

[Lldb-commits] [PATCH] D128832: [lldb-server] Skip shared regions for memory allocation

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128832/new/ https://reviews.llvm.org/D128832

[Lldb-commits] [PATCH] D128541: [WIP][lldb][windows] Handle OutputDebugString from debuggee

labath added a comment. In D128541#3608718 , @alvinhochun wrote: > I think this should be enabled by default, but none of the logging categories > for `LLDB_LOG` has default active. That's because it's not really meant for this use case. The logging

[Lldb-commits] [PATCH] D128879: [lldb] [llgs] Fix `?` packet response for running threads

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Fix the response to `?` packet for threads that are running at the time (in non-stop mode).