[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. FWIW, this change also broke this check in Firefox's clang plugin: https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Why was this reverted? Please make extensive tests especially for something dealing with the build system. When reverting a commit, briefly describe what happened. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

JDevlieghere updated this revision to Diff 444511. JDevlieghere added a comment. Rebase on D129703 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129707/new/ https://reviews.llvm.org/D129707 Files: lldb/source/Interpreter/CommandObject.cpp

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere updated this revision to Diff 444510. JDevlieghere added a comment. Add static_assert that ensures that the entries in the table have the same order as in the enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129703/new/ https://reviews.llvm.org/D129703 Files:

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere updated this revision to Diff 444506. JDevlieghere added a comment. Herald added a subscriber: mgorny. - Merge two tables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129703/new/ https://reviews.llvm.org/D129703 Files: lldb/include/lldb/Interpreter/CommandObject.h

[Lldb-commits] [PATCH] D129724: [lldb] Remove ELF .zdebug support

MaskRay created this revision. MaskRay added reviewers: ckissane, labath. Herald added subscribers: StephenFan, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef07169ec9f: [llvm] add zstd to `llvm::compression` namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 89. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd - [Support] update zstd interface to use uint8_t * and ArrayRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129707/new/ https://reviews.llvm.org/D129707 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere added a comment. In case anyone is wondering why I created a new table instead of using `g_arguments_data`, the answers is that I didn't want to pull that whole table, and the help text callbacks it depends on, into a separate header. But after having discovered two entries that

[Lldb-commits] [PATCH] D129707: [lldb] Print the enum values and their description in the argument value help output

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Print the enum values and their description in the argument value help output. Here's what the output looks like: (lldb) help

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Support/Compression.h:54 + +void compress(StringRef InputBuffer, SmallVectorImpl , + int Level = DefaultCompression);

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5ccfeb6bfbb: [lldb] Add image dump pcm-info command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b5ccfeb - [lldb] Add image dump pcm-info command

Author: Dave Lee Date: 2022-07-13T16:56:53-07:00 New Revision: b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306 URL: https://github.com/llvm/llvm-project/commit/b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306 DIFF: https://github.com/llvm/llvm-project/commit/b5ccfeb6bfbbc5436b91a1e317f88e2c499c9306.diff

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 59. Michael137 marked an inline comment as done. Michael137 added a comment. - Address stylistic comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

jasonmolenda added a comment. ach, that's great groundwork. I've always been a little annoyed doing `settings set stop-disassembly-display bogusvalue` to see the list of enumerated value names, but not annoyed enough to get to the bottom of it. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e690137 - [Support] Change compression::zlib::{compress, uncompress} to use uint8_t *

Author: Fangrui Song Date: 2022-07-13T16:26:54-07:00 New Revision: e690137dde1c9b037e0c987d393da054d86eeeab URL: https://github.com/llvm/llvm-project/commit/e690137dde1c9b037e0c987d393da054d86eeeab DIFF: https://github.com/llvm/llvm-project/commit/e690137dde1c9b037e0c987d393da054d86eeeab.diff

[Lldb-commits] [PATCH] D129703: [lldb] Refactor command option enum values (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Refactor command option enum values so that there's a table that connects the CommandArgumentType enumeration with the corresponding enum

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3648624 , @JDevlieghere wrote: > This breaks all the LLDB tests that import the std module: > > Given that the bot has been red for 14 hours I went ahead and reverted this > change. Please keep an eye on this bot

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 32. ckissane added a comment. - Merge branch main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. > From Jim, First off, I am supportive of your project, this is a pain point > for some folks for sure. I am in favor of trying to automate "I built my > binaries with sources in one location but locally they are in another" > scenario. Great to hear that! Seems

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added inline comments. Comment at: llvm/lib/Support/Compression.cpp:63 __msan_unpoison(CompressedBuffer.data(), CompressedSize); - CompressedBuffer.truncate(CompressedSize); + if (CompressedSize < CompressedBuffer.size()) +

[Lldb-commits] [lldb] a1568fa - [lldb] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-07-13T23:57:01+03:00 New Revision: a1568fa27885d12c504e42dd02b0ce3687863fd8 URL: https://github.com/llvm/llvm-project/commit/a1568fa27885d12c504e42dd02b0ce3687863fd8 DIFF:

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane marked 6 inline comments as done. ckissane added a comment. Mark handled comments from @MaskRay as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 00. ckissane added a comment. tidy some code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt llvm/cmake/config-ix.cmake

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

kimgr added a comment. This patch also broke IWYU, not exactly sure how or why yet. We run around the AST quite a bit, so structural changes like this often bite us. Can you expand on what happened here? Before/after kind-of thing? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. The patch looks mostly good but please fix the subject and the summary. Note: if you fix the local commit message, you can use ` arc diff --head=HEAD 'HEAD^' --verbatim` to update the subject and the summary. Comment at:

[Lldb-commits] [PATCH] D129332: [trace][intel pt] Support dumping the trace info in json

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0466d1df23b9: [trace][intel pt] Support dumping the trace info in json (authored by ymeng ym...@devvm4974.frc0.facebook.com, committed by Walter

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30fd5c3a17b: [trace][intel pt] Add a cgroup filter (authored by Gaurav Gaur g...@fb.com, committed by Walter Erquinigo wall...@fb.com). Changed prior to commit:

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a843d928275: [trace][intel pt] Create a CPU change event and expose it in the dumper (authored by Walter Erquinigo wall...@fb.com). Changed prior

[Lldb-commits] [lldb] 0466d1d - [trace][intel pt] Support dumping the trace info in json

Author: ymeng Date: 2022-07-13T12:26:11-07:00 New Revision: 0466d1df23b9157144c32e03f6477ed250991215 URL: https://github.com/llvm/llvm-project/commit/0466d1df23b9157144c32e03f6477ed250991215 DIFF: https://github.com/llvm/llvm-project/commit/0466d1df23b9157144c32e03f6477ed250991215.diff LOG:

[Lldb-commits] [lldb] d30fd5c - [trace][intel pt] Add a cgroup filter

Author: Gaurav Gaur Date: 2022-07-13T12:26:11-07:00 New Revision: d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c URL: https://github.com/llvm/llvm-project/commit/d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c DIFF: https://github.com/llvm/llvm-project/commit/d30fd5c3a17b5b8301e3413ae9b398ca7ee1f69c.diff

[Lldb-commits] [lldb] 4a843d9 - [trace][intel pt] Create a CPU change event and expose it in the dumper

Author: Walter Erquinigo Date: 2022-07-13T12:26:11-07:00 New Revision: 4a843d9282754b1c96c8d9fcbbbe45f000b42452 URL: https://github.com/llvm/llvm-project/commit/4a843d9282754b1c96c8d9fcbbbe45f000b42452 DIFF:

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. thanks for answering those questions, lgtm Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:87-90 +std::string slice =

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. thanks for following up on those questions, lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129340/new/ https://reviews.llvm.org/D129340

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, JDevlieghere, labath. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Context: When setting a breakpoint by name, we invoke

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444374. ckissane added a comment. - Trim CMAKE modifications to minimum needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:87-90 +std::string slice = line.substr(line.find_first_of("/")); +if (slice.empty()) + return None; +std::string cgroup_file = formatv("/sys/fs/cgroup/{0}", slice);

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

wallace requested review of this revision. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +decoded_thread.NotifyCPU(execution.thread_execution.cpu_id); + jj10306 wrote: > Does this mean our trace will

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444361. cassanova added a comment. Updated the ProtobufMutator CMake module and expression fuzzer CMakeLists file so that the expression fuzzer will create its own target name in its CMake file, and the ProtobufMutator will not attempt to create another

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

This revision was automatically updated to reflect the committed changes. Closed by commit rGb532dd545fcd: [trace] Add an option to save a compact trace bundle (authored by Walter Erquinigo wall...@fb.com). Changed prior to commit: https://reviews.llvm.org/D129239?vs=442779=444358#toc

[Lldb-commits] [lldb] b532dd5 - [trace] Add an option to save a compact trace bundle

Author: Walter Erquinigo Date: 2022-07-13T11:43:28-07:00 New Revision: b532dd545fcd03562b324d99eb28523f8510e821 URL: https://github.com/llvm/llvm-project/commit/b532dd545fcd03562b324d99eb28523f8510e821 DIFF:

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:318 +should_copy = true; +} else if (perf_record.IsErrorRecord()) { + should_copy = true; jj10306 wrote: > why do we want the error

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

wallace added a comment. I'll remove the unwanted formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129239/new/ https://reviews.llvm.org/D129239 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D129249: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f9464e02ada: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode (authored by Peicong Wu wupeic...@fb.com, committed by Walter Erquinigo wall...@fb.com). Repository: rG

[Lldb-commits] [lldb] 9f9464e - [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode

Author: Peicong Wu Date: 2022-07-13T11:08:14-07:00 New Revision: 9f9464e02adaeb0a56211db35e8d22929ef3191f URL: https://github.com/llvm/llvm-project/commit/9f9464e02adaeb0a56211db35e8d22929ef3191f DIFF: https://github.com/llvm/llvm-project/commit/9f9464e02adaeb0a56211db35e8d22929ef3191f.diff

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb73a52d7b19: [trace][intel pt] Add a nice parser for the trace size (authored by rnofenko rnofe...@fb.com, committed by Walter Erquinigo wall...@fb.com). Changed prior to commit:

[Lldb-commits] [lldb] db73a52 - [trace][intel pt] Add a nice parser for the trace size

Author: rnofenko Date: 2022-07-13T10:53:14-07:00 New Revision: db73a52d7b19249670c9cf169c0535b36f388496 URL: https://github.com/llvm/llvm-project/commit/db73a52d7b19249670c9cf169c0535b36f388496 DIFF: https://github.com/llvm/llvm-project/commit/db73a52d7b19249670c9cf169c0535b36f388496.diff

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646601 , @MaskRay wrote: > In D128465#3646561 , @ckissane > wrote: > >> In D128465#3646258 , @MaskRay >> wrote: >> >>> In

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:1013-1015 +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return Is this `error` function needed? `SetError` prepends the string "error:

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return Can we do this with a

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1022 +# 1. Try to use the user-provided target +if options.target_path is not None and options.target_path != "": +target = debugger.CreateTarget(options.target_path)

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

jingham accepted this revision. jingham added a comment. One trivial naming tweak, otherwise this looks good. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionUtil.cpp:20 + + if (auto thisValSP = frame->FindVariable(ConstString("this"))) +if

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere added a comment. - Do we need the source file for anything? I think it's fine to keep it around to regenerate the test, but please fix the extension. Nothing in lldb uses `.cc`. - I think if we check in the "binary", we should also update the other crashlogs tests to rely on it,

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. This breaks all the LLDB tests that import the std module: import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py

[Lldb-commits] [PATCH] D128932: [lldb] [llgs] Improve stdio forwarding in multiprocess+nonstop

mgorny updated this revision to Diff 444296. mgorny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128932/new/ https://reviews.llvm.org/D128932 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny updated this revision to Diff 444295. mgorny added a comment. Implemented the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128893/new/ https://reviews.llvm.org/D128893 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1913-1915 + auto process_it = m_inhibit_stop_reason_processes.find(process.GetID()); + if (process_it !=

[Lldb-commits] [PATCH] D128710: [lldb] [llgs] Fix multi-resume bugs with nonstop mode

mgorny updated this revision to Diff 444294. mgorny added a comment. Rebase on top of `m_debugged_processes` changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128710/new/ https://reviews.llvm.org/D128710 Files:

[Lldb-commits] [PATCH] D129249: [trace][intel pt] Measure the time it takes to decode a thread in per-cpu mode

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129249/new/ https://reviews.llvm.org/D129249

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:174 + + std::map multipliers = {{"mib", 1024 * 1024}, +

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582 } - + Target *target = m_exe_ctx.GetTargetPtr(); wallace wrote: > many formatting changes sneaked in. The actual changes are in the end of this

[Lldb-commits] [PATCH] D129652: [lldb] [llgs] Convert m_debugged_processes into a map of structs

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a project: All. mgorny requested review of this revision. Convert the m_debugged_processes map from NativeProcessProtocol pointers to structs, and combine the additional set(s) holding the

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. lgtm, two minor comments Comment at: lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:318 +should_copy = true; +} else if

[Lldb-commits] [PATCH] D129257: [trace][intel pt] Add a cgroup filter

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks good overall, just a couple questions from my end Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:87-90 +std::string slice =

[Lldb-commits] [PATCH] D129340: [trace][intel pt] Create a CPU change event and expose it in the dumper

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks good overall, just a couple minor suggestions and questions Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:288 +

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

mgorny added a comment. In D128893#3647663 , @labath wrote: > In D128893#3621673 , @mgorny wrote: > >> FYI, I don't feel very strongly about this. If you really dislike adding >>

[Lldb-commits] [lldb] f827b4b - [LLDB] Fix TestConvenienceVariables.test AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-13T16:46:55+05:00 New Revision: f827b4b657d5922beef3799337e91ba98fce852e URL: https://github.com/llvm/llvm-project/commit/f827b4b657d5922beef3799337e91ba98fce852e DIFF:

[Lldb-commits] [lldb] 7610524 - [LLDB] Fix TestThreadAPI.py for AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-13T16:30:09+05:00 New Revision: 7610524af3c99e63ec6b3a452c45af51ffae57fa URL: https://github.com/llvm/llvm-project/commit/7610524af3c99e63ec6b3a452c45af51ffae57fa DIFF:

[Lldb-commits] [lldb] b82b018 - [LLDB] XFail TestLoadUnload.test_static_init_during_load AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-13T16:18:18+05:00 New Revision: b82b0187129ddb40d85c6fc0847c536967273600 URL: https://github.com/llvm/llvm-project/commit/b82b0187129ddb40d85c6fc0847c536967273600 DIFF:

[Lldb-commits] [lldb] 891319f - [LLDB] Fix pointers.test for AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-13T15:55:31+05:00 New Revision: 891319f654c102572cf7028ed04bbaf6c59e7bff URL: https://github.com/llvm/llvm-project/commit/891319f654c102572cf7028ed04bbaf6c59e7bff DIFF:

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3647530 , @nikic wrote: > FYI this change had a noticeable compile-time impact >

[Lldb-commits] [PATCH] D128893: [lldb] [llgs] Fix disabling non-stop mode

labath added a comment. In D128893#3621673 , @mgorny wrote: > FYI, I don't feel very strongly about this. If you really dislike adding > `m_inhibit_stop_reason_processes`, I suppose we could alternatively just > declare disabling non-stop as

[Lldb-commits] [lldb] 306fc2c - [lldb] Fix build with GCC 9 after "[ADT] Use Empty Base Optimization for Allocators"

Author: Martin Storsjö Date: 2022-07-13T12:57:04+03:00 New Revision: 306fc2cd87f2a52c21eb3606eff33d78e25d9368 URL: https://github.com/llvm/llvm-project/commit/306fc2cd87f2a52c21eb3606eff33d78e25d9368 DIFF:

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

labath added a comment. In D129307#3646623 , @clayborg wrote: >> - The fact that the breakpoint path `/src/foo/bar.cc` could match debug info >> path `/build/foo/bar.cc` is definitely strange. > > Not strange at all for production builds where you build

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. FYI this change had a noticeable compile-time impact (http://llvm-compile-time-tracker.com/compare.php?from=ee88c0cf09969ba44307068797e12533b94768a6=bdc6974f92304f4ed542241b9b89ba58ba6b20aa=instructions), is that expected? Largest regressions are in kimwitu++, where