[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

jasonmolenda added a comment. In D62732#3680154 , @tzb99 wrote: > In D62732#2790160 , @sven wrote: > >> >> But the unwind can not work on my machine, the issue is similar to which >> @jade reported >> >>

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 447890. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp

[Lldb-commits] [PATCH] D130607: [trace] Add instruction control flow kind to JSON trace dumper's output

persona0220 accepted this revision. persona0220 added a comment. This revision is now accepted and ready to land. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130607/new/ https://reviews.llvm.org/D130607

[Lldb-commits] [PATCH] D130607: [trace] Add instruction control flow kind to JSON trace dumper's output

jj10306 created this revision. jj10306 added reviewers: wallace, persona0220. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D128477 adds a '-k' flag which displays

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36ae4952d70: Add string conversion for InstructionControlFlowKind enum (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130580/new/

[Lldb-commits] [lldb] d36ae49 - Add string conversion for InstructionControlFlowKind enum

Author: Jakob Johnson Date: 2022-07-26T16:09:57-07:00 New Revision: d36ae4952d709cf303a92cd4dfe38650c1c49bb1 URL: https://github.com/llvm/llvm-project/commit/d36ae4952d709cf303a92cd4dfe38650c1c49bb1 DIFF: https://github.com/llvm/llvm-project/commit/d36ae4952d709cf303a92cd4dfe38650c1c49bb1.diff

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

clayborg added a comment. In D129521#3653770 , @jingham wrote: > > If that seems right, then for now you want to just ensure that the vfork is > allowed to continue while lldb follows the parent. In that case, this isn't > quite the right way to

[Lldb-commits] [PATCH] D130602: [LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan. Part 3

fixathon created this revision. fixathon added reviewers: clayborg, aadsm, JDevlieghere, jingham. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Improve LLDB reliability by fixing the following

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:37 +Mangled mangled_name(die.GetMangledName()); +if (!lookup_info.NameMatchesLookupInfo(mangled_name.GetDemangledName(), +

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:37 +Mangled mangled_name(die.GetMangledName()); +if (!lookup_info.NameMatchesLookupInfo(mangled_name.GetDemangledName(), +

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

clayborg added inline comments. Comment at: lldb/source/Core/Module.cpp:730 +bool Module::LookupInfo::NameMatchesLookupInfo( +ConstString function_name, LanguageType language_type) const { So this function can end up being called with an empty

[Lldb-commits] [lldb] c5ddacb - [lldb/ClangExpressionParser] Fix compiler error due to `clang::CreateLLVMCodeGen()` API change

Author: Argyrios Kyrtzidis Date: 2022-07-26T14:05:22-07:00 New Revision: c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e URL: https://github.com/llvm/llvm-project/commit/c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e DIFF:

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

jasonmolenda added a comment. One small comment on the updated test: surprisingly SBSymbol doesn't have a GetSymbolSize(), probably because it's a computed value and it's possible that we could not compute it, or the heuristic may be incorrect in a stripped binary, so I get the start & end

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

jasonmolenda updated this revision to Diff 447821. jasonmolenda added a comment. Update test to address David's feedback, make it clearer how I picked the slide values and also check that the load address of the symbols are updated properly as the binary is slid. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

jasonmolenda added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:34 + +# View the first element of `first` and `second` with +# a load address . DavidSpickett wrote: > Is it worth checking here

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

JDevlieghere marked an inline comment as done. JDevlieghere added subscribers: adrian, ismail. JDevlieghere added inline comments. Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10 +def apple_silicon(test): +return platform.system() == 'Darwin' and

[Lldb-commits] [lldb] 5ee910f - [lldb] Disable TestStackFromStdModule.py

Author: Augusto Noronha Date: 2022-07-26T13:02:51-07:00 New Revision: 5ee910fef52448c141d0cd2507cee29432541cda URL: https://github.com/llvm/llvm-project/commit/5ee910fef52448c141d0cd2507cee29432541cda DIFF:

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

jj10306 updated this revision to Diff 447804. jj10306 marked 3 inline comments as done. jj10306 added a comment. Remove unnecessary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130580/new/ https://reviews.llvm.org/D130580 Files:

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

jj10306 updated this revision to Diff 447802. jj10306 added a comment. Rebase, fix merge conflicts with D130320 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130580/new/ https://reviews.llvm.org/D130580 Files:

[Lldb-commits] [PATCH] D130054: [trace][intel pt] Introduce wall clock time for each trace item

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4f676c2599eb: [trace][intel pt] Introduce wall clock time for each trace item (authored by Walter Erquinigo

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG0538e5431afd: Move GetControlFlowKinds logic to DisassemblerLLVMC.cpp (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0538e54 - Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

Author: Walter Erquinigo Date: 2022-07-26T12:05:23-07:00 New Revision: 0538e5431afdb1fa05bdcedf70ee502ccfcd112a URL: https://github.com/llvm/llvm-project/commit/0538e5431afdb1fa05bdcedf70ee502ccfcd112a DIFF:

[Lldb-commits] [lldb] 4f676c2 - [trace][intel pt] Introduce wall clock time for each trace item

Author: Walter Erquinigo Date: 2022-07-26T12:05:23-07:00 New Revision: 4f676c2599eb9c5c57528ebad93269a9ee30d7ca URL: https://github.com/llvm/llvm-project/commit/4f676c2599eb9c5c57528ebad93269a9ee30d7ca DIFF:

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

wallace accepted this revision. wallace added a comment. just remove that comment. I've just pushed Sujin's diff as well, so you can rebase Comment at: lldb/include/lldb/lldb-enumerations.h:975-976 /// A single instruction can match one or more of these categories. +/// The

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

persona0220 accepted this revision. persona0220 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/Disassembler.cpp:930 + } +} + jj10306 wrote: > Thoughts on adding a default case with a string that indicates

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

aprantl added inline comments. Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10 +def apple_silicon(test): +return platform.system() == 'Darwin' and test.getArchitecture() in [ +'arm64', 'arm64e' +] mib wrote: > Why not add this to

[Lldb-commits] [PATCH] D130524: Don't hold the StackFrame mutex while getting a ValueObject Dynamic value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b7775a472e3: StackFrame::GetValueObjectForFrameVariable holds the StackFrame lock too long. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8b7775a - StackFrame::GetValueObjectForFrameVariable holds the StackFrame lock too long.

Author: Jim Ingham Date: 2022-07-26T10:13:19-07:00 New Revision: 8b7775a472e3665dc0a9e5953f84c43da295eddd URL: https://github.com/llvm/llvm-project/commit/8b7775a472e3665dc0a9e5953f84c43da295eddd DIFF: https://github.com/llvm/llvm-project/commit/8b7775a472e3665dc0a9e5953f84c43da295eddd.diff

[Lldb-commits] [PATCH] D130540: [lldb] Read from the Rosetta shared cache with Xcode 14

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with a comment. Comment at: lldb/test/API/macosx/rosetta/TestRosetta.py:7-10 +def apple_silicon(test): +return platform.system() == 'Darwin' and test.getArchitecture() in

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

tzb99 added a comment. In D62732#2790160 , @sven wrote: > In D62732#2790087 , @luismarques > wrote: > >> In D62732#2790028 , @luismarques >> wrote: >> >>> That's

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. Can anyone with windows access try applying this patch and seeing if things build? Any help to avoid having Buildbot issues would be great Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130549/new/

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

clayborg added inline comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:32-33 +self.runCmd("run", RUN_SUCCEEDED) +self.expect("expr --allow-jit false -- a + b", VARIABLES_DISPLAYED_CORRECTLY, +substrs=['double', '44']) +

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

jj10306 added inline comments. Comment at: lldb/source/Core/Disassembler.cpp:930 + } +} + Thoughts on adding a default case with a string that indicates that no string conversion was implemented for the provided variant? This would potentially make it easier

[Lldb-commits] [PATCH] D130582: [lldb] Skip the new mte_core_file test like other MTE tests

labath added a subscriber: DavidSpickett. labath added a comment. (@DavidSpickett ) I don't think this is correct, as we should be able to open the core file on non-arm machines as well. The x86 bot (https://lab.llvm.org/buildbot/#/builders/68) seems to be fine with this. Repository: rG

[Lldb-commits] [PATCH] D130582: [lldb] Skip the new mte_core_file test like other MTE tests

gribozavr created this revision. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current exclusion is checking the LLVM backend, but it should be checking the target platform. Repository: rG

[Lldb-commits] [PATCH] D130580: Add string conversion for InstructionControlFlowKind enum

jj10306 added inline comments. Comment at: lldb/source/Target/TraceDumper.cpp:221 _info->exe_ctx))); + +m_j.attribute( ignore this accidentally included change, will delete this and update the diff Repository: rG LLVM

[Lldb-commits] [PATCH] D130580: Add string conversion for InstructionControlFlowKind enum

jj10306 updated this revision to Diff 447727. jj10306 added a comment. remove accidentily included change to trace dumper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130580/new/ https://reviews.llvm.org/D130580 Files:

[Lldb-commits] [PATCH] D130580: Add string conversion for InstructionControlFlowKind enum

jj10306 created this revision. jj10306 added reviewers: persona0220, wallace. Herald added a project: All. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Refactor the string conversion of the `lldb::InstructionControlFlowKind`

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

nhaehnle updated this revision to Diff 447708. nhaehnle added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129131/new/ https://reviews.llvm.org/D129131 Files: bolt/tools/driver/llvm-bolt.cpp

[Lldb-commits] [PATCH] D130561: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a412b3505f4: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0a412b3 - [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

Author: Michael Buch Date: 2022-07-26T15:47:35+01:00 New Revision: 0a412b3505f42558573e0d9005d4fe7c6102d8c9 URL: https://github.com/llvm/llvm-project/commit/0a412b3505f42558573e0d9005d4fe7c6102d8c9 DIFF: https://github.com/llvm/llvm-project/commit/0a412b3505f42558573e0d9005d4fe7c6102d8c9.diff

[Lldb-commits] [PATCH] D130561: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130561/new/ https://reviews.llvm.org/D130561

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 added inline comments. Comment at: lldb/test/API/lang/c/fpeval/TestFPEval.py:32 +self.runCmd("run", RUN_SUCCEEDED) +self.expect("expr --allow-jit false -- a + b", VARIABLES_DISPLAYED_CORRECTLY, +substrs=['double', '44'])

[Lldb-commits] [PATCH] D130561: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some codepaths lead to `namespace_map == nullptr` when we get to

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny added a comment. @labath, gentle ping. We appreciate all the work you've done reviewing my patches already, and we realize this is a lot of extra work for you. However, could you please try to review this one as well? It's starting to block our further work. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128989: [lldb] [llgs] Support resuming multiple processes via vCont w/ nonstop

mgorny added a comment. @labath, gentle ping. We appreciate all the work you've done reviewing my patches already, and we realize this is a lot of extra work for you. However, could you please try to review this one as well? It's the last patch from our LLGS effort, so getting it in could help

[Lldb-commits] [lldb] d0479cb - [lldb][ARM] Use portable printf tokens for 64 bit types

Author: David Spickett Date: 2022-07-26T09:12:57Z New Revision: d0479cb29018d9157ef9c90a922ffa09c445aa7d URL: https://github.com/llvm/llvm-project/commit/d0479cb29018d9157ef9c90a922ffa09c445aa7d DIFF: https://github.com/llvm/llvm-project/commit/d0479cb29018d9157ef9c90a922ffa09c445aa7d.diff

[Lldb-commits] [PATCH] D130468: [lldb][ARM] Add tests for vpush/vpop D registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10c2bab50e7a: [lldb][ARM] Add tests for vpush/vpop D registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 10c2bab - [lldb][ARM] Add tests for vpush/vpop D registers

Author: David Spickett Date: 2022-07-26T08:41:24Z New Revision: 10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4 URL: https://github.com/llvm/llvm-project/commit/10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4 DIFF: https://github.com/llvm/llvm-project/commit/10c2bab50e7aab5ad1cb5e8ecd3b12ddca3b19b4.diff

[Lldb-commits] [PATCH] D130467: [lldb][ARM] Misc improvements to TestEmulations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b6e5f9500f: [lldb][ARM] Misc improvements to TestEmulations (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130467/new/

[Lldb-commits] [lldb] c4b6e5f - [lldb][ARM] Misc improvements to TestEmulations

Author: David Spickett Date: 2022-07-26T08:31:55Z New Revision: c4b6e5f9500fc3c44d587896eb402c8ede21eb10 URL: https://github.com/llvm/llvm-project/commit/c4b6e5f9500fc3c44d587896eb402c8ede21eb10 DIFF: https://github.com/llvm/llvm-project/commit/c4b6e5f9500fc3c44d587896eb402c8ede21eb10.diff

[Lldb-commits] [PATCH] D130464: [lldb][ARM] Print mismatched registers in emulation tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ebd54194446: [lldb][ARM] Print mismatched registers in emulation tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3ebd541 - [lldb][ARM] Print mismatched registers in emulation tests

Author: David Spickett Date: 2022-07-26T08:28:27Z New Revision: 3ebd541944466dbe6b208f21c4445c65153c3103 URL: https://github.com/llvm/llvm-project/commit/3ebd541944466dbe6b208f21c4445c65153c3103 DIFF: https://github.com/llvm/llvm-project/commit/3ebd541944466dbe6b208f21c4445c65153c3103.diff

[Lldb-commits] [PATCH] D130462: [LLDB][ARM] Generalise adding register state in emulation tests and add D registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG290c4bc7be45: [LLDB][ARM] Generalise adding register state in emulation tests and add D… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 290c4bc - [LLDB][ARM] Generalise adding register state in emulation tests and add D registers

Author: David Spickett Date: 2022-07-26T08:22:26Z New Revision: 290c4bc7be45a29d98ea2e8460ef50f4924a1c4b URL: https://github.com/llvm/llvm-project/commit/290c4bc7be45a29d98ea2e8460ef50f4924a1c4b DIFF: https://github.com/llvm/llvm-project/commit/290c4bc7be45a29d98ea2e8460ef50f4924a1c4b.diff

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:34 + +# View the first element of `first` and `second` with +# a load address .

[Lldb-commits] [lldb] 2f9fa9e - [lldb][AArch64] Add support for memory tags in core files

Author: David Spickett Date: 2022-07-26T08:46:36+01:00 New Revision: 2f9fa9ef5387de3d87b0c866c678d93695c1c1f3 URL: https://github.com/llvm/llvm-project/commit/2f9fa9ef5387de3d87b0c866c678d93695c1c1f3 DIFF:

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9fa9ef5387: [lldb][AArch64] Add support for memory tags in core files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

fixathon added a comment. Thanks for review and for adding unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130307/new/ https://reviews.llvm.org/D130307 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80dbfddc5aa: [LLDB][Reliability] Fix register value unpacking (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130307/new/

[Lldb-commits] [lldb] e80dbfd - [LLDB][Reliability] Fix register value unpacking

Author: Slava Gurevich Date: 2022-07-26T00:22:40-07:00 New Revision: e80dbfddc5aa567aea0a974708af4122c2b49829 URL: https://github.com/llvm/llvm-project/commit/e80dbfddc5aa567aea0a974708af4122c2b49829 DIFF:

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg created this revision. clayborg added reviewers: JDevlieghere, thakis, smeenai. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Resubmission of