[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. The only concern is that if it would be not so easy to read if there is too many levels? (Consider the 30levels example in D132451 ). If it would be better to print `...` at certain level? Or this is already handled by lldb?

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. LGTM basically. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132624/new/ https://reviews.llvm.org/D132624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

jasonmolenda added a comment. `Process::ReadModuleFromMemory()` takes a FileSpec and header address in memory (and a size to read, default 512 bytes). It calls through `Module::GetMemoryObjectFile`. That reads the 512 bytes of memory into a buffer and calls `ObjectFile::FindPlugin` class

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, I meant to remove those in a previous patch. Thanks for following up on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang created this revision. avogelsgesang added reviewers: Chuanfeng, aprantl, dblaikie, ychen, jryans, JDevlieghere. Herald added subscribers: ChuanqiXu, Prazek. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets

JDevlieghere updated this revision to Diff 455428. JDevlieghere retitled this revision from "[lldb] Teach LLDB about filesets (WIP)" to "[lldb] Teach LLDB about filesets". JDevlieghere added a comment. - Rebase - Support reading Filesets from memory CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b6d56dd - [LLDB] Clean up after command fails

Author: Zequan Wu Date: 2022-08-24T16:00:50-07:00 New Revision: b6d56ddac1bf50d532abdc86a84f9bc8e3e7a266 URL: https://github.com/llvm/llvm-project/commit/b6d56ddac1bf50d532abdc86a84f9bc8e3e7a266 DIFF: https://github.com/llvm/llvm-project/commit/b6d56ddac1bf50d532abdc86a84f9bc8e3e7a266.diff

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d56ddac1bf: [LLDB] Clean up after command fails (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione added a comment. @jingham what do you think of this update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D132514: [lldb] Remove obsolete Android-specific definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGee9d52a28196: [lldb] Remove obsolete Android-specific definitions (authored by pirama). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132514/new/

[Lldb-commits] [lldb] ee9d52a - [lldb] Remove obsolete Android-specific definitions

Author: Pirama Arumuga Nainar Date: 2022-08-24T21:47:13Z New Revision: ee9d52a2819668c746aa66e7d628cce04bedbd17 URL: https://github.com/llvm/llvm-project/commit/ee9d52a2819668c746aa66e7d628cce04bedbd17 DIFF:

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

This revision was automatically updated to reflect the committed changes. Closed by commit rG91389000abe8: [LLDB] Add data formatter for std::coroutine_handle (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/

[Lldb-commits] [lldb] 9138900 - [LLDB] Add data formatter for std::coroutine_handle

Author: Adrian Vogelsgesang Date: 2022-08-24T14:40:53-07:00 New Revision: 91389000abe8ef5d06d98cbbefd3fa03ac7e4480 URL: https://github.com/llvm/llvm-project/commit/91389000abe8ef5d06d98cbbefd3fa03ac7e4480 DIFF:

[Lldb-commits] [lldb] f012087 - [lldb] Remove unused functions in ObjectContainer (NFC)

Author: Jonas Devlieghere Date: 2022-08-24T14:26:16-07:00 New Revision: f01208781fd72fca2c49c24c651bf0ce3bc0fb3e URL: https://github.com/llvm/llvm-project/commit/f01208781fd72fca2c49c24c651bf0ce3bc0fb3e DIFF:

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455371. kasper81 added a comment. Added a `FIXME` comment in `CreateDefaultUnwindPlan`, based on advice from @jasonmolenda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132598/new/ https://reviews.llvm.org/D132598

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda added a comment. In D132510#3745412 , @kasper81 wrote: > @jasonmolenda the problem with original review is that we were waiting for > the wholesale support for 3.5 years, and it rendered into an impossible task > for the author. I don't

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } fdeazeve

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

fdeazeve added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } aprantl

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 +filter_modules.EmplaceBack("libc++abi.1.0.dylib"); +filter_modules.EmplaceBack("libc++abi.1.dylib"); } Should these

[Lldb-commits] [PATCH] D132598: [lldb] Add more dylib paths for exception breakpoints

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When setting a breakpoint upon throwing exceptions, LLDB only searches for the libc++abi code inside dylibs named: 1.

[Lldb-commits] [PATCH] D132596: [lldb][nfc] Remove unused makefile test variables

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The variables LLDB_USING_LIBSTDCPP and LLDB_USING_LIBSTDCPP are no longer used anywhere. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu updated this revision to Diff 455311. zequanwu added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/ https://reviews.llvm.org/D132397 Files: lldb/source/Interpreter/CommandObject.cpp

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny updated this revision to Diff 455295. mgorny added a comment. Update to the version with error support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132578/new/ https://reviews.llvm.org/D132578 Files: lldb/include/lldb/Core/Communication.h

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. When read thread is enabled, perform all the writes in the thread as well. Most importantly,

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny updated this revision to Diff 455291. mgorny added a comment. Rebase/update for the new error passing mechanism. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132283/new/ https://reviews.llvm.org/D132283 Files: lldb/include/lldb/Core/Communication.h

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Ensure that the ConnectionStatus and Status from Communication::ReadThread() is correctly

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38 + +enum riscv_dwarf_regnums { + dwarf_x0 = 0, Emmmer wrote: > This enum can be included from `lldb/source/Utility/RISCV_DWARF_Registers.h` Thanks, I have reused that

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Actually, I think this is 100% correct, and corrects an error I made when I added argument number checking a little while back. The comments on CheckRequirements say: Every command should

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. Whew, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

jingham added a comment. Each new command invocation is expected to prime the ExecutionContext before invoking the command. I don't think there's any situation where one command should use a previous command's execution context on purpose. So if we're getting to Execute without the

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

sebastian-ne added a comment. The build afterwards succeeded again. Seems like every ~20th build on that windows machine fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 added a comment. https://lab.llvm.org/buildbot#builders/13/builds/24958 I am worried this failure is not spurious? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added inline comments. Herald added subscribers: pmatos, asb. Herald added a project: All. Comment at: lldb/source/Symbol/ObjectFile.cpp:739 +// are protected by a mutex in the Symtab object itself. +llvm::call_once(*m_symtab_once_up, [&]() { +

[Lldb-commits] [lldb] 849ca46 - [LLDB] Skip TestFunctionTemplateSpecializationTempArgs for Arm64/Windows

Author: Muhammad Omair Javaid Date: 2022-08-24T20:07:00+05:00 New Revision: 849ca4626e9706d7b132ea696c5bf8c0ba0dc977 URL: https://github.com/llvm/llvm-project/commit/849ca4626e9706d7b132ea696c5bf8c0ba0dc977 DIFF:

[Lldb-commits] [lldb] ad8c34b - [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Author: John Ericson Date: 2022-08-24T10:14:05-04:00 New Revision: ad8c34bc3089d847a09bb740f7a58c96073e0959 URL: https://github.com/llvm/llvm-project/commit/ad8c34bc3089d847a09bb740f7a58c96073e0959 DIFF: https://github.com/llvm/llvm-project/commit/ad8c34bc3089d847a09bb740f7a58c96073e0959.diff

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455177. kasper81 marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files: lldb/source/Plugins/ABI/CMakeLists.txt

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 updated this revision to Diff 455176. kasper81 added a comment. Reuse existing dwarf enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510 Files:

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @jasonmolenda the problem with original review is that we were waiting for the wholesale support for 3.5 years, and it rendered into an impossible task for the author. I don't want to make this one "all or none" kind of a deal as well. This patch is n neither bringing

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

mgorny added a comment. Yeah, I meant inside LLDB, since that's what we're talking about. Basically, I'm wondering if we should perhaps rename `WriteAll()` to `Write()`, remove the old `Write()` method and just use the looped variant everywhere (implying also via `SB*`). Repository: rG

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D131437#3741132 , @clayborg wrote: > So I can't get -fsplit-dwarf-inlining to emit anything when I try to cross > with clang. I add the flag but

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

labath added a comment. > To be honest, I can't think of a real use case where aliasing Write() to > WriteAll() would make a caller-visible difference. If you mean, "in the lldb code base", then you might be right, but generally speaking, the difference is in the handling of interrupts and

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

labath added a comment. I'm not really familiar this code, but could something like `llvm::make_scope_exit` be useful here? Also, what is the effect of not calling Cleanup? That subsequent commands fail in some way? Could we make a test case for that? Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

labath added a comment. In D131159#3743497 , @mstorsjo wrote: > In D131159#3742370 , @labath wrote: > >> In D131159#3742364 , @mgorny wrote: >> >>> In D131159#3742235

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:39 + CompilerType coro_func_type = ast_ctx.CreateFunctionType( + /*result_type*/ void_type, /*args*/ _type, /*num_args*/ 1, + /*is_variadic*/ false, /*qualifiers*/

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 455111. avogelsgesang marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt

[Lldb-commits] [PATCH] D132514: [lldb] Remove obsolete Android-specific definitions

srhines accepted this revision. srhines added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132514/new/ https://reviews.llvm.org/D132514 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

Emmmer added a comment. Currently, `lldb/source/Plugins/Instruction/RISCV/EmulateInstructionRISCV.cpp` only handles a few jump instructions, we can refine it further if needed. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:38 + +enum riscv_dwarf_regnums { +

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda added a comment. I think this DefaultUnwindPlan has the same problem that the previous patch did -- this looks like the unwind state on function entry. There is an `ABI::CreateFunctionEntryUnwindPlan()` for the unwind state on the first instruction of a function, but the idea of