[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

2022-09-17 Thread Thorsten via Phabricator via lldb-commits
tschuett added a comment. Sorry. I hoped that variant would make your life easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134041/new/ https://reviews.llvm.org/D134041 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

2022-09-17 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. FYI, this change caused a strange regression for reading PDB files in i386 mode, when LLDB is built in mingw mode (not when it is built in MSVC mode), see https://github.com/llvm/llvm-project/issues/57799 for details. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D134111: [lldb] Add newline in output of `target modules lookup`

2022-09-17 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun created this revision. alvinhochun added a reviewer: labath. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a line break between each result address in the output of the lldb c

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

2022-09-17 Thread Alvin Wong via Phabricator via lldb-commits
alvinhochun added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1550 +} else { + strm.IndentMore(); + strm.Indent("Value: "); This `IndentMore` added is missing a matching `IndentLess` call.