[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

yinghuitan added a comment. Do you plan to detect missing dwp file from `SymbolFileDWARF::GetDwpSymbolFile()` as well? Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755-1756 cu_die.GetAttributeValueAsString(dwarf_cu, DW_AT_comp_dir, nullptr);

[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b4db10f3492: [lldb] Actually support more than 32 logging categories (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 3b4db10 - [lldb] Actually support more than 32 logging categories

Author: Jonas Devlieghere Date: 2022-09-19T22:31:20-07:00 New Revision: 3b4db10f3492dfbab705ca4b2dd19d32fee075b9 URL: https://github.com/llvm/llvm-project/commit/3b4db10f3492dfbab705ca4b2dd19d32fee075b9 DIFF:

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aadsm, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When debugging using Fission (-gsplit-dwarf), we can

[Lldb-commits] [lldb] d3a536f - [lldb] Appease the MSCV compiler

Author: Jonas Devlieghere Date: 2022-09-19T17:37:27-07:00 New Revision: d3a536fa933bba5ffad48d7e5ab7de6f358550e7 URL: https://github.com/llvm/llvm-project/commit/d3a536fa933bba5ffad48d7e5ab7de6f358550e7 DIFF:

[Lldb-commits] [PATCH] D134245: [lldb] Actually support more than 32 logging categories

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. In January, Greg put up a patch (D117382 ) to support more than 32 log categories, among other

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

jgorbe created this revision. jgorbe added reviewers: labath, rupprecht, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. - Merge pairs like `eFormatCategoryItemSummary` and

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/

[Lldb-commits] [lldb] dc9e6c5 - Add auto deduce source map setting

Author: Jeffrey Tan Date: 2022-09-19T13:40:22-07:00 New Revision: dc9e6c52f3d805ab454bcf2a4502037d15fb2b8c URL: https://github.com/llvm/llvm-project/commit/dc9e6c52f3d805ab454bcf2a4502037d15fb2b8c DIFF: https://github.com/llvm/llvm-project/commit/dc9e6c52f3d805ab454bcf2a4502037d15fb2b8c.diff

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1550 +} else { + strm.IndentMore(); + strm.Indent("Value: "); alvinhochun wrote: > This `IndentMore` added is missing a matching `IndentLess`

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

alvinhochun added a comment. Separated the first part with some new changes here: https://reviews.llvm.org/D134196 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134133/new/ https://reviews.llvm.org/D134133

[Lldb-commits] [PATCH] D134196: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This reimplements

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

This revision was automatically updated to reflect the committed changes. Closed by commit rG974958749827: [lldb] Reset breakpoint hit count before new runs (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133858/new/

[Lldb-commits] [lldb] 9749587 - [lldb] Reset breakpoint hit count before new runs

Author: Felipe de Azevedo Piovezan Date: 2022-09-19T12:56:12-04:00 New Revision: 974958749827bc4fb88b67feab4bcd7536f70456 URL: https://github.com/llvm/llvm-project/commit/974958749827bc4fb88b67feab4bcd7536f70456 DIFF:

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 461235. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. rename `IsNoopResumeDestroy` -> `IsNoopCoroFunction` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132735/new/

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang marked 4 inline comments as done. avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:19 -static ValueObjectSP GetCoroFramePtrFromHandle(ValueObject ) { - ValueObjectSP valobj_sp(valobj.GetNonSyntheticValue());

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang added a comment. > wondering if we couldn't fix this by creating the (non-pointer) object using > the CreateValueObjectFromAddress function, as above, but then actually use > valobj->AddressOf as the synthetic child yes, that worked quite nicely Repository: rG LLVM Github

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 461232. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132815/new/ https://reviews.llvm.org/D132815

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd +=

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)

labath added inline comments. Comment at: lldb/include/lldb/API/SBError.h:95 private: - std::unique_ptr m_opaque_up; + std::shared_ptr m_opaque_sp; This is technically an ABI break (changes `sizeof(SBError)`). I don't care, but someone might.

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

labath added a comment. In D133906#3792666 , @JDevlieghere wrote: > In D133906#3792230 , @labath wrote: > >> // no .def file >> #define LLDB_FORWARD_CLASS(cls) \ >> namespace lldb_private { class cls; }

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

labath added a comment. I think the main reason that the RegisterInfo struct is such as it is, is because it wants to be trivially constructible (or whatever the c++ term for that is). I'm pretty sure that adding a std::string member will make it stop being that, and I don't think we suddenly

[Lldb-commits] [PATCH] D134111: [lldb] Add newline in output of `target modules lookup`

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/Commands/command-target-modules-lookup.test:13 +# CHECK-NEXT: Summary: [[MODULE]]`someOtherFunc(double) +# CHECK-NOT: ignoreThisFunction

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata()->SetIsForcefullyCompleted(); + } zequanwu wrote: > rnk wrote: > > Is this

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

alvinhochun added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819 + if (exported->GetType() != lldb::eSymbolTypeReExported && + exported->GetAddressRef() == symbols[i].GetAddressRef()) { +

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

mstorsjo added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:787 + Symbol *symbols = symtab.Extend(num_syms); + uint32_t i = 0; + for (const auto _ref : m_binary->symbols()) { alvinhochun wrote: > mstorsjo wrote: > >

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

alvinhochun added a comment. Thanks for the review. Yes I shall split the changes into smaller pieces to aid review. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1558 } + strm.IndentLess(); } mstorsjo wrote: > Looks

[Lldb-commits] [PATCH] D134133: WIP: [lldb][COFF] Enhance symtab loading of symbol and export tables

mstorsjo added a comment. So previously, LLDB essentially used the COFF symbol table for executables, but only the list of exported symbols for DLLs, ignoring (or, reading and then overwriting) the symbol table for any DLL with exports? Then this certainly does look like a good direction.