[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After recent diffs that enable variable errors that stop

[Lldb-commits] [PATCH] D133670: [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV

Emmmer added a comment. In D133670#3804437 , @aprantl wrote: > Hey @Emmmer the unit test is throwing a UBSAN failure, could you please take > a look? > >

[Lldb-commits] [lldb] 07d0ef3 - [LLDB][RISCV] Fix UndefinedBehaviorSanitizer in RISCVEmulatorTester

Author: Emmmer Date: 2022-09-21T11:56:55+08:00 New Revision: 07d0ef306b74fbcede432ad3480d2f299c051a98 URL: https://github.com/llvm/llvm-project/commit/07d0ef306b74fbcede432ad3480d2f299c051a98 DIFF: https://github.com/llvm/llvm-project/commit/07d0ef306b74fbcede432ad3480d2f299c051a98.diff LOG:

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe marked 3 inline comments as done. jgorbe added a comment. Thanks for the review! Please take another look. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:76 +uint32_t result = 0; +for (auto sc : m_subcontainers) { + result += sc->GetCount();

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

jgorbe updated this revision to Diff 461775. jgorbe added a comment. Address review feedback: - Removed asserts on `GetXXXAtIndex` methods when the index is out of range. Return a default-initialized shared_ptr of the right type instead (which will result in an invalid value when returned back

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

clayborg updated this revision to Diff 461760. clayborg added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Remove commented out dead code from TestFrameVar.py - Add DWO error for when compilation directory isn't available for a relative path .dwo file -

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

GeorgeHuyubo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:82 if (!m_dwo_id) return; // No DWO file. Do we want to SetDwoError here? Since there is no DWO file. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755-1756 cu_die.GetAttributeValueAsString(dwarf_cu, DW_AT_comp_dir, nullptr); if (!comp_dir) return nullptr; yinghuitan wrote: > We

[Lldb-commits] [PATCH] D133670: [LLDB][RISCV] Add RVM and RVA instruction support for EmulateInstructionRISCV

aprantl added a comment. Hey @Emmmer the unit test is throwing a UBSAN failure, could you please take a look? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/lastFailedBuild/testReport/lldb-unit/Instruction___EmulatorTests_3/26/ Stacktrace Script(shard): --

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. In D132510#3771030 , @kasper81 wrote: > @jasonmolenda, @Emmmer, any other feedback, or good to merge? i will work on >

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

clayborg added a comment. I do share the concern that Pavel has where currently RegisterInfo does not require global constructors, and it would be good to keep it this way. Right now RegisterInfo is POD which means if there is a global array of RegisterInfo structs, it gets written into a data

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

clayborg added a comment. Looks fine to me as this is all NFC with a look toward the future. Only one questions about if we want to switch the EmulateInstruction::GetRegisterInfo to return an optional as well? Comment at:

[Lldb-commits] [lldb] d4514b1 - [LLDB][NativePDB] Pass register_kind as reference (an oversight in 71d778f).

Author: Zequan Wu Date: 2022-09-20T13:41:13-07:00 New Revision: d4514b155337f013022c6e989d3e6b7183a8b80e URL: https://github.com/llvm/llvm-project/commit/d4514b155337f013022c6e989d3e6b7183a8b80e DIFF: https://github.com/llvm/llvm-project/commit/d4514b155337f013022c6e989d3e6b7183a8b80e.diff

[Lldb-commits] [lldb] 3ae6337 - [LLDB]Initialize accept_socket with nullptr

Author: George Hu Date: 2022-09-20T12:17:32-07:00 New Revision: 3ae633766b57717522644ef44c5602a9a6402ee6 URL: https://github.com/llvm/llvm-project/commit/3ae633766b57717522644ef44c5602a9a6402ee6 DIFF: https://github.com/llvm/llvm-project/commit/3ae633766b57717522644ef44c5602a9a6402ee6.diff

[Lldb-commits] [PATCH] D134293: [LLDB]Initialize accept_socket with nullptr

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae633766b57: [LLDB]Initialize accept_socket with nullptr (authored by GeorgeHuyubo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134293/new/

[Lldb-commits] [PATCH] D134293: [LLDB]Initialize accept_socket with nullptr

GeorgeHuyubo created this revision. Herald added a project: All. GeorgeHuyubo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix high impact issue of illegal access of memory. Initialize accept_socket with nullptr. Repository: rG LLVM

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/include/lldb/lldb-private-enumerations.h:131-134 eFormatCategoryItemSummary = 0x0001, - eFormatCategoryItemRegexSummary = 0x0002, eFormatCategoryItemFilter = 0x0004, -

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdce688733600: [NFCI] Clean up enum FormatCategoryItem. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D134244?vs=461418=461613#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] dce6887 - [NFCI] Clean up enum FormatCategoryItem.

Author: Jorge Gorbe Moya Date: 2022-09-20T10:41:06-07:00 New Revision: dce68873360097be77ff8b3ce68b6eedc612fbef URL: https://github.com/llvm/llvm-project/commit/dce68873360097be77ff8b3ce68b6eedc612fbef DIFF:

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd += ['--libcxx-include-target-dir',

[Lldb-commits] [PATCH] D134244: [NFCI] Clean up enum FormatCategoryItem.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM modulo the enum values. Comment at: lldb/include/lldb/lldb-private-enumerations.h:131-134 eFormatCategoryItemSummary = 0x0001, -

[Lldb-commits] [PATCH] D134196: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

alvinhochun marked 2 inline comments as done. alvinhochun added a comment. Thanks for reviewing. The COFF symbol table seems to be used by MinGW binaries in conjunction with DWARF debugging symbols. Some symbols (those added by the linker in particular) are not included in the DWARF symbol. I

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

This revision was automatically updated to reflect the committed changes. Closed by commit rGec3e290502db: [lldb] Log when we cannot find an equivalent for a gdb register type (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ec3e290 - [lldb] Log when we cannot find an equivalent for a gdb register type

Author: David Spickett Date: 2022-09-20T09:26:55Z New Revision: ec3e290502db5ab7dbaa067e674c5ee6cb34ac10 URL: https://github.com/llvm/llvm-project/commit/ec3e290502db5ab7dbaa067e674c5ee6cb34ac10 DIFF: https://github.com/llvm/llvm-project/commit/ec3e290502db5ab7dbaa067e674c5ee6cb34ac10.diff

[Lldb-commits] [PATCH] D134039: [LLDB] Make instruction emulation context type private

This revision was automatically updated to reflect the committed changes. Closed by commit rG01d8270a1560: [LLDB] Make instruction emulation context type private (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134039/new/

[Lldb-commits] [lldb] 01d8270 - [LLDB] Make instruction emulation context type private

Author: David Spickett Date: 2022-09-20T09:10:14Z New Revision: 01d8270a1560f2b9282cb50dab99f087e860a162 URL: https://github.com/llvm/llvm-project/commit/01d8270a1560f2b9282cb50dab99f087e860a162 DIFF: https://github.com/llvm/llvm-project/commit/01d8270a1560f2b9282cb50dab99f087e860a162.diff

[Lldb-commits] [PATCH] D134035: [LLDB] Format lldb-server's target XML

This revision was automatically updated to reflect the committed changes. Closed by commit rGba822e248d3a: [LLDB] Format lldb-servers target XML (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134035/new/

[Lldb-commits] [lldb] ba822e2 - [LLDB] Format lldb-server's target XML

Author: David Spickett Date: 2022-09-20T09:02:17Z New Revision: ba822e248d3a41aa334eb1b79396364ee251c10c URL: https://github.com/llvm/llvm-project/commit/ba822e248d3a41aa334eb1b79396364ee251c10c DIFF: https://github.com/llvm/llvm-project/commit/ba822e248d3a41aa334eb1b79396364ee251c10c.diff

[Lldb-commits] [PATCH] D134265: [lldb][COFF] Improve info of symbols from export table

alvinhochun created this revision. alvinhochun added reviewers: labath, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Skip dummy/invalid export symbols. - Make the

[Lldb-commits] [PATCH] D134043: [lldb] Log when we cannot find an equivalent for a gdb register type

DavidSpickett added a comment. I didn't know about that, it's exactly what I wanted - if it worked with msvc https://godbolt.org/z/cqYf3c39n. It is used in lldb but only in tests we know will be compiled with clang (well, we assume) and some Mac OS native code which will be clang compiled.

[Lldb-commits] [PATCH] D134196: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

alvinhochun updated this revision to Diff 461496. alvinhochun added a comment. Updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134196/new/ https://reviews.llvm.org/D134196 Files:

[Lldb-commits] [PATCH] D134111: [lldb] Add newline in output of `target modules lookup`

alvinhochun updated this revision to Diff 461486. alvinhochun added a comment. Use --implicit-check-not in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134111/new/ https://reviews.llvm.org/D134111 Files:

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

labath added inline comments. Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:76 +uint32_t result = 0; +for (auto sc : m_subcontainers) { + result += sc->GetCount(); According to

[Lldb-commits] [PATCH] D134196: [lldb][COFF] Rewrite ParseSymtab to list both export and symbol tables

labath added a comment. I don't know how coff symbol tables work, but this seems reasonable to me. Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbols-export-table.yaml:10 +# CHECK-NEXT: D Code 0x0001800010100x{{[0-9a-f]+}} 0x{{[0-9a-f]+}} exportfunc +#