[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

shafik added a comment. Note, in both C and C++ converting a `-1` to unsigned will always result in the max unsigned value e.g.: #include #include int main() { int8_t i8 = -1; int32_t i32 = -1; unsigned x = i8; std::cout << x << "\n"; x = i32; std::cout

[Lldb-commits] [PATCH] D130534: loading a binary at a slide multiple times leaves old entries in the SectionLoadList

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fee25629d9d: Clear old section-to-addr entry when loading Section at new addr (authored by jasonmolenda). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 1fee256 - Clear old section-to-addr entry when loading Section at new addr

Author: Jason Molenda Date: 2022-09-27T16:20:26-07:00 New Revision: 1fee25629d9d3f33cc618cb2b61cdf3823bfd092 URL: https://github.com/llvm/llvm-project/commit/1fee25629d9d3f33cc618cb2b61cdf3823bfd092 DIFF: https://github.com/llvm/llvm-project/commit/1fee25629d9d3f33cc618cb2b61cdf3823bfd092.diff

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The callback system to iterate over every formatter of a given kind in a

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

clayborg added a comment. In D134508#381 , @JDevlieghere wrote: > Instead of storing a bool, would it make sense to store the error instead and > then have the statistics call `isFail` on it to determine whether there was > an issue? We would

[Lldb-commits] [PATCH] D134768: [NFCI] More TypeCategoryImpl refactoring.

jgorbe abandoned this revision. jgorbe added a comment. whoops, I need to commit some other local change before this one. I'm going to abandon this revision and I'll re-send this patch when its dependency lands. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134768: [NFCI] More TypeCategoryImpl refactoring.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The main aim of this patch is deleting the remaining instances of code reaching into

[Lldb-commits] [PATCH] D133910: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jgorbe marked 3 inline comments as done. Closed by commit rG1f2a21820dfa: [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer. (authored by jgorbe).

[Lldb-commits] [lldb] 1f2a218 - [NFCI] Refactor FormatterContainerPair into TieredFormatterContainer.

Author: Jorge Gorbe Moya Date: 2022-09-27T14:28:41-07:00 New Revision: 1f2a21820dfa2c97de8cc9e09cd03cf1c1684e31 URL: https://github.com/llvm/llvm-project/commit/1f2a21820dfa2c97de8cc9e09cd03cf1c1684e31 DIFF:

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu added a comment. >> For members from parent classes, pdb only has information saying that its >> direct parents class are at some offsets for this class. For class without >> vtable, it's easy to calculate inherited member offsets by adding parent >> class offsets with their member

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

jasonmolenda added a comment. This looks good to me, fwiw. I agree with Pavel about hardcoding the order that libraries might appear unless that ordering is essentially considered API. We could get in a situation where different versions of windows report the binaries in different order, and

[Lldb-commits] [lldb] 670cac7 - Rename a duplicate test, also give the test class a useful name.

Author: Jim Ingham Date: 2022-09-27T12:38:22-07:00 New Revision: 670cac72804bbeb91fd0653de621aa03f70600e3 URL: https://github.com/llvm/llvm-project/commit/670cac72804bbeb91fd0653de621aa03f70600e3 DIFF: https://github.com/llvm/llvm-project/commit/670cac72804bbeb91fd0653de621aa03f70600e3.diff

[Lldb-commits] [PATCH] D134508: Track which modules have debug info variable errors.

JDevlieghere added a comment. Instead of storing a bool, would it make sense to store the error instead and then have the statistics call `isFail` on it to determine whether there was an issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

labath added a comment. In D134656#3818759 , @zequanwu wrote: > In D134656#3818234 , @labath wrote: > >> That said, I am kinda surprised that this is the whole thing. I would have >> expected to see more here.

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM pending Pavel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

labath added a comment. In D133858#3818755 , @jingham wrote: > If we use Target::CreateProcess to handle this task, how do we ensure that > that will always get called any time we make a new process? I'm not really sure how to answer that. Clearly

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd434f437200b: [LLDB][NativePDB] Add class/union layout bit size. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] d434f43 - [LLDB][NativePDB] Add class/union layout bit size.

Author: Zequan Wu Date: 2022-09-27T11:41:55-07:00 New Revision: d434f437200bdf8d94a47346dd5c64cc3cc5c5fa URL: https://github.com/llvm/llvm-project/commit/d434f437200bdf8d94a47346dd5c64cc3cc5c5fa DIFF: https://github.com/llvm/llvm-project/commit/d434f437200bdf8d94a47346dd5c64cc3cc5c5fa.diff

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu added a comment. In D134656#3818234 , @labath wrote: > That said, I am kinda surprised that this is the whole thing. I would have > expected to see more here. In dwarf we specify the offsets of individual > class members. Does PDB encode that

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu updated this revision to Diff 463290. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134656/new/ https://reviews.llvm.org/D134656 Files:

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

jingham added a comment. If we use Target::CreateProcess to handle this task, how do we ensure that that will always get called any time we make a new process? That function doesn't do all that much special, it's only a couple lines long so it could easily get inlined somewhere. Repository:

[Lldb-commits] [PATCH] D134751: [lldb] Fix running tests when LLVM target triple is different from host

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Supporting builds with different host and target triples makes sense. However, I have a few concerns about the current patch: - I wouldn't cal it the "host triple". The

[Lldb-commits] [PATCH] D134754: [lldb/gdb-server] Better reporting of launch errors

labath created this revision. labath added reviewers: mgorny, jasonmolenda. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Use our "rich error" facility to propagate error reported by the stub to the user. lldb-server reports rich launch

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3e60044d758: [LLDB][NativePDB] Let native pdb use class layout in debug info. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a3e6004 - [LLDB][NativePDB] Let native pdb use class layout in debug info.

Author: Zequan Wu Date: 2022-09-27T11:01:32-07:00 New Revision: a3e60044d75823a3cd8e35de76b7bde2599fe740 URL: https://github.com/llvm/llvm-project/commit/a3e60044d75823a3cd8e35de76b7bde2599fe740 DIFF: https://github.com/llvm/llvm-project/commit/a3e60044d75823a3cd8e35de76b7bde2599fe740.diff

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun added a comment. Okay, I'll rebase the change to remove the dependency on D134581 . Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:21-22 # CHECK-NEXT: .main.exe -# CHECK-NEXT: .shlib.dll +# CHECK-NEXT:

[Lldb-commits] [PATCH] D134751: [lldb] Fix running tests when LLVM target triple is different from host

alvinhochun created this revision. alvinhochun added reviewers: labath, JDevlieghere, DavidSpickett, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This passes the host triple to the

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

labath added subscribers: jingham, labath. labath added a reviewer: jingham. labath added a comment. The current behavior is clearly not useful, but I don't have any context to be able to determine whether there's something else that can be done about that. @jingham might have it. CHANGES

[Lldb-commits] [PATCH] D134661: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Michael137 marked an inline comment as done. Closed by commit rG60eb06be6d23: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++… (authored by

[Lldb-commits] [lldb] 60eb06b - [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

Author: Michael Buch Date: 2022-09-27T18:03:23+01:00 New Revision: 60eb06be6d23e3c5fd80113143784aac0d962965 URL: https://github.com/llvm/llvm-project/commit/60eb06be6d23e3c5fd80113143784aac0d962965 DIFF: https://github.com/llvm/llvm-project/commit/60eb06be6d23e3c5fd80113143784aac0d962965.diff

[Lldb-commits] [PATCH] D134661: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:41 #include "llvm/Demangle/Demangle.h" #include "clang/AST/CXXInheritance.h" labath wrote: > I guess the

[Lldb-commits] [PATCH] D134661: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

Michael137 updated this revision to Diff 463268. Michael137 added a comment. - Fix includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134661/new/ https://reviews.llvm.org/D134661 Files:

[Lldb-commits] [PATCH] D134518: [lldb][COFF] Add note to forwarder export symbols in symtab

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D134518#3811382 , @alvinhochun wrote: > In D134518#3811218 , @labath wrote: > >> Ok, so is there any

[Lldb-commits] [PATCH] D134426: [lldb][COFF] Match symbols from COFF symbol table to export symbols

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems fine to me from a general perspective. I think others have already checked the windows parts. Comment at:

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:21-22 # CHECK-NEXT: .main.exe -# CHECK-NEXT: .shlib.dll +# CHECK-NEXT: ntdll.dll +# CHECK-NEXT:

[Lldb-commits] [PATCH] D134661: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

labath accepted this revision. labath added a subscriber: zequanwu. labath added a comment. This revision is now accepted and ready to land. Looks straight forward enough. Tagging @zequanwu, as he might want to do something similar for PDB. Comment at:

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

labath added a comment. In D133858#3816105 , @fdeazeve wrote: > In D133858#3805630 , @labath wrote: > >> I am afraid that this patch misses one method of initiating a debug session >> -- connecting to a running

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

labath added a comment. The vscode change seems fine to me, but I don't consider myself an authority on that. In D134333#3812653 , @jingham wrote: > In D134333#3812448 , @clayborg > wrote: > >> I just did a

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

labath added a comment. In D134581#3817457 , @alvinhochun wrote: > In D134581#3815766 , @jasonmolenda > wrote: > >> In D134581#3813757 , @alvinhochun >> wrote: >> >>>

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

labath added a comment. That said, I am kinda surprised that this is the whole thing. I would have expected to see more here. In dwarf we specify the offsets of individual class members. Does PDB encode that information? If not, how does it handle the case when the definition of some class is

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM modulo formatting. Comment at: lldb/test/Shell/SymbolFile/NativePDB/packed_class_layout.cpp:24 + +union __attribute__((packed, aligned(1))) U { + char c[2];

[Lldb-commits] [PATCH] D134727: [lldb][test] Remove failing ValueCheck on deprecated libcxx entity

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ccfaecba6b1: [lldb][test] Remove failing ValueCheck on deprecated libcxx entity (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7ccfaec - [lldb][test] Remove failing ValueCheck on deprecated libcxx entity

Author: Michael Buch Date: 2022-09-27T14:11:02+01:00 New Revision: 7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c URL: https://github.com/llvm/llvm-project/commit/7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c DIFF: https://github.com/llvm/llvm-project/commit/7ccfaecba6b1aa80eea1903b2c5ee20d4f00374c.diff

[Lldb-commits] [PATCH] D134734: [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc97e5adbf7c4: [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions (authored by Michael137). Repository: rG LLVM

[Lldb-commits] [lldb] c97e5ad - [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions

Author: Michael Buch Date: 2022-09-27T14:09:12+01:00 New Revision: c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9 URL: https://github.com/llvm/llvm-project/commit/c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9 DIFF: https://github.com/llvm/llvm-project/commit/c97e5adbf7c44ba5c46ec14712d3d8ee8b45aac9.diff

[Lldb-commits] [PATCH] D134734: [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions

Michael137 updated this revision to Diff 463209. Michael137 added a comment. - Works on DWARFv3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134734/new/ https://reviews.llvm.org/D134734 Files:

[Lldb-commits] [PATCH] D134734: [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134734/new/ https://reviews.llvm.org/D134734

[Lldb-commits] [PATCH] D134734: [lldb][test] Disable TestSBValueUnsignedEnumBitField.py for old DWARF versions

Michael137 created this revision. Michael137 added reviewers: aprantl, fdeazeve. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With older DWARF versions we don't encode the enum's underlying type

[Lldb-commits] [PATCH] D134727: [lldb][test] Remove failing ValueCheck on deprecated libcxx entity

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. Thanks for looking into this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134727/new/ https://reviews.llvm.org/D134727

[Lldb-commits] [PATCH] D134727: [lldb][test] Remove failing ValueCheck on deprecated libcxx entity

Michael137 created this revision. Michael137 added reviewers: aprantl, fdeazeve. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A recent libcxx change renamed all internal variables starting with

[Lldb-commits] [PATCH] D134516: [lldb] Improve display of absolute symbol lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4991bfa891e: [lldb] Improve display of absolute symbol lookup (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134111: [lldb] Add newline in output of `target modules lookup`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa426753ef029: [lldb] Add newline in output of `target modules lookup` (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a426753 - [lldb] Add newline in output of `target modules lookup`

Author: Alvin Wong Date: 2022-09-27T13:09:45+03:00 New Revision: a426753ef0290362a0268f917dba46d6b9744b02 URL: https://github.com/llvm/llvm-project/commit/a426753ef0290362a0268f917dba46d6b9744b02 DIFF: https://github.com/llvm/llvm-project/commit/a426753ef0290362a0268f917dba46d6b9744b02.diff

[Lldb-commits] [lldb] f4991bf - [lldb] Improve display of absolute symbol lookup

Author: Alvin Wong Date: 2022-09-27T13:09:59+03:00 New Revision: f4991bfa891eaf9f36aa3b79da6fed4228b69de9 URL: https://github.com/llvm/llvm-project/commit/f4991bfa891eaf9f36aa3b79da6fed4228b69de9 DIFF: https://github.com/llvm/llvm-project/commit/f4991bfa891eaf9f36aa3b79da6fed4228b69de9.diff

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett added a comment. Turns out you're not the only one https://github.com/llvm/llvm-project/issues/56268. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134037/new/ https://reviews.llvm.org/D134037

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

tonkosi updated this revision to Diff 463158. tonkosi added a comment. Forgot to propagate "epformat" when calling GetExpressionPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 Files:

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:53 llvm::cantFail(TypeDeserializer::deserializeAs(cvt, m_cvr.cr)); + m_layout.bit_size = m_cvr.cr.getSize() * 8; break; Drive by

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun added a comment. In D134581#3815766 , @jasonmolenda wrote: > In D134581#3813757 , @alvinhochun > wrote: > >> Thanks for the comment. >> >> In D134581#3813484

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg updated this revision to Diff 463102. clayborg added a comment. Don't constify SBError::GetCString anymore. We can fix this in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg added a comment. In D134333#3812653 , @jingham wrote: > In D134333#3812448 , @clayborg > wrote: > >> I just did a search through our test sources and we use >> GetError().GetCString() 34 times in our