[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. The codes look good and also the tests pass. So LGTM. Thanks! Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1082-1094 +auto merge = [this, &Redecl, FD](auto &&F) { + auto *Existing = cast_or_null(Red

[Lldb-commits] [lldb] c338516 - Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

Author: Greg Clayton Date: 2022-10-13T17:40:23-07:00 New Revision: c338516463ff9bb7183c8322847f2eddf6febec9 URL: https://github.com/llvm/llvm-project/commit/c338516463ff9bb7183c8322847f2eddf6febec9 DIFF: https://github.com/llvm/llvm-project/commit/c338516463ff9bb7183c8322847f2eddf6febec9.diff

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc338516463ff: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] 3d8d9c9 - PlatformDarwinKernel calls the ctor directly, not setting no-jit

Author: Jason Molenda Date: 2022-10-13T16:28:18-07:00 New Revision: 3d8d9c9884db2b2a0fbd518990019b24de6f72d8 URL: https://github.com/llvm/llvm-project/commit/3d8d9c9884db2b2a0fbd518990019b24de6f72d8 DIFF: https://github.com/llvm/llvm-project/commit/3d8d9c9884db2b2a0fbd518990019b24de6f72d8.diff

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. Ah yes, it’s all done now, feel free to clean up your local state however you prefer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 _

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. I mean my **local** changes, can I consider this done and clean up? Sorry for the very newbie question. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 updated this revision to Diff 467629. Michael137 added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135921/new/ https://reviews.llvm.org/D135921 Files: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. In D115324#3857081 , @dblaikie wrote: > Been experimenting with this recently and I noticed that loading in the > cached indexes seems to do a lot of loading - specifically interning a lot of > strings from the index and the sy

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

dblaikie added a comment. Been experimenting with this recently and I noticed that loading in the cached indexes seems to do a lot of loading - specifically interning a lot of strings from the index and the symtab. Does this happen when reading a built-in index (apple_names/debug_names) (I don'

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. No, once it has been committed, it can’t really be removed from a project of this size. Changes can be reverted, but the existence of the commits and messages remains. Don’t worry about it for this one, just something to think about next time. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/cpp/TestCPPBreakpointLocations.py:63 + 'auto ns::Foo::func>()']}, +# {'name': 'func>', 'loc_names': ['auto ns::Foo::func>()']}, # FIXME

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 created this revision. Michael137 added reviewers: aprantl, labath, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes a regression with setting breakpoints on templa

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace updated this revision to Diff 467605. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135917/new/ https://reviews.llvm.org/D135917 Files: lldb/include/lldb/Target/TraceDumper.h lldb/source/Commands/CommandObj

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff implements the reconstruction algorithm for the call tree and add t

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord updated this revision to Diff 467587. bulbazord added a comment. Implement David's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135825/new/ https://reviews.llvm.org/D135825 Files: lldb/test/CMakeLists.txt lldb/test/Shell/lit.cfg.py lldb/test/Shell/lit.site.c

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

dblaikie added a comment. Looking pretty good to me FWIW Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561 +std::string +DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE &die) { + if (!die.IsValid()) Sorry, when I gave

[Lldb-commits] [lldb] d3492ed - [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

Author: Zequan Wu Date: 2022-10-13T12:43:45-07:00 New Revision: d3492ed01667a1fdebff4421a83b6c0500f07348 URL: https://github.com/llvm/llvm-project/commit/d3492ed01667a1fdebff4421a83b6c0500f07348 DIFF: https://github.com/llvm/llvm-project/commit/d3492ed01667a1fdebff4421a83b6c0500f07348.diff LOG

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3492ed01667: [LLDB][NativePDB] Fix struct layout when it has anonymous unions. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 467573. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. Is there anything to be done at this point? Can I reset my branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___ lldb-comm

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

bulbazord added a comment. In D135825#3855539 , @DavidSpickett wrote: > Would a `lit.local.cfg` work in this folder (`lldb/test/Shell/lldb-server/` > that is)? That would automatically apply it to all existing and future tests. > > `llvm/test/MC/AArch64

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8673444598be: Update developer policy on potentially breaking changes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/

[Lldb-commits] [lldb] 32cb683 - [lldb] Place PlatformQemu Properties into anonymous namespace

Author: Pavel Labath Date: 2022-10-13T15:23:58+02:00 New Revision: 32cb683d2d3aa9c8fe0f8b24bd3ad1a5ea53bdcc URL: https://github.com/llvm/llvm-project/commit/32cb683d2d3aa9c8fe0f8b24bd3ad1a5ea53bdcc DIFF: https://github.com/llvm/llvm-project/commit/32cb683d2d3aa9c8fe0f8b24bd3ad1a5ea53bdcc.diff

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

DavidSpickett added a comment. Would a `lit.local.cfg` work in this folder (`lldb/test/Shell/lldb-server/` that is)? That would automatically apply it to all existing and future tests. `llvm/test/MC/AArch64/lit.local.cfg` is one example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I suggested some changes, which I hope will reduce duplication and better empasize the differences between the various branches in the code. I think I understand the algorithm now,