[Lldb-commits] [PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. I see, thank you. I know you've marked this a WIP, but it's always good to describe these things in the patch description; that's what it's for. This is quite exciting! Thank you for looking into this. I think you could usefully be much more incremental here.

[Lldb-commits] [PATCH] D127695: [clang] Implement Template Specialization Resugaring

mizvekov added a comment. In D127695#3860237 , @rjmccall wrote: > What is this work about? I have written more about it in this discourse thread: https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks added a comment. not 100% sure this is the right fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136011/new/ https://reviews.llvm.org/D136011 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D136011: [lldb] Don't check environment default char signedness when creating clang type for "char"

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With -f(un)signed-char, the die corresponding to "char" may be the wrong DW_ATE_(un)signed_char. Ultimately we can

[Lldb-commits] [PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. What is this work about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127695/new/ https://reviews.llvm.org/D127695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe marked 2 inline comments as done. jgorbe added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2306 if (type == eRegularSynth) { -if (category->AnyMatches(type_name, eFormatCategoryItemFilter, false)) { +// TODO: Get a suitable type

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

jgorbe updated this revision to Diff 467987. jgorbe added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135648/new/ https://reviews.llvm.org/D135648 Files: lldb/bindings/python/python-swigsafecast.swig lldb/bindings/python/python-wrapper.swig

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Fix ParseAllNamespacesPlusChildrenOf and avoid duplicate iteration on symbol stream

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136006 Files:

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1534 + std::string qualified_name; + DWARFDIE parent_decl_ctx_die = die.GetParentDeclContextDIE(); + // TODO: change this to get the correct decl context parent

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

aprantl added a comment. In case anyone is curious about the motivation — In swift-lldb `GetUserExpressionForLanguage()` can actually fail and then you get into this very situation. Even though the expression still fails, a command line user has no feedback about this. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

aprantl created this revision. aprantl added reviewers: jingham, kastiglione, labath. Herald added a project: All. aprantl requested review of this revision. When `UserExpression::Evaluate()` fails and doesn't return a ValueObject there is no vehicle for returning the error in the return value.

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1534 + std::string qualified_name; + DWARFDIE parent_decl_ctx_die = die.GetParentDeclContextDIE(); + // TODO: change this to get the correct decl context parent

[Lldb-commits] [PATCH] D135921: [lldb][Breakpoint] Fix setting breakpoints on templates by basename

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a55ad34651: [lldb][Breakpoint] Fix setting breakpoints on templates by basename (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d4a55ad - [lldb][Breakpoint] Fix setting breakpoints on templates by basename

Author: Michael Buch Date: 2022-10-14T23:51:00+01:00 New Revision: d4a55ad346514b2478762cbc198942c72347e81e URL: https://github.com/llvm/llvm-project/commit/d4a55ad346514b2478762cbc198942c72347e81e DIFF: https://github.com/llvm/llvm-project/commit/d4a55ad346514b2478762cbc198942c72347e81e.diff

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 467946. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [lldb] 8a98287 - [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

Author: Arthur Eubanks Date: 2022-10-14T15:36:58-07:00 New Revision: 8a98287f255b974a8636c50a662e13ad61a59446 URL: https://github.com/llvm/llvm-project/commit/8a98287f255b974a8636c50a662e13ad61a59446 DIFF:

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a98287f255b: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. I pushed some late changes: - Implement this new scheme uniformly across all template parameter kinds. Before we were doing only type parameters, now we are doing non-type and template template parameters. While the diff is not very small, it's more of the same

[Lldb-commits] [PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 467920. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files:

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks updated this revision to Diff 467916. aeubanks added a comment. check if string is empty before assigning to unique_typename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/new/ https://reviews.llvm.org/D135979 Files:

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace updated this revision to Diff 467911. wallace marked 7 inline comments as done. wallace added a comment. - address all comments - turn all the structs into classes with safe accessors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

wallace marked 8 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceDumper.h:213-214 + /// The symbol information of the delimiting instructions. + SymbolInfo first_symbol_info; + SymbolInfo last_symbol_info; +

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1600 // file and line that things are declared on. - std::string qualified_name; - if (die.GetQualifiedName(qualified_name)) -unique_typename =

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

thakis created this revision. thakis added a reviewer: JDevlieghere. Herald added a project: All. thakis requested review of this revision. Fixes: ../../lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:633:26: warning: 'CFPropertyListCreateFromXMLData' is deprecated: first

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looked like this was a fairly uncontroversial part of the other patch, so I feel confident approving it - but welcome to wait for a second opinion from more lldb-affiliated developers.

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cfa50154a47: [LLDB] Only run lldb-server Shell tests if it gets built (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135825/new/

[Lldb-commits] [lldb] 0cfa501 - [LLDB] Only run lldb-server Shell tests if it gets built

Author: Alex Langford Date: 2022-10-14T12:00:57-07:00 New Revision: 0cfa50154a47eb65de5bc687f6565625f556edc8 URL: https://github.com/llvm/llvm-project/commit/0cfa50154a47eb65de5bc687f6565625f556edc8 DIFF: https://github.com/llvm/llvm-project/commit/0cfa50154a47eb65de5bc687f6565625f556edc8.diff

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561 +std::string +DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE ) { + if (!die.IsValid()) dblaikie wrote: > Sorry, when I gave feedback on

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks updated this revision to Diff 467868. aeubanks added a comment. Herald added a subscriber: JDevlieghere. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135979/new/ https://reviews.llvm.org/D135979 Files:

[Lldb-commits] [PATCH] D135979: [lldb][NFCish] Move DWARFDebugInfoEntry::GetQualifiedName() into DWARFASTParserClang

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In D134378 , we'll need the clang AST to be able to

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16 + +self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY, substrs=["2 matches found", "\nid =", "\nid ="])

[Lldb-commits] [PATCH] D135826: [lldb] Start from end of previous substr when checking ordered substrs

This revision was automatically updated to reflect the committed changes. Closed by commit rG021a3d5a3f73: [lldb] Start from end of previous substr when checking ordered substrs (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 021a3d5 - [lldb] Start from end of previous substr when checking ordered substrs

Author: Arthur Eubanks Date: 2022-10-14T11:16:51-07:00 New Revision: 021a3d5a3f73c59d7e43857c0230e07fa602d948 URL: https://github.com/llvm/llvm-project/commit/021a3d5a3f73c59d7e43857c0230e07fa602d948 DIFF:

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

mgorny updated this revision to Diff 467834. mgorny added a comment. Move and rename the `bool`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135516/new/ https://reviews.llvm.org/D135516 Files: lldb/include/lldb/Host/posix/MainLoopPosix.h lldb/source/Host/posix/MainLoopPosix.cpp

[Lldb-commits] [PATCH] D135516: [lldb] [MainLoopPosix] Fix crash upon adding lots of pending callbacks

mgorny added inline comments. Comment at: lldb/source/Host/posix/MainLoopPosix.cpp:408 assert(bytes_written == 1); + m_trigger_done = true; } labath wrote: > I /think/ this is not right. The other thread can wake up as soon as the > Write call is done, and

[Lldb-commits] [PATCH] D135917: [lldb][trace] Add a basic function call dump [2] - Implement the reconstruction algorithm

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. this is awesome - the tests do a great job documenting the code and weird edge cases so thanks for that. just some minor nits and questions, looks good overall

[Lldb-commits] [lldb] 7349bc3 - Speculatively fix the lldb test bots

Author: Aaron Ballman Date: 2022-10-14T08:37:08-04:00 New Revision: 7349bc34836b73518ca3e9366019ef20094f2525 URL: https://github.com/llvm/llvm-project/commit/7349bc34836b73518ca3e9366019ef20094f2525 DIFF: https://github.com/llvm/llvm-project/commit/7349bc34836b73518ca3e9366019ef20094f2525.diff

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 updated this revision to Diff 467741. Michael137 added a comment. - Add more test cases - Remove FIXMEs - Add docs - Don't return empty string for non-templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135921/new/

[Lldb-commits] [PATCH] D135648: [lldb] Add matching based on Python callbacks for data formatters.

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:2306 if (type == eRegularSynth) { -if (category->AnyMatches(type_name, eFormatCategoryItemFilter, false)) { +// TODO: Get a suitable type object for type_name so we can create a +

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:280 + + return {}; +} labath wrote: > I think this should return `basename` here. Otherwise, all non-templated > names will match the empty string. Very

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:167 + EXPECT_TRUE(reference_4.ContainsPath("operator")); EXPECT_TRUE(reference_4.ContainsPath("operator bool")); Michael137 wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:167 + EXPECT_TRUE(reference_4.ContainsPath("operator")); EXPECT_TRUE(reference_4.ContainsPath("operator bool")); labath wrote: > Is this actually

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:280 + + return {}; +} I think this should return `basename` here. Otherwise, all non-templated names will match the empty string. Repository: rG LLVM

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

labath added inline comments. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:167 + EXPECT_TRUE(reference_4.ContainsPath("operator")); EXPECT_TRUE(reference_4.ContainsPath("operator bool")); Is this actually expected? Like, I don't

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/cpp/TestCPPBreakpointLocations.py:63 + 'auto ns::Foo::func>()']}, +# {'name': 'func>', 'loc_names': ['auto ns::Foo::func>()']}, # FIXME

[Lldb-commits] [PATCH] D135921: [WIP][lldb][Breakpoint] Fix setting breakpoints on templates by basename

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/cpp/TestCPPBreakpointLocations.py:63 + 'auto ns::Foo::func>()']}, +# {'name': 'func>', 'loc_names': ['auto ns::Foo::func>()']}, # FIXME

[Lldb-commits] [PATCH] D135825: [LLDB] Only run lldb-server Shell tests if it gets built

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135825/new/ https://reviews.llvm.org/D135825 ___

[Lldb-commits] [PATCH] D135826: [lldb] Start from end of previous substr when checking ordered substrs

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135826/new/

[Lldb-commits] [PATCH] D135827: [lldb] Print newline between found types

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. This LGTM thanks for the fix just one comment on the test. Comment at: lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16 + +self.expect("image lookup -A -t Foo",

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding

persona0220 accepted this revision. persona0220 added a comment. This revision is now accepted and ready to land. LGTM! I'll also review the algorithm soon :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135521/new/