[Lldb-commits] [lldb] 8cca7f3 - Reland "[LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()"

Author: Tiezhu Yang Date: 2022-11-04T10:40:53+08:00 New Revision: 8cca7f3bf741287eb21ce273106244349a03345a URL: https://github.com/llvm/llvm-project/commit/8cca7f3bf741287eb21ce273106244349a03345a DIFF: https://github.com/llvm/llvm-project/commit/8cca7f3bf741287eb21ce273106244349a03345a.diff

[Lldb-commits] [lldb] b3578f3 - Revert "[LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()"

Author: Weining Lu Date: 2022-11-04T10:38:10+08:00 New Revision: b3578f33c8b0a05070661565af54352fe3381f6d URL: https://github.com/llvm/llvm-project/commit/b3578f33c8b0a05070661565af54352fe3381f6d DIFF: https://github.com/llvm/llvm-project/commit/b3578f33c8b0a05070661565af54352fe3381f6d.diff

[Lldb-commits] [PATCH] D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

This revision was automatically updated to reflect the committed changes. Closed by commit rGde865087f8c0: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport() (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] de86508 - [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

Author: Weining Lu Date: 2022-11-04T10:26:31+08:00 New Revision: de865087f8c07c742dec3523ec8cbe6895bd57ac URL: https://github.com/llvm/llvm-project/commit/de865087f8c07c742dec3523ec8cbe6895bd57ac DIFF: https://github.com/llvm/llvm-project/commit/de865087f8c07c742dec3523ec8cbe6895bd57ac.diff

[Lldb-commits] [lldb] e3ccbae - [lldb-vscode] Send Statistics Dump in terminated event

Author: Wanyi Ye Date: 2022-11-03T18:15:38-07:00 New Revision: e3ccbae309273900a42e30b606c15c873d57f1ea URL: https://github.com/llvm/llvm-project/commit/e3ccbae309273900a42e30b606c15c873d57f1ea DIFF: https://github.com/llvm/llvm-project/commit/e3ccbae309273900a42e30b606c15c873d57f1ea.diff

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

This revision was automatically updated to reflect the committed changes. kusmour marked an inline comment as done. Closed by commit rGe3ccbae30927: [lldb-vscode] Send Statistics Dump in terminated event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM, but you'll want to be ready to jump on any bot failures. That's just the nature of these kinds of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

zequanwu added a comment. In D137287#3905474 , @probinson wrote: > Nice work! > have you verified that all the modified tests pass? naively it looks like > you'd need at least 3 different targets to run them all (windows, > webassembly, powerpc) Those

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu updated this revision to Diff 473077. zequanwu added a comment. Update to forcefully complete a record type only if it has empty debug info and is required to have complete type. I basically copied RequireCompleteType

[Lldb-commits] [lldb] 3d83a57 - [lldb] Support simplified template names when looking up functions

Author: Arthur Eubanks Date: 2022-11-03T16:19:15-07:00 New Revision: 3d83a57721def7aad227d68b1e5e0afa6a74a33f URL: https://github.com/llvm/llvm-project/commit/3d83a57721def7aad227d68b1e5e0afa6a74a33f DIFF:

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names when looking up functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d83a57721de: [lldb] Support simplified template names when looking up functions (authored by aeubanks). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. GeorgeHuyubo marked 2 inline comments as done. Closed by commit rG0309081e1f4b: Override CalculateFrameVariableError in SymbolFileOnDemand

[Lldb-commits] [lldb] 0309081 - Override CalculateFrameVariableError in SymbolFileOnDemand

Author: George Hu Date: 2022-11-03T15:09:07-07:00 New Revision: 0309081e1f4b564693dd4e4d3c7b1d700780c62b URL: https://github.com/llvm/llvm-project/commit/0309081e1f4b564693dd4e4d3c7b1d700780c62b DIFF: https://github.com/llvm/llvm-project/commit/0309081e1f4b564693dd4e4d3c7b1d700780c62b.diff

[Lldb-commits] [PATCH] D137359: [lldb/Plugins] Use default initializers for StructuredData::*SP (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3350d5574864: [lldb/Plugins] Use default initializers for StructuredData::*SP (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

This revision was automatically updated to reflect the committed changes. Closed by commit rG78d6e1d1d4b3: [lldb/crashlog] Add support for Application Specific Backtraces Information (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

This revision was automatically updated to reflect the committed changes. Closed by commit rGe861d053dd43: [lldb/Utility] Add GetDescription(Stream) to StructureData::* (authored by mib). Changed prior to commit: https://reviews.llvm.org/D135547?vs=472497=473040#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

This revision was automatically updated to reflect the committed changes. Closed by commit rG90608963d40b: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135616/new/

[Lldb-commits] [lldb] 3350d55 - [lldb/Plugins] Use default initializers for StructuredData::*SP (NFC)

Author: Med Ismail Bennani Date: 2022-11-03T14:44:53-07:00 New Revision: 3350d5574864442d7c4120af25404762a840da00 URL: https://github.com/llvm/llvm-project/commit/3350d5574864442d7c4120af25404762a840da00 DIFF:

[Lldb-commits] [lldb] 78d6e1d - [lldb/crashlog] Add support for Application Specific Backtraces & Information

Author: Med Ismail Bennani Date: 2022-11-03T14:44:53-07:00 New Revision: 78d6e1d1d4b3b5c6bdd779256c915a8ac7148174 URL: https://github.com/llvm/llvm-project/commit/78d6e1d1d4b3b5c6bdd779256c915a8ac7148174 DIFF:

[Lldb-commits] [PATCH] D135482: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

This revision was automatically updated to reflect the committed changes. Closed by commit rG42df155ae628: [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135482/new/

[Lldb-commits] [lldb] 9060896 - [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

Author: Med Ismail Bennani Date: 2022-11-03T14:44:52-07:00 New Revision: 90608963d40b4765fc95e039d5100940ad822535 URL: https://github.com/llvm/llvm-project/commit/90608963d40b4765fc95e039d5100940ad822535 DIFF:

[Lldb-commits] [lldb] e861d05 - [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

Author: Med Ismail Bennani Date: 2022-11-03T14:44:53-07:00 New Revision: e861d053dd43f2e5a63f150ee2f9d1d643ea29c1 URL: https://github.com/llvm/llvm-project/commit/e861d053dd43f2e5a63f150ee2f9d1d643ea29c1 DIFF:

[Lldb-commits] [lldb] 268628c - [lldb/Commands] Add newline for extended backtrace thread (NFCI)

Author: Med Ismail Bennani Date: 2022-11-03T14:44:52-07:00 New Revision: 268628cb79b0f8bb0edec86d9d500c16eadd516a URL: https://github.com/llvm/llvm-project/commit/268628cb79b0f8bb0edec86d9d500c16eadd516a DIFF:

[Lldb-commits] [lldb] cc05487 - [lldb/Plugins] Cleanup error handling in Scripted{Process, Thread} (NFC)

Author: Med Ismail Bennani Date: 2022-11-03T14:44:52-07:00 New Revision: cc05487a834e55659072918393f5c7490af67ed2 URL: https://github.com/llvm/llvm-project/commit/cc05487a834e55659072918393f5c7490af67ed2 DIFF:

[Lldb-commits] [lldb] 42df155 - [lldb/crashlog] Fix the image_regex_uuid to skip null UUID images

Author: Med Ismail Bennani Date: 2022-11-03T14:44:52-07:00 New Revision: 42df155ae628b4ae756a858bd09b105ee10b86eb URL: https://github.com/llvm/llvm-project/commit/42df155ae628b4ae756a858bd09b105ee10b86eb DIFF:

[Lldb-commits] [lldb] 3be8643 - [lldb/crashlog] Add support for 32bit frame addresses

Author: Med Ismail Bennani Date: 2022-11-03T14:44:52-07:00 New Revision: 3be864333a8843534465bcbf3d355fcd12b42369 URL: https://github.com/llvm/llvm-project/commit/3be864333a8843534465bcbf3d355fcd12b42369 DIFF:

[Lldb-commits] [PATCH] D135310: [lldb/crashlog] Add support for 32bit frame addresses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3be864333a88: [lldb/crashlog] Add support for 32bit frame addresses (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135310/new/

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib updated this revision to Diff 473036. mib added a comment. Addressed @JDevlieghere feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126260/new/ https://reviews.llvm.org/D126260 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:601-605 +for idx, backtrace in enumerate(json_app_specific_bts): +thread = self.crashlog.Thread(idx, True) +thread.queue = "Application

[Lldb-commits] [PATCH] D137359: [lldb/Plugins] Use default initializers for StructuredData::*SP (NFC)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch replaces the ScriptedProcessInterface getters to return default initializers for

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

clayborg accepted this revision. clayborg added a comment. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137284/new/ https://reviews.llvm.org/D137284 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

GeorgeHuyubo updated this revision to Diff 472998. GeorgeHuyubo added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137284/new/ https://reviews.llvm.org/D137284 Files: lldb/include/lldb/Symbol/SymbolFileOnDemand.h

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

clayborg added a comment. The refactoring comment should be done as well for this diff as suggested. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:564-566 +@no_debug_info_test +@skipUnlessDarwin +def

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just have the case when debug info is not enabled return "Status()" (a default constructed error with no error) and this will be good to go. Comment at:

[Lldb-commits] [lldb] fd2065b - Have GetSupportedArchitectures report all supported arches

Author: Jason Molenda Date: 2022-11-03T10:46:48-07:00 New Revision: fd2065b70f2a74503725ebadb39c5dd2f9aa15c9 URL: https://github.com/llvm/llvm-project/commit/fd2065b70f2a74503725ebadb39c5dd2f9aa15c9 DIFF: https://github.com/llvm/llvm-project/commit/fd2065b70f2a74503725ebadb39c5dd2f9aa15c9.diff

[Lldb-commits] [PATCH] D137301: PlatformDarwinKernel::GetSupportedArchitectures should report all supported architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2065b70f2a: Have GetSupportedArchitectures report all supported arches (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. @jingham any comments on https://reviews.llvm.org/D137000#3897162? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137000/new/ https://reviews.llvm.org/D137000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few nits but overall this LGTM. Comment at: lldb/examples/python/crashlog.py:601-605 +for idx, backtrace in enumerate(json_app_specific_bts): +

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT with the missing periods fixed. Comment at: lldb/source/Utility/StructuredData.cpp:208 + +// Reset original indentation level +

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

sylvestre.ledru added a comment. i hope not too many people rely on it. LGTM but please add it to the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

probinson added a comment. Nice work! have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

serge-sans-paille added a comment. The consensus in the discourse thread you mention is not super strong, but I tend to agree with that patch. +1 for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay. mgorny added a comment. Herald added subscribers: Michael137, StephenFan. To be honest, I've never seen much purpose in the x.y.z directory naming and I feel like it's making packaging unnecessarily more complex, at

[Lldb-commits] [PATCH] D137098: [lldb] Support simplified template names when looking up functions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D137098#3903547 , @aeubanks wrote: > In D137098#3902140 , @labath wrote: > >> Why is it that the other

[Lldb-commits] [PATCH] D136795: [LLDB] Add a `(not loaded) ` prefix to placeholder object filename to indicate they are not loaded.

labath added a comment. That's exactly why i don't like this stringly typed `GetPluginName` API. If you had to write `isa(objfile)`, or even just `objfile->GetPluginName()==ProcessMinidump::Placeholder::GetPluginNameStatic()` , you'll be a lot less likely to think that you can get away with

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

labath added a comment. I'm pretty sure that's because YAMA prevents the attach operation. The test probably needs to launch the binary through something like this . Repository: rG LLVM

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

labath added a comment. In D134066#3903831 , @zequanwu wrote: > It shouldn't reach the code path to complete a class with empty debug info. How about this? $ cat a.cc struct A { int x; A(); }; A::A() : x(47) {} $ cat b.cc struct A { int x;

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGc188910694ab: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c188910 - [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

Author: Michael Buch Date: 2022-11-03T06:30:14-07:00 New Revision: c188910694ab821aabc0ca11f4636b69f5f7b4f1 URL: https://github.com/llvm/llvm-project/commit/c188910694ab821aabc0ca11f4636b69f5f7b4f1 DIFF: https://github.com/llvm/llvm-project/commit/c188910694ab821aabc0ca11f4636b69f5f7b4f1.diff

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

Michael137 added a comment. Thanks for confirming @DavidSpickett Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137272/new/ https://reviews.llvm.org/D137272 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. I haven't tried the patch myself, but I see no reason why it should behave for me (x86) any different than on aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137272: [lldb][Test] Make TestFrameFormatNameWithArgs.test more compatible across platforms

DavidSpickett added a comment. Test passes on AArch64 Ubuntu 20.04.4, where it failed prior to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137272/new/ https://reviews.llvm.org/D137272 ___

[Lldb-commits] [PATCH] D137312: [LLDB] [LoongArch] Add loongarch64 case in ComputeHostArchitectureSupport()

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM. Follows the same logic AArch64 does. (meaning: we don't support debugging 32 bit from a 64 bit lldb very well, if it all, but it's still noted here as possible) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added inline comments. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:719 + Type:ET_EXEC + Machine: EM_386 +Sections: DavidSpickett wrote: > I know it's just a test but is there an `EM_WASM` you could use? > > Maybe

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 472863. pfaffe marked 4 inline comments as done. pfaffe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files: