[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting with reading memory in Scripted Process

mib updated this revision to Diff 476019. mib marked 2 inline comments as done. mib retitled this revision from "[lldb/Plugins] Improve error reporting with reading/writing memory in a Scripted Process (WIP)" to "[lldb/Plugins] Improve error reporting with reading memory in Scripted Process".

[Lldb-commits] [PATCH] D132510: [RISCV][LLDB] Add initial SysV ABI support

kasper81 added a comment. @labath, if there is anything needed by me, please let me know. i'm new to phabricator patch system. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132510/new/ https://reviews.llvm.org/D132510

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack added a comment. Either way works as long as we can pass the Android serial number to AdbClient.cpp. This diff just followed the current code which is actually already working for USB-connected devices and emulator. So adding TCPIP-connected device support here makes sense.

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

clayborg added a comment. Just wanted to let you know that the "platform connect" parameters are not fixed. Each platform can make their own arguments. The Android platform currently expects a URL that will get forwarded to an internal Connection class that has registered a connection URL

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some test cases are already marked @skipIfNoSBHeaders, but they make use of SBAPI headers in test setup. The setup

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 475988. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address @friss' feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files:

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

friss added inline comments. Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:81-82 + +/// Is DIE a forward or backward reference? +bool Reference : 1; }; When I read the comment, I was confused as I thought the flag was used to

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 475985. JDevlieghere added a comment. Remove unrelated changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere created this revision. JDevlieghere added reviewers: avl, friss, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. D125469

[Lldb-commits] [lldb] 3f36421 - Fix use of std::unique / erase. This fixes a bot error after D136650.

Author: Adrian Prantl Date: 2022-11-16T17:35:51-08:00 New Revision: 3f36421aa74031fb554c780dba66c1c1a437d953 URL: https://github.com/llvm/llvm-project/commit/3f36421aa74031fb554c780dba66c1c1a437d953 DIFF: https://github.com/llvm/llvm-project/commit/3f36421aa74031fb554c780dba66c1c1a437d953.diff

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650

[Lldb-commits] [PATCH] D138164: [LLDB][Android] Fix Android serial number handling

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added a reviewer: clayborg. splhack updated this revision to Diff 475962. splhack added a comment. splhack published this revision for review. Herald added a project: LLDB. Herald added a

[Lldb-commits] [lldb] 0ec24e1 - Only use major version in the clang resource directory for standalone builds.

Author: Jim Ingham Date: 2022-11-16T16:00:26-08:00 New Revision: 0ec24e1f956616c54f38e104b482dec9309a93fa URL: https://github.com/llvm/llvm-project/commit/0ec24e1f956616c54f38e104b482dec9309a93fa DIFF: https://github.com/llvm/llvm-project/commit/0ec24e1f956616c54f38e104b482dec9309a93fa.diff

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:300 - TypeSystem *GetTypeSystem(bool prefer_dynamic); + CompilerType::TypeSystemSPWrapper GetTypeSystem(bool prefer_dynamic); labath wrote: > Maybe the wrapper type should just be

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:13 #include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "lldb/Core/Debugger.h" #include "lldb/Utility/Args.h" labath wrote: > We shouldn't have Host->Core

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu added a comment. In D137873#3931888 , @mstorsjo wrote: > In D137873#3930683 , @labath wrote: > >> If that doesn't work then (besides knowing why), I'd like us try some kind >> of a single-setting

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

mstorsjo added a subscriber: alvinhochun. mstorsjo added a comment. In D137873#3930683 , @labath wrote: > If that doesn't work then (besides knowing why), I'd like us try some kind of > a single-setting solution, as I don't think it makes sense to have

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); tejohnson wrote: > MaskRay wrote: > > What if

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475895. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

clayborg added a comment. Yeah, sending this data at the entry point is not a good way to tell anything about the debug session having debug info. Some shared libraries might be loaded on macOS, but not on linux or android. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6435fe699c29: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info… (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D134066?vs=475517=475879#toc

[Lldb-commits] [lldb] 6435fe6 - [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

Author: Zequan Wu Date: 2022-11-16T11:17:07-08:00 New Revision: 6435fe699c2978aa8a91dc1cf5daa82fb4b28d95 URL: https://github.com/llvm/llvm-project/commit/6435fe699c2978aa8a91dc1cf5daa82fb4b28d95 DIFF: https://github.com/llvm/llvm-project/commit/6435fe699c2978aa8a91dc1cf5daa82fb4b28d95.diff

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410 + LLDB_LOG(log, "xcrun returned exit code %d", status); + return ""; +} JDevlieghere wrote: > Why not return an Error? For the caller of this lambda

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl updated this revision to Diff 475857. aprantl added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138060/new/ https://reviews.llvm.org/D138060 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm lldb/unittests/Host/CMakeLists.txt

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

labath added a comment. We have tests for shared libraries (grep for DYLIB_C(XX)_SOURCES)), but it's easier to reproduce this problem by compiling one CU with -g0 -- see inline comment. (If you are creating an "API" test for this, beware that their default is to build everything with

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); MaskRay wrote: > What if two input bitcode

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

labath added a comment. Adding a new setting isn't exactly what I had in mind. I was actually hoping that it would be enough to fiddle with that setting and leave the minidump environment blank (because we have code

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9816-9819 +/// Complete a type from debug info, or mark it as forcefully completed if +/// there is

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

labath accepted this revision. labath added a comment. Some more comments inline, but I think this is essentially as good as we can make it. Comment at: lldb/include/lldb/Symbol/Type.h:300 - TypeSystem *GetTypeSystem(bool prefer_dynamic); +

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

labath added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:13 #include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "lldb/Core/Debugger.h" #include "lldb/Utility/Args.h" We shouldn't have Host->Core dependencies. Could you

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

labath added a comment. It fails on all linux bots, so I've reverted it for now. From what I can tell, the problem is that linux does not immediately (before running the process) load the shared library, and so the overall startup debug info size is reported as zero (because the main

[Lldb-commits] [lldb] 22887ff - Revert "Send statistics in initialized event"

Author: Pavel Labath Date: 2022-11-16T12:20:21+01:00 New Revision: 22887ff964ee9135417f7c0f99915296b710934f URL: https://github.com/llvm/llvm-project/commit/22887ff964ee9135417f7c0f99915296b710934f DIFF: https://github.com/llvm/llvm-project/commit/22887ff964ee9135417f7c0f99915296b710934f.diff

[Lldb-commits] [PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. Ping @Ericson2314 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 475706. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt