[Lldb-commits] [PATCH] D138248: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

mib updated this revision to Diff 476361. mib marked an inline comment as done. mib added a comment. Implement @labath suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138248/new/ https://reviews.llvm.org/D138248 Files:

[Lldb-commits] [PATCH] D138248: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:191-194 +template <> struct PythonFormat { + static constexpr char format = 's'; + static auto get(char *value) { return value; } +};

[Lldb-commits] [PATCH] D138237: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks, this makes sense. I just wish we could get D137035 in and avoid this whole complexity in the first place. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Thanks. In D134033#3935424 , @mib wrote: > In D134033#3933936 , @labath wrote: > >> I kinda like it.

[Lldb-commits] [PATCH] D138250: [lldb/Python] Unify PythonFormat & GetPythonValueFormatString (NFC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. celebration_balloons Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D138248: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Thanks for doing that. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:191-194 +template <> struct PythonFormat { + static constexpr

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. We can see this in action with the before "var" output of: (InheritsFromOne) ::inherits_from_one = { (int) member = 47 } And after, we see the "One" class definition and we can see that it is incomplete: (InheritsFromOne) ::inherits_from_one = { (One)

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. Forgot to mention that this patch will force any empty base classes that were forcefully completed to show up in the variable display so the user can know that the type was forcefully completed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, yinghuitan, aprantl. Herald added a subscriber: mstorsjo. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib updated this revision to Diff 476299. mib added a comment. Fix failure when building PythonScriptInterpreter unit test libraries CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 Files: lldb/bindings/python/python-swigsafecast.swig

[Lldb-commits] [PATCH] D138250: [lldb/Python] Unify PythonFormat & GetPythonValueFormatString (NFC)

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch removes all occurences to GetPythonValueFormatString and use the template

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib added a comment. In D134033#3933936 , @labath wrote: > I kinda like it. One thing that I think would help with the readability is if > the "transformation" methods were grouped according to the type of the object > being transformed, rather than

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib updated this revision to Diff 476292. mib marked 8 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @labath comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 Files:

[Lldb-commits] [PATCH] D138248: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch extends the template specialization of PythonFormat structs and makes use of

[Lldb-commits] [lldb] d2b6b21 - Comment function

Author: Adrian Prantl Date: 2022-11-17T15:24:48-08:00 New Revision: d2b6b2147b6123f7c470457ed3c06ffebcc9231d URL: https://github.com/llvm/llvm-project/commit/d2b6b2147b6123f7c470457ed3c06ffebcc9231d DIFF: https://github.com/llvm/llvm-project/commit/d2b6b2147b6123f7c470457ed3c06ffebcc9231d.diff

[Lldb-commits] [PATCH] D138237: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

bulbazord created this revision. bulbazord added reviewers: labath, mgorny. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In 52f39853abd46495a6d636c4b035e1b92cf4b833

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

aprantl added a comment. I think it's fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu updated this revision to Diff 476221. zequanwu added a comment. Use plugin.object-file.pe-coff.abi as minidump process abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ https://reviews.llvm.org/D137873 Files:

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. In D137983#3930973 , @labath wrote: > We have tests for shared libraries (grep for DYLIB_C(XX)_SOURCES)), but it's > easier to reproduce this problem by compiling one CU with -g0 -- see inline > comment. (If you are creating

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 476199. aeubanks added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

aprantl added a comment. In D136650#3932481 , @stella.stamenova wrote: > Looks like this broke the windows lldb bot: > https://lab.llvm.org/buildbot/#/builders/83/builds/26042 I'm trying to fix this blindly. Should hopefully work after a few

[Lldb-commits] [lldb] 0acc08b - Attempt ro fix Windows build errors.

Author: Adrian Prantl Date: 2022-11-17T10:50:34-08:00 New Revision: 0acc08b4eabdeb9b681259921df9e1b554a927e2 URL: https://github.com/llvm/llvm-project/commit/0acc08b4eabdeb9b681259921df9e1b554a927e2 DIFF: https://github.com/llvm/llvm-project/commit/0acc08b4eabdeb9b681259921df9e1b554a927e2.diff

[Lldb-commits] [PATCH] D135030: [lldb] [gdb-remote] Abstract sending ^c packet into SendCtrlC() method

emaste added a comment. Maybe we want to call it SendInterrupt? Looks fine to me as a minor tidy-up either way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135030/new/ https://reviews.llvm.org/D135030 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

emaste added a comment. With D131159 and D131160 in, where does that leave us wrt this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131075/new/

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:13 #include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "lldb/Core/Debugger.h" #include "lldb/Utility/Args.h" aprantl wrote: > labath wrote: > > We shouldn't

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 476158. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address @avl's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files:

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added inline comments. Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:82 +/// Is this a reference to a DIE that hasn't been cloned yet? +bool Reference : 1; }; Probably name it UnclonedReference ? or RefShouldBePatched?(or

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8be41c787f9e: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders (authored by rupprecht). Repository: rG LLVM Github

[Lldb-commits] [lldb] 8be41c7 - [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

Author: Jordan Rupprecht Date: 2022-11-17T08:17:10-08:00 New Revision: 8be41c787f9e12a4eb101e2dcad67ddc2da7ec1f URL: https://github.com/llvm/llvm-project/commit/8be41c787f9e12a4eb101e2dcad67ddc2da7ec1f DIFF:

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht added a comment. Thanks! Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:146 +# reason is used for both args. +return unittest2.skipIf(reason, reason)(func) DavidSpickett wrote: > This would make more immediate

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht updated this revision to Diff 476137. rupprecht marked an inline comment as done. rupprecht added a comment. - Use named args to indicate reason is used as condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138181/new/

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

labath added a comment. I kinda like it. One thing that I think would help with the readability is if the "transformation" methods were grouped according to the type of the object being transformed, rather than according to the direction. So something like: // general transform // general

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

labath added a comment. In D137873#3933171 , @alvinhochun wrote: > I think the module spec of the modules should reflect the value of the > `plugin.object-file.pe-coff.abi` setting. Can ProcessMinidump take the module > spec of the executable module

[Lldb-commits] [PATCH] D137761: [LLDB][RISCV] Allow accessing FPR registers through ABI names

This revision was automatically updated to reflect the committed changes. Closed by commit rG201ed71cfd7e: [LLDB][RISCV] Allow accessing FPR registers through ABI names (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 201ed71 - [LLDB][RISCV] Allow accessing FPR registers through ABI names

Author: Emmmer Date: 2022-11-17T19:58:21+08:00 New Revision: 201ed71cfd7e68f3925b1308e09f1a437f377080 URL: https://github.com/llvm/llvm-project/commit/201ed71cfd7e68f3925b1308e09f1a437f377080 DIFF: https://github.com/llvm/llvm-project/commit/201ed71cfd7e68f3925b1308e09f1a437f377080.diff LOG:

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe added a comment. I threaded dwarf_cu down to where it's really used and added the necessary check, so if it is nullptr, the fallback will be skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/

[Lldb-commits] [PATCH] D137508: [LLDB][RISCV] Allow accessing registers through ABI names

This revision was automatically updated to reflect the committed changes. Closed by commit rG4113e98ea785: [LLDB][RISCV] Allow accessing registers through ABI names (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4113e98 - [LLDB][RISCV] Allow accessing registers through ABI names

Author: Emmmer Date: 2022-11-17T19:39:06+08:00 New Revision: 4113e98ea78590eac217a8a76201120b57f9d39f URL: https://github.com/llvm/llvm-project/commit/4113e98ea78590eac217a8a76201120b57f9d39f DIFF: https://github.com/llvm/llvm-project/commit/4113e98ea78590eac217a8a76201120b57f9d39f.diff LOG:

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

DavidSpickett added a comment. What was the decision on `m_dwarf_cu` possibly being nullptr? We at least want asserts in paths where we assume it'll not be null. Beyond that this seems fine but I'm not really into DWARF, @labath any comments? Seems like quite a cheap fallback to add, and my

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

CharKeaney created this revision. CharKeaney added reviewers: DavidSpickett, simoncook, lewis-revill, edward-jones. CharKeaney added a project: LLDB. Herald added subscribers: JDevlieghere, kbarton, nemanjai. Herald added a project: All. CharKeaney requested review of this revision. Herald added

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Do what makes sense to you with the comment. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:146 +# reason is used for both

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

alvinhochun added a comment. I think the module spec of the modules should reflect the value of the `plugin.object-file.pe-coff.abi` setting. Can ProcessMinidump take the module spec of the executable module to use its target environment? Mixing MSVC and MinGW DLLs is a tricky case so I will