[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces both the ScriptedPlatformInterface and the

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 479809. mib added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 Files: lldb/bindings/python/CMakeLists.txt lldb/bindings/python/python-wrapper.swig

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces both the Scripted Platform python base implementation and an

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib created this revision. mib added reviewers: JDevlieghere, jingham, labath. mib added a project: LLDB. Herald added a subscriber: emaste. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is preparatory work for Scripted

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch makes `ScriptedPythonInterface::GetStatusFromMethod` take a parameter pack

[Lldb-commits] [PATCH] D139247: [lldb/Utility] Make ScriptedProcessInfo more generic

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the ScriptedProcessInfo class out of the ScriptedProcess and hoist it

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3967397 , @tschuett wrote: > I do not ask you to do anything! I just noticed that you add a lot of > `FormatXXXDiagnostic` functions. An alternativ design is to have one > `FormatDiagnostic` function with a mode

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#3966539 , @labath wrote: > I don't believe there's no way to split this patch up. I mean, just half of > it is dedicated to changing PRIx32 into PRIx64. Surely that can be a patch of > it's own, even if it meant

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 479769. ayermolo added a comment. Addressed inlined comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Michael137

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 479759. aeubanks marked 2 inline comments as done. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 Files:

[Lldb-commits] [PATCH] D139226: Don't mark DW_OP_addr addresses as file addresses while converting them to load addresses sometimes

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c2b7fa8691e: Leave DW_OP_addr addresses as load addresses in DWARFExpression (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0c2b7fa - Leave DW_OP_addr addresses as load addresses in DWARFExpression

Author: Jason Molenda Date: 2022-12-02T14:45:02-08:00 New Revision: 0c2b7fa8691e9d1f6c7dd656e44321ef8c84ae87 URL: https://github.com/llvm/llvm-project/commit/0c2b7fa8691e9d1f6c7dd656e44321ef8c84ae87 DIFF: https://github.com/llvm/llvm-project/commit/0c2b7fa8691e9d1f6c7dd656e44321ef8c84ae87.diff

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

dblaikie added a comment. Sorry if this is derailing, but I wonder/worry about a few things here: 1. Compounding structured output with phraseology - it seems like it might be worthwhile for these to be separate issues (doesn't mean the terminal output has to say exactly the same thing - as

[Lldb-commits] [PATCH] D139226: Don't mark DW_OP_addr addresses as file addresses while converting them to load addresses sometimes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Yeah, the previous code was a hack that worked under *some* circumstances. That's not good enough to keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139226: Don't mark DW_OP_addr addresses as file addresses while converting them to load addresses sometimes

jasonmolenda created this revision. jasonmolenda added a reviewer: aprantl. jasonmolenda added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere, arichardson. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

aprantl added a comment. (or skip the test on Windows) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl added a comment. I have only two concerns left: 1. IMHO it would be better if `find_one` (which I think of as a search *input*) would live in TypeQuery instead of TypeResult. It feels wrong to use TypeResult to pass something *in*. 2. It's inconsistent that Module has a

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. I do not ask you to do anything! I just noticed that you add a lot of `FormatXXXDiagnostic` functions. An alternativ design is to have one `FormatDiagnostic` function with a mode parameter. Then you can decide whether to print legacy or user-oriented reasons. If next

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e24afdc706: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a9e24af - [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

Author: Argyrios Kyrtzidis Date: 2022-12-02T10:45:49-08:00 New Revision: a9e24afdc706e6946c4da78188732fc60bdb863b URL: https://github.com/llvm/llvm-project/commit/a9e24afdc706e6946c4da78188732fc60bdb863b DIFF:

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG36bea8759d1f: [lldb] Fix the `dwarf` log descriptions (authored by akyrtzi). Changed prior to commit: https://reviews.llvm.org/D139061?vs=479099=479672#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 36bea87 - [lldb] Fix the `dwarf` log descriptions

Author: Argyrios Kyrtzidis Date: 2022-12-02T10:18:38-08:00 New Revision: 36bea8759d1fa07ac7fd8b16e6c7d15f10b0d145 URL: https://github.com/llvm/llvm-project/commit/36bea8759d1fa07ac7fd8b16e6c7d15f10b0d145 DIFF:

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3966938 , @tschuett wrote: > Maybe the kind/amount of information printed ( `DiagnosticMode` ) and the > output device (console/sarif) are orthogonal issues. > > Still it would nice to be able to toggle the diagnostic

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. Maybe the kind/amount of information printed ( `DiagnosticMode` ) and the output device (console/sarif) are orthogonal issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138939/new/ https://reviews.llvm.org/D138939

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3965985 , @tschuett wrote: > Then Sarif was a distraction. Still to reduce boilerplate and for A/B testing: > > enum class DiagnosticMode { > Legacy, > UserOriented, > Default = Legacy > } It took a fair

[Lldb-commits] [PATCH] D138271: Fix license header in TraceHTR.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11d53e30d3d: [lldb] fix license header in TraceHTR.h (authored by pietroalbini, committed by durin42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a11d53e - [lldb] fix license header in TraceHTR.h

Author: Pietro Albini Date: 2022-12-02T10:59:50-05:00 New Revision: a11d53e30d3d19cf6594cf4bd4cf39ba0271899d URL: https://github.com/llvm/llvm-project/commit/a11d53e30d3d19cf6594cf4bd4cf39ba0271899d DIFF: https://github.com/llvm/llvm-project/commit/a11d53e30d3d19cf6594cf4bd4cf39ba0271899d.diff

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

labath added a comment. A simple `USE_LIBDL := 1` could fix the linux test. As for windows, we have some dlopen "portability wrappers" in `packages/Python/lldbsuite/test/make/dylib.h`, but windows has the additional problem (well, maybe it's kind of a feature) of not being able to modify a

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. I don't believe there's no way to split this patch up. I mean, just half of it is dedicated to changing PRIx32 into PRIx64. Surely that can be a patch of it's own, even if it meant that DWARFDIE::GetOffset temporarily returns something other than dw_offset_t. And if we

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. Reverted for now while figuring out how to best deal with the tests on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 ___

[Lldb-commits] [lldb] 71f3cac - Revert "[lldb][Target] Flush the scratch TypeSystem when owning lldb_private::Module gets unloaded"

Author: Michael Buch Date: 2022-12-02T14:12:41Z New Revision: 71f3cac7895ad516ec25438f803ed3c9916c215a URL: https://github.com/llvm/llvm-project/commit/71f3cac7895ad516ec25438f803ed3c9916c215a DIFF: https://github.com/llvm/llvm-project/commit/71f3cac7895ad516ec25438f803ed3c9916c215a.diff LOG:

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Michael137

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:765 +m_ast.CreateClassTemplateSpecializationType(class_specialization_decl); +return clang_type.GetTypeName(/*BaseOnly*/ true); + } Ok so what

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

tmatheson added a comment. Herald added a subscriber: JDevlieghere. > And this is the file that was being generated: > https://github.com/ziglang/zig/blob/c86589a738e5053a26b2be7d156bcfee1565f00b/lib/std/target/aarch64.zig Thanks for the heads up. It looks like that file hasn't been updated for

[Lldb-commits] [PATCH] D139102: [AArch64] Inline AArch64TargetParser.def

tmatheson updated this revision to Diff 479598. tmatheson added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update lldb test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139102/new/

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added a comment. Broke windows and linux build bots. Checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 added a comment. In D138558#3963732 , @labath wrote: > You may want to check that this kind of automatic dereferencing does not send > lldb into a tailspin if the printed data structure is recursive. I know we > had problems like that with

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

This revision was automatically updated to reflect the committed changes. Closed by commit rG4df11394a10b: [lldb][Target] Flush the scratch TypeSystem when owning lldb_private::Module… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG5941858efdca: [lldb][Module][NFC] Add ModuleList::AnyOf (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139083/new/

[Lldb-commits] [lldb] 5941858 - [lldb][Module][NFC] Add ModuleList::AnyOf

Author: Michael Buch Date: 2022-12-02T10:52:40Z New Revision: 5941858efdca72425c29bf043d3ec84e7fec6f62 URL: https://github.com/llvm/llvm-project/commit/5941858efdca72425c29bf043d3ec84e7fec6f62 DIFF: https://github.com/llvm/llvm-project/commit/5941858efdca72425c29bf043d3ec84e7fec6f62.diff LOG:

[Lldb-commits] [PATCH] D139082: [lldb][Module] Document ModuleList::ForEach and assert nullness

This revision was automatically updated to reflect the committed changes. Closed by commit rG83599000e1f4: [lldb][Module] Document ModuleList::ForEach and assert nullness (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4df1139 - [lldb][Target] Flush the scratch TypeSystem when owning lldb_private::Module gets unloaded

Author: Michael Buch Date: 2022-12-02T10:52:41Z New Revision: 4df11394a10b3b15d2fb9bde8b831cf68785aa45 URL: https://github.com/llvm/llvm-project/commit/4df11394a10b3b15d2fb9bde8b831cf68785aa45 DIFF: https://github.com/llvm/llvm-project/commit/4df11394a10b3b15d2fb9bde8b831cf68785aa45.diff LOG:

[Lldb-commits] [lldb] 8359900 - [lldb][Module] Document ModuleList::ForEach and assert nullness

Author: Michael Buch Date: 2022-12-02T10:52:39Z New Revision: 83599000e1f4b30d93b8f4509011b9b68d722835 URL: https://github.com/llvm/llvm-project/commit/83599000e1f4b30d93b8f4509011b9b68d722835 DIFF: https://github.com/llvm/llvm-project/commit/83599000e1f4b30d93b8f4509011b9b68d722835.diff LOG:

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h:91 + lldb_private::ConstString + GetForwardDeclarationDIETemplateParams(const DWARFDIE ) override; Can we add a docstring? Comment at:

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

lh03061238 added a comment. In D139158#3965478 , @jingham wrote: > Note that the two most common uses of single step in lldb are 1) stepping > over the instruction under a breakpoint (which may be a branch) and 2) > stepping to the next instruction

[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. Then Sarif was a distraction. Still to reduce boilerplate and for A/B testing: enum class DiagnosticMode { Legacy, UserOriented, Default = Legacy } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138939/new/