[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Currently in

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco created this revision. Herald added a project: All. eloparco requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implement DAP (Debug Adapter Protocol) for Disassemble Requests. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:11-58 +#include "AppleDWARFIndex.h" +#include "DWARFASTParser.h" +#include "DWARFASTParserClang.h" +#include "DWARFCompileUnit.h"

[Lldb-commits] [lldb] 2916b99 - [ADT] Alias llvm::Optional to std::optional

Author: Benjamin Kramer Date: 2022-12-20T01:01:46+01:00 New Revision: 2916b99182752b1aece8cc4479d8d6a20b5e02da URL: https://github.com/llvm/llvm-project/commit/2916b99182752b1aece8cc4479d8d6a20b5e02da DIFF:

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 accepted this revision. barannikov88 added inline comments. Comment at: llvm/lib/CodeGen/RegAllocGreedy.h:83 public: -ExtraRegInfo() = default; +ExtraRegInfo() {} ExtraRegInfo(const ExtraRegInfo &) = delete; bkramer wrote: >

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added a comment. In D140332#4005988 , @MaskRay wrote: > Can you push `using OptionalFileEntryRef = > CustomizableOptional;` and the renaming as a separate commit to > make this patch smaller? > There is

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

bkramer marked an inline comment as done. bkramer added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; barannikov88

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. look reasonable to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140240/new/ https://reviews.llvm.org/D140240

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py:15 +lldbutil.run_to_source_breakpoint(self, "// Set breakpoint here", lldb.SBFileSpec("main.cpp")) +# FIXME: these should successfully print the values +

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py:15 +lldbutil.run_to_source_breakpoint(self, "// Set breakpoint here", lldb.SBFileSpec("main.cpp")) +# FIXME: these should successfully print the values +

[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

aeubanks updated this revision to Diff 484077. aeubanks added a comment. check if type is template by looking at underlying clang Type, rather than looking for a '<' properly handle typedefs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

MaskRay added a comment. Can you push `using OptionalFileEntryRef = CustomizableOptional;` and the renaming as a separate commit to make this patch smaller? There is a smaller that this rename may be reverted. 205c0589f918f95d2f2c586a01bea2716d73d603

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

barannikov88 added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:513 if (Opts.MaxBitIntWidth) -MaxBitIntWidth = Opts.MaxBitIntWidth; +MaxBitIntWidth = (unsigned)Opts.MaxBitIntWidth; Nit: C-style casts are generally discouraged (there

[Lldb-commits] [PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

probinson added a comment. Herald added subscribers: jsetoain, JDevlieghere, ormris. Worth trying on MSVC, which is the other more likely place to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > I can't test it on macOS platforms because the bots won't be able to build & > run arm64e (ARMv8.3 w/ ptrauth) binaries. :/ Well our bots can't either but I've got QEMU locally is what I mean. We can run top byte

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 accepted this revision. barannikov88 added a comment. In D139973#4005120 , @sebastian-ne wrote: > the question gets wether we want to keep llvm::Any around as a wrapper of > std::any once we can use it (in this case this patch would be

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. I think we both agree that OptionArgParser::ToAddress needs to fix the address, but I don't have an opinion about whether we should also do it in GetBreakableLoadAddress. I'm

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

jasonmolenda added a comment. In D136938#4005138 , @DavidSpickett wrote: >> What do you think about locating this change in ToAddress instead of >> Target::GetBreakableLoadAddress? It looks like the one caller to >> GetBreakableLoadAddress is

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett added a comment. > What do you think about locating this change in ToAddress instead of > Target::GetBreakableLoadAddress? It looks like the one caller to > GetBreakableLoadAddress is Target::CreateBreakpoint(addr_t addr) - which is > probably called by an SBTarget method if we

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast()); return llvm::any_cast(parser); } barannikov88 wrote: >

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne updated this revision to Diff 483975. sebastian-ne marked 2 inline comments as done. sebastian-ne added a comment. > It is surprising to me that std::any can work without RTTI. Never thought it > could be implemented. It seems like libstdc++ and libc++ both implement it the way

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Related: https://reviews.llvm.org/D139974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

jasonmolenda added a comment. I have a little example of a function pointer using ptrath in an arm64e (ARMv8.3) program, to show what I was talking about, * thread #1, queue = 'com.apple.main-thread', stop reason = instruction step into frame #0: 0x00013fa0 a.out`main + 40 at

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

labath added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platform. + mib wrote: > labath wrote: > > mib wrote: > > > mib

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. I think that the main reason we've arrived at such different conclusions is that I treat the "user IDs of DIEs" and and "user IDs of symbol files" as essentially two different things (namespaces if you will). Obviously, one needs the symbol file ID in order to compute

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

labath added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; Michael137 wrote: > Michael137 wrote: > > labath wrote: > > > This may depend on

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:193 - if (any_isa(IR)) { -const Function *F = any_cast(IR); -return F->getName().str(); + if (const auto **F = any_cast()) { +return (*F)->getName().str();

[Lldb-commits] [PATCH] D140293: [lldb] Update custom commands to always be overrriden

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This is a follow-up patch to 6f7835f309b9. As explained previously, when running from

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. In D139973#4004408 , @jsilvanus wrote: > I just checked on Godbolt that gcc 12.2 with libstdc++, clang 15.0 with both > libstd++ and libc++ and MSVC 19.33 support `std::any` without RTTI. > But gcc and clang do not provide

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jsilvanus added a comment. In D139973#4004344 , @barannikov88 wrote: > - std::any uses RTTI, so it is unlikely to ever replace llvm::Any. I just checked on Godbolt that gcc 12.2 with libstdc++, clang 15.0 with both libstd++ and libc++ and MSVC 19.33

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

Michael137 added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; Michael137 wrote: > labath wrote: > > This may depend on where you're going

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

Michael137 added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; labath wrote: > This may depend on where you're going with this, but right

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast()); return llvm::any_cast(parser); } This is not

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

barannikov88 added a comment. Just thoughts. llvm::any_isa is usually paired with llvm::any_cast; replacing them with llvm::any_cast and nullptr check seems fine. However, - std::any uses RTTI, so it is unlikely to ever replace llvm::Any. - llvm::any_isa<> is kind of convenient and is aligned

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jsilvanus accepted this revision. jsilvanus added a comment. This revision is now accepted and ready to land. LGTM, but let's wait for the other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973

Re: [Lldb-commits] [EXTERNAL] [lldb] fbaf48b - [lldb] Remove redundant .c_str() and .get() calls

(I fixed the test failures with 071c62c5d3eda2836174c0de82f6c55b082e26fc, so this should be safe to reapply now.) On 19/12/2022 01:09, Stella Stamenova via lldb-commits wrote: I think this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/27352 Can you address

[Lldb-commits] [lldb] 071c62c - [lldb] Modernize sprintf in FormatEntity.cpp

Author: Pavel Labath Date: 2022-12-19T10:53:20+01:00 New Revision: 071c62c5d3eda2836174c0de82f6c55b082e26fc URL: https://github.com/llvm/llvm-project/commit/071c62c5d3eda2836174c0de82f6c55b082e26fc DIFF: https://github.com/llvm/llvm-project/commit/071c62c5d3eda2836174c0de82f6c55b082e26fc.diff

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > If you just run ninja check-lldb prior to this patch libLTO would not be > built. Great, put that in the commit message. What I was trying to get at was the meaning of

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +};

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

labath accepted this revision. labath added a comment. That looks great. I have just one small nit. I think the test would read better if you made the names of temporary `TemplateArgument` objects more descriptive -- i.e. encode the kind and value information in the name. For example.

[Lldb-commits] [lldb] 58e9cc1 - Revert "[lldb] Remove redundant .c_str() and .get() calls"

Author: Muhammad Omair Javaid Date: 2022-12-19T13:52:10+05:00 New Revision: 58e9cc13e24f668a33abdae201d59a02e10c22c0 URL: https://github.com/llvm/llvm-project/commit/58e9cc13e24f668a33abdae201d59a02e10c22c0 DIFF: