[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 486719. ayermolo added a comment. removed + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Utility/Stat

[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

MaskRay accepted this revision. MaskRay added a comment. I don't think it is necessary to deprecate the old header then delete it after 16.0.0 is branched. llvm/Support/AArch64TargetParser.h has very few open-source out-of-tree uses. Perhaps only ldc `driver/targetmachine.cpp` uses the header. S

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D141042: [lldb] Allow configuring on Windows with python interpreter within a junction

clayborg accepted this revision. clayborg added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141042/new/ https://reviews.llvm.org/D141042 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D141087: Revert an unintentional API ABI break

This revision was automatically updated to reflect the committed changes. Closed by commit rG69f2b5fcf1be: Revert an unintentional API ABI break (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 69f2b5f - Revert an unintentional API ABI break

Author: Adrian Prantl Date: 2023-01-05T13:43:12-08:00 New Revision: 69f2b5fcf1be2226181cce21066f072279ba5d14 URL: https://github.com/llvm/llvm-project/commit/69f2b5fcf1be2226181cce21066f072279ba5d14 DIFF: https://github.com/llvm/llvm-project/commit/69f2b5fcf1be2226181cce21066f072279ba5d14.diff

[Lldb-commits] [PATCH] D140066: Add a final fallback technique to the old Darwin dynamic loader plugin to find the dyld_all_image_infos structure

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140066/new/ https://reviews.llvm.org/D140066 ___

[Lldb-commits] [PATCH] D141042: [lldb] Allow configuring on Windows with python interpreter within a junction

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable to me. @lawrence_danna do you happen to remember why you wrote: exe = os.path.join(os.path.realpath(os.path.dirname(exe)), os.readlink(exe)) instead of exe =

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486554. eloparco added a comment. Add integration tests for disassemble request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarg

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486553. eloparco added a comment. Add integration tests for disassemble request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarg

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486514. eloparco added a comment. Remove printf usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarget.h lldb/source/API/SBT

[Lldb-commits] [PATCH] D141042: [lldb] Allow configuring on Windows with python interpreter within a junction

zero9178 created this revision. zero9178 added reviewers: JDevlieghere, lawrence_danna, clayborg, labath, jingham. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current implementation nicely take

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; clayborg wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999