[Lldb-commits] [PATCH] D142793: Remove -py3 command line arg from swig invocation; generates warning with swig 4.1.1

jasonmolenda abandoned this revision. jasonmolenda added a comment. hasn't landed it, hasn't beaten me!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142793/new/ https://reviews.llvm.org/D142793 ___

[Lldb-commits] [PATCH] D142793: Remove -py3 command line arg from swig invocation; generates warning with swig 4.1.1

JDevlieghere added a comment. Ismail beat you to it: https://reviews.llvm.org/D142245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142793/new/ https://reviews.llvm.org/D142793 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D142793: Remove -py3 command line arg from swig invocation; generates warning with swig 4.1.1

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When I touch the bindings and build with ninja, I see

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda updated this revision to Diff 492951. jasonmolenda added a comment. Fix the nits Jonas pointed out, thanks Jonas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142792/new/ https://reviews.llvm.org/D142792 Files:

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

JDevlieghere added inline comments. Comment at: lldb/source/API/SBValue.cpp:935-940 +ProcessSP process_sp = m_opaque_sp->GetProcessSP(); +if (!process_sp) + return ret_val; +ABISP abi_sp = process_sp->GetABI(); +if (abi_sp) + return

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added inline comments. Comment at: lldb/source/API/SBValue.cpp:935-940 +ProcessSP process_sp = m_opaque_sp->GetProcessSP(); +if (!process_sp) + return ret_val; +ABISP abi_sp = process_sp->GetABI(); +if (abi_sp) + return

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added a comment. Thanks for the nits, good points. Comment at: lldb/source/API/SBValue.cpp:935-940 +ProcessSP process_sp = m_opaque_sp->GetProcessSP(); +if (!process_sp) + return ret_val; +ABISP abi_sp = process_sp->GetABI(); +if (abi_sp) +

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

JDevlieghere added a comment. I figured I'd leave some nits on a Friday afternoon. Comment at: lldb/bindings/interface/SBValue.i:117-132 +" // Return the value as an address. On failure, LLDB_INVALID_ADDRESS + // will be returned. On architectures like AArch64,

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda created this revision. jasonmolenda added a reviewer: DavidSpickett. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber:

[Lldb-commits] [lldb] 9000a36 - Manual DWARF index: don't skip over -gmodules debug info

Author: Adrian Prantl Date: 2023-01-27T15:59:46-08:00 New Revision: 9000a36f5cbd2993cd9c746610f7666ed173991a URL: https://github.com/llvm/llvm-project/commit/9000a36f5cbd2993cd9c746610f7666ed173991a DIFF: https://github.com/llvm/llvm-project/commit/9000a36f5cbd2993cd9c746610f7666ed173991a.diff

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rG9000a36f5cbd: Manual DWARF index: dont skip over -gmodules debug info (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D142683?vs=492852=492939#toc

[Lldb-commits] [lldb] f58de21 - [lldb][Test] TestVSCode_completions.py: fix expected type strings

Author: Michael Buch Date: 2023-01-27T23:21:52Z New Revision: f58de2125caf75ec0d40bc3e094a93c0b314a66a URL: https://github.com/llvm/llvm-project/commit/f58de2125caf75ec0d40bc3e094a93c0b314a66a DIFF: https://github.com/llvm/llvm-project/commit/f58de2125caf75ec0d40bc3e094a93c0b314a66a.diff LOG:

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

This revision was automatically updated to reflect the committed changes. Closed by commit rGce6a56e66781: Reland [lldb] Add support for DW_AT_default_value in template params (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ce6a56e - Reland "[lldb] Add support for DW_AT_default_value in template params"

Author: Michael Buch Date: 2023-01-27T22:49:46Z New Revision: ce6a56e66781eaad11c7285d37c1c410414676de URL: https://github.com/llvm/llvm-project/commit/ce6a56e66781eaad11c7285d37c1c410414676de DIFF: https://github.com/llvm/llvm-project/commit/ce6a56e66781eaad11c7285d37c1c410414676de.diff LOG:

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG47f0384bb969: [lldb][test] Set minimum compiler_versions (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/

[Lldb-commits] [lldb] 47f0384 - [lldb][test] Set minimum compiler_versions

Author: Dave Lee Date: 2023-01-27T14:29:45-08:00 New Revision: 47f0384bb96964e1416a52fc03b184a37fe05588 URL: https://github.com/llvm/llvm-project/commit/47f0384bb96964e1416a52fc03b184a37fe05588 DIFF: https://github.com/llvm/llvm-project/commit/47f0384bb96964e1416a52fc03b184a37fe05588.diff

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

rsmith added a comment. Including a link to the RFC (https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/68004/2) in each of the patches in this series would be helpful. Assuming that we want to go in this direction, it seems quite expensive to model

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Much better, thanks for making sure we don't end up indexing real skeleton units as they cause problems if they do get indexed. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4086789 , @labath wrote: > I'm sorry, but that patch does not fix the problem I am trying to point out. > In fact, I think it makes things a lot worse. > > We clearly have some kind of a communication problem, but I

[Lldb-commits] [PATCH] D142779: [LLDB][DRAFT] Add 64bit support to LLDB

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test Plan: Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

aprantl updated this revision to Diff 492852. aprantl added a comment. Added another heuristic to distinguish gmodules and fission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142683/new/ https://reviews.llvm.org/D142683 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. I'm sorry, but that patch does not fix the problem I am trying to point out. In fact, I think it makes things a lot worse. We clearly have some kind of a communication problem, but I am running out of ideas of what can I do about it. Let me try rephrasing it one more

[Lldb-commits] [PATCH] D142775: [LLDB] Remove GetUID API

ayermolo updated this revision to Diff 492848. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142775/new/ https://reviews.llvm.org/D142775 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. Created commit that removes getUID(...) https://reviews.llvm.org/D142775 Seems like it's isolated to SymbolFile and DWARF code. So now userid goes through DIERef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/

[Lldb-commits] [PATCH] D142775: [LLDB] Remove GetUID API

ayermolo created this revision. Herald added a reviewer: shafik. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Removed the GetUID API to make it

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo updated this revision to Diff 492842. ayermolo marked an inline comment as done. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139957/new/ https://reviews.llvm.org/D139957 Files:

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 492841. ayermolo added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:180-182 +// The unit has a dwo_id, but this isn't a .dwo skeleton unit, so +// the assumption is that this is a file produced by -gmodules and +// that we want to

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

aprantl added a comment. In D142683#4086026 , @aprantl wrote: > It shouldn't be able to interfere with the declarations in the (missing) .dwo > file in that case, right? Maybe I should have bothered reading your comment in the code. That's exactly the

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

This revision was automatically updated to reflect the committed changes. jgorbe marked an inline comment as done. Closed by commit rG805600c7d573: [lldb] Make SBSection::GetSectionData call Section::GetSectionData. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 805600c - [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

Author: Jorge Gorbe Moya Date: 2023-01-27T10:15:35-08:00 New Revision: 805600c7d573cf88cf035d01a2ea9389fc24d435 URL: https://github.com/llvm/llvm-project/commit/805600c7d573cf88cf035d01a2ea9389fc24d435 DIFF:

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

rriddle added a comment. I don't understand the MLIR changes here, how are they relevant to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142733/new/ https://reviews.llvm.org/D142733 ___

[Lldb-commits] [PATCH] D142662: Allow bytes-only mach-o corefile to load into lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG841b26f1d80f: Dont flag memory-only mach-o corefiles as invalid (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142662/new/

[Lldb-commits] [PATCH] D142663: Improve disable-language-runtime-unwindplans description to be more searchable

This revision was automatically updated to reflect the committed changes. Closed by commit rG8112bd2cb484: disable-language-runtime-unwindplans desc rewrite to be searchable (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8112bd2 - disable-language-runtime-unwindplans desc rewrite to be searchable

Author: Jason Molenda Date: 2023-01-27T09:40:54-08:00 New Revision: 8112bd2cb4845e0449088c764ad36748514259b8 URL: https://github.com/llvm/llvm-project/commit/8112bd2cb4845e0449088c764ad36748514259b8 DIFF: https://github.com/llvm/llvm-project/commit/8112bd2cb4845e0449088c764ad36748514259b8.diff

[Lldb-commits] [lldb] 841b26f - Don't flag memory-only mach-o corefiles as invalid

Author: Jason Molenda Date: 2023-01-27T09:40:54-08:00 New Revision: 841b26f1d80f69c45bbf2426761f3e3b9c927d86 URL: https://github.com/llvm/llvm-project/commit/841b26f1d80f69c45bbf2426761f3e3b9c927d86 DIFF: https://github.com/llvm/llvm-project/commit/841b26f1d80f69c45bbf2426761f3e3b9c927d86.diff

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

aprantl updated this revision to Diff 492782. aprantl added a comment. I added an unambiguous check for DWARF5+. The remaining incorrectly handled case is a DWARF4 + GNU fission extension where the .dwo file has been deleted. Is there any harm in indexing the skeleton in that case? It shouldn't

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

chrisbazley created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen,

[Lldb-commits] [PATCH] D142714: [lldb][CXXModuleHandler] Set TemplateArgument::IsDefaulted

This revision was automatically updated to reflect the committed changes. Closed by commit rG12e8e3fe90c9: [lldb][CXXModuleHandler] Set TemplateArgument::IsDefaulted (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142714/new/

[Lldb-commits] [lldb] 12e8e3f - [lldb][CXXModuleHandler] Set TemplateArgument::IsDefaulted

Author: Michael Buch Date: 2023-01-27T16:39:18Z New Revision: 12e8e3fe90c976d08d466b24ce21a7f7e86f4249 URL: https://github.com/llvm/llvm-project/commit/12e8e3fe90c976d08d466b24ce21a7f7e86f4249 DIFF: https://github.com/llvm/llvm-project/commit/12e8e3fe90c976d08d466b24ce21a7f7e86f4249.diff LOG:

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492749. Michael137 added a comment. - Remove redundant HostInfo calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett added reviewers: JDevlieghere, jasonmolenda. DavidSpickett added a comment. Apologies it took me so long to get around to this. As a superset of your change I presume the test you added will still pass. I don't have a Mac to confirm that myself. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow up to https://reviews.llvm.org/D141629 and applies

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 added a comment. API tests should all work once following lands: - https://reviews.llvm.org/D142713 - https://reviews.llvm.org/D142714 Just the Linux unit-test issue left now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492733. Michael137 added a comment. - Fix `import-std-module` API tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D142714: [lldb][CXXModuleHandler] Set TemplateArgument::IsDefaulted

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since https://reviews.llvm.org/D141827 this field gets used to print

[Lldb-commits] [PATCH] D142709: [lldb][Target] GetScratchTypeSystems: sort TypeSystems with strict weak ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rG78fee46d8d8e: [lldb][Target] GetScratchTypeSystems: sort TypeSystems with strict weak ordering (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 78fee46 - [lldb][Target] GetScratchTypeSystems: sort TypeSystems with strict weak ordering

Author: Michael Buch Date: 2023-01-27T13:22:11Z New Revision: 78fee46d8d8e82158b79a4ad948e8723e89f7f65 URL: https://github.com/llvm/llvm-project/commit/78fee46d8d8e82158b79a4ad948e8723e89f7f65 DIFF: https://github.com/llvm/llvm-project/commit/78fee46d8d8e82158b79a4ad948e8723e89f7f65.diff LOG:

[Lldb-commits] [PATCH] D142709: [lldb][Target] GetScratchTypeSystems: sort TypeSystems with strict weak ordering

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142709/new/ https://reviews.llvm.org/D142709

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset) ayermolo wrote: > labath wrote:

[Lldb-commits] [PATCH] D142709: [lldb][Target] GetScratchTypeSystems: sort TypeSystems with strict weak ordering

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added subscribers: mgrang, kristof.beyls. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `std::sort` requires a

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. In D138618#4083481 , @clayborg wrote: > We just need to create all DIERef objects using the GetID() from the symbol > file as the file index, and we should be able to remove the > SymbolFile::GetUID() function now. As long as

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I wouldn't exactly use the word happy, but I also don't have the time to come up with an alternative proposal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 added a comment. In D141828#4085191 , @Michael137 wrote: > In D141828#4085190 , @DavidSpickett > wrote: > >> I've reverted this due to test failures on Arm and AArch64. They were >> obscured by the

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

DavidSpickett added a comment. It appears that they passed on Windows, could be a Linux only issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 ___

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 added a comment. In D141828#4085190 , @DavidSpickett wrote: > I've reverted this due to test failures on Arm and AArch64. They were > obscured by the build failure so once you'd fixed that the bot was silent > about it. > > Here's one of

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

DavidSpickett added a comment. I've reverted this due to test failures on Arm and AArch64. They were obscured by the build failure so once you'd fixed that the bot was silent about it. Here's one of the builds: https://lab.llvm.org/buildbot/#/builders/96/builds/34718 SymbolFileDWARFTests:

[Lldb-commits] [lldb] 1efde67 - Revert "[lldb] Add support for DW_AT_default_value in template params"

Author: David Spickett Date: 2023-01-27T11:36:42Z New Revision: 1efde67d990c198b1480b2ab7b820f86388b84da URL: https://github.com/llvm/llvm-project/commit/1efde67d990c198b1480b2ab7b820f86388b84da DIFF: https://github.com/llvm/llvm-project/commit/1efde67d990c198b1480b2ab7b820f86388b84da.diff

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 492684. paperchalice added a comment. Use `LLVM_LIBRARY_OUTPUT_INTDIR`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files: