[Lldb-commits] [lldb] d6eaaa1 - [lldb] Remove unimplemented SBTraceCursor::GetExecutionContextRef

Author: Jonas Devlieghere Date: 2023-01-30T20:35:52-08:00 New Revision: d6eaaa1f13a9f7c3d3f87257ea2cf18e0dc13d86 URL: https://github.com/llvm/llvm-project/commit/d6eaaa1f13a9f7c3d3f87257ea2cf18e0dc13d86 DIFF:

[Lldb-commits] [lldb] 003f2b3 - [lldb, FreeBSD] getValue => operator* for Optional migration

Author: Fangrui Song Date: 2023-01-30T18:57:54-08:00 New Revision: 003f2b379d52832171eaa6272e3a2b1cabcd6f4e URL: https://github.com/llvm/llvm-project/commit/003f2b379d52832171eaa6272e3a2b1cabcd6f4e DIFF: https://github.com/llvm/llvm-project/commit/003f2b379d52832171eaa6272e3a2b1cabcd6f4e.diff

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

bulbazord added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:91 DEPENDS ${header} OUTPUT ${staged_header} -COMMAND ${CMAKE_COMMAND} -E copy ${header} ${staged_header} -COMMENT "LLDB.framework: collect framework header") +COMMAND unifdef

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib requested review of this revision. mib added a comment. I changed the implementation to be a blue to fix the tests. Could you guys please take another look ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/ https://reviews.llvm.org/D141658

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:452 -with open(path, 'r', encoding='utf-8') as f: +with open(os.path.normpath(os.path.expanduser(path)), 'r', encoding='utf-8') as f:

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib updated this revision to Diff 493456. mib edited the summary of this revision. mib added a comment. Fix test failures: - Change `-b|--batch` flag to `-m|--mode` options that expects an enum value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBAddress.h:14-16 +#ifdef SWIG +%include "interface/SBAddressDocstrings.i" +#endif Do we want two different .i files? Right now we have both"interface/SB*Docstrings.i" and

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 493453. mib added a comment. Address @JDevlieghere comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. So looks like this function needs to be fixed: llvm::Optional DWARFBaseDIE::GetDIERef() const { if (!IsValid()) return llvm::None; return DIERef(m_cu->GetSymbolFileDWARF().GetDwoNum(), m_cu->GetDebugSection(), m_die->GetOffset());

[Lldb-commits] [lldb] 40cef80 - [lldb/test] Skip TestStackCoreScriptedProcess if Asan is enabled

Author: Med Ismail Bennani Date: 2023-01-30T15:01:31-08:00 New Revision: 40cef80647cc21b86cbc7c969c7007f9a8f40715 URL: https://github.com/llvm/llvm-project/commit/40cef80647cc21b86cbc7c969c7007f9a8f40715 DIFF:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. In D138618#4086789 , @labath wrote: > I'm sorry, but that patch does not fix the problem I am trying to point out. > In fact, I think it makes things a lot worse. > > We clearly have some kind of a communication problem, but I

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. Looks good to me. Pavel? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:67 "attach the file at the start of this error message", -m_offset, (unsigned)abbr_idx); +(uint64_t)m_offset,

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated flags for generating bindings

kastiglione added a comment. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated flags for generating bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG8520b0fc59c0: [lldb/swig] Remove deprecated flags for generating bindings (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/

[Lldb-commits] [lldb] 8520b0f - [lldb/swig] Remove deprecated flags for generating bindings

Author: Med Ismail Bennani Date: 2023-01-30T14:07:32-08:00 New Revision: 8520b0fc59c010675afbfdae71d48893afc7b68b URL: https://github.com/llvm/llvm-project/commit/8520b0fc59c010675afbfdae71d48893afc7b68b DIFF:

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8b1cd3749eb6: [lldb] Use lldbassert in BuildObjCObjectPointerType (authored by JDevlieghere). Herald added a project:

[Lldb-commits] [lldb] 8b1cd37 - [lldb] Use lldbassert in BuildObjCObjectPointerType

Author: Jonas Devlieghere Date: 2023-01-30T13:52:44-08:00 New Revision: 8b1cd3749eb6872b3a71cee4fe65ae3b9de4dc93 URL: https://github.com/llvm/llvm-project/commit/8b1cd3749eb6872b3a71cee4fe65ae3b9de4dc93 DIFF:

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

mib added a comment. I'm very excited about this :) ! We've already discussed that offline but it would be nice if we could use Doxygen comments in the header files to generate the python Docstrings (I'm pretty sure SWIG supports it). Then, for python specific comments, we would have a

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, clayborg, jingham, labath, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. This is a proof-of-concept change that shows what it would take to use the API headers

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

goldstein.w.n added a comment. FWIW, if the only use if hashtables `xxhash` has a slight perf bug in `XXH3_len_129to240_128b` and `XXH3_len_129to240_64b` where it will repeat the last the block if length is a factor of `32`/`16` respectively. `XXH3_len_129to240_128b`: -

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

MaskRay added a comment. To enable smooth hash function migration in the future, we can explore the idea of adding `#ifdef EXPENSIVE_CHECKS\nshuffle` (see https://github.com/llvm/llvm-project/issues/34483). That means we should fix these tests properly to be non-dependent on the iteration

[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

asahay updated this revision to Diff 493337. asahay added a comment. Retain 'choices' for 'arch'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140839/new/ https://reviews.llvm.org/D140839 Files:

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added a subscriber: nikic. erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I don't

[Lldb-commits] [lldb] 8b4d263 - [lldb] Fix TestVSCode_completions for D141828

Author: Pavel Labath Date: 2023-01-30T13:20:30+01:00 New Revision: 8b4d263799e15e287ce1722eec5a133dd86aa06c URL: https://github.com/llvm/llvm-project/commit/8b4d263799e15e287ce1722eec5a133dd86aa06c DIFF: https://github.com/llvm/llvm-project/commit/8b4d263799e15e287ce1722eec5a133dd86aa06c.diff

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

labath added a comment. I'm sorry Omair, my comment was meant for Jorge, not you. `@skipIfXml` is not the right decorator here, although it will probably kinda fix the failure (because the bot does not have xml support either). I *think* the compressed section support is controlled by presence

[Lldb-commits] [PATCH] D136938: [LLDB] Fix code breakpoints on tagged addresses

DavidSpickett abandoned this revision. DavidSpickett added a comment. Superseded by https://reviews.llvm.org/D141629. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136938/new/ https://reviews.llvm.org/D136938

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde5d31e96f5: Revert Revert [lldb] Make SBSection::GetSectionData call Section… (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D142672?vs=492839=493267#toc Repository: rG

[Lldb-commits] [lldb] bde5d31 - Revert "Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData.""

Author: Muhammad Omair Javaid Date: 2023-01-30T16:49:15+05:00 New Revision: bde5d31e96f556fed30bf9120cc6ff05a2116b64 URL: https://github.com/llvm/llvm-project/commit/bde5d31e96f556fed30bf9120cc6ff05a2116b64 DIFF:

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

DavidSpickett added a comment. > Script authors may want access to both the actual uint64_t value, and the > address that will be accessed, in an SBValue, so I added a new method in > addition to GetValueAsUnsigned to provide this. In my rough cut of API stuff for memory tagging I had:

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

labath added a comment. I'm pretty sure that's because that bot builds without zlib support. You'll need to add something like `@skipIfXmlSupportMissing` to this test (I think we don't have a decorator for zlib now, so you'll probably need to add one). While you're at it, you might as well

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Do you intend to (optionnaly) provide XXH3 as described in https://github.com/Cyan4973/xxHash ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. Can you take a shot against https://llvm-compile-time-tracker.com/ so that we get an hint of the practical speedup? Looks like xxhash.h is missing from the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION