[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

2023-02-15 Thread Kamlesh Kumar via Phabricator via lldb-commits
kkcode0 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf18e4757b2: [debugserver] Initialize logging earlier in the startup sequence (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144142/

[Lldb-commits] [lldb] dcf18e4 - [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-02-15T16:35:51-08:00 New Revision: dcf18e4757b2bc2410031e7b69082117d540a1d6 URL: https://github.com/llvm/llvm-project/commit/dcf18e4757b2bc2410031e7b69082117d540a1d6 DIFF: https://github.com/llvm/llvm-project/commit/dcf18e4757b2bc2410031e7b69082117d540a1d6.diff

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

2023-02-15 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Conceptually, I think this looks good to me. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:68 // First, try `expr` as the name of a frame variable. - if (

[Lldb-commits] [PATCH] D144138: [lldb] Remove pydoc import during script interpreter init

2023-02-15 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf1ddfa6d8a72: [lldb] Remove pydoc import during script interpreter init (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144138/new/

[Lldb-commits] [lldb] f1ddfa6 - [lldb] Remove pydoc import during script interpreter init

2023-02-15 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2023-02-15T15:25:59-08:00 New Revision: f1ddfa6d8a72bcc89e01ab8f73bbe5ae5a0dc475 URL: https://github.com/llvm/llvm-project/commit/f1ddfa6d8a72bcc89e01ab8f73bbe5ae5a0dc475 DIFF: https://github.com/llvm/llvm-project/commit/f1ddfa6d8a72bcc89e01ab8f73bbe5ae5a0dc475.diff LOG:

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Alex Langford via Phabricator via lldb-commits
bulbazord updated this revision to Diff 497818. bulbazord added a comment. Moving second use of DNBSetLogMask outside of the log file block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144142/new/ https://reviews.llvm.org/D144142 Files: lldb/to

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added inline comments. Comment at: lldb/tools/debugserver/source/debugserver.cpp:1342 DNBLogSetLogMask(log_flags); } jasonmolenda wrote: > Should this be moved out of this `log_file != NULL` block so that the logging > flags are set based on

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added inline comments. Comment at: lldb/tools/debugserver/source/debugserver.cpp:1342 DNBLogSetLogMask(log_flags); } Should this be moved out of this `log_file != NULL` block so that the logging flags are set based on `-f` value? Otherwis

[Lldb-commits] [PATCH] D144142: [debugserver] Initialize logging earlier in the startup sequence

2023-02-15 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to setting up logging, we have uses of RNBLogSTDERR and RNBLogSTDOUT. Th

[Lldb-commits] [PATCH] D144138: [lldb] Remove pydoc import during script interpreter init

2023-02-15 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: jasonmolenda, mib, jingham, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The Python script interpreter imports `pydoc` duri

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

2023-02-15 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 497723. kastiglione added a comment. Use `expression`'s "description verbosity" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 Files: lldb/source/Commands/Comm

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

2023-02-15 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 497720. kastiglione added a comment. Some `expression` flags force the use of expression evaluation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 Files: lldb

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

2023-02-15 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adopt `expression`'s options in `dwim-print`

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

2023-02-15 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Looking good, one question left on the test file. Comment at: lldb/source/API/SBValue.cpp:936 + if (ABISP abi_sp = process_sp->GetABI()) +return abi_sp->FixCodeAddress(ret_val); +return ret_val; jasonmolenda wrote

[Lldb-commits] [PATCH] D144078: [lldb] Fix a log format warning on Windows, don't assume uint64_t is a long type

2023-02-15 Thread Martin Storsjö via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa8483b9b3038: [lldb] Fix a log format warning on Windows, don't assume uint64_t is a long type (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] a8483b9 - [lldb] Fix a log format warning on Windows, don't assume uint64_t is a long type

2023-02-15 Thread Martin Storsjö via lldb-commits
Author: Martin Storsjö Date: 2023-02-15T14:44:17+02:00 New Revision: a8483b9b30385807790882b3b770fa6d016a0aa4 URL: https://github.com/llvm/llvm-project/commit/a8483b9b30385807790882b3b770fa6d016a0aa4 DIFF: https://github.com/llvm/llvm-project/commit/a8483b9b30385807790882b3b770fa6d016a0aa4.diff

[Lldb-commits] [PATCH] D144078: [lldb] Fix a log format warning on Windows, don't assume uint64_t is a long type

2023-02-15 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: Emmmer, DavidSpickett, JDevlieghere, labath. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,