[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay updated this revision to Diff 498257. emrekultursay added a comment. Herald added a subscriber: JDevlieghere. Fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 Files:

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Leaving bits uncleared set causes callbacks to be triggered even though there are no events to process.

[Lldb-commits] [lldb] e052838 - [lldb] Add missing decorators import in TestPoPersistentResult.py

Author: Dave Lee Date: 2023-02-16T21:45:56-08:00 New Revision: e0528382b570bb18b438c20eadad34f8857a69a8 URL: https://github.com/llvm/llvm-project/commit/e0528382b570bb18b438c20eadad34f8857a69a8 DIFF: https://github.com/llvm/llvm-project/commit/e0528382b570bb18b438c20eadad34f8857a69a8.diff

[Lldb-commits] [lldb] 5552c4d - [lldb] Limit TestPoPersistentResult to darwin

Author: Dave Lee Date: 2023-02-16T21:11:48-08:00 New Revision: 5552c4ddd76de2447a86ab4b99506bd30590d36f URL: https://github.com/llvm/llvm-project/commit/5552c4ddd76de2447a86ab4b99506bd30590d36f DIFF: https://github.com/llvm/llvm-project/commit/5552c4ddd76de2447a86ab4b99506bd30590d36f.diff

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

This revision was automatically updated to reflect the committed changes. Closed by commit rG3328ee550c86: [lldb] Suppress persistent result when running po (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/

[Lldb-commits] [lldb] 3328ee5 - [lldb] Suppress persistent result when running po

Author: Dave Lee Date: 2023-02-16T21:05:19-08:00 New Revision: 3328ee550c86458ade5b3daf5fb4ad97b6a99e6c URL: https://github.com/llvm/llvm-project/commit/3328ee550c86458ade5b3daf5fb4ad97b6a99e6c DIFF: https://github.com/llvm/llvm-project/commit/3328ee550c86458ade5b3daf5fb4ad97b6a99e6c.diff

[Lldb-commits] [lldb] b3215c8 - [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC)

Author: Dave Lee Date: 2023-02-16T21:04:23-08:00 New Revision: b3215c8106170e586c59cc66a118329108cb72a4 URL: https://github.com/llvm/llvm-project/commit/b3215c8106170e586c59cc66a118329108cb72a4 DIFF: https://github.com/llvm/llvm-project/commit/b3215c8106170e586c59cc66a118329108cb72a4.diff

[Lldb-commits] [PATCH] D144042: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3215c810617: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498245. kastiglione added a comment. - Fix bug in new OptionGroupOptions::Append - Fix typo in GetEvaluateExpressionOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498241. kastiglione added a comment. Add and adopt new variation of OptionGroupOptions::Append Pass OptionGroupValueObjectDisplay to GetEvalateExpressionOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

aprantl added a comment. Did you forget to git-add the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144230/new/ https://reviews.llvm.org/D144230 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D144230: [lldb] Make persisting result variables configurable

aprantl added inline comments. Comment at: lldb/source/Commands/CommandObjectExpression.cpp:149 + case 'C': { +// 'C' for "caching", since both 'P' and 'p' for persist are taken. Both 'R' Do we expect people to actually use this flag or to just use an

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

saugustine added a comment. Thanks for the quick fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144228/new/ https://reviews.llvm.org/D144228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM then (with nits ;p) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144238/new/ https://reviews.llvm.org/D144238

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord added a comment. In D144238#4133940 , @mib wrote: > Should we also add a negative integer to the dictionary to make sure this > didn't cause a regression ? Negative integers are not correctly handled currently. I plan on fixing that in a

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

mib added a comment. Should we also add a negative integer to the dictionary to make sure this didn't cause a regression ? Comment at: lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py:25 s.Print( -

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rGffe982f96bff: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ffe982f - [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

Author: Alex Langford Date: 2023-02-16T18:33:12-08:00 New Revision: ffe982f96bff77c1b326f5109e2dddfbcde4ca2a URL: https://github.com/llvm/llvm-project/commit/ffe982f96bff77c1b326f5109e2dddfbcde4ca2a DIFF: https://github.com/llvm/llvm-project/commit/ffe982f96bff77c1b326f5109e2dddfbcde4ca2a.diff

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib updated this revision to Diff 498229. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 Files:

[Lldb-commits] [PATCH] D144238: [lldb] StructuredData should not truncate uint64_t values

bulbazord created this revision. bulbazord added a reviewer: mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In json::Value, getAsInteger returns an optional and getAsNumber returns an optional.

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Utility/ProcessInfo.h:90 + bool IsScriptedProcess() const; + JDevlieghere wrote: > Can we not ask this from the ScriptedMetadata? I think this is fine to ask the

[Lldb-commits] [PATCH] D143983: Remove Renderscript support from LLDB

kazu added a comment. In D143983#416 , @kazu wrote: > This patch seems to trigger: > > > lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:398:34: > error: variable 'lang_rt' set but not used [-Werror,-Wunused-but-set-variable]

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib updated this revision to Diff 498211. mib marked an inline comment as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 Files: lldb/bindings/python/python-swigsafecast.swig

[Lldb-commits] [lldb] 58bedae - [LLDB] Remove unused variable 'lang_rt' in ClangExpressionParser.cpp (NFC)

Author: Jie Fu Date: 2023-02-17T09:43:09+08:00 New Revision: 58bedaed0fea43fbf14bdb5f1da500528ca6dc80 URL: https://github.com/llvm/llvm-project/commit/58bedaed0fea43fbf14bdb5f1da500528ca6dc80 DIFF: https://github.com/llvm/llvm-project/commit/58bedaed0fea43fbf14bdb5f1da500528ca6dc80.diff LOG:

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:310-311 +size_t ScriptedProcess::DoWriteMemory(lldb::addr_t vm_addr, const void *buf, + size_t size,

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

bulbazord added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:310-311 +size_t ScriptedProcess::DoWriteMemory(lldb::addr_t vm_addr, const void *buf, + size_t size, Status ) { + lldb::DataExtractorSP

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib updated this revision to Diff 498207. mib added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 Files: lldb/bindings/python/python-swigsafecast.swig lldb/examples/python/scripted_process/scripted_process.py

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib updated this revision to Diff 498206. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 Files: lldb/bindings/python/python-swigsafecast.swig lldb/examples/python/scripted_process/scripted_process.py

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib updated this revision to Diff 498205. mib added a comment. Reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 Files: lldb/bindings/python/python-swigsafecast.swig lldb/examples/python/scripted_process/scripted_process.py

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4133717 , @mib wrote: > Hi @ayermolo! > > This patch is causing some failure on the macOS lldb bot: > https://green.lab.llvm.org/green/job/lldb-cmake/51257/ > > Could you take a look ? If you don't have the time, we

[Lldb-commits] [lldb] 8116fc5 - Revert "[LLDB] Enable 64 bit debug/type offset"

Author: Alexander Yermolovich Date: 2023-02-16T17:20:27-08:00 New Revision: 8116fc592c5eef88584033ec4f3539f405dee0e0 URL: https://github.com/llvm/llvm-project/commit/8116fc592c5eef88584033ec4f3539f405dee0e0 DIFF:

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

bulbazord added a comment. LGTM. @jingham what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

mib updated this revision to Diff 498201. mib retitled this revision from "[lldb] Extend SWIG SBProcess interface with WriteCStringToMemory method" to "[lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method". mib edited the summary of this revision. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds memory writing capabilities to the Scripted Process plugin. This allows

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

mib added a comment. Hi @ayermolo! This patch is causing some failure on the macOS lldb bot: https://green.lab.llvm.org/green/job/lldb-cmake/51257/ Could you take a look ? If you don't have the time, we can revert your patch until you manage to reproduce these failures. Let me know if you

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord added a comment. Just a personal preference but making those lambdas into static functions may make it easier to read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 ___ lldb-commits

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

pranavk accepted this revision. pranavk added a comment. This revision is now accepted and ready to land. I tested this and this does fix the issue with older swig version. Thanks for working on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteCStringToMemory method

bulbazord added a reviewer: jingham. bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I'm alright with the implementation, but I think you should add some documentation here. Also, what do you think of the name

[Lldb-commits] [PATCH] D144230: [lldb] Make use of persistent result variables configurable

kastiglione created this revision. kastiglione added reviewers: jingham, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Context: The `expression` command uses artificial variables to store

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133440 , @bulbazord wrote: > I'll upload a patch to handle that. D144228 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D144228: [lldb] Stop generating swig bindings for SBLaunchInfo copy constructor

bulbazord created this revision. bulbazord added reviewers: saugustine, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Given the line launch_info = lldb.SBLaunchInfo(None) We see different

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4133356 , @saugustine wrote: > I don't think this necessarily matters or is a reason to revert, but we are > seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. > > The docs claim that

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteCStringToMemory method

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch tries to address an interoperability issue when

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

saugustine added a comment. I don't think this necessarily matters or is a reason to revert, but we are seeing issues with this patch and swig 3.0.2, that disappear with swig 4.0. The docs claim that versions past 3.0 are supported (except for some odd corner cases). The failure is:

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

jingham requested changes to this revision. jingham added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119 } + +llvm::ArrayRef There's a version of Append that lets you exclude and

[Lldb-commits] [PATCH] D143983: Remove Renderscript support from LLDB

kazu added a comment. Herald added subscribers: Michael137, JDevlieghere. This patch seems to trigger: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:398:34: error: variable 'lang_rt' set but not used [-Werror,-Wunused-but-set-variable] lldb_private::LanguageRuntime

[Lldb-commits] [lldb] 2062e90 - [LLDB] Enable 64 bit debug/type offset

Author: Alexander Yermolovich Date: 2023-02-16T14:46:13-08:00 New Revision: 2062e90aa531e8445e5dc0e16222c0f246af1bf4 URL: https://github.com/llvm/llvm-project/commit/2062e90aa531e8445e5dc0e16222c0f246af1bf4 DIFF:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

This revision was automatically updated to reflect the committed changes. Closed by commit rG2062e90aa531: [LLDB] Enable 64 bit debug/type offset (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. OK, managed to setup windows VM, and couldn't repro. After reverting my fix for cross-projects tests locally, I saw test failures. Will try to push again and see if it triggers bot build failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

aprantl accepted this revision. aprantl added a comment. Yeah, this is better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144114/new/ https://reviews.llvm.org/D144114 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 53862b5 - RenderScript still exists as a clang language, so handle as invalid

Author: Sterling Augustine Date: 2023-02-16T12:23:05-08:00 New Revision: 53862b5658dd2dd5a38ecd0b4476cd22920d8f2a URL: https://github.com/llvm/llvm-project/commit/53862b5658dd2dd5a38ecd0b4476cd22920d8f2a DIFF:

[Lldb-commits] [lldb] b8d3d02 - Remove now unused enum.

Author: Sterling Augustine Date: 2023-02-16T11:54:35-08:00 New Revision: b8d3d02d7c8c67ba50c4e9508c435365317def9c URL: https://github.com/llvm/llvm-project/commit/b8d3d02d7c8c67ba50c4e9508c435365317def9c DIFF:

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG662548c82683: [lldb] Replace SB swig interfaces with API headers (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:68 // First, try `expr` as the name of a frame variable. - if (StackFrame *frame = m_exe_ctx.GetFramePtr()) { -auto valobj_sp = frame->FindVariable(ConstString(expr)); -if

[Lldb-commits] [PATCH] D144114: [lldb] Add expression command options in dwim-print

kastiglione updated this revision to Diff 498054. kastiglione added a comment. Use only a subset of expression flags. Specifically, don't expose `--debug`/`-g` or `--top-level`/`-p`. These, unlike the other `expression` flags, the semantics of these flags would seem to force `expression`

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

DavidSpickett added a comment. Note that this fixes https://github.com/llvm/llvm-project/issues/58769 in the commit message ("fixes #"). Also ping again! If you don't have the time to work on this in the near future, perhaps I can do the finishing touches and get it in (with you as co-author)?