[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:397-398 + /// cooperative interruption. If this is non-zero, InterruptRequested will + /// return true. Interruptible operations are expected to query this + /// flag periodically, and interrupt

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added a comment. I like this idea of this, but I would like to see this be a bit more complete. One idea is to remove the ObjectFileJSON::Symbol definition and just use lldb_private::Symbol objects and allow these objects to construct encode and decode from JSON. Then we have the

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Turns out breakpoint statistics is missing hitCount.

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added a comment. Hm, I've also got some problems with some ObjC tagged pointers in the testsuite, regardless of the FixCodeAddress/FixDataAddress issue. Need to look at this a bit more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

JDevlieghere added a comment. This will break the Xcode build again. It's being discussed here: https://github.com/llvm/llvm-project/issues/60314 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145181/new/ https://reviews.llvm.org/D145181

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added a comment. Maybe the right answer is to use FixDataAddress. It's possible someone could make a AArch64 FixCodeAddress that clears the low 2 bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142792/new/

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added a comment. Need to figure out something for the armv7 case before I try re-landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142792/new/ https://reviews.llvm.org/D142792 ___

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda updated this revision to Diff 501995. jasonmolenda added a comment. Updating patch with the final version, barring some fix for the armv7 ubuntu bot and TestDataFormatterSmartArray.py line 229 where it has a c-string pointer that gets its 0th bit cleared, Got output: (char *)

[Lldb-commits] [lldb] 7e770f9 - Revert "Add SBValue::GetValueAsAddress API for removing non-addressing metadata"

Author: Jason Molenda Date: 2023-03-02T14:36:37-08:00 New Revision: 7e770f9c1713046cb7b724b51e928186ec123c26 URL: https://github.com/llvm/llvm-project/commit/7e770f9c1713046cb7b724b51e928186ec123c26 DIFF: https://github.com/llvm/llvm-project/commit/7e770f9c1713046cb7b724b51e928186ec123c26.diff

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked 5 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp:37 + offset_t file_offset, offset_t length) { + if (!data_sp) { +data_sp = MapFileData(*file,

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

kastiglione added a comment. Given that json numbers are read into double, should the addresses be stored as strings to avoid any issues with address integer values that can't be represented as double (>=2**53)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. So from my point of view, this is a good path forward, so assuming that the other reviewers agree, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

aprantl added a comment. So, one could say that (right now) this patch is NFC for end-users, because `dwim-print` supports all use-cases that the old `p` alias supported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham, labath, werat. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6db44e52ce47: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6db44e5 - [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

Author: Jordan Rupprecht Date: 2023-03-02T13:51:30-08:00 New Revision: 6db44e52ce474bbeb66042073a6e3c6c586f78a2 URL: https://github.com/llvm/llvm-project/commit/6db44e52ce474bbeb66042073a6e3c6c586f78a2 DIFF:

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d635be2dbad: Add SBValue::GetValueAsAddress API for removing non-addressing metadata (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D142792?vs=501574=501962#toc

[Lldb-commits] [lldb] 4d635be - Add SBValue::GetValueAsAddress API for removing non-addressing metadata

Author: Jason Molenda Date: 2023-03-02T13:32:37-08:00 New Revision: 4d635be2dbadc77522eddc9668697385a3b9f8b4 URL: https://github.com/llvm/llvm-project/commit/4d635be2dbadc77522eddc9668697385a3b9f8b4 DIFF: https://github.com/llvm/llvm-project/commit/4d635be2dbadc77522eddc9668697385a3b9f8b4.diff

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

kparzysz added a comment. Looks good. Thanks for the quick fix @mib! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

mib added a comment. Left some comments but overall looks good to me :) Thanks for taking this ! Comment at: lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp:37 + offset_t file_offset, offset_t length) { + if (!data_sp) { +data_sp =

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin created this revision. aheejin added reviewers: jingham, JDevlieghere. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, clayborg, labath, DavidSpickett, mib. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber:

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib added a comment. @kparzysz I landed the fix in ab81fc29d9f7a8f8807293fc987f68f9ccf42259 . Let me know if you still have some issues. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ab81fc2 - [lldb/Interpreter] Fix build failures in ScriptInterpreterLua

Author: Med Ismail Bennani Date: 2023-03-02T12:46:34-08:00 New Revision: ab81fc29d9f7a8f8807293fc987f68f9ccf42259 URL: https://github.com/llvm/llvm-project/commit/ab81fc29d9f7a8f8807293fc987f68f9ccf42259 DIFF:

[Lldb-commits] [lldb] b970e72 - Revert "[lldb/Interpreter] Fix build failures in ScriptInterpreterLua"

Author: Med Ismail Bennani Date: 2023-03-02T12:46:18-08:00 New Revision: b970e725d8fd3f9b3d587e5203efd5e6f2e84e9a URL: https://github.com/llvm/llvm-project/commit/b970e725d8fd3f9b3d587e5203efd5e6f2e84e9a DIFF:

[Lldb-commits] [lldb] 6de18eb - [lldb/Interpreter] Fix build failures in ScriptInterpreterLua

Author: Med Ismail Bennani Date: 2023-03-02T12:44:45-08:00 New Revision: 6de18eb050a66544cc38210024860366b84faf35 URL: https://github.com/llvm/llvm-project/commit/6de18eb050a66544cc38210024860366b84faf35 DIFF:

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

MaskRay added a comment. In D138539#4164313 , @steakhal wrote: > Oh, I forgot to mention why this change breaks the equality operator of > `llvm::StringSet`. It's because the `StringMap::operator==` will try to > compare the `value` as well, which is

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib added a comment. In D144688#4165152 , @delcypher wrote: > In D144688#4165144 , @kparzysz > wrote: > >> This broke Lua support: >> >> In file included from >>

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added a comment. In D144688#4165144 , @kparzysz wrote: > This broke Lua support: > > In file included from > /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9: > >

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

kparzysz added a comment. This broke Lua support: In file included from /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9: /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h:95:68: error: non-virtual member function marked

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Hm, it would be easier to use `llvm::StringMap` instead of `std::nullopt_t`, or some adhoc empty struct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138539/new/ https://reviews.llvm.org/D138539

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Oh, I forgot to mention why this change breaks the equality operator of `llvm::StringSet`. It's because the `StringMap::operator==` will try to compare the `value` as well, which is of type `std::nullopt_t` and that has no equality comparison operator. Previously, the

[Lldb-commits] [PATCH] D138539: Use std::nullopt_t instead of NoneType (NFC)

steakhal added a comment. Herald added a subscriber: thopre. This patch breaks `llvm::StringSet` equality. The following code would no longer compile: llvm::StringSet LHS; llvm::StringSet RHS; bool equal = LHS == RHS; Such code might be used as gtest assertions like `EXPECT_EQ(LHS, RHS)`.

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. 2 minor things otherwise LGTM. Comment at: lldb/test/API/api/clear-sbvalue-nonadressable-bits/TestClearSBValueNonAddressableBits.py:20 +