[Lldb-commits] [PATCH] D145462: [LLDB][ObjectFileELF] Support LoongArch64 in ApplyReloctions

SixWeining created this revision. SixWeining added reviewers: labath, davide, DavidSpickett, xen0n, wangleiat, MaskRay. Herald added subscribers: pengfei, emaste. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: LLDB. Herald added a subscriber:

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 502897. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://reviews.llvm.org/D143520 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D145446: Fix LLDB windows build

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b38063b282: Fix LLDB windows build (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145446/new/

[Lldb-commits] [lldb] 71b3806 - Fix LLDB windows build

Author: Muhammad Omair Javaid Date: 2023-03-07T05:37:15+04:00 New Revision: 71b38063b282937640e05ab219c2baa6ed7d4ac7 URL: https://github.com/llvm/llvm-project/commit/71b38063b282937640e05ab219c2baa6ed7d4ac7 DIFF:

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Michael137 added a comment. In D145242#4173609 , @stella.stamenova wrote: > In D145242#4173592 , @Michael137 > wrote: > >> In D145242#4173577 , >> @stella.stamenova

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

aprantl added a comment. We might consider using dwim-print here in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145437/new/ https://reviews.llvm.org/D145437 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That seems to be clearly better, since `p` could be aliased to anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145437/new/

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

aprantl added a comment. Herald added a subscriber: JDevlieghere. From an end-user perspective, I like this. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 +if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. In D145242#4173592 , @Michael137 wrote: > In D145242#4173577 , > @stella.stamenova wrote: > >> Looks like either this change or D125241 >>

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Michael137 added a comment. In D145242#4173577 , @stella.stamenova wrote: > Looks like either this change or D125241 > broke the Windows lldb bot: > https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib marked an inline comment as done. mib added a subscriber: omjavaid. mib added a comment. In D143104#4173574 , @stella.stamenova wrote: > Looks like this change broke the windows lldb build: > https://lab.llvm.org/buildbot/#/builders/83/builds/29801

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

stella.stamenova added a comment. Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104

[Lldb-commits] [lldb] 470fd9c - [lldb] Stop opening Console.app and TextEdit.app when running the testsuite on macOS

Author: Alex Langford Date: 2023-03-06T16:47:56-08:00 New Revision: 470fd9c50a20a79e75b116ab938b9f87f38cba5c URL: https://github.com/llvm/llvm-project/commit/470fd9c50a20a79e75b116ab938b9f87f38cba5c DIFF: https://github.com/llvm/llvm-project/commit/470fd9c50a20a79e75b116ab938b9f87f38cba5c.diff

[Lldb-commits] [lldb] aa728ff - [lldb] Fix stack-use-after-scope issue in ScriptedInterface.h

Author: Med Ismail Bennani Date: 2023-03-06T16:35:24-08:00 New Revision: aa728ff754e9de91f20fca1e2847d69a81cccb75 URL: https://github.com/llvm/llvm-project/commit/aa728ff754e9de91f20fca1e2847d69a81cccb75 DIFF:

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 502854. JDevlieghere added a comment. Implement Greg's features. I'll add a unit test for the deserialization later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 Files:

[Lldb-commits] [PATCH] D145450: [lldb] Respect empty arguments in target.run-args

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, clayborg, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently empty arguments are not

[Lldb-commits] [PATCH] D145446: Fix LLDB windows build

omjavaid created this revision. omjavaid added a reviewer: mib. Herald added a subscriber: mstorsjo. Herald added a project: All. omjavaid requested review of this revision. LLDB WoA buildbot is failing due to pid_t redefinition after recent changes in

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

mib reopened this revision. mib added a comment. I've landed this by mistake, please take another look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145296/new/ https://reviews.llvm.org/D145296 ___

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib reopened this revision. mib added a comment. Landed this by mistake, please take another look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145295/new/ https://reviews.llvm.org/D145295 ___

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:23 +struct JSONSymbol { + uint64_t value; + std::optional size; JDevlieghere wrote: > clayborg wrote: > > clayborg wrote: > > > JDevlieghere wrote: > > > > clayborg wrote: > > > > >

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

mib reopened this revision. mib added a comment. I landed this by mistake ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145294/new/ https://reviews.llvm.org/D145294 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:23 +struct JSONSymbol { + uint64_t value; + std::optional size; clayborg wrote: > clayborg wrote: > > JDevlieghere wrote: > > >

[Lldb-commits] [PATCH] D145437: [lldb-vscode] Use `expression` command for completion

kastiglione created this revision. kastiglione added a reviewer: aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change lldb-vscode to use the `expression` command for generating

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:23 +struct JSONSymbol { + uint64_t value; + std::optional size; JDevlieghere wrote: > clayborg wrote: > > Do we something that says "value is an address"? Or are we inferring that >

[Lldb-commits] [lldb] 7975e3b - Revert "[lldb] Redefine p alias to dwim-print command"

Author: Dave Lee Date: 2023-03-06T15:05:15-08:00 New Revision: 7975e3b1255d8506b7a4c9a33ab91c39291996ba URL: https://github.com/llvm/llvm-project/commit/7975e3b1255d8506b7a4c9a33ab91c39291996ba DIFF: https://github.com/llvm/llvm-project/commit/7975e3b1255d8506b7a4c9a33ab91c39291996ba.diff

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:23 +struct JSONSymbol { + uint64_t value; + std::optional size; clayborg wrote: > Do we something that says "value is an address"?

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:351-356 +bool fromJSON(const llvm::json::Value , lldb_private::JSONSymbol , + llvm::json::Path path); + +bool fromJSON(const llvm::json::Value , lldb::SymbolType , +

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

clayborg added a comment. If these files can be used as the only source of information (without a stripped executable), we really should include a serialized SectionList in the JSON that can be loaded into ObjectFileJSON. This would be very useful for easily creating unit tests.

[Lldb-commits] [lldb] 9f8c974 - [lldb] Fix cyclic dependency issue in ScriptedMetadata

Author: Med Ismail Bennani Date: 2023-03-06T14:00:06-08:00 New Revision: 9f8c974f792d9d29387858842f05b86e92b0636c URL: https://github.com/llvm/llvm-project/commit/9f8c974f792d9d29387858842f05b86e92b0636c DIFF:

[Lldb-commits] [PATCH] D145414: [lldb/Utility] Fix layering violation caused by ScriptedMetadata

mib closed this revision. mib added a comment. Landed in 601583e5a3083b87b48bc6747c12dc0027b09481 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145414/new/

[Lldb-commits] [lldb] 896a346 - Revert "[lldb/Plugin] Add breakpoint setting support to ScriptedProcesses."

Author: Med Ismail Bennani Date: 2023-03-06T13:17:45-08:00 New Revision: 896a3469802122a37bba04bfebf2ab302c84cc87 URL: https://github.com/llvm/llvm-project/commit/896a3469802122a37bba04bfebf2ab302c84cc87 DIFF:

[Lldb-commits] [lldb] f9a663f - Revert "[lldb] Add an example of interactive scripted process debugging (NFC)"

Author: Med Ismail Bennani Date: 2023-03-06T13:17:46-08:00 New Revision: f9a663f9692f5e5342be0cbb27abc74cdf417434 URL: https://github.com/llvm/llvm-project/commit/f9a663f9692f5e5342be0cbb27abc74cdf417434 DIFF:

[Lldb-commits] [lldb] 20dbb29 - Revert "[lldb] Move ScriptedProcess private state update to implementation"

Author: Med Ismail Bennani Date: 2023-03-06T13:17:43-08:00 New Revision: 20dbb29a1a94c60b556f8880ab841b150e83ab25 URL: https://github.com/llvm/llvm-project/commit/20dbb29a1a94c60b556f8880ab841b150e83ab25 DIFF:

[Lldb-commits] [lldb] 480eb74 - Revert "[lldb/API] Introduce SBProcess::ForceScriptedState method"

Author: Med Ismail Bennani Date: 2023-03-06T13:17:40-08:00 New Revision: 480eb744982f2cecd9aa75ef32910fe023d8d4dc URL: https://github.com/llvm/llvm-project/commit/480eb744982f2cecd9aa75ef32910fe023d8d4dc DIFF:

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe06f495beb: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses. (authored by mib). Repository: rG

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3c33d72e7fa8: [lldb] Move ScriptedProcess private state update to implementation (authored by mib). Repository: rG

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3675e0bb67fa: [lldb/API] Introduce SBProcess::ForceScriptedState method (authored by mib). Repository: rG LLVM Github

[Lldb-commits] [lldb] 601583e - [lldb/Utility] Fix layering violation caused by ScriptedMetadata

Author: Med Ismail Bennani Date: 2023-03-06T13:14:15-08:00 New Revision: 601583e5a3083b87b48bc6747c12dc0027b09481 URL: https://github.com/llvm/llvm-project/commit/601583e5a3083b87b48bc6747c12dc0027b09481 DIFF:

[Lldb-commits] [lldb] 70b9822 - [lldb] Add an example of interactive scripted process debugging (NFC)

Author: Med Ismail Bennani Date: 2023-03-06T13:14:15-08:00 New Revision: 70b9822ef3b0774609c72d380504c9abfa717f81 URL: https://github.com/llvm/llvm-project/commit/70b9822ef3b0774609c72d380504c9abfa717f81 DIFF:

[Lldb-commits] [lldb] cfe06f4 - [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

Author: Med Ismail Bennani Date: 2023-03-06T13:14:15-08:00 New Revision: cfe06f495beb520ab366957d1108bb80c7c92832 URL: https://github.com/llvm/llvm-project/commit/cfe06f495beb520ab366957d1108bb80c7c92832 DIFF:

[Lldb-commits] [lldb] 3c33d72 - [lldb] Move ScriptedProcess private state update to implementation

Author: Med Ismail Bennani Date: 2023-03-06T13:14:15-08:00 New Revision: 3c33d72e7fa83beb8a9b39fb3b8ecf4ee00c697d URL: https://github.com/llvm/llvm-project/commit/3c33d72e7fa83beb8a9b39fb3b8ecf4ee00c697d DIFF:

[Lldb-commits] [lldb] 3675e0b - [lldb/API] Introduce SBProcess::ForceScriptedState method

Author: Med Ismail Bennani Date: 2023-03-06T13:14:15-08:00 New Revision: 3675e0bb67fa86b8476a67bb1a7623a6b1a373b3 URL: https://github.com/llvm/llvm-project/commit/3675e0bb67fa86b8476a67bb1a7623a6b1a373b3 DIFF:

[Lldb-commits] [PATCH] D145414: [lldb/Utility] Fix layering violation caused by ScriptedMetadata

mib added inline comments. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:33-38 - ScriptedMetadata(const OptionGroupPythonClassWithDict _group) { -auto opt_group = const_cast(option_group); -m_class_name = opt_group.GetName(); -m_args_sp =

[Lldb-commits] [PATCH] D145414: [lldb/Utility] Fix layering violation caused by ScriptedMetadata

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/include/lldb/Utility/ScriptedMetadata.h:33-38 - ScriptedMetadata(const OptionGroupPythonClassWithDict _group) { -auto opt_group =

[Lldb-commits] [PATCH] D145276: [lldb] Let 'v' command directly access ivars of _any_ self/this

kastiglione created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. kastiglione updated this revision to Diff 502753. kastiglione added a comment. kastiglione edited the summary of this revision. kastiglione added reviewers: aprantl, Michael137, jingham.

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

This revision was automatically updated to reflect the committed changes. Closed by commit rGa00801d94b02: [lldb] Redefine p alias to dwim-print command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/

[Lldb-commits] [lldb] a00801d - [lldb] Redefine p alias to dwim-print command

Author: Dave Lee Date: 2023-03-06T12:27:15-08:00 New Revision: a00801d94b02eaebd1385b03fb9e549c07cc8585 URL: https://github.com/llvm/llvm-project/commit/a00801d94b02eaebd1385b03fb9e549c07cc8585 DIFF: https://github.com/llvm/llvm-project/commit/a00801d94b02eaebd1385b03fb9e549c07cc8585.diff

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

kastiglione added a comment. > So, one could say that (right now) this patch is NFC for end-users, because > `dwim-print` supports all use-cases that the old `p` alias supported? Correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/source/Utility/ProcessInfo.cpp:11 +#include "lldb/Interpreter/ScriptedMetadata.h" #include "lldb/Utility/ArchSpec.h" labath wrote: > This is a layering violation. Can we

[Lldb-commits] [PATCH] D145414: [lldb/Utility] Fix layering violation caused by ScriptedMetadata

mib created this revision. mib added reviewers: labath, bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves `ScriptedMetadata.h` from the `Interpreter` directory to the

[Lldb-commits] [lldb] 23ee705 - Recommit [lldb] Test 'v' support for direct ivar access (NFC)

Author: Dave Lee Date: 2023-03-06T11:52:41-08:00 New Revision: 23ee705ac99aade24cec0ebb8f6c4cfc76bcdb08 URL: https://github.com/llvm/llvm-project/commit/23ee705ac99aade24cec0ebb8f6c4cfc76bcdb08 DIFF: https://github.com/llvm/llvm-project/commit/23ee705ac99aade24cec0ebb8f6c4cfc76bcdb08.diff

[Lldb-commits] [lldb] 3df28ef - Revert "[lldb] Test 'v' support for direct ivar access (NFC)"

Author: Dave Lee Date: 2023-03-06T11:12:28-08:00 New Revision: 3df28efaa0d2611e033a5fdce8e369446da9d3dc URL: https://github.com/llvm/llvm-project/commit/3df28efaa0d2611e033a5fdce8e369446da9d3dc DIFF: https://github.com/llvm/llvm-project/commit/3df28efaa0d2611e033a5fdce8e369446da9d3dc.diff

[Lldb-commits] [PATCH] D145124: [lldb] Add variable completion to dwim-print

This revision was automatically updated to reflect the committed changes. Closed by commit rG8794712e8877: [lldb] Add variable completion to dwim-print (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145124/new/

[Lldb-commits] [lldb] 8794712 - [lldb] Add variable completion to dwim-print

Author: Dave Lee Date: 2023-03-06T10:42:32-08:00 New Revision: 8794712e8877ed366542c32e28abe40d0a9ced6d URL: https://github.com/llvm/llvm-project/commit/8794712e8877ed366542c32e28abe40d0a9ced6d DIFF: https://github.com/llvm/llvm-project/commit/8794712e8877ed366542c32e28abe40d0a9ced6d.diff

[Lldb-commits] [lldb] 03e5c46 - [lldb] Test 'v' support for direct ivar access (NFC)

Author: Dave Lee Date: 2023-03-06T10:41:51-08:00 New Revision: 03e5c46e15b4a196cdca0c646e61f0c92a6dc7e1 URL: https://github.com/llvm/llvm-project/commit/03e5c46e15b4a196cdca0c646e61f0c92a6dc7e1 DIFF: https://github.com/llvm/llvm-project/commit/03e5c46e15b4a196cdca0c646e61f0c92a6dc7e1.diff

[Lldb-commits] [PATCH] D145348: [lldb] Test 'v' support for direct ivar access (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03e5c46e15b4: [lldb] Test v support for direct ivar access (NFC)

[Lldb-commits] [PATCH] D145348: [lldb] Test 'v' support for direct ivar access (NFC)

kastiglione updated this revision to Diff 502716. kastiglione added a comment. Split into separate cpp/this and objc/self tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145348/new/ https://reviews.llvm.org/D145348 Files:

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

clayborg added a comment. Just change HandleDestroryCallback to a member function and this is good to go. Comment at: lldb/source/Core/Debugger.cpp:688-694 +void Debugger::HandleDestroyCallback(const DebuggerSP _sp) { + if (debugger_sp->m_destroy_callback) { +

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG960126e04a6f: [LLDB][NativePDB] Check string table in PDB files. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145115/new/

[Lldb-commits] [lldb] 960126e - [LLDB][NativePDB] Check string table in PDB files.

Author: Zequan Wu Date: 2023-03-06T10:25:38-05:00 New Revision: 960126e04a6faad1b71e110a4262c5733e50fab7 URL: https://github.com/llvm/llvm-project/commit/960126e04a6faad1b71e110a4262c5733e50fab7 DIFF: https://github.com/llvm/llvm-project/commit/960126e04a6faad1b71e110a4262c5733e50fab7.diff

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of signals for ELF core files

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp:230 + + siginfo_t info; + info.si_signo = m_signo; labath wrote: > I think this won't work on Windows (no

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

labath added a comment. I kinda like this. Comment at: lldb/include/lldb/Core/Debugger.h:563 + // the previous IOHandler thread. + const HostThread SetIOHandlerThread(HostThread _thread); `const` on a return value rarely makes sense. OTOH, `const` on the

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of signals for ELF core files

labath added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp:230 + + siginfo_t info; + info.si_signo = m_signo; I think this won't work on Windows (no siginfo_t type, nor constants to decode it) -- and it may return garbage

[Lldb-commits] [PATCH] D145377: [LLDB] Show sub type of faults for ELF core files

DavidSpickett created this revision. Herald added subscribers: atanasyan, arichardson, sdardis, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Previously we only looked

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

labath added inline comments. Comment at: lldb/source/Utility/ProcessInfo.cpp:11 +#include "lldb/Interpreter/ScriptedMetadata.h" #include "lldb/Utility/ArchSpec.h" This is a layering violation. Can we restructure this so that it this does not depend on code

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG98c3dc3fa748: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines (authored by dstenb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 98c3dc3 - [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

Author: David Stenberg Date: 2023-03-06T14:23:29+01:00 New Revision: 98c3dc3fa748072fc42054fb90b295c2d5190bfe URL: https://github.com/llvm/llvm-project/commit/98c3dc3fa748072fc42054fb90b295c2d5190bfe DIFF:

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

dstenb added a comment. In D142552#4083939 , @clayborg wrote: > As long as there are no regressions in the test suite this looks good to me Thanks, and sorry for the delay with landing this! I have ran check-lldb. I will land this shortly.