[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

buttaface added a comment. I looked online and it appears that you nominate a trunk commit by opening a github issue ? I am new to this LLVM workflow myself, but here is what appears to be a recent example

[Lldb-commits] [lldb] 5831206 - [lldb][NFC] Remove outdated TODO in Log.h

Author: Alex Langford Date: 2023-03-24T17:53:54-07:00 New Revision: 583120642694f21dc5f7cfc59b22fa6e709258eb URL: https://github.com/llvm/llvm-project/commit/583120642694f21dc5f7cfc59b22fa6e709258eb DIFF: https://github.com/llvm/llvm-project/commit/583120642694f21dc5f7cfc59b22fa6e709258eb.diff

[Lldb-commits] [lldb] 5fb4147 - [lldb][NFC] Update and re-organize lldb-types.h

Author: Alex Langford Date: 2023-03-24T17:40:58-07:00 New Revision: 5fb4147f74ad90095f08f243e5f19877d09d11b9 URL: https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 DIFF: https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9.diff

[Lldb-commits] [lldb] 0016f47 - [lldb] Remove errant call to SBReproducer.SetWorkingDirectory

Author: Jonas Devlieghere Date: 2023-03-24T17:32:58-07:00 New Revision: 0016f476ab1f9013d336491924495ec01f43a045 URL: https://github.com/llvm/llvm-project/commit/0016f476ab1f9013d336491924495ec01f43a045 DIFF:

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

jgorbe added a comment. I just noticed a minor aesthetic problem with the input of `dwim-print` when using data formatters. There are some spacing adjustments in this commit but I'm not sure if they are the actual cause (please let me know if you'd prefer me to file a bug instead). You can

[Lldb-commits] [lldb] d0acc6f - [lldb][NFC] Remove outdated TODOs from API headers

Author: Alex Langford Date: 2023-03-24T15:50:57-07:00 New Revision: d0acc6f8c285a47eadc703385861c570f8a84978 URL: https://github.com/llvm/llvm-project/commit/d0acc6f8c285a47eadc703385861c570f8a84978 DIFF: https://github.com/llvm/llvm-project/commit/d0acc6f8c285a47eadc703385861c570f8a84978.diff

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

This revision was automatically updated to reflect the committed changes. Closed by commit rG23349d83a98f: [lldb] Add ability to hide the root name of a value (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/

[Lldb-commits] [lldb] 23349d8 - [lldb] Add ability to hide the root name of a value

Author: Dave Lee Date: 2023-03-24T14:07:31-07:00 New Revision: 23349d83a98f23e67ff0321dad7c378b117ce6aa URL: https://github.com/llvm/llvm-project/commit/23349d83a98f23e67ff0321dad7c378b117ce6aa DIFF: https://github.com/llvm/llvm-project/commit/23349d83a98f23e67ff0321dad7c378b117ce6aa.diff

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

emrekultursay added a comment. Sure, you are right that it should be pulled back into release/16.x, and I expect it to apply cleanly. However, I don't know what mechanism should bve used to create cherry-pick changes into release branches on GitHub: (1) this was not a GitHub issue/PR, so I

[Lldb-commits] [lldb] 44650a9 - [lldb] Add header REPL.h to lldb_Expression

Author: Alex Langford Date: 2023-03-24T12:42:50-07:00 New Revision: 44650a96a58b1233ed8e192232da05f6f74c6d5d URL: https://github.com/llvm/llvm-project/commit/44650a96a58b1233ed8e192232da05f6f74c6d5d DIFF: https://github.com/llvm/llvm-project/commit/44650a96a58b1233ed8e192232da05f6f74c6d5d.diff

[Lldb-commits] [lldb] 0999996 - Don't expect what newlines look like - never works on Windows.

Author: Jim Ingham Date: 2023-03-24T12:28:16-07:00 New Revision: 096f68186183eaf065e4a05a3e73170a19ae URL: https://github.com/llvm/llvm-project/commit/096f68186183eaf065e4a05a3e73170a19ae DIFF: https://github.com/llvm/llvm-project/commit/096f68186183eaf065e4a05a3e73170a19ae.diff

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione added inline comments. Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:278 - if (!m_options.m_hide_name) { + if (ShowName()) { if (m_options.m_flat_output) jgorbe wrote: > This method name reads like a command, rather than a

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe added a comment. I found the actual reason for the crash I was talking about. This patch only addressed the incorrect `OverflowError`, but the crash comes from a double free (as @rupprecht mentioned) in the error handling logic. The error path here

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

kastiglione updated this revision to Diff 508173. kastiglione added a comment. Rename ShowName to ShouldShowName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146783/new/ https://reviews.llvm.org/D146783 Files:

[Lldb-commits] [PATCH] D146783: [lldb] Add ability to hide the root name of a value

jgorbe added a comment. I've tried building lldb with this patch applied and it fixes the problem I saw. Thanks for the quick fix! I'm not very familiar with the code so I'd appreciate if someone else gives their LGTM too but the changes look reasonable to me (just one small nit I've

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

buttaface added a comment. @emrekultursay, do you think you can get this into the release/16.x branch next? It fixed lldb for us on the Android Termux app . Repository: rG LLVM Github

[Lldb-commits] [lldb] e7654a7 - [lldb] Explicitly mark PlatformFreeBSD's dependency on PlatformPOSIX

Author: Alex Langford Date: 2023-03-24T10:55:36-07:00 New Revision: e7654a7692c4f894eec136af07fe6756bef315fc URL: https://github.com/llvm/llvm-project/commit/e7654a7692c4f894eec136af07fe6756bef315fc DIFF: https://github.com/llvm/llvm-project/commit/e7654a7692c4f894eec136af07fe6756bef315fc.diff

[Lldb-commits] [PATCH] D146779: Fix handling of backticks in CommandObjectParsed commands

jingham added a comment. I fixed those two nits on submission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146779/new/ https://reviews.llvm.org/D146779 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 75ca15f - Fix backtick handling in parsed commands.

Author: Jim Ingham Date: 2023-03-24T10:40:10-07:00 New Revision: 75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae URL: https://github.com/llvm/llvm-project/commit/75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae DIFF: https://github.com/llvm/llvm-project/commit/75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae.diff

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. In D145803#4219894 , @probinson wrote: > This is pretty different from the "always desugar to the canonical type" > habit that has always been in place. Sony has done some downstream things to > try to work around that in the

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1187-1192 +symbol_file = os.path.join(tmp_dir.name, module.GetUUIDString() + ".json") +with open(symbol_file, 'w') as f: +f.write(json.dumps(symbol_data)) + +

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

probinson added subscribers: wolfgangp, probinson. probinson added a comment. This is pretty different from the "always desugar to the canonical type" habit that has always been in place. Sony has done some downstream things to try to work around that in the past. @wolfgangp will remember it

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. No issues with the patch. If you want to get it enabled on Linaro's lldb bots, email linaro-toolch...@lists.linaro.org and one of us will set it up for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/