[Lldb-commits] [PATCH] D147674: Interpret ESR/FAR bits directly on watchpoint exceptions in debugserver, clarify how watchpoint descriptions in stop packets work

jasonmolenda added a comment. One possible criticism I have of the current reason:watchpoint + description-up-to-three-integers is that we should add key-value pairs to the stop-info packet `wp-address:` `wp-index:` `wp-hit-address` and honestly, `silently-continue:` instead of doing an

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4246832 , @JDevlieghere wrote: > The change looks fine and regardless of whether this makes sense or even > complies with the standard, we should be resilient against it. I would like > to see a test though. Thanks a

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4245804 , @DavidSpickett wrote: > I'm not familiar with this code, but the issue as explained I think I > understand. > > It seems like you're checking for empty ranges in two places, what does each > one do? > > Is

[Lldb-commits] [PATCH] D147674: Interpret ESR/FAR bits directly on watchpoint exceptions in debugserver, clarify how watchpoint descriptions in stop packets work

jasonmolenda created this revision. jasonmolenda added reviewers: labath, JDevlieghere, omjavaid, DavidSpickett. jasonmolenda added a project: LLDB. Herald added subscribers: atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jasonmolenda requested review of this

[Lldb-commits] [PATCH] D147587: Fix the check in StopInfoBreakpoint for "are we running an expression"

This revision was automatically updated to reflect the committed changes. Closed by commit rGf79c037b6327: Fix the check in StopInfoBreakpoint for are we currently running an expression (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D147587?vs=510984=511237#toc

[Lldb-commits] [lldb] f79c037 - Fix the check in StopInfoBreakpoint for "are we currently running an expression"

Author: Jim Ingham Date: 2023-04-05T17:14:25-07:00 New Revision: f79c037b63278bc5b4481a1a55c68e42f0ea1461 URL: https://github.com/llvm/llvm-project/commit/f79c037b63278bc5b4481a1a55c68e42f0ea1461 DIFF: https://github.com/llvm/llvm-project/commit/f79c037b63278bc5b4481a1a55c68e42f0ea1461.diff

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873 LLDB_LOG(log, "ObjectFilePECOFF::AppendFromExportTable - failed to get export " "table entry name: {0}",

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873 LLDB_LOG(log, "ObjectFilePECOFF::AppendFromExportTable - failed to get export " "table entry name: {0}",

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873 LLDB_LOG(log, "ObjectFilePECOFF::AppendFromExportTable - failed to get export " "table entry name: {0}",

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd created this revision. compnerd added reviewers: bulbazord, sgraenitz, labath. compnerd added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. compnerd requested review of this revision. Ensure that we explicitly indicate that we would like the move

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

JDevlieghere added a comment. The change looks fine and regardless of whether this makes sense or even complies with the standard, we should be resilient against it. I would like to see a test though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e289b53 - [lldb] Remove unused functions from RegisterContextLinux_x86

Author: Pavel Labath Date: 2023-04-05T20:16:48+02:00 New Revision: e289b53f4d9bffd71613d6f91747bf9bda0ae352 URL: https://github.com/llvm/llvm-project/commit/e289b53f4d9bffd71613d6f91747bf9bda0ae352 DIFF: https://github.com/llvm/llvm-project/commit/e289b53f4d9bffd71613d6f91747bf9bda0ae352.diff

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511155. sgraenitz added a comment. Second try for the out-of-range test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 511151. sgraenitz added a comment. Add the missing 5th relocation to the test that exercises the out-of-range case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added a comment. In D145580#4245911 , @DavidSpickett wrote: > @bulbazord Please take a look and see if I've done the plugin/core code split > correctly. This looks fine. Thanks for being flexible and working with us to find something that

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Adding an abstraction for reading implicit addend or somehow integrate it into `ELFRelocation::RelocAddend32()` might be more confusing for the reader than keeping it in the function inline. What do you think? Comment at:

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz added a comment. This would be good to land in preparation for D147642 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147627/new/ https://reviews.llvm.org/D147627

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, peter.smith, labath, davide. Herald added subscribers: omjavaid, kristof.beyls, emaste. Herald added a project: All. sgraenitz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project:

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:127 llvm::Triple::hexagon, llvm::Triple::mips, llvm::Triple::mips64el, - llvm::Triple::mipsel, llvm::Triple::systemz}, + llvm::Triple::mipsel,

[Lldb-commits] [PATCH] D147587: Fix the check in StopInfoBreakpoint for "are we running an expression"

bulbazord accepted this revision. bulbazord added a comment. LGTM. It'd be nice if we could have a test that wasn't specific to Darwin or ObjC though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147587/new/ https://reviews.llvm.org/D147587

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, SixWeining. Herald added a subscriber: emaste. Herald added a project: All. sgraenitz requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. ObjectFileELF::ApplyRelocations()

[Lldb-commits] [lldb] 7e28a2c - Skip tests under asan

Author: Adrian Prantl Date: 2023-04-05T09:00:55-07:00 New Revision: 7e28a2c9f49d74b0dde02fd81b40f837f6140083 URL: https://github.com/llvm/llvm-project/commit/7e28a2c9f49d74b0dde02fd81b40f837f6140083 DIFF: https://github.com/llvm/llvm-project/commit/7e28a2c9f49d74b0dde02fd81b40f837f6140083.diff

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett marked 9 inline comments as done. DavidSpickett added a comment. @bulbazord Please take a look and see if I've done the plugin/core code split correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett updated this revision to Diff 511096. DavidSpickett added a comment. This revision is now accepted and ready to land. Move the type generation into a new plugin type, RegisterTypeBuilder. This means we're still resuing types if you read the same register multiple times, but we are

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

DavidSpickett added a comment. I'm not familiar with this code, but the issue as explained I think I understand. It seems like you're checking for empty ranges in two places, what does each one do? Is there anything else these ranges indicate or do we think it is simply a missed optimisation

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy created this revision. jwnhy added reviewers: Michael137, DavidSpickett, JDevlieghere. Herald added a project: All. jwnhy requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves an issue that lldb not be able to match the

[Lldb-commits] [lldb] e42f920 - [lldb] Remove unused private field 'm_orig_rax_info' in RegisterContextLinux_x86_64.h (NFC)

Author: Jie Fu Date: 2023-04-05T19:54:23+08:00 New Revision: e42f920918ca5b84329970825ce6a69b53f17bdb URL: https://github.com/llvm/llvm-project/commit/e42f920918ca5b84329970825ce6a69b53f17bdb DIFF: https://github.com/llvm/llvm-project/commit/e42f920918ca5b84329970825ce6a69b53f17bdb.diff LOG:

[Lldb-commits] [PATCH] D147045: [lldb] Drop RegisterInfoInterface::GetDynamicRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG933d3ee60007: [lldb] Drop RegisterInfoInterface::GetDynamicRegisterInfo (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147045/new/

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9e1fa17843: [lldb] Detach the child process when stepping over a fork (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141605/new/

[Lldb-commits] [lldb] af9e1fa - [lldb] Detach the child process when stepping over a fork

Author: Pavel Labath Date: 2023-04-05T13:25:43+02:00 New Revision: af9e1fa178433653eb3d36c42cad016449873cfc URL: https://github.com/llvm/llvm-project/commit/af9e1fa178433653eb3d36c42cad016449873cfc DIFF: https://github.com/llvm/llvm-project/commit/af9e1fa178433653eb3d36c42cad016449873cfc.diff

[Lldb-commits] [lldb] 933d3ee - [lldb] Drop RegisterInfoInterface::GetDynamicRegisterInfo

Author: Pavel Labath Date: 2023-04-05T13:25:43+02:00 New Revision: 933d3ee60007f5798319cad05b981cb265578ba0 URL: https://github.com/llvm/llvm-project/commit/933d3ee60007f5798319cad05b981cb265578ba0 DIFF: https://github.com/llvm/llvm-project/commit/933d3ee60007f5798319cad05b981cb265578ba0.diff