[Lldb-commits] [PATCH] D148063: [lldb] Parse the crashlog only once

This revision was automatically updated to reflect the committed changes. Closed by commit rG88f409194d5a: [lldb] Parse the crashlog only once (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148

[Lldb-commits] [lldb] 88f4091 - [lldb] Parse the crashlog only once

Author: Jonas Devlieghere Date: 2023-04-11T17:05:15-07:00 New Revision: 88f409194d5ac84eb19ee91260a17c6c8b992eda URL: https://github.com/llvm/llvm-project/commit/88f409194d5ac84eb19ee91260a17c6c8b992eda DIFF: https://github.com/llvm/llvm-project/commit/88f409194d5ac84eb19ee91260a17c6c8b992eda.d

[Lldb-commits] [PATCH] D148063: [lldb] Parse the crashlog only once

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148063/new/ https://reviews.llvm.org/D148063 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D148063: [lldb] Parse the crashlog only once

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Now that we can pass Python objects to the scripted process instance, we don't need to parse the crashlog twice anymore. https://reviews.llvm.org/

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

JDevlieghere created this revision. JDevlieghere added reviewers: mib, jingham. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds support for creating modules from JSON object files. This is necessary for crashlogs (see c17a1f3df70b

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

jasonmolenda updated this revision to Diff 512610. jasonmolenda added a comment. Update the patch to incorporate David's first feedback. I know this is a bit of a tricky patch to review because it is 95% comments/documentation/renaming of variables, followed by the one key change of removing `c

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

jasonmolenda added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:1609 +// There may be false-positive watchpoint hits on AArch64 as well, +// in the SVE Streaming Mode, but that is less common (v. ESR +// register flag "WPF", "Watchpoin

[Lldb-commits] [PATCH] D148053: [lldb] Parse image high address from JSON crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb67b7bb2f735: [lldb] Parse image high address from JSON crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] b67b7bb - [lldb] Parse image high address from JSON crashlogs

Author: Jonas Devlieghere Date: 2023-04-11T14:46:49-07:00 New Revision: b67b7bb2f73568efac077de189f86e86d9e010d6 URL: https://github.com/llvm/llvm-project/commit/b67b7bb2f73568efac077de189f86e86d9e010d6 DIFF: https://github.com/llvm/llvm-project/commit/b67b7bb2f73568efac077de189f86e86d9e010d6.d

[Lldb-commits] [PATCH] D148053: [lldb] Parse image high address from JSON crashlogs

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148053/new/ https://reviews.llvm.org/D148053 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D148053: [lldb] Parse image high address from JSON crashlogs

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Correctly parse the image high address from JSON crashlogs. This is invisible in the output but necessary for a follow up patch that will test the

[Lldb-commits] [PATCH] D148050: [lldb] Change formatter helper function parameter list to remove ConstString

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148050/new/ https://reviews.llvm.org/D148050 ___ lldb

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

jasonmolenda updated this revision to Diff 512577. jasonmolenda added a comment. Update patch to incorporate Jonas' & David's feedback. I'm holding this patch until I can get the lldb changes to fix the reason:watchpoint `description` handling corrected, or the test case in this patch will fail

[Lldb-commits] [PATCH] D148050: [lldb] Change formatter helper function parameter list to remove ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. All of these functions take a ConstString for the t

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

jasonmolenda added inline comments. Comment at: lldb/test/API/commands/watchpoints/unaligned-watchpoint/main.c:8-11 + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); + printf("%lld %lld\n", (*u64_p)++, (*u64_p)++); + printf(

[Lldb-commits] [lldb] 1fa26e6 - [PATCH][lldb] Fix dereference of null pointer.

Author: Caroline Tice Date: 2023-04-11T13:33:03-07:00 New Revision: 1fa26e64fd87c848ff54d08e9a14ea03e01ae645 URL: https://github.com/llvm/llvm-project/commit/1fa26e64fd87c848ff54d08e9a14ea03e01ae645 DIFF: https://github.com/llvm/llvm-project/commit/1fa26e64fd87c848ff54d08e9a14ea03e01ae645.diff

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ebf1bc66b89: [lldb] Change return type of EventData::GetFlavor (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147833/new/ https://r

[Lldb-commits] [lldb] 6ebf1bc - [lldb] Change return type of EventData::GetFlavor

Author: Alex Langford Date: 2023-04-11T10:49:17-07:00 New Revision: 6ebf1bc66b898e942f0f483aba200211c6c8ef31 URL: https://github.com/llvm/llvm-project/commit/6ebf1bc66b898e942f0f483aba200211c6c8ef31 DIFF: https://github.com/llvm/llvm-project/commit/6ebf1bc66b898e942f0f483aba200211c6c8ef31.diff

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147833/new/ https://reviews.llvm.org/D147833 ___

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added subscribers: aprantl, dblaikie. Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/no_unique_address/main.cpp:38 + long v = 42; +} _f3; + I haven't checked the reworked logic yet, but it still crashes on this: ``` self.expect_e

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

DavidSpickett added a comment. Thanks for looking into all this, it makes my head hurt thinking about it :) It will likely take us (Linaro) a while to do the lldb-server changes, but I do want to see this fixed eventually. We have some work upcoming for memcopy operations that will need special

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

DavidSpickett added a comment. > This patch takes the trap address (FAR register) and finds the nearest > watchpoint if it is not contained in any watched region. From what I remember, the Linux kernel also does this. Comment at: lldb/test/API/commands/watchpoints/unaligned-

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. > Looked into core dumping in LLDB a bit, I think it pretty much requires that > there is an OS, and there needs to be an explicit support for the > architecture in question. Plus, mspdebug doesn't actually support core files, > there is no use for it now even if

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. In D147606#4246832 , @JDevlieghere wrote: > The change looks fine and regardless of whether this makes sense or even > complies with the standard, we should be resilient against it. I would like > to see a test though. It seems

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy updated this revision to Diff 512362. jwnhy added a comment. Updated the patch to remove unncessary checks and added a testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147606/new/ https://reviews.llvm.org/D147606 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

labath added a comment. In D147606#4249283 , @JDevlieghere wrote: > In D147606#4247462 , @jwnhy wrote: > >> In D147606#4246832 , @JDevlieghere >> wrote: >> >>> The chang