[Lldb-commits] [lldb] 0ae342f - [lldb][test] Fix -Wsign-compare in RegisterFlagsTest.cpp (NFC)

Author: Jie Fu Date: 2023-04-14T09:47:21+08:00 New Revision: 0ae342f45bedd29e34690de087011a9da4db6a65 URL: https://github.com/llvm/llvm-project/commit/0ae342f45bedd29e34690de087011a9da4db6a65 DIFF: https://github.com/llvm/llvm-project/commit/0ae342f45bedd29e34690de087011a9da4db6a65.diff LOG:

[Lldb-commits] [PATCH] D148282: Fix the help for "type X delete" to make the -a & -w behaviors clear

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectType.cpp:112-113 +return "format"; + } +}; + maybe add an `llvm_unreachable` after the switch statement? Comment at:

[Lldb-commits] [PATCH] D148282: Fix the help for "type X delete" to make the -a & -w behaviors clear

jingham created this revision. jingham added reviewers: JDevlieghere, aprantl. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If you run: (lldb) type summary delete Foo that will only search for the

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rG27f27d15f6c9: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 27f27d1 - [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

Author: Jonas Devlieghere Date: 2023-04-13T16:56:29-07:00 New Revision: 27f27d15f6c90b026eca23b8ee238fdbf772fd80 URL: https://github.com/llvm/llvm-project/commit/27f27d15f6c90b026eca23b8ee238fdbf772fd80 DIFF:

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

aprantl accepted this revision. aprantl added a comment. Okay, then let the refactor fest begin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 ___

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

JDevlieghere accepted this revision. JDevlieghere added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. In D148175#4263217 , @aprantl wrote: > I understand that the opposite direction is explicit because actual work is > being done. In this

[Lldb-commits] [lldb] 6f8360a - [lldb] Use the host's target triple in TestObjectFileJSON

Author: Jonas Devlieghere Date: 2023-04-13T14:20:58-07:00 New Revision: 6f8360a0e15f3affe3f711130c693059930bc317 URL: https://github.com/llvm/llvm-project/commit/6f8360a0e15f3affe3f711130c693059930bc317 DIFF:

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5cdbf07e6d: [lldb] Make ObjectFileJSON loadable as a module (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0e5cdbf - [lldb] Make ObjectFileJSON loadable as a module

Author: Jonas Devlieghere Date: 2023-04-13T14:08:19-07:00 New Revision: 0e5cdbf07e6d45ca168a76b2bc19b6e385cfae17 URL: https://github.com/llvm/llvm-project/commit/0e5cdbf07e6d45ca168a76b2bc19b6e385cfae17 DIFF:

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/examples/python/crashlog.py:515 def parse_images(self, json_images): -idx = 0 -for json_image in json_images: +for idx,

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz added a comment. I think it's a very good practice that objects in moved-from state will only ever get destroyed. While the move ctor itself has no preconditions and thus might be fine to call again, the implementation of `consumeError()` does inspect the object. This adds an

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere updated this revision to Diff 513327. JDevlieghere marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148172/new/ https://reviews.llvm.org/D148172 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:515 def parse_images(self, json_images): -idx = 0 -for json_image in json_images: +for idx, json_image in enumerate(json_images): img_uuid =

[Lldb-commits] [lldb] 4c8662e - [lldb] Fix library layering after D145574

Author: Fangrui Song Date: 2023-04-13T10:55:15-07:00 New Revision: 4c8662e3fe304005d1a64c1c8bfb0c0d71e21324 URL: https://github.com/llvm/llvm-project/commit/4c8662e3fe304005d1a64c1c8bfb0c0d71e21324 DIFF: https://github.com/llvm/llvm-project/commit/4c8662e3fe304005d1a64c1c8bfb0c0d71e21324.diff

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:515 def parse_images(self, json_images): -idx = 0 -for json_image in json_images: +for idx, json_image in enumerate(json_images): img_uuid =

[Lldb-commits] [PATCH] D148172: [lldb] Use ObjectFileJSON to create modules for interactive crashlogs

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:515 def parse_images(self, json_images): -idx = 0 -for json_image in json_images: +for idx, json_image in enumerate(json_images): img_uuid =

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

MaskRay added inline comments. Comment at: lldb/include/lldb/lldb-private-types.h:14 +#include "lldb/Target/RegisterFlags.h" #include "lldb/lldb-private.h" Is there a library layering violation? I assume that `lldb/Target/*.h` files depend on

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 513245. kuilpd added a comment. Rebased and updated register info initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h

[Lldb-commits] [PATCH] D148151: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe58b42a7510: [lldb] Add CHECK to class-type-nullptr-deref.s test. (authored by cmtice). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] be58b42 - [lldb] Add 'CHECK' to class-type-nullptr-deref.s test.

Author: Caroline Tice Date: 2023-04-13T08:17:53-07:00 New Revision: be58b42a7510e3fe204e015bcf5faa9ed35d1766 URL: https://github.com/llvm/llvm-project/commit/be58b42a7510e3fe204e015bcf5faa9ed35d1766 DIFF: https://github.com/llvm/llvm-project/commit/be58b42a7510e3fe204e015bcf5faa9ed35d1766.diff

[Lldb-commits] [PATCH] D148228: [lldb] Change some pointers to refs in register printing code

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No one was passing nullptr for these. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148228

[Lldb-commits] [lldb] e07a421 - [lldb] Show register fields using bitfield struct types

Author: David Spickett Date: 2023-04-13T13:04:34Z New Revision: e07a421dd587f596b3b34ac2f79081402089f878 URL: https://github.com/llvm/llvm-project/commit/e07a421dd587f596b3b34ac2f79081402089f878 DIFF: https://github.com/llvm/llvm-project/commit/e07a421dd587f596b3b34ac2f79081402089f878.diff

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07a421dd587: [lldb] Show register fields using bitfield struct types (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145580/new/

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true;

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

This revision was automatically updated to reflect the committed changes. Closed by commit rG54981bb75d37: [lldb] Read register fields from target XML (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145574/new/

[Lldb-commits] [lldb] 54981bb - [lldb] Read register fields from target XML

Author: David Spickett Date: 2023-04-13T12:34:14Z New Revision: 54981bb75d374863c6a15530018c6d7ac5be6478 URL: https://github.com/llvm/llvm-project/commit/54981bb75d374863c6a15530018c6d7ac5be6478 DIFF: https://github.com/llvm/llvm-project/commit/54981bb75d374863c6a15530018c6d7ac5be6478.diff

[Lldb-commits] [lldb] cc6ab26 - [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

Author: Stefan Gränitz Date: 2023-04-13T14:32:15+02:00 New Revision: cc6ab268d89b27723f62517a07e86df85e999c89 URL: https://github.com/llvm/llvm-project/commit/cc6ab268d89b27723f62517a07e86df85e999c89 DIFF:

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

This revision was automatically updated to reflect the committed changes. sgraenitz marked an inline comment as done. Closed by commit rGcc6ab268d89b: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations (authored by sgraenitz). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks for your feedback Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2704 +default: + assert(false && "unexpected relocation type"); + break;

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

sgraenitz updated this revision to Diff 513187. sgraenitz added a comment. Include `R_386_NONE` for error reporting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147627/new/ https://reviews.llvm.org/D147627 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Addressed feedback and added handling for `R_ARM_REL32`. I didn't see a real-world case for it yet. Hope it's ok to have the error reported for the time being. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2640 +static void

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513179. sgraenitz added a comment. Add error reporting for `R_ARM_REL32` relocations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/ https://reviews.llvm.org/D147642 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz updated this revision to Diff 513178. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename new function to `ApplyELF32ABS32RelRelocation()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147642/new/

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. I just landed https://github.com/llvm/llvm-project/commit/57c8fee1b97eb7e70513b935b765f8381a941b18 which will give you build errors. All you have to do is add an extra `nullptr` to your register infos. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D145566: [lldb] Add RegisterFlags class

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea45e3007b8: [lldb] Add RegisterFlags class (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145566/new/

[Lldb-commits] [lldb] 6ea45e3 - [lldb] Add RegisterFlags class

Author: David Spickett Date: 2023-04-13T10:54:52Z New Revision: 6ea45e3007b8a489afa56af13a2b8bfcec201a93 URL: https://github.com/llvm/llvm-project/commit/6ea45e3007b8a489afa56af13a2b8bfcec201a93 DIFF: https://github.com/llvm/llvm-project/commit/6ea45e3007b8a489afa56af13a2b8bfcec201a93.diff

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. Also please update the commit message to make it clear that this is for using lldb with mspdebug, not with lldb-server. To help us and also to help anyone who might link to this commit to share the good news :) CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

DavidSpickett added a comment. Thanks for the test changes, looks good. There is some documentation that lists what targets we support, MSP430 should be added there. `lldb/docs/index.rst` is one of those. Otherwise, can anyone else think of major debug features that should be (at least) smoke

[Lldb-commits] [lldb] c912c0e - [LLDB][docs] Remove outdated list of Buildbots

Author: David Spickett Date: 2023-04-13T08:53:06Z New Revision: c912c0eef349b0a541c933a1a6ba9dd09dab5ce8 URL: https://github.com/llvm/llvm-project/commit/c912c0eef349b0a541c933a1a6ba9dd09dab5ce8 DIFF: https://github.com/llvm/llvm-project/commit/c912c0eef349b0a541c933a1a6ba9dd09dab5ce8.diff