[Lldb-commits] [lldb] d81cdb4 - Revert D148384 "[Demangle] replace use of llvm::StringView w/ std::string_view"

Author: Fangrui Song Date: 2023-04-14T18:42:11-07:00 New Revision: d81cdb49d74064e88843733e7da92db865943509 URL: https://github.com/llvm/llvm-project/commit/d81cdb49d74064e88843733e7da92db865943509 DIFF: https://github.com/llvm/llvm-project/commit/d81cdb49d74064e88843733e7da92db865943509.diff

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

MaskRay added a comment. In D148384#4270505 , @dhoekwater wrote: > It looks like this breaks the build: > https://lab.llvm.org/buildbot#builders/119/builds/12865 > https://lab.llvm.org/buildbot#builders/123/builds/18388 >

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

bulbazord added a comment. Creating a ProcessAttachInfo from a ProcessLaunchInfo with this change means they'll have different listeners. Is that ProcessLaunchInfo kept around for any other reason? Or is it just made to create the ProcessAttachInfo? This seems like a reasonable move to me, but

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

dhoekwater added a comment. It looks like this breaks the build: https://lab.llvm.org/buildbot#builders/119/builds/12865 https://lab.llvm.org/buildbot#builders/123/builds/18388 https://lab.llvm.org/buildbot#builders/60/builds/11628 I'm pretty new with LLVM so I'll leave reverting the change

[Lldb-commits] [PATCH] D148402: [lldb] Remove use of ConstString from Args::GetShellSafeArgument

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Having the names of various shells in

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 513818. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ https://reviews.llvm.org/D145297 Files: lldb/test/API/functionalities/interactive_scripted_process/Makefile

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

mib updated this revision to Diff 513817. mib retitled this revision from "[lldb] Add an example of interactive scripted process debugging (NFC)" to "[lldb] Add an example of interactive scripted process debugging". mib edited the summary of this revision. mib added a comment. Many changes: -

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

MaskRay added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + chapuni wrote: > Odd layering... Good catch. LLVMDemangle cannot depend on other LLVM libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new convience constructor to the SBError

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib created this revision. mib added reviewers: jingham, JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch should address an issue that caused the process public run lock to not be

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

chapuni added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + Odd layering... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib created this revision. mib added reviewers: bulbazord, jingham, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improves process state change logging messages to include to process

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a subscriber: emaste. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch augments lldb's event listeners

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

bulbazord added a comment. In D148380#4270090 , @JDevlieghere wrote: > In D148380#4270085 , @bulbazord > wrote: > >> In D148380#4269876 , @bulbazord >> wrote: >> >>>

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a simple refactor that unifies the default and hijack listener methods and

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. In D148384#4270106 , @nickdesaulniers wrote: > These windows buildbot failures are tough to make out: > https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio > > [2/1778] Building CXX object >

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. These windows buildbot failures are tough to make out: https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio [2/1778] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\DLangDemangle.cpp.obj FAILED:

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148380/new/ https://reviews.llvm.org/D148380

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e559509b426: [Demangle] replace use of llvm::StringView w/ std::string_view (authored by nickdesaulniers). Herald added a subscriber: JDevlieghere.

[Lldb-commits] [lldb] 3e55950 - [Demangle] replace use of llvm::StringView w/ std::string_view

Author: Nick Desaulniers Date: 2023-04-14T15:48:38-07:00 New Revision: 3e559509b426b6aae735a7f57dbdaed1041d2622 URL: https://github.com/llvm/llvm-project/commit/3e559509b426b6aae735a7f57dbdaed1041d2622 DIFF:

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

JDevlieghere added a comment. In D148380#4270085 , @bulbazord wrote: > In D148380#4269876 , @bulbazord > wrote: > >> In D148380#4269862 , @JDevlieghere >> wrote: >> >>>

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

bulbazord added a comment. In D148380#4269876 , @bulbazord wrote: > In D148380#4269862 , @JDevlieghere > wrote: > >> Does this actually have to be a //recursive// mutex? > > Good point, I don't think it does.

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 513779. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fix lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

bulbazord added a comment. In D148380#4269862 , @JDevlieghere wrote: > Does this actually have to be a //recursive// mutex? Good point, I don't think it does. I'll update this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

JDevlieghere added a comment. Does this actually have to be a //recursive// mutex? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148380/new/ https://reviews.llvm.org/D148380 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This class is not safe in multithreaded code. It's

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Adrian's and my comments addressed. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function.

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D148228: [lldb] Change some pointers to refs in register printing code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148228/new/ https://reviews.llvm.org/D148228

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:518 +// because C++14 is the default standard for Clang but enabling CPlusPlus14 +// expression evaluatino doesn't pass the test-suite cleanly. +

[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/include/lldb/lldb-private-types.h:14 +#include "lldb/Target/RegisterFlags.h" #include "lldb/lldb-private.h" MaskRay wrote: > Is there a library layering

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdfa2957437: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6cdfa29 - [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Author: Michael Buch Date: 2023-04-14T17:11:30+01:00 New Revision: 6cdfa295743729178ff6f15a8dcd36f8f7d27c2c URL: https://github.com/llvm/llvm-project/commit/6cdfa295743729178ff6f15a8dcd36f8f7d27c2c DIFF: https://github.com/llvm/llvm-project/commit/6cdfa295743729178ff6f15a8dcd36f8f7d27c2c.diff

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

This revision was automatically updated to reflect the committed changes. Closed by commit rG0301a492f43e: [lldb][Language] Add more language types (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/D143061?vs=493896=513622#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 89cd0e8 - [lldb] Allow evaluating expressions in C++20 mode

Author: Michael Buch Date: 2023-04-14T17:10:18+01:00 New Revision: 89cd0e8c267f57004a734c94ff15c6bd0facf646 URL: https://github.com/llvm/llvm-project/commit/89cd0e8c267f57004a734c94ff15c6bd0facf646 DIFF: https://github.com/llvm/llvm-project/commit/89cd0e8c267f57004a734c94ff15c6bd0facf646.diff

[Lldb-commits] [lldb] 0301a49 - [lldb][Language] Add more language types

Author: Michael Buch Date: 2023-04-14T17:10:17+01:00 New Revision: 0301a492f43efc3a2c1fa1bddd16e46aac8ab77e URL: https://github.com/llvm/llvm-project/commit/0301a492f43efc3a2c1fa1bddd16e46aac8ab77e DIFF: https://github.com/llvm/llvm-project/commit/0301a492f43efc3a2c1fa1bddd16e46aac8ab77e.diff

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 updated this revision to Diff 513621. Michael137 added a comment. - Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143062/new/ https://reviews.llvm.org/D143062 Files:

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd added a comment. @sgraenitz done :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd updated this revision to Diff 513614. compnerd added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/ https://reviews.llvm.org/D147669 Files: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Index:

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGce7a54a27c09: [lldb] Add `operator StringRef` to ConstString (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/

[Lldb-commits] [lldb] ce7a54a - [lldb] Add `operator StringRef` to ConstString

Author: Dave Lee Date: 2023-04-14T09:08:19-06:00 New Revision: ce7a54a27c0960e057a6eaf968d6967f75590fb1 URL: https://github.com/llvm/llvm-project/commit/ce7a54a27c0960e057a6eaf968d6967f75590fb1 DIFF: https://github.com/llvm/llvm-project/commit/ce7a54a27c0960e057a6eaf968d6967f75590fb1.diff

[Lldb-commits] [PATCH] D148175: [lldb] Add `operator StringRef` to ConstString

fdeazeve added a comment. > since ConstStrings live forever So long as this is true, I don't see any pitfalls either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148175/new/ https://reviews.llvm.org/D148175

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:548 +[[fallthrough]]; case lldb::eLanguageTypeC_plus_plus: case lldb::eLanguageTypeC_plus_plus_11: aprantl wrote: > Why no case C++17?

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:551 case lldb::eLanguageTypeC_plus_plus_14: lang_opts.CPlusPlus11 = true;

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

labath added inline comments. Comment at: lldb/test/API/macosx/symbols/TestObjectFileJSON.py:82 +} +self.emitJSON(data, json_object_file) + The test was (95%!) flaky because the two generated files had the same timestamp (and so lldb considered

[Lldb-commits] [lldb] 09ba7b6 - [lldb] Add a sleep to TestObjectFileJSON

Author: Pavel Labath Date: 2023-04-14T14:37:32+02:00 New Revision: 09ba7b605327812cfcec4f3c01d7fc232dee651d URL: https://github.com/llvm/llvm-project/commit/09ba7b605327812cfcec4f3c01d7fc232dee651d DIFF: https://github.com/llvm/llvm-project/commit/09ba7b605327812cfcec4f3c01d7fc232dee651d.diff

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513547. Michael137 added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513542. Michael137 added a comment. - Make condition more readable - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files:

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513539. Michael137 added a comment. - Move doxygen comment - Add source comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files:

[Lldb-commits] [PATCH] D147436: [lldb][ClangExpression] Filter out non-root namespaces in FindNamespace

Michael137 updated this revision to Diff 513531. Michael137 added a comment. - Only search for root namespace if we're doing a qualified lookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147436/new/ https://reviews.llvm.org/D147436 Files:

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

sgraenitz added a comment. Double-checked and found source locations on Raspberry Pi 3b with this patch applied https://github.com/llvm/llvm-project/issues/61948#issuecomment-1508305542 Is there more feedback on this? It would be nice to land it soon, i.e. before EuroLLVM =) Repository: rG

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Michael137