[Lldb-commits] [PATCH] D148603: Remove hardcoding of addressing bits in ABIMacOSX_arm64

2023-04-17 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: kristof.beyls, arichardson. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Early in

[Lldb-commits] [PATCH] D148588: [lldb] Add more asserts to TestExec

2023-04-17 Thread Dave Lee via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG773d9c360432: [lldb] Add more asserts to TestExec (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 773d9c3 - [lldb] Add more asserts to TestExec

2023-04-17 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2023-04-17T18:43:42-07:00 New Revision: 773d9c36043204c284324bc37a1de769a7575034 URL: https://github.com/llvm/llvm-project/commit/773d9c36043204c284324bc37a1de769a7575034 DIFF: https://github.com/llvm/llvm-project/commit/773d9c36043204c284324bc37a1de769a7575034.diff

[Lldb-commits] [PATCH] D148588: [lldb] Add more asserts to TestExec

2023-04-17 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148588/new/ https://reviews.llvm.org/D148588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D148579: [lldb] Change parameter type of StructuredData::ParseJSON

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bddb13c2470: [lldb] Change parameter type of StructuredData::ParseJSON (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148579/new/

[Lldb-commits] [lldb] 8bddb13 - [lldb] Change parameter type of StructuredData::ParseJSON

2023-04-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-04-17T17:25:05-07:00 New Revision: 8bddb13c2470b95651955c61913627b31e9c99d6 URL: https://github.com/llvm/llvm-project/commit/8bddb13c2470b95651955c61913627b31e9c99d6 DIFF: https://github.com/llvm/llvm-project/commit/8bddb13c2470b95651955c61913627b31e9c99d6.diff

[Lldb-commits] [PATCH] D148588: [lldb] Add more asserts to TestExec

2023-04-17 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: augusto2112, jingham, mib, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If this test fails, the error message isn't

[Lldb-commits] [PATCH] D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.

2023-04-17 Thread Jorge Gorbe Moya via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb. (authored by jgorbe). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 3c91d01 - [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.

2023-04-17 Thread Jorge Gorbe Moya via lldb-commits
Author: Jorge Gorbe Moya Date: 2023-04-17T17:03:29-07:00 New Revision: 3c91d016349a5189691cf788da84608cae68bc13 URL: https://github.com/llvm/llvm-project/commit/3c91d016349a5189691cf788da84608cae68bc13 DIFF:

[Lldb-commits] [PATCH] D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.

2023-04-17 Thread Jorge Gorbe Moya via Phabricator via lldb-commits
jgorbe created this revision. jgorbe added reviewers: Michael137, dblaikie, aprantl. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The functionality added by https://reviews.llvm.org/D145803 is gated

[Lldb-commits] [PATCH] D148579: [lldb] Change parameter type of StructuredData::ParseJSON

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148579/new/ https://reviews.llvm.org/D148579 ___

[Lldb-commits] [PATCH] D148579: [lldb] Change parameter type of StructuredData::ParseJSON

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of taking a `const std::string &` we can take an

[Lldb-commits] [lldb] 81beb15 - [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Anton Korobeynikov via lldb-commits
Author: Ilya Kuklin Date: 2023-04-17T16:03:35-07:00 New Revision: 81beb15d7e54b16f4beba0bafd982d56c6b95222 URL: https://github.com/llvm/llvm-project/commit/81beb15d7e54b16f4beba0bafd982d56c6b95222 DIFF: https://github.com/llvm/llvm-project/commit/81beb15d7e54b16f4beba0bafd982d56c6b95222.diff

[Lldb-commits] [PATCH] D148402: [lldb] Remove use of ConstString from Args::GetShellSafeArgument

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc8bb7c234c68: [lldb] Remove use of ConstString from Args::GetShellSafeArgument (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c8bb7c2 - [lldb] Remove use of ConstString from Args::GetShellSafeArgument

2023-04-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-04-17T15:15:36-07:00 New Revision: c8bb7c234c6814b80e2be27eba9718de7ab1ad79 URL: https://github.com/llvm/llvm-project/commit/c8bb7c234c6814b80e2be27eba9718de7ab1ad79 DIFF: https://github.com/llvm/llvm-project/commit/c8bb7c234c6814b80e2be27eba9718de7ab1ad79.diff

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Ilia Kuklin via Phabricator via lldb-commits
kuilpd updated this revision to Diff 514435. kuilpd added a comment. Fixed Triple.h include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/lldb/Utility/DataExtractor.h

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I find "passthrough" somewhat confusing in this context. When using a listener in this new mode, where does the event go after it has pass trough this event listener? Maybe my understanding of how the event listeners is incomplete, but I was under the impression

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG43ac269bdd00: [lldb] Lock accesses to PathMappingListss internals (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148380/new/

[Lldb-commits] [lldb] 43ac269 - [lldb] Lock accesses to PathMappingLists's internals

2023-04-17 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-04-17T14:48:16-07:00 New Revision: 43ac269bdd00d709005f8f3550db6b657b2bf940 URL: https://github.com/llvm/llvm-project/commit/43ac269bdd00d709005f8f3550db6b657b2bf940 DIFF: https://github.com/llvm/llvm-project/commit/43ac269bdd00d709005f8f3550db6b657b2bf940.diff

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBError.h:26 + SBError(const char *message); + mib wrote: > bulbazord wrote: > > JDevlieghere wrote: > > > Why not a StringRef? > > I'm not sure we have

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/bindings/interface/SBTargetExtensions.i:144-171 +class watchpoints_access(object): +'''A helper object that will lazily hand out watchpoints for a target when supplied an

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D148548#4275567 , @bulbazord wrote: > Seems okay to me, but it's a little messy that we're having to manage > breakpoints like this. I don't think there is a better way to do this, as breakpoint are managed per target but we're

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. Seems okay to me, but it's a little messy that we're having to manage breakpoints like this. Comment at: lldb/bindings/interface/SBTargetExtensions.i:144-171 +class watchpoints_access(object): +'''A helper object that will lazily

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. A few high-level comments: - You're doing a lot of type-annotations in python which is good, but you're not being very consistent about it. It would be tremendously helpful if you could add type annotations everywhere. - I would recommend using f-strings over `%` and

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added inline comments. Comment at: lldb/include/lldb/API/SBError.h:26 + SBError(const char *message); + bulbazord wrote: > JDevlieghere wrote: > > Why not a StringRef? > I'm not sure we have `StringRef` type map in swig? We would have to create > one for

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBError.h:26 + SBError(const char *message); + JDevlieghere wrote: > Why not a StringRef? I'm not sure we have `StringRef` type map in swig? We would have to create one for swig to pick up on

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBError.h:26 + SBError(const char *message); + Why not a StringRef? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148401/new/

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:270-271 +Status ScriptedProcess::EnableBreakpointSite(BreakpointSite *bp_site) { + assert(bp_site != nullptr); + bulbazord wrote: > I like the assert, but

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers closed this revision. nickdesaulniers added a comment. Let's use D148546 as the reland (sorry, couldn't get arcanist to work to reuse this instance of code review reopened). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/

[Lldb-commits] [PATCH] D148531: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and pointers

2023-04-17 Thread Michael Buch via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1414a5bdfeff: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1414a5b - [lldb][DataFormatter] Fix libcxx std::deque formatter for references and pointers

2023-04-17 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2023-04-17T21:31:30+01:00 New Revision: 1414a5bdfeff3dbbbaae9816ef4017c81112c3c0 URL: https://github.com/llvm/llvm-project/commit/1414a5bdfeff3dbbbaae9816ef4017c81112c3c0 DIFF: https://github.com/llvm/llvm-project/commit/1414a5bdfeff3dbbbaae9816ef4017c81112c3c0.diff

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers updated this revision to Diff 514386. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/ https://reviews.llvm.org/D148546 Files:

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D148401#4275398 , @bulbazord wrote: > I like this! Reading through the call stack, it looks like we shouldn't hit > any issues if `message` is `nullptr`. Could you add a small test to > `TestSBError.py` constructing an error

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I like this! Reading through the call stack, it looks like we shouldn't hit any issues if `message` is `nullptr`. Could you add a small test to `TestSBError.py` constructing an error

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Seems ok to me, one small thought. Shouldn't hold this patch up though. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:270-271 +Status

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. Idea is good, few concerns about the implementation. Comment at: lldb/source/Target/Process.cpp:404-419 +llvm::StringRef

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. +1 to what Jonas said. `LLDB_LOG` would greatly simplify this since it puts `__FILE__` and `__func__` in each message, which is what these are doing manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/Broadcaster.h:520-522 +/// A optional listener that all private events get also broadcasted to, +/// on top the hijacked / default listeners. +lldb::ListenerSP m_passthrough_listener = nullptr;

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7978abd5aef1: [lldb] fix build issue on MSVC because of missing byte-swap builtins (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7978abd - [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via lldb-commits
Author: Ashay Rane Date: 2023-04-17T14:39:00-05:00 New Revision: 7978abd5aef1ba84d7a1cefbc3443245acff2c48 URL: https://github.com/llvm/llvm-project/commit/7978abd5aef1ba84d7a1cefbc3443245acff2c48 DIFF: https://github.com/llvm/llvm-project/commit/7978abd5aef1ba84d7a1cefbc3443245acff2c48.diff

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/ https://reviews.llvm.org/D148541

[Lldb-commits] [lldb] f40ed1f - [lldb] Fix TestObjectFileJSON and TestSymbolFileJSON

2023-04-17 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-04-17T12:01:24-07:00 New Revision: f40ed1f619046e98d08b092b1afb835ed5156f52 URL: https://github.com/llvm/llvm-project/commit/f40ed1f619046e98d08b092b1afb835ed5156f52 DIFF:

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
ashay-github updated this revision to Diff 514341. ashay-github added a comment. Updated to check for builtins and use them, if available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/ https://reviews.llvm.org/D148541 Files:

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I didn't see this until now. I'll update the test. We shouldn't need strip for this test but we're sharing the Makefile for `SymbolFileJSON`. I'll see if it makes more sense to split up the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Anton Korobeynikov via Phabricator via lldb-commits
asl added a comment. @kuilpd Please ensure that the patch is rebased into top of `main` and builds w/o errors / warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965

[Lldb-commits] [lldb] 8456120 - Revert "[lldb] Add support for MSP430 in LLDB."

2023-04-17 Thread Anton Korobeynikov via lldb-commits
Author: Anton Korobeynikov Date: 2023-04-17T11:30:27-07:00 New Revision: 845612062389e3defbe073119b481a5472e9fc36 URL: https://github.com/llvm/llvm-project/commit/845612062389e3defbe073119b481a5472e9fc36 DIFF:

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. Instead of not using `__builtin_bswap{32,64}` entirely, we should check if they're available. You can use the clang feature-checking macro `__has_builtin` (and if it doesn't

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 514326. mib added a comment. Re-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148548/new/ https://reviews.llvm.org/D148548 Files: lldb/bindings/interface/SBTargetExtensions.i lldb/bindings/python/python-wrapper.swig

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

2023-04-17 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improves breakpoint management when doing interactive scripted

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Anton Korobeynikov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG82c02b733c77: [lldb] Add support for MSP430 in LLDB. (authored by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/

[Lldb-commits] [lldb] 82c02b7 - [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Anton Korobeynikov via lldb-commits
Author: Anton Korobeynikov Date: 2023-04-17T11:05:09-07:00 New Revision: 82c02b733c7736507a41a26bebd37d3f8e88bd4e URL: https://github.com/llvm/llvm-project/commit/82c02b733c7736507a41a26bebd37d3f8e88bd4e DIFF:

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Anton Korobeynikov via Phabricator via lldb-commits
asl added a comment. Thanks @bulbazord @DavidSpickett ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + I'll probably revert https://reviews.llvm.org/D148367 for

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. In D146965#4274274 , @DavidSpickett wrote: > I'm sure there's something missing but LGTM. > > @bulbazord ? I'm satisfied with this since there are tests. I'm not sure what might be missing

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers closed this revision. nickdesaulniers added a comment. Creating https://reviews.llvm.org/D148546 instead; `arcanist` really doesn't like how I've reopened this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, erichkeane. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits,

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers updated this revision to Diff 514306. nickdesaulniers added a comment. This revision is now accepted and ready to land. - reopen with D148392 folded in, and 3 additional fixes for windows as reported by buildbots CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + MaskRay wrote: > chapuni wrote: > > Odd layering... > Good catch. LLVMDemangle cannot depend on other LLVM libraries. If these are inline function

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

2023-04-17 Thread Nick Desaulniers via Phabricator via lldb-commits
nickdesaulniers added a comment. In D148384#4270505 , @dhoekwater wrote: > It looks like this breaks the build: > https://lab.llvm.org/buildbot#builders/119/builds/12865 > https://lab.llvm.org/buildbot#builders/123/builds/18388 >

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

2023-04-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I think a lot of this can be simplified by using `LLDB_LOG` instead of `LLDB_LOGF`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
ashay-github created this revision. ashay-github added reviewers: DavidSpickett, jasonmolenda, bulbazord. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `__builtin_bswap{32,64}()` builtins

[Lldb-commits] [PATCH] D148062: [lldb] Make ObjectFileJSON loadable as a module

2023-04-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added subscribers: omjavaid, DavidSpickett. DavidSpickett added a comment. FYI this test is failing on our Windows on Arm bot due to not finding `strip`: https://lab.llvm.org/buildbot/#/builders/219/builds/2164/steps/6/logs/stdio I see other uses so not sure why this one isn't

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

2023-04-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I'm sure there's something missing but LGTM. @bulbazord ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

2023-04-17 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd87cd45e4d85: PECOFF: consume errors properly (authored by Saleem Abdulrasool abdulras@thebrowser.company). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d87cd45 - PECOFF: consume errors properly

2023-04-17 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2023-04-17T07:53:54-07:00 New Revision: d87cd45e4d855b57aed76dbd72c270ed152542ff URL: https://github.com/llvm/llvm-project/commit/d87cd45e4d855b57aed76dbd72c270ed152542ff DIFF:

[Lldb-commits] [PATCH] D148531: [lldb][DataFormatter] Fix libcxx std::deque formatter for references and pointers

2023-04-17 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. (Addresses GH#62153) The `SBType` APIs to retrieve details about

[Lldb-commits] [PATCH] D148228: [lldb] Change some pointers to refs in register printing code

2023-04-17 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2ad771cf7bae: [lldb] Change some pointers to refs in register printing code (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2ad771c - [lldb] Change some pointers to refs in register printing code

2023-04-17 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-04-17T07:40:13Z New Revision: 2ad771cf7bae513da6e54772e4e50e0e049af9ac URL: https://github.com/llvm/llvm-project/commit/2ad771cf7bae513da6e54772e4e50e0e049af9ac DIFF: https://github.com/llvm/llvm-project/commit/2ad771cf7bae513da6e54772e4e50e0e049af9ac.diff