Author: Jonas Devlieghere
Date: 2023-05-04T22:24:23-07:00
New Revision: 300dce986f656a2d787b8e882381f39746d2fc0a
URL:
https://github.com/llvm/llvm-project/commit/300dce986f656a2d787b8e882381f39746d2fc0a
DIFF:
Author: Jonas Devlieghere
Date: 2023-05-04T22:10:28-07:00
New Revision: ab73a9c1a77cc9502f07ff8a9d1fd9dadccd702f
URL:
https://github.com/llvm/llvm-project/commit/ab73a9c1a77cc9502f07ff8a9d1fd9dadccd702f
DIFF:
Author: Jonas Devlieghere
Date: 2023-05-04T22:00:17-07:00
New Revision: 917b3a7e62063398d2cbc4f8fe56feb68b0fae4f
URL:
https://github.com/llvm/llvm-project/commit/917b3a7e62063398d2cbc4f8fe56feb68b0fae4f
DIFF:
Author: Jonas Devlieghere
Date: 2023-05-04T21:48:14-07:00
New Revision: b193bd3f28acba2686e6f7d376884deb82ae43c6
URL:
https://github.com/llvm/llvm-project/commit/b193bd3f28acba2686e6f7d376884deb82ae43c6
DIFF:
jwnhy updated this revision to Diff 519735.
jwnhy added a comment.
Update the patch for better naming.
The assertion is correct, I somehow delete
a file directive from the assembly generated
by clang.
It should work now...Thanks a lot for checking
this.
CHANGES SINCE LAST ACTION
jwnhy updated this revision to Diff 519733.
jwnhy added a comment.
Update the patch to pass the assertion.
Sorry I forget to enable these on my machine.
Given that said, this assertion seems pretty weird to me.
Since this assembly is also generated by clang (with handcrafted DWARF,
this
Michael137 added a comment.
I tried the new test case on my Mac but it's now hitting an assertion:
TEST 'lldb-shell ::
SymbolFile/DWARF/x86/DW_OP_div-with-signed.s' FAILED
Script:
--
: 'RUN: at line 2';
tstellar added inline comments.
Comment at: cmake/Modules/GetClangResourceDir.cmake:13
+ if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "")
+set(ret_dir bin/${CLANG_RESOURCE_DIR})
+ else()
tstellar wrote:
> paperchalice wrote:
> >
tstellar added inline comments.
Comment at: cmake/Modules/GetClangResourceDir.cmake:13
+ if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "")
+set(ret_dir bin/${CLANG_RESOURCE_DIR})
+ else()
paperchalice wrote:
> tstellar wrote:
> > Why is
paperchalice added inline comments.
Comment at: cmake/Modules/GetClangResourceDir.cmake:13
+ if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "")
+set(ret_dir bin/${CLANG_RESOURCE_DIR})
+ else()
tstellar wrote:
> Why is the bin prefix
Author: Alex Langford
Date: 2023-05-04T16:49:30-07:00
New Revision: 3d6073a9c33005abf8c6fc074e434c90b36dccb9
URL:
https://github.com/llvm/llvm-project/commit/3d6073a9c33005abf8c6fc074e434c90b36dccb9
DIFF:
https://github.com/llvm/llvm-project/commit/3d6073a9c33005abf8c6fc074e434c90b36dccb9.diff
bulbazord added a comment.
Looks like this may have broken the Debian buildbot:
https://lab.llvm.org/buildbot/#/builders/68/builds/52162/steps/6/logs/stdio
I'm taking a look and will try to fix forward. If I can't figure it out
quickly, I will revert.
Repository:
rG LLVM Github Monorepo
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked 2 inline comments as done.
Closed by commit rG6f8b33f6dfd0: [lldb] Use templates to simplify
{Get,Set}PropertyAtIndex (NFC) (authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to
Author: Jonas Devlieghere
Date: 2023-05-04T16:42:46-07:00
New Revision: 6f8b33f6dfd0a0f8d2522b6c832bd6298ae2f3f3
URL:
https://github.com/llvm/llvm-project/commit/6f8b33f6dfd0a0f8d2522b6c832bd6298ae2f3f3
DIFF:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04aa943be8ed: [lldb] Expose a const iterator for
SymbolContextList (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Alex Langford
Date: 2023-05-04T16:36:44-07:00
New Revision: 04aa943be8ed5c03092e2a90112ac638360ec253
URL:
https://github.com/llvm/llvm-project/commit/04aa943be8ed5c03092e2a90112ac638360ec253
DIFF:
https://github.com/llvm/llvm-project/commit/04aa943be8ed5c03092e2a90112ac638360ec253.diff
bulbazord updated this revision to Diff 519690.
bulbazord added a comment.
Explicitly write out type
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
Files:
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Interpreter/OptionValue.h:325-344
+ template ::value, bool> = true>
+ std::optional GetValueAs() const {
+if constexpr (std::is_same_v)
+ return
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, kastiglione.
Herald added a subscriber: arphaman.
Herald added a reviewer: shafik.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a
mib added a comment.
Very cool stuff!
Comment at: lldb/include/lldb/Interpreter/OptionValue.h:325-344
+ template ::value, bool> = true>
+ std::optional GetValueAs() const {
+if constexpr (std::is_same_v)
+ return GetUInt64Value();
+if constexpr (std::is_same_v)
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
___
lldb-commits mailing list
mib added a comment.
LGTM but I'd prefer if we kept the type in the for loop
for (const SymbolContext _ctx : sc_list)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Please do more of this!
I haven't checked all the replacements for correctness but the direction is
good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc39d98c3faa: [lldb][NFCI] Add unittests for
ObjCLanguage::MethodName (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149804/new/
Author: Alex Langford
Date: 2023-05-04T13:50:57-07:00
New Revision: dc39d98c3faa81ea48b89489b17ba80dae38c9b9
URL:
https://github.com/llvm/llvm-project/commit/dc39d98c3faa81ea48b89489b17ba80dae38c9b9
DIFF:
https://github.com/llvm/llvm-project/commit/dc39d98c3faa81ea48b89489b17ba80dae38c9b9.diff
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: lldb-commits, jplehr, sstefan1.
Herald added a project: LLDB.
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2e16e41b28b1: Add AArch64 MASK watchpoint support in
debugserver (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Jason Molenda
Date: 2023-05-04T13:23:51-07:00
New Revision: 2e16e41b28b1b1e027d0303e1a37ccbded96a46f
URL:
https://github.com/llvm/llvm-project/commit/2e16e41b28b1b1e027d0303e1a37ccbded96a46f
DIFF:
https://github.com/llvm/llvm-project/commit/2e16e41b28b1b1e027d0303e1a37ccbded96a46f.diff
jasonmolenda updated this revision to Diff 519629.
jasonmolenda added a comment.
Update patch with Dan and Jonas' feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149792/new/
https://reviews.llvm.org/D149792
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4fac08ff1dcd: Recognize `addressing_bits` kv in stop reply
packet (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149803/new/
Author: Jason Molenda
Date: 2023-05-04T13:14:10-07:00
New Revision: 4fac08ff1dcd02c89c677365b10921399caf79df
URL:
https://github.com/llvm/llvm-project/commit/4fac08ff1dcd02c89c677365b10921399caf79df
DIFF:
https://github.com/llvm/llvm-project/commit/4fac08ff1dcd02c89c677365b10921399caf79df.diff
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149804/new/
https://reviews.llvm.org/D149804
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Some small nits but LGTM
Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:1079
+ // masked off) -- a MASK value of 31.
+ uint64_t
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbfb7c99f3aea: [LLDB] Add a hook to notify REPLs that an
expression was evaluated (authored by wallace).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdb5f745a2bfc: [lldb] Make some functions useful to REPLs
public (authored by wallace).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
Author: walter erquinigo
Date: 2023-05-04T14:44:03-05:00
New Revision: bfb7c99f3aeab09236adf1f684f7144f384c6dd7
URL:
https://github.com/llvm/llvm-project/commit/bfb7c99f3aeab09236adf1f684f7144f384c6dd7
DIFF:
Author: walter erquinigo
Date: 2023-05-04T14:44:03-05:00
New Revision: db5f745a2bfcd1b93fc298da6cfcf5ed2f00e98f
URL:
https://github.com/llvm/llvm-project/commit/db5f745a2bfcd1b93fc298da6cfcf5ed2f00e98f
DIFF:
tstellar added inline comments.
Herald added subscribers: ekilmer, jplehr.
Comment at: cmake/Modules/GetClangResourceDir.cmake:13
+ if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "")
+set(ret_dir bin/${CLANG_RESOURCE_DIR})
+ else()
Why
wallace added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:124
+const lldb::ValueObjectSP _valobj_sp,
+const Status ) {
+return llvm::Error::success();
bulbazord wrote:
> Do you still need
JDevlieghere updated this revision to Diff 519580.
JDevlieghere added a comment.
Remove duplicate if-clause
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149774/new/
https://reviews.llvm.org/D149774
Files:
lldb/include/lldb/Core/Debugger.h
Author: Dave Lee
Date: 2023-05-04T11:01:37-07:00
New Revision: eee32d66febfbfa6fea44adc8a4416c5896b8c97
URL:
https://github.com/llvm/llvm-project/commit/eee32d66febfbfa6fea44adc8a4416c5896b8c97
DIFF:
https://github.com/llvm/llvm-project/commit/eee32d66febfbfa6fea44adc8a4416c5896b8c97.diff
JDevlieghere updated this revision to Diff 519570.
JDevlieghere added a comment.
Use C++17 to simplify things
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149774/new/
https://reviews.llvm.org/D149774
Files:
lldb/include/lldb/Core/Debugger.h
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
https://reviews.llvm.org/D149717
bulbazord added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:124
+const lldb::ValueObjectSP _valobj_sp,
+const Status ) {
+return llvm::Error::success();
Do you still need the `Status`
wallace updated this revision to Diff 519542.
wallace added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149717/new/
https://reviews.llvm.org/D149717
Files:
lldb/include/lldb/Core/Debugger.h
Index:
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:505
+ /// that directly use the \a lldb_private namespace and want to use the
+ /// default LLDB event handler thread instead of defining their own.
+ bool StartEventHandlerThread();
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeadf6db585e1: [docs] Hide collaboration and include graphs
in doxygen docs (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES
kwk accepted this revision.
kwk added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149641/new/
https://reviews.llvm.org/D149641
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.
LGTM, only the inheritance graph is useful, which this preserves if I
understand correctly (CLASS_GRAPH is still YES).
Repository:
rG LLVM Github
49 matches
Mail list logo
