[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord added a comment. This is going to need some tests... And because you're adding templates to the SBAPI we'll need multiple tests -- Not just on the python side but I think we should add some actual C++ tests here in `test/API/api/` Comment at:

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

mib created this revision. mib added reviewers: labath, bulbazord, JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch refactors the `StructuredData::Integer` class to make it

[Lldb-commits] [lldb] 050c09f - [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

Author: Alex Langford Date: 2023-05-12T13:11:56-07:00 New Revision: 050c09f0bed67f3135cb2ad99d4d35e241e5d61b URL: https://github.com/llvm/llvm-project/commit/050c09f0bed67f3135cb2ad99d4d35e241e5d61b DIFF: https://github.com/llvm/llvm-project/commit/050c09f0bed67f3135cb2ad99d4d35e241e5d61b.diff

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG050c09f0bed6: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl (authored by bulbazord). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord updated this revision to Diff 521771. bulbazord added a comment. - Use emplace_back - llvm::SmallVector size 8 -> 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150418/new/ https://reviews.llvm.org/D150418 Files:

[Lldb-commits] [lldb] be71d4c - [lldb][NFCI] Delete commented out method OptionValueProperties::GetQualifiedName

Author: Alex Langford Date: 2023-05-12T12:33:25-07:00 New Revision: be71d4cc5010cf6e52aafc430691afd12a1c07c6 URL: https://github.com/llvm/llvm-project/commit/be71d4cc5010cf6e52aafc430691afd12a1c07c6 DIFF: https://github.com/llvm/llvm-project/commit/be71d4cc5010cf6e52aafc430691afd12a1c07c6.diff

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGc909b491cb5f: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D150402?vs=521453=521757#toc Repository:

[Lldb-commits] [lldb] c909b49 - [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

Author: Alex Langford Date: 2023-05-12T12:17:21-07:00 New Revision: c909b491cb5f392147de4490749abc1e5372a571 URL: https://github.com/llvm/llvm-project/commit/c909b491cb5f392147de4490749abc1e5372a571 DIFF: https://github.com/llvm/llvm-project/commit/c909b491cb5f392147de4490749abc1e5372a571.diff

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

luporl added a comment. LGTM. With this patch, if I re-enable the restart tests on ARM I get a failure after a few seconds, instead of timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f1fda29e2d: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 64f1fda - [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

Author: Alex Langford Date: 2023-05-12T11:58:50-07:00 New Revision: 64f1fda29e2dd133c84f23474e29de02d7ed392d URL: https://github.com/llvm/llvm-project/commit/64f1fda29e2dd133c84f23474e29de02d7ed392d DIFF: https://github.com/llvm/llvm-project/commit/64f1fda29e2dd133c84f23474e29de02d7ed392d.diff

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

bulbazord added a comment. In D150402#4337400 , @fdeazeve wrote: > Thanks for doing this! In particular, all the early returns are very welcome > :) > > I suspect you already have this in your radar, but `ExtractFormValueAtIndex` > could probably

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

bulbazord added a comment. In D150418#4337243 , @JDevlieghere wrote: > Given the numbers I'm surprised you decided to stick with 8 rather than 4? > Unless I'm reading them wrong, it seems that despite the number of > allocations, it's about as fast

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

jgorbe added a comment. See also https://github.com/llvm/llvm-project/issues/62684 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

jgorbe created this revision. jgorbe added reviewers: ted, luporl, wallace. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. After https://reviews.llvm.org/D147831, lldb-vscode doesn't send a process

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4338118 , @tahonermann wrote: >> I do wonder if we need two bfloat implementations, but for that I'll leave a >> comment on D149573 . > > Given the discussions occurring in D149573

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rG25159ee3af5c: Fix libstdc++ data formatter for reference/pointer to std::string (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 25159ee - Fix libstdc++ data formatter for reference/pointer to std::string

Author: Jeffrey Tan Date: 2023-05-12T10:09:58-07:00 New Revision: 25159ee3af5cd1c05c010ea195b4b359df3fe820 URL: https://github.com/llvm/llvm-project/commit/25159ee3af5cd1c05c010ea195b4b359df3fe820 DIFF: https://github.com/llvm/llvm-project/commit/25159ee3af5cd1c05c010ea195b4b359df3fe820.diff

[Lldb-commits] [lldb] b58dd92 - [lldb-vscode] Skip restart tests on ARM

Author: Leandro Lupori Date: 2023-05-12T13:52:17-03:00 New Revision: b58dd9230e655feb0d904b8095f113a4f0246cbf URL: https://github.com/llvm/llvm-project/commit/b58dd9230e655feb0d904b8095f113a4f0246cbf DIFF:

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. > I do wonder if we need two bfloat implementations, but for that I'll leave a > comment on D149573 . Given the discussions occurring in

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

fdeazeve added a comment. In D150366#4336168 , @bulbazord wrote: > Ok, this looks like it's doing the same thing to me which is good. My > understanding of this change is that you're changing > `lldb::DWARFDebugRanges::Extract` to use

[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

This revision was automatically updated to reflect the committed changes. Closed by commit rG81be68062f49: [lldb][nfc] Simplify DebugRanges class (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150363/new/

[Lldb-commits] [lldb] 81be680 - [lldb][nfc] Simplify DebugRanges class

Author: Felipe de Azevedo Piovezan Date: 2023-05-12T08:48:31-04:00 New Revision: 81be68062f49dccfb0c28b98f04d88b5343c4ae6 URL: https://github.com/llvm/llvm-project/commit/81be68062f49dccfb0c28b98f04d88b5343c4ae6 DIFF:

[Lldb-commits] [PATCH] D150299: [lldb][NFCI] Redefine dw_attr_t typedef with llvm::dwarf::Attribute

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150299/new/ https://reviews.llvm.org/D150299

[Lldb-commits] [lldb] 5130e04 - [lldb] Don't write to source directory in test

Author: Benjamin Kramer Date: 2023-05-12T12:26:29+02:00 New Revision: 5130e049ff43eee4fcabdfda3c626f1bc051ba31 URL: https://github.com/llvm/llvm-project/commit/5130e049ff43eee4fcabdfda3c626f1bc051ba31 DIFF:

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm surprised this didn't work but was able to reproduce the failure on Linux with libstdcpp. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150418: [lldb][NFCI] Replace use of DWARFAttribute in DWARFAbbreviationDecl

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given the numbers I'm surprised you decided to stick with 8 rather than 4? Unless I'm reading them wrong, it seems that despite the number of allocations, it's about as fast and

[Lldb-commits] [PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

stuij accepted this revision. stuij added a comment. Regarding this particular change, we at Arm are happy with the name change. I saw BFloat16 instead of BF16 as tech debt that we didn't get round to fixing. I do wonder if we need two bfloat implementations, but for that I'll leave a comment

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. Herald added a subscriber: luke. Hi! I wondering if someone knows what is the status of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612