[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. thank you @jingham, that is great feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522875. kastiglione added a comment. - Explicitly control expression evaluation options for suppressing persistent result - Use the ValueObject's display language instead of the CU or frame's language Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3227e74e3bf: lldb PlatformDarwinKernel make local filesystem scan lazy (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e3227e7 - lldb PlatformDarwinKernel make local filesystem scan lazy

Author: Jason Molenda Date: 2023-05-16T18:15:59-07:00 New Revision: e3227e74e3bfab7c5aed07c20b515202275ce7c4 URL: https://github.com/llvm/llvm-project/commit/e3227e74e3bfab7c5aed07c20b515202275ce7c4 DIFF: https://github.com/llvm/llvm-project/commit/e3227e74e3bfab7c5aed07c20b515202275ce7c4.diff

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

jingham added a comment. This seems fine in general, with one quibble: IIUC, the "indirect" removal of persistent results which you are trying to avoid happens here: lldb::ExpressionResults UserExpression::Execute(DiagnosticManager _manager, ExecutionContext _ctx,

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. So the problem is that `CMakePolicy.cmake` is not included in `compiler-rt/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda updated this revision to Diff 522813. jasonmolenda added a comment. Update patch to use a std::once operation instead of hand-rolling it, as suggested by Jonas and Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. It's related, though, because now that I look at my build logs, the difference between when it works and when it doesn't is `/MT` vs `-MD` when compiler-rt is compiled. The main peculiarity on our end, though, is that the Windows compiler-rt is cross-compiled.

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4347604 , @mstorsjo wrote: > See D150688 - I believe that might fix the > issue you're seeing, as that one mentions compiler-rt. Unfortunately, it doesn't. FWIW, the errors looks

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, fdeazeve, rastogishubham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Both LLVM and LLDB implement

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. Herald added subscribers: bviyer, ekilmer, jplehr. FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake

[Lldb-commits] [lldb] ec388ad - [lldb][docs] Update SB API design document

Author: Alex Langford Date: 2023-05-16T12:58:54-07:00 New Revision: ec388adbbcbf2cf7f2743464ef5b3c5c540a2d23 URL: https://github.com/llvm/llvm-project/commit/ec388adbbcbf2cf7f2743464ef5b3c5c540a2d23 DIFF: https://github.com/llvm/llvm-project/commit/ec388adbbcbf2cf7f2743464ef5b3c5c540a2d23.diff

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

This revision was automatically updated to reflect the committed changes. Closed by commit rGec388adbbcbf: [lldb][docs] Update SB API design document (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150630/new/

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150630/new/ https://reviews.llvm.org/D150630

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

bulbazord created this revision. bulbazord added a reviewer: kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't think this needs to be a ConstString. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D148761: Emit the correct flags for the PROC CodeView Debug Symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8499d5709e3: Emit the correct flags for the PROC CodeView Debug Symbol (authored by dpaoliello, committed by efriedma). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed

[Lldb-commits] [lldb] f8499d5 - Emit the correct flags for the PROC CodeView Debug Symbol

Author: Daniel Paoliello Date: 2023-05-16T10:58:10-07:00 New Revision: f8499d5709e37b4e9a6d2a39c385cfd2c00bad6e URL: https://github.com/llvm/llvm-project/commit/f8499d5709e37b4e9a6d2a39c385cfd2c00bad6e DIFF:

[Lldb-commits] [lldb] d95aec2 - [lldb][NFCI] Small adjustment to Breakpoint::AddName

Author: Alex Langford Date: 2023-05-16T10:39:44-07:00 New Revision: d95aec2de2be114b4c331783fcceae233bf49aff URL: https://github.com/llvm/llvm-project/commit/d95aec2de2be114b4c331783fcceae233bf49aff DIFF: https://github.com/llvm/llvm-project/commit/d95aec2de2be114b4c331783fcceae233bf49aff.diff

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

kparzysz added a comment. It works now. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/ https://reviews.llvm.org/D150624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 CaprYang wrote: > arsenm wrote: > > Generate full

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

rupprecht added a comment. In D150639#4346649 , @JDevlieghere wrote: > In D150639#4346009 , @rupprecht > wrote: > >> +1 to being surprised this is not already the case >> >> Some other places should be updated

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

This revision was automatically updated to reflect the committed changes. Closed by commit rG10a50762caa6: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 10a5076 - [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

Author: Jonas Devlieghere Date: 2023-05-16T09:27:09-07:00 New Revision: 10a50762caa6ac17dd063b28863a2ec60576c6f7 URL: https://github.com/llvm/llvm-project/commit/10a50762caa6ac17dd063b28863a2ec60576c6f7 DIFF:

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

JDevlieghere added a comment. In D150639#4346009 , @rupprecht wrote: > +1 to being surprised this is not already the case > > Some other places should be updated after this, e.g. > lldb/source/Symbol/SymbolFile.cpp also has a use that can be trivially

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. +1 to being surprised this is not already the case Some other places should be updated after this, e.g. lldb/source/Symbol/SymbolFile.cpp also has a use that can be trivially updated:

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 522582. sgraenitz added a comment. Rebase and re-run pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058 Files:

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c30f224005e: [lldb][DWARFASTParserClang] Dont create unnamed bitfields to account for… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150589: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition

This revision was automatically updated to reflect the committed changes. Closed by commit rGca64f9af0447: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

This revision was automatically updated to reflect the committed changes. Closed by commit rG56eff197d0d6: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3c30f22 - [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

Author: Michael Buch Date: 2023-05-16T11:18:09+01:00 New Revision: 3c30f224005e3749c89e00592bd2a43aba2aaf75 URL: https://github.com/llvm/llvm-project/commit/3c30f224005e3749c89e00592bd2a43aba2aaf75 DIFF: https://github.com/llvm/llvm-project/commit/3c30f224005e3749c89e00592bd2a43aba2aaf75.diff

[Lldb-commits] [lldb] ca64f9a - [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition

Author: Michael Buch Date: 2023-05-16T11:18:09+01:00 New Revision: ca64f9af04472a27656d84c06f4e332ebbf14b4d URL: https://github.com/llvm/llvm-project/commit/ca64f9af04472a27656d84c06f4e332ebbf14b4d DIFF: https://github.com/llvm/llvm-project/commit/ca64f9af04472a27656d84c06f4e332ebbf14b4d.diff

[Lldb-commits] [lldb] 56eff19 - [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

Author: Michael Buch Date: 2023-05-16T11:18:09+01:00 New Revision: 56eff197d0d629c768e8e48fb995e8a1d2cd6441 URL: https://github.com/llvm/llvm-project/commit/56eff197d0d629c768e8e48fb995e8a1d2cd6441 DIFF: https://github.com/llvm/llvm-project/commit/56eff197d0d629c768e8e48fb995e8a1d2cd6441.diff

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); CaprYang wrote: > arsenm

[Lldb-commits] [lldb] 617c31c - [LLDB] Fix typo in TestDataFormatterSynthVal.py

Author: Muhammad Omair Javaid Date: 2023-05-16T10:13:06+04:00 New Revision: 617c31c6a1ddd57c6b750b3882c177175067a735 URL: https://github.com/llvm/llvm-project/commit/617c31c6a1ddd57c6b750b3882c177175067a735 DIFF: