[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

2023-05-23 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda created this revision. jasonmolenda added reviewers: DavidSpickett, JDevlieghere, jingham, omjavaid. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber:

[Lldb-commits] [lldb] 23e26cb - [lldb] Fix typos in documentation

2023-05-23 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2023-05-23T22:10:59-07:00 New Revision: 23e26cb98d5f817b951d6e7e2346246fc937ffb6 URL: https://github.com/llvm/llvm-project/commit/23e26cb98d5f817b951d6e7e2346246fc937ffb6 DIFF: https://github.com/llvm/llvm-project/commit/23e26cb98d5f817b951d6e7e2346246fc937ffb6.diff

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

2023-05-23 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Thanks for the review comments, really helpful. I've also added a new block to `DynamicLoader::LoadBinaryWithUUIDAndAddress` to make the binary search system: (1) `Target::GetOrCreateModule` (lldb already has it), (2) `Symbols::LocateExecutableObjectFile` /

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to lldb tests

2023-05-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. The change itself looks fine, but isn't this an issue for the API tests too? If so, how is the sys root passed to `dotest.py` and can the shell tests do the same? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151269: Pass CMAKE_SYSROOT through to lldb tests.

2023-05-23 Thread Daniel Thornburgh via Phabricator via lldb-commits
mysterymath created this revision. Herald added a project: All. mysterymath updated this revision to Diff 524935. mysterymath added a comment. mysterymath updated this revision to Diff 524937. mysterymath added a project: LLDB. Herald added a subscriber: JDevlieghere. mysterymath added a reviewer:

[Lldb-commits] [PATCH] D151268: [lldb][DataFormatter] Add dereference support to libstdcpp std::shared_ptr formatter

2023-05-23 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This mimicks the implementation of the libstdcpp std::unique_ptr formatter. This has been attempted several years

[Lldb-commits] [lldb] 429e748 - Revert "[lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module"

2023-05-23 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-05-23T16:03:34-07:00 New Revision: 429e74839506ea8ba962d24647264ed81f680bbf URL: https://github.com/llvm/llvm-project/commit/429e74839506ea8ba962d24647264ed81f680bbf DIFF:

[Lldb-commits] [PATCH] D151236: [lldb][NFCI] Remove unused member from ObjectFileMachO

2023-05-23 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG973f1fe7a859: [lldb][NFCI] Remove unused member from ObjectFileMachO (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151236/new/

[Lldb-commits] [lldb] 973f1fe - [lldb][NFCI] Remove unused member from ObjectFileMachO

2023-05-23 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-05-23T15:14:47-07:00 New Revision: 973f1fe7a8591c7af148e573491ab68cc15b6ecf URL: https://github.com/llvm/llvm-project/commit/973f1fe7a8591c7af148e573491ab68cc15b6ecf DIFF: https://github.com/llvm/llvm-project/commit/973f1fe7a8591c7af148e573491ab68cc15b6ecf.diff

[Lldb-commits] [PATCH] D151236: [lldb][NFCI] Remove unused member from ObjectFileMachO

2023-05-23 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151236/new/ https://reviews.llvm.org/D151236

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

2023-05-23 Thread walter erquinigo via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf237513cda8e: [LLDB] Add some declarations related to REPL support for mojo (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/

[Lldb-commits] [lldb] f237513 - [LLDB] Add some declarations related to REPL support for mojo

2023-05-23 Thread walter erquinigo via lldb-commits
Author: walter erquinigo Date: 2023-05-23T13:39:43-05:00 New Revision: f237513cda8e6ec32579ff047b008e22422db2ff URL: https://github.com/llvm/llvm-project/commit/f237513cda8e6ec32579ff047b008e22422db2ff DIFF:

[Lldb-commits] [PATCH] D151236: [lldb][NFCI] Remove unused member from ObjectFileMachO

2023-05-23 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. >From what I can see, `m_mach_segments` is completely unused.

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

2023-05-23 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3c276eaf8f4a: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3c276ea - [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

2023-05-23 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-05-23T10:26:08-07:00 New Revision: 3c276eaf8f4a4adab3c0b25c78b5c1fdbf071a94 URL: https://github.com/llvm/llvm-project/commit/3c276eaf8f4a4adab3c0b25c78b5c1fdbf071a94 DIFF: https://github.com/llvm/llvm-project/commit/3c276eaf8f4a4adab3c0b25c78b5c1fdbf071a94.diff

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

2023-05-23 Thread Felipe de Azevedo Piovezan via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG70aad4ec90f2: [lldb][NFCI] Use llvms libDebugInfo for DebugRanges (authored by fdeazeve). Changed prior to commit: https://reviews.llvm.org/D150366?vs=521300=524731#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] 70aad4e - [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

2023-05-23 Thread Felipe de Azevedo Piovezan via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2023-05-23T11:11:10-04:00 New Revision: 70aad4ec90f2df69b91a356b91c3dd16e15be3d1 URL: https://github.com/llvm/llvm-project/commit/70aad4ec90f2df69b91a356b91c3dd16e15be3d1 DIFF: