[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. Herald added subscribers: Michael137, JDevlieghere. @kastiglione I wonder if we should hint in all 3 command objects (expr, frame var and DWIM) or if we should limit this to DWIM instead (since DWIM is the one aliased to p and po and I don't think `vo` or `expr -O`

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, jingham. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Lots of users use "po" as their default print command. If the

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti added a comment. In D153447#4439359 , @wallace wrote: > Please write an entry about this in the documentation of lldb-vscode Updated with some additional documentation in the lldb-vscode/README.md Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti updated this revision to Diff 533440. ashgti marked 3 inline comments as done. ashgti added a comment. Adding documentation to the lldb-vscode/README.md. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The use of ConstString in StructuredDataPlugin is

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please write an entry about this in the documentation of lldb-vscode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153447/new/

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. pretty nice! Just a few nits, but other than that it's good to go Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1475 + auto cmd =

[Lldb-commits] [lldb] 3858e9d - Add two new entitlements when debugserver is built by Apple

Author: Jason Molenda Date: 2023-06-21T14:56:11-07:00 New Revision: 3858e9d6c5136e5a491795c1dcb720361c525526 URL: https://github.com/llvm/llvm-project/commit/3858e9d6c5136e5a491795c1dcb720361c525526 DIFF: https://github.com/llvm/llvm-project/commit/3858e9d6c5136e5a491795c1dcb720361c525526.diff

[Lldb-commits] [PATCH] D153447: Creating a startDebugging reverse DAP request handler in lldb-vscode.

ashgti created this revision. Herald added a project: All. ashgti updated this revision to Diff 533349. ashgti added a comment. ashgti published this revision for review. ashgti added reviewers: wallace, ivanhernandez13. ashgti added a project: LLDB. Herald added subscribers: lldb-commits,

[Lldb-commits] [lldb] d10a61c - [lldb/test] Disable TestStackCoreScriptedProcess.py

Author: Med Ismail Bennani Date: 2023-06-21T14:05:55-07:00 New Revision: d10a61c8d2666a00ad483c71e72b49412a57c2bd URL: https://github.com/llvm/llvm-project/commit/d10a61c8d2666a00ad483c71e72b49412a57c2bd DIFF:

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c5b6320716b: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64 (authored by mib). Changed prior to commit: https://reviews.llvm.org/D152848?vs=531017=57#toc Repository: rG LLVM

[Lldb-commits] [lldb] 0c5b632 - [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

Author: Med Ismail Bennani Date: 2023-06-21T10:57:13-07:00 New Revision: 0c5b6320716b4761f2c4307bc95197be5717d132 URL: https://github.com/llvm/llvm-project/commit/0c5b6320716b4761f2c4307bc95197be5717d132 DIFF:

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG1704c8d1047d: [lldb][MachO] Fix section type recognition for new DWARF 5 sections (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1704c8d - [lldb][MachO] Fix section type recognition for new DWARF 5 sections

Author: Felipe de Azevedo Piovezan Date: 2023-06-21T13:25:10-04:00 New Revision: 1704c8d1047d75e0f17736de146281d68fe7b203 URL: https://github.com/llvm/llvm-project/commit/1704c8d1047d75e0f17736de146281d68fe7b203 DIFF:

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4827a3c0a7e: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b4827a3 - [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

Author: Alex Langford Date: 2023-06-21T10:17:24-07:00 New Revision: b4827a3c0a7ef121ca376713e115b04eff0f5194 URL: https://github.com/llvm/llvm-project/commit/b4827a3c0a7ef121ca376713e115b04eff0f5194 DIFF: https://github.com/llvm/llvm-project/commit/b4827a3c0a7ef121ca376713e115b04eff0f5194.diff

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve updated this revision to Diff 533320. fdeazeve added a comment. Add missing dwo sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433 Files:

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve updated this revision to Diff 533281. fdeazeve added a comment. Add missing debug_cu_index and debug_tu_index sections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433 Files:

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB needs to access a debug section, it generally calls

[Lldb-commits] [PATCH] D152918: [lldb] Add register field tables to the "register info" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcfe5a52a39d: [lldb] Add register field tables to the register info command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] bcfe5a5 - [lldb] Add register field tables to the "register info" command

Author: David Spickett Date: 2023-06-21T10:50:31Z New Revision: bcfe5a52a39dee6d50d5e2410863fc555d2f50a8 URL: https://github.com/llvm/llvm-project/commit/bcfe5a52a39dee6d50d5e2410863fc555d2f50a8 DIFF: https://github.com/llvm/llvm-project/commit/bcfe5a52a39dee6d50d5e2410863fc555d2f50a8.diff

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Sorry I missed the comments before landing, I've addressed those in https://github.com/llvm/llvm-project/commit/c7759df03825f63f8334d88c9525d655acfab685. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] c7759df - [lldb] Correct spelling in RegisterFlags comments

Author: David Spickett Date: 2023-06-21T09:34:22Z New Revision: c7759df03825f63f8334d88c9525d655acfab685 URL: https://github.com/llvm/llvm-project/commit/c7759df03825f63f8334d88c9525d655acfab685 DIFF: https://github.com/llvm/llvm-project/commit/c7759df03825f63f8334d88c9525d655acfab685.diff

[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b73a2e82191: [LLDB] Add table formatting for register fields (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152917/new/

[Lldb-commits] [lldb] 8b73a2e - [LLDB] Add table formatting for register fields

Author: David Spickett Date: 2023-06-21T09:28:48Z New Revision: 8b73a2e8219127b707280b689edb20753849bd4c URL: https://github.com/llvm/llvm-project/commit/8b73a2e8219127b707280b689edb20753849bd4c DIFF: https://github.com/llvm/llvm-project/commit/8b73a2e8219127b707280b689edb20753849bd4c.diff

[Lldb-commits] [PATCH] D152916: [lldb] Add "register info" command

This revision was automatically updated to reflect the committed changes. Closed by commit rGba85f206fe6f: [lldb] Add register info command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152916/new/

[Lldb-commits] [lldb] ba85f20 - [lldb] Add "register info" command

Author: David Spickett Date: 2023-06-21T08:48:18Z New Revision: ba85f206fe6f2fec9dd5fee55bf2a1e966fc37aa URL: https://github.com/llvm/llvm-project/commit/ba85f206fe6f2fec9dd5fee55bf2a1e966fc37aa DIFF: https://github.com/llvm/llvm-project/commit/ba85f206fe6f2fec9dd5fee55bf2a1e966fc37aa.diff