[Lldb-commits] [lldb] 7319d7d - [lldb] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after D154542

Author: Fangrui Song Date: 2023-07-06T20:33:09-07:00 New Revision: 7319d7dbcfa94998ae3befeff0b84140dcf29a69 URL: https://github.com/llvm/llvm-project/commit/7319d7dbcfa94998ae3befeff0b84140dcf29a69 DIFF: https://github.com/llvm/llvm-project/commit/7319d7dbcfa94998ae3befeff0b84140dcf29a69.diff

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

MaskRay added a comment. Hi! The added lines have some spaces at line ends. I think using `clang-format-diff.py` would remove them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542

[Lldb-commits] [lldb] 61d8da3 - [lldb] Replace countPopulation with popcount after D153686

Author: Fangrui Song Date: 2023-07-06T20:26:23-07:00 New Revision: 61d8da327cab76932e8236bbf03543c9b3f7864c URL: https://github.com/llvm/llvm-project/commit/61d8da327cab76932e8236bbf03543c9b3f7864c DIFF: https://github.com/llvm/llvm-project/commit/61d8da327cab76932e8236bbf03543c9b3f7864c.diff

[Lldb-commits] [lldb] 9895c89 - Revert "Change the dyld notification function that lldb puts a breakpoint in"

Author: Jason Molenda Date: 2023-07-06T18:23:54-07:00 New Revision: 9895c8979a4f025a112d0830a8f59f1820c8c49e URL: https://github.com/llvm/llvm-project/commit/9895c8979a4f025a112d0830a8f59f1820c8c49e DIFF: https://github.com/llvm/llvm-project/commit/9895c8979a4f025a112d0830a8f59f1820c8c49e.diff

[Lldb-commits] [lldb] c319219 - Change the dyld notification function that lldb puts a breakpoint in

Author: Jason Molenda Date: 2023-07-06T18:00:09-07:00 New Revision: c3192196aea279eea0a87247a02f224ebe067c44 URL: https://github.com/llvm/llvm-project/commit/c3192196aea279eea0a87247a02f224ebe067c44 DIFF: https://github.com/llvm/llvm-project/commit/c3192196aea279eea0a87247a02f224ebe067c44.diff

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 537942. jasonmolenda added a comment. Herald added a subscriber: wangpc. After reverting to avoid CI bot failures on macos intel, this is an updated patch that (1) corrects the binary image count size, (2) allows for a fallback if it can't find the

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: kastiglione wrote: > did you mean to use this, or should it be deleted?

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

mib added a comment. LGTM! Thanks Jim! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b0c88654212: Refine the reporting mechanism for interruption. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/

[Lldb-commits] [lldb] 2b0c886 - Refine the reporting mechanism for interruption.

Author: Jim Ingham Date: 2023-07-06T16:19:19-07:00 New Revision: 2b0c8865421287a30ddda0f459f17f76bfeb1358 URL: https://github.com/llvm/llvm-project/commit/2b0c8865421287a30ddda0f459f17f76bfeb1358 DIFF: https://github.com/llvm/llvm-project/commit/2b0c8865421287a30ddda0f459f17f76bfeb1358.diff

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham updated this revision to Diff 537908. jingham added a comment. Add some std;:move's, Jonas agrees all the cool kids are doing that these days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/include/lldb/Target/Target.h:496 + std::once_flag target_once_flag; // These two functions fill out the Broadcaster interface: did you mean to use this, or should it be deleted? Comment

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:455-456 +InterruptionReport(std::string function_name, std::string description) : +m_function_name(function_name), +m_description(description), +

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

jingham added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:455-456 +InterruptionReport(std::string function_name, std::string description) : +m_function_name(function_name), +m_description(description), +

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5f4169c427: [lldb] Fix dead lock issue when loading modules in Scripted Process (authored by mib). Changed prior to commit: https://reviews.llvm.org/D154649?vs=537846=537887#toc Repository: rG

[Lldb-commits] [lldb] 1f5f416 - [lldb] Fix dead lock issue when loading modules in Scripted Process

Author: Med Ismail Bennani Date: 2023-07-06T14:33:52-07:00 New Revision: 1f5f4169c427c51c6919e0013c89a191dba564e8 URL: https://github.com/llvm/llvm-project/commit/1f5f4169c427c51c6919e0013c89a191dba564e8 DIFF:

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

This revision was automatically updated to reflect the committed changes. Closed by commit rG032de3ee0d35: [lldb][DebugNamesDWARF] Also use mangled name when matching regex (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 032de3e - [lldb][DebugNamesDWARF] Also use mangled name when matching regex

Author: Felipe de Azevedo Piovezan Date: 2023-07-06T17:15:06-04:00 New Revision: 032de3ee0d3575557f25fb2d78b9423f3f50 URL: https://github.com/llvm/llvm-project/commit/032de3ee0d3575557f25fb2d78b9423f3f50 DIFF:

[Lldb-commits] [PATCH] D154610: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3bb6a59027: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2c3bb6a - [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

Author: Felipe de Azevedo Piovezan Date: 2023-07-06T17:14:14-04:00 New Revision: 2c3bb6a5902791dd7a32bf1639255ea0c0366d43 URL: https://github.com/llvm/llvm-project/commit/2c3bb6a5902791dd7a32bf1639255ea0c0366d43 DIFF:

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. > Cool, might be worth mentioning that in the commit message. LGMT. Agreed! I'll update it prior to merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/new/ https://reviews.llvm.org/D154617

[Lldb-commits] [PATCH] D154029: [lldb-vscode] Adding support for column break points.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda59370b0977: [lldb-vscode] Adding support for column break points. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] da59370 - [lldb-vscode] Adding support for column break points.

Author: John Harrison Date: 2023-07-06T16:33:22-04:00 New Revision: da59370b0977083fa081f4f113179110c86916e5 URL: https://github.com/llvm/llvm-project/commit/da59370b0977083fa081f4f113179110c86916e5 DIFF: https://github.com/llvm/llvm-project/commit/da59370b0977083fa081f4f113179110c86916e5.diff

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Might be worth adding a little comment there to make sure we remember why the check is there in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154649/new/

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, that makes sense. lldb always updates its shared library state in reaction to a stop, so it's much safer to have the scripted process emulate this behavior. Plus, refreshing the

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

JDevlieghere accepted this revision. JDevlieghere added a comment. In D154617#4478402 , @fdeazeve wrote: > In D154617#4478369 , @JDevlieghere > wrote: > >> Is the reason this is necessary because the apple

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154549/new/ https://reviews.llvm.org/D154549 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch attempts to fix a dead lock when loading modules in a Scripted Process. This

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve added a comment. In D154617#4478369 , @JDevlieghere wrote: > Is the reason this is necessary because the apple accelerator tables would > emit an entry for both the mangled and demangled name? Not quite. The name inside the accelerator table

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

JDevlieghere added a comment. Is the reason this is necessary because the apple accelerator tables would emit an entry for both the mangled and demangled name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154617/new/

[Lldb-commits] [PATCH] D154643: [lldb] Prevent crash when completing ambiguous subcommands

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Fix a crash when trying to complete an ambiguous subcommand. Take `set s tar` for example: here `s` is ambiguous between `set` and `show`.

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

bulbazord added inline comments. Comment at: lldb/source/Target/DynamicRegisterInfo.cpp:204 +m_sets.push_back( +{ConstString(set_name).AsCString(), nullptr, 0, nullptr}); } else { mib wrote: > I guess `m_sets` is a vector of `char*`

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. There are some potential improvements we could make to this code (which I'm sure you can already identify), but to keep this change relatively risk-free we should

[Lldb-commits] [PATCH] D154534: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f7e41d0400e: [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8f7e41d - [lldb][NFCI] Minor cleanups to StructuredData::GetObjectForDotSeparatedPath

Author: Alex Langford Date: 2023-07-06T08:51:54-07:00 New Revision: 8f7e41d0400ecc41f8120e330baed15b0d203036 URL: https://github.com/llvm/llvm-project/commit/8f7e41d0400ecc41f8120e330baed15b0d203036 DIFF: https://github.com/llvm/llvm-project/commit/8f7e41d0400ecc41f8120e330baed15b0d203036.diff

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc55b0b38446: [lldb][NFCI] Remove use of ConstString from OptionValue (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/

[Lldb-commits] [lldb] fc55b0b - [lldb][NFCI] Remove use of ConstString from OptionValue

Author: Alex Langford Date: 2023-07-06T08:49:07-07:00 New Revision: fc55b0b38446be8948a291057b3086b4a01fe0a7 URL: https://github.com/llvm/llvm-project/commit/fc55b0b38446be8948a291057b3086b4a01fe0a7 DIFF: https://github.com/llvm/llvm-project/commit/fc55b0b38446be8948a291057b3086b4a01fe0a7.diff

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:430-431 + template + bool InterruptRequested(const char *cur_func, + const char *formatv, Args &&... args) { +bool ret_val = InterruptRequested();

[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLDB queries the debug names index with a regex, we should use the `Mangled`

[Lldb-commits] [PATCH] D154610: [lldb][NFC] Remove unused parameter from DebugNames::ProcessEntry

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154610 Files:

[Lldb-commits] [PATCH] D154505: [lldb][NFC] Remove code duplication in InitOSO

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cea22c0be95: [lldb][NFC] Remove code duplication in InitOSO (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154505/new/

[Lldb-commits] [lldb] 7cea22c - [lldb][NFC] Remove code duplication in InitOSO

Author: Felipe de Azevedo Piovezan Date: 2023-07-06T08:20:31-04:00 New Revision: 7cea22c0be95834317c920c21839cdd4c80fbdd8 URL: https://github.com/llvm/llvm-project/commit/7cea22c0be95834317c920c21839cdd4c80fbdd8 DIFF:

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG7aafea001282: [llvm][Support] Deprecate llvm::writeFileAtomically API (authored by hokein). Repository:

[Lldb-commits] [PATCH] D154413: [lldb] Fix crash when completing register names after program exit

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd8929904d88: [lldb] Fix crash when completing register names after program exit (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D154413?vs=537021=537622#toc Repository:

[Lldb-commits] [lldb] fd89299 - [lldb] Fix crash when completing register names after program exit

Author: David Spickett Date: 2023-07-06T08:35:04Z New Revision: fd8929904d8820629bae940bce5141ef65bcaa11 URL: https://github.com/llvm/llvm-project/commit/fd8929904d8820629bae940bce5141ef65bcaa11 DIFF: https://github.com/llvm/llvm-project/commit/fd8929904d8820629bae940bce5141ef65bcaa11.diff