[Lldb-commits] [PATCH] D156483: [lldb] Support CTF forward declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c70a3d9178f: [lldb] Support CTF forward declarations (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D156483?vs=544925=545324#toc

[Lldb-commits] [lldb] 9c70a3d - [lldb] Support CTF forward declarations

Author: Jonas Devlieghere Date: 2023-07-28T19:10:36-07:00 New Revision: 9c70a3d9178f46c3eccb2243286deb1830c276f4 URL: https://github.com/llvm/llvm-project/commit/9c70a3d9178f46c3eccb2243286deb1830c276f4 DIFF:

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added a comment. In D156562#4543743 , @jasonmolenda wrote: > This is fine to me but maybe instead of `ifndef apple` we could do a `if > __has_include()` and include the system header if it's avail. One reason I decided not to do this is

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord updated this revision to Diff 545289. bulbazord added a comment. Fix incorrect includes that @jasonmolenda pointed out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156562/new/ https://reviews.llvm.org/D156562 Files:

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added a comment. In D156562#4543743 , @jasonmolenda wrote: > This is fine to me but maybe instead of `ifndef apple` we could do a `if > __has_include()` and include the system header if it's avail. I > must be misreading the patch but it

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

jasonmolenda added a comment. This is fine to me but maybe instead of `ifndef apple` we could do a `if __has_include()` and include the system header if it's avail. I must be misreading the patch but it seems like you're changing the filename to AppleUuidCompatbility.h but the two places it's

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

ashgti updated this revision to Diff 545278. ashgti added a comment. Adjusting the unit test to only check 2 frames instead of 3 and adjusted the assertions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/

[Lldb-commits] [lldb] 1bf6f55 - [lldb-vscode] Adding support for displaying backtraces.

Author: John Harrison Date: 2023-07-28T16:54:27-04:00 New Revision: 1bf6f55911ca6427789093b1df8a63d7e72dac51 URL: https://github.com/llvm/llvm-project/commit/1bf6f55911ca6427789093b1df8a63d7e72dac51 DIFF: https://github.com/llvm/llvm-project/commit/1bf6f55911ca6427789093b1df8a63d7e72dac51.diff

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bf6f55911ca: [lldb-vscode] Adding support for displaying backtraces. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15 // uuid_t is guaranteed to always be a 16-byte array typedef unsigned char uuid_t[16]; #endif // utility_UUID_COMPATIBILITY_H mib wrote: > May be this could be

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

mib added inline comments. Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15 // uuid_t is guaranteed to always be a 16-byte array typedef unsigned char uuid_t[16]; #endif // utility_UUID_COMPATIBILITY_H May be this could be moved to

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit does a few related things: - Removes

[Lldb-commits] [lldb] 0a5e0d3 - [lldb] Split CTF parsing and type creation (NFC)

Author: Jonas Devlieghere Date: 2023-07-28T09:41:47-07:00 New Revision: 0a5e0d3fad8dfdebc8bb2f51f6008bdd41e27580 URL: https://github.com/llvm/llvm-project/commit/0a5e0d3fad8dfdebc8bb2f51f6008bdd41e27580 DIFF:

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0a5e0d3fad8d: [lldb] Split CTF parsing and type creation (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

DavidSpickett added a comment. I have no excuse to not try vcsode with lldb now, thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493

[Lldb-commits] [PATCH] D156465: [lldb-vscode] Adding support for displaying backtraces.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. fancy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156465/new/ https://reviews.llvm.org/D156465

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. you are my hero Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156493/new/ https://reviews.llvm.org/D156493

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

Michael137 added a comment. Generally LGTM, just some clarifications questions Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); +

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

DavidSpickett updated this revision to Diff 545045. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156512/new/ https://reviews.llvm.org/D156512 Files:

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett updated this revision to Diff 545044. DavidSpickett added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156118/new/ https://reviews.llvm.org/D156118 Files: lldb/include/lldb/Host/linux/Ptrace.h

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we were storing them but not restoring them. This fixes