[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,17 @@ +#include +int main() { + int value = 5; jasonmolenda wrote: Yeah, if this was compiled with any optimization at all, the body of the function becomes `mv x0, #0xa`; `ret` so I didn't try to defeat compiler cleverness.

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,17 @@ +#include +int main() { + int value = 5; + + value = 5; // break here + value = 5; + value = 5; + value = 5; + value = 5; + value = 5; + value = 10; + value = 10; jasonmolenda wrote: Good point. I figured existing watchpoint tests

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Is this change testable in a test case? I assume it must be somehow as it is fixing a bug? https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self): self.exe_name = "a.out" self.do_add_dsym_with_dSYM_bundle(self.exe_name) +@no_debug_info_test +def test_report_symbol_load(self): +"""Test that when adding a symbol file, the

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolFileChange = (1 << 3),

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,17 @@ +#include +int main() { + int value = 5; + + value = 5; // break here + value = 5; + value = 5; + value = 5; + value = 5; + value = 5; + value = 10; + value = 10; clayborg wrote: We could change it back to 5 to ensure that the

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,17 @@ +#include +int main() { + int value = 5; clayborg wrote: If you take the address of "value" then it will always be in memory. Here we might be just getting lucky that the compiler choses to put this on the stack at -O0.

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Since users probably want a behavior like GDB by default, one idea is to just add a setting: ``` (llldb) settings show target.watchpoint-stop-on-write [always|changed] ``` When watchpoints are set, they just read the current value for this. Most of your

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,17 @@ +#include +int main() { + int value = 5; + + value = 5; // break here + value = 5; + value = 5; + value = 5; + value = 5; + value = 5; + value = 10; + value = 10; clayborg wrote: Can we check that it stops when the value changes from

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

2023-09-13 Thread Min-Yih Hsu via lldb-commits
https://github.com/mshockwave approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -982,6 +982,13 @@ class StopInfoWatchpoint : public StopInfo { m_should_stop = false; } } + +// Don't stop if the watched region value is unmodified, and +// this is a Modify-type watchpoint. +if (m_should_stop &&

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext _ctx) { return (m_new_value_sp && m_new_value_sp->GetError().Success()); } +bool Watchpoint::WatchedValueReportable(const ExecutionContext _ctx) { + if (!m_watch_modify) +return true; +

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -31,13 +31,15 @@ class OptionGroupWatchpoint : public OptionGroup { void OptionParsingStarting(ExecutionContext *execution_context) override; // Note: - // eWatchRead == LLDB_WATCH_TYPE_READ; and + // eWatchRead == LLDB_WATCH_TYPE_READ // eWatchWrite ==

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Account for Unicode when computing the prompt column width. Previously, the string length (i.e. number of bytes) rather than the width of the Glyph was used to compute the cursor position. The result was that the cursor would be

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Related to #66218 https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/66312: Account for Unicode when computing the prompt column width. Previously, the string length (i.e. number of bytes) rather than the width of the Glyph was used to compute the cursor position. The result was

[Lldb-commits] [lldb] [lldb] Support Unicode in the prompt (PR #66312)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/66144: >From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 12 Sep 2023 13:49:50 -0700 Subject: [PATCH 1/3] [lldb][Commands] Show symbol change bit in SB API

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Just to be clear, I need to find a solution for SBTarget::CreateWatchpoint before this PR is ready to land. I'm inclined towards adding a third bool parameter 'modify', but I'm not sure that's the best choice. https://github.com/llvm/llvm-project/pull/66308

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Watchpoints in lldb can be either 'read', 'write', or 'read/write'. This is exposing the actual behavior of hardware watchpoints. gdb has a different behavior: a "write" type watchpoint only stops when the watched memory

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda review_requested https://github.com/llvm/llvm-project/pull/66308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

2023-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/66308: Watchpoints in lldb can be either 'read', 'write', or 'read/write'. This is exposing the actual behavior of hardware watchpoints. gdb has a different behavior: a "write" type watchpoint only stops when

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Reid Kleckner via lldb-commits
https://github.com/rnk commented: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > can we wire up the ansi color formatting without supporting all these other > bits of data? Yes, but you'd still need to solve (1), (3) and (4) which are the "hard" ones. Doing what you suggests only saves you (2) which is by far the easiest one in the list.

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Does this API work for eBroadcastBitSymbolsLoaded: > > ``` > static lldb::SBModule lldb::SBTarget::GetModuleAtIndexFromEvent(const > uint32_t idx, const lldb::SBEvent ); > ``` > > ? > > > Note, Jonas already added the Target::eBroadcastBitSymbolsChanged, but it > >

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-09-13 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148: >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/11] [libc++] Implement ranges::contains Differential

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Arthur Eubanks via lldb-commits
https://github.com/aeubanks review_requested https://github.com/llvm/llvm-project/pull/66295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 705f24c - [lldb] Accept optional module in Value::ResolveValue (#66286)

2023-09-13 Thread via lldb-commits
Author: Augusto Noronha Date: 2023-09-13T14:23:50-07:00 New Revision: 705f24cdabea6b7bf36ba068aa15adae566857f0 URL: https://github.com/llvm/llvm-project/commit/705f24cdabea6b7bf36ba068aa15adae566857f0 DIFF:

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-09-13 Thread via lldb-commits
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812: >From a42cbcc0731725929c60ba4c1fd5254ae5e46613 Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH] Support: hoist lld's executable name code to Path Instead of

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
bnbarham wrote: Sorry, which PR? https://github.com/llvm/llvm-project/pull/66281 is a revert of https://github.com/llvm/llvm-project/pull/65683 which caused the failures to begin with. The only non-NFC part of that PR is

[Lldb-commits] [lldb] 377497f - [NFC][lldb] Replace usage of deprecated llvm::makeArrayRef

2023-09-13 Thread Arthur Eubanks via lldb-commits
Author: Arthur Eubanks Date: 2023-09-13T13:46:46-07:00 New Revision: 377497f32ac9b9a182018e12903f236c42629251 URL: https://github.com/llvm/llvm-project/commit/377497f32ac9b9a182018e12903f236c42629251 DIFF:

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Value::ResolveValue calls Value::GetValueAsData as part of its implementation. The latter can receive an optional Module pointer, which is always null when called from the former. Allow threading in the Module in

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 review_requested https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 review_requested https://github.com/llvm/llvm-project/pull/66286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Accept optional module in Value::ResolveValue (PR #66286)

2023-09-13 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/66286: Value::ResolveValue calls Value::GetValueAsData as part of its implementation. The latter can receive an optional Module pointer, which is always null when called from the former. Allow threading in the

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Dave Lee via lldb-commits
kastiglione wrote: > You will need access to the debugger, target, process etc. Currently Editline > lives in Host, so we'd have to move that out into Core to avoid circular > dependencies. can we wire up the ansi color formatting without supporting all these other bits of data? if we're

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
@@ -66,6 +66,7 @@ #include "llvm/ADT/ScopeExit.h" #include "llvm/ADT/SetVector.h" +#include <_types/_uint32_t.h> chelcassanova wrote: This was included by mistake https://github.com/llvm/llvm-project/pull/66144

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/66144: >From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 12 Sep 2023 13:49:50 -0700 Subject: [PATCH 1/2] [lldb][Commands] Show symbol change bit in SB API

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/66144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

2023-09-13 Thread Chelsea Cassanova via lldb-commits
@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From bb1941649714c424bbcaab6c14892657aab55c93 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

2023-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From 9e3ccc3b7209ef92abedb3f7aa9b1ddd6687f410 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Vassil Vassilev via lldb-commits
vgvassilev wrote: Does that PR fix the tests you mentioned? https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
bnbarham wrote: > If you can provide links to the failing tests I can take a look. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/60022/ https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Vassil Vassilev via lldb-commits
vgvassilev wrote: @bnbarham, I think it would be useful to keep it. > If we think this is useful to keep I'll need to look into how > https://github.com/llvm/llvm-project/pull/65683 broke LLDB testing: Incremental processing should also enable the llvm expression parser workflows. The

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
bnbarham wrote: > Isn't that a better way to support the expression parsing logic where we > execute statements on the global scope to evaluate their results? This is currently enabled during module loading, where we definitely don't want any change in behavior IMO. Perhaps we could enable it

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
bnbarham wrote: Sorry about the noise here. I accidentally pushed over the same branch name. https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

2023-09-13 Thread Ben Barham via lldb-commits
https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >