[Lldb-commits] [lldb] 5ba239f - Remove expected-fail for Linux on TestStepOverWatchpoint.py

2023-09-22 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-09-22T18:22:02-07:00 New Revision: 5ba239fe2a338ca6dc293a2dd9ea0758f25c738e URL: https://github.com/llvm/llvm-project/commit/5ba239fe2a338ca6dc293a2dd9ea0758f25c738e DIFF: https://github.com/llvm/llvm-project/commit/5ba239fe2a338ca6dc293a2dd9ea0758f25c738e.diff

[Lldb-commits] [lldb] 4a43ee0 - Re-enable StepOverWatchpoint test, make it more focused

2023-09-22 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2023-09-22T18:11:33-07:00 New Revision: 4a43ee08e73287c006a317b94a94e3f19dbcf957 URL: https://github.com/llvm/llvm-project/commit/4a43ee08e73287c006a317b94a94e3f19dbcf957 DIFF: https://github.com/llvm/llvm-project/commit/4a43ee08e73287c006a317b94a94e3f19dbcf957.diff

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Ed Maste via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-22 Thread Greg Clayton via lldb-commits
clayborg wrote: If we have a end to end test that shows the problem you are trying to fix it would help as well. https://github.com/llvm/llvm-project/pull/66879 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

2023-09-22 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. Is there a reason we need to complete nested types within a type? Seems like we can put that off until later. Right now if you parse a member function, any types it needs will be parsed lazily and only if needed, which is ok.

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-22 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/67190 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -559,6 +560,7 @@ void CommandInterpreter::LoadCommandDictionary() { REGISTER_COMMAND_OBJECT("settings", CommandObjectMultiwordSettings); REGISTER_COMMAND_OBJECT("session", CommandObjectSession);

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: @@ -36,6 +36,7 @@ #include "Commands/CommandObjectSession.h" #include "Commands/CommandObjectSettings.h" #include "Commands/CommandObjectSource.h" +#include "Commands/CommandObjectStart.h" clayborg

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -30,6 +30,7 @@ add_lldb_library(lldbCommands NO_PLUGIN_DEPENDENCIES CommandObjectSession.cpp CommandObjectSettings.cpp CommandObjectSource.cpp + CommandObjectStart.cpp clayborg wrote: revert

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -0,0 +1,32 @@ +//===-- CommandObjectStart.h -*- C++ -*-===// clayborg wrote: Revert this source file since we are just adding an option to "process launch" right?

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntry); break; - + case 'm': // Stop at main function +

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -0,0 +1,102 @@ +//===-- CommandObjectStart.cpp ---===// clayborg wrote: Revert this source file since we are just adding an option to "process launch" right?

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue( case 's': // Stop at program entry point launch_info.GetFlags().Set(eLaunchFlagStopAtEntry); break; - + case 'm': // Stop at main function +

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Greg Clayton via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Augusto Noronha via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -935,6 +935,16 @@ lldb_private::Address ObjectFileELF::GetEntryPointAddress() { } Address ObjectFileELF::GetBaseAddress() { + if (GetType() == ObjectFile::eTypeObjectFile) { +for (SectionHeaderCollIter I = std::next(m_section_headers.begin()); + I !=

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Ed Maste via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -0,0 +1,165 @@ +#ifndef LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H bulbazord wrote: This file needs a license header. https://github.com/llvm/llvm-project/pull/67106 ___

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Ed Maste via lldb-commits
@@ -0,0 +1,165 @@ +#ifndef LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H +#define LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H + +#include +#include +#include + +#include "lldb/Target/DynamicLoader.h" +#include

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Alex Langford via lldb-commits
@@ -935,6 +935,16 @@ lldb_private::Address ObjectFileELF::GetEntryPointAddress() { } Address ObjectFileELF::GetBaseAddress() { + if (GetType() == ObjectFile::eTypeObjectFile) { +for (SectionHeaderCollIter I = std::next(m_section_headers.begin()); + I !=

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,165 @@ +#ifndef LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H +#define LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H + +#include +#include +#include + +#include "lldb/Target/DynamicLoader.h" +#include

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Alex Langford via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: bulbazord wrote: You also may want to change the title of your PR to reflect the actual change you'll be making as well. When you squash and merge, you'll have an opportunity to rewrite the commit message to more accurately reflect what

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Alex Langford via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: bulbazord wrote: Concretely, you can revert the first commit and push that so that your branch has your first commit, second commit, and a revert commit for the first one. As Walter said, it should squash down and resolve correctly.

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes I want to work towards unifying the implementations. It would be a lot easier to do if LLDB's DWARFDebugAbbrev looked more similar to LLVM's implementation, so this change moves in that direction. --- Full diff:

[Lldb-commits] [lldb] [lldb] Modify the DWARFDebugAbbrev interface to be closer to LLVM's (PR #67190)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/67190 I want to work towards unifying the implementations. It would be a lot easier to do if LLDB's DWARFDebugAbbrev looked more similar to LLVM's implementation, so this change moves in that direction. >From

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Walter Erquinigo via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: That's file. You can have multiple commits in the same PR, because when it gets approved and merged, github will squash all your commits into a single one. https://github.com/llvm/llvm-project/pull/67019

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread José Lira Junior via lldb-commits
junior-jl wrote: This might be a dumb question, but I committed the implementation as an option as the second commit thinking you would/could discard my first commit. Is that possible? What would be the best way to correct this? https://github.com/llvm/llvm-project/pull/67019

[Lldb-commits] [lldb] 66e8398 - [lldb] Fix a warning

2023-09-22 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2023-09-22T11:32:14-07:00 New Revision: 66e83983491415d7431067181fd2816305f615e0 URL: https://github.com/llvm/llvm-project/commit/66e83983491415d7431067181fd2816305f615e0 DIFF: https://github.com/llvm/llvm-project/commit/66e83983491415d7431067181fd2816305f615e0.diff

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c0a9722 - [lldb][NFC] Move some ctors and tors to cpp files (#67165)

2023-09-22 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-09-22T13:33:07-04:00 New Revision: c0a9722bd66d3452ba095d9f9ef6ab67b9965c76 URL: https://github.com/llvm/llvm-project/commit/c0a9722bd66d3452ba095d9f9ef6ab67b9965c76 DIFF:

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67165 >From 0f7b275c5fa608dce8b345c81794514abda017f3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 22 Sep 2023 12:29:46 -0400 Subject: [PATCH] [lldb][NFC] Move some ctors and tors to cpp files

[Lldb-commits] [lldb] [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (PR #67055)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 55ec9db - [lldb][NFCI] Change parameter type in UserExpression::GetObjectPointer (#67055)

2023-09-22 Thread via lldb-commits
Author: Alex Langford Date: 2023-09-22T10:10:21-07:00 New Revision: 55ec9db42ae03661d1a2913423f56b58db581199 URL: https://github.com/llvm/llvm-project/commit/55ec9db42ae03661d1a2913423f56b58db581199 DIFF: https://github.com/llvm/llvm-project/commit/55ec9db42ae03661d1a2913423f56b58db581199.diff

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me, if we're defining a lot of the methods for these classes in implementation files, we should do the same for constructors and destructors too. https://github.com/llvm/llvm-project/pull/67165

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. --- Full diff: https://github.com/llvm/llvm-project/pull/67165.diff 4 Files Affected: -

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67165 This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. >From 68818ce0376ba717157edaffd5ae2101cf26d4e2 Mon Sep

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for the explanation. Now I understand what I'm seeing is the expected behaviour, and async mode is the expected way to achieve what the test needs. https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: The other improvement I'd suggest here is that the breakpoints you set to implement the "stop at main" behavior need to be be "one-shot" breakpoints. Otherwise, if you do: (lldb) process launch --stop-at-main ... the

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-22 Thread via lldb-commits
jimingham wrote: The comment in front of the `SyntheticChildProviderFrontEnd::Update` is actually pretty clear about what it does, the problem is that it isn't really obvious from the comment when discarding the cached children would be a good or bad idea. I'm not sure you could express that

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread Walter Erquinigo via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: Btw, I'm building support for the mojo language, and very likely the `main` method will not have the symbol `main`, so building an abstraction around this, for every language, would be very convenient.

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: jimingham wrote: I can't tell how to read the "Files Changed" part of the GitHub PR change. It looks like the --stop-at-main is additive, but to be clear, the second of these two commits looks okay to me, but the first commit is still not

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: https://github.com/jimingham commented: The reason that gdb has a "start" command is that not all languages and their runtimes use the same name for the the entry point function. So `start` does "figure out what the start function in the

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread via lldb-commits
jimingham wrote: process attach --continue won't return till the process stops when in sync mode. That's really what sync mode means: "commands that continue the target don't return till the target stops". But if the process is hitting a breakpoint or exiting and we aren't exiting the

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread José Lira Junior via lldb-commits
junior-jl wrote: Thank you for the explanation here and in Discourse. I added the option `stop-at-main` to `process launch`. https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

2023-09-22 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/2] [lldb] add command start ---

[Lldb-commits] [lldb] bb01fd5 - [lldb] Require paused process and frame for "register info" command (#67124)

2023-09-22 Thread via lldb-commits
Author: David Spickett Date: 2023-09-22T15:55:27+01:00 New Revision: bb01fd57bcaec533cd08b4d107979511d893f5b3 URL: https://github.com/llvm/llvm-project/commit/bb01fd57bcaec533cd08b4d107979511d893f5b3 DIFF:

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett resolved https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/67124 >From 90d4354a0305b9a88fee8e25292ecc3dcec5723d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 22 Sep 2023 12:26:24 + Subject: [PATCH 1/2] [lldb] Require paused process and frame for "register

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread Walter Erquinigo via lldb-commits
@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread David Truby via lldb-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/67125 >From 0690521dd83e8fae81f65bce173ed7189ff9307b Mon Sep 17 00:00:00 2001 From: David Truby Date: Fri, 22 Sep 2023 12:22:49 + Subject: [PATCH 1/2] [cmake] Add LLVM_FORCE_VC_REVISION option This patch adds

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

2023-09-22 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Do you think it would be a good idea to provide aliases for the return values of the Update method with better names that match the behavior you just discovered? I'm not a fan of true/false in this case, because it confuses synthetic type developers, but I'm just

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread Walter Erquinigo via lldb-commits
@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread Tobias Hieta via lldb-commits
https://github.com/tru commented: It looks fine to me, but maybe we should have an entry for it in the `CMake.rst` documentation since the other `LLVM_*_VC` options are documented. https://github.com/llvm/llvm-project/pull/67125 ___ lldb-commits

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This patch adds a LLVM_FORCE_VC_REVISION option to force a custom VC revision to be included instead of trying to fetch one from a git command. This is helpful in environments where git is not available or is non-functional but the vc

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread David Truby via lldb-commits
https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/67125 This patch adds a LLVM_FORCE_VC_REVISION option to force a custom VC revision to be included instead of trying to fetch one from a git command. This is helpful in environments where git is not available or is

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Prior to this the command would simply crash when run on a running process. Of the three register commands, "info" was the only one missing these requirements. On some level it makes sense because you're not going to read a value or

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

2023-09-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/67124 Prior to this the command would simply crash when run on a running process. Of the three register commands, "info" was the only one missing these requirements. On some level it makes sense because you're

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel ---

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel ---

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel ---

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast updated https://github.com/llvm/llvm-project/pull/67106 >From f8ed3ed64be0a451542a4ec71f254dc9038b2d19 Mon Sep 17 00:00:00 2001 From: aokblast Date: Fri, 22 Sep 2023 18:11:07 +0800 Subject: [PATCH 1/2] feat: add DynamicLoaderFreeBSDKernel ---

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This commit is moved from [llvm-phabricator](https://reviews.llvm.org/D159076). The implemtation support parsing kernel module for FreeBSD Kernel and has been test on x86-64 and arm64. In summary, this class parse the linked list resides in

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f78d6ab146874d20144f9f5fcbb894931279c7d dc15a7dc299e36930fa52405a4137c184e252305 --

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-09-22 Thread via lldb-commits
https://github.com/aokblast created https://github.com/llvm/llvm-project/pull/67106 This commit is moved from [llvm-phabricator](https://reviews.llvm.org/D159076). The implemtation support parsing kernel module for FreeBSD Kernel and has been test on x86-64 and arm64. In summary, this class