[Lldb-commits] [lldb] 4ec9cda - [lldb/test] Fix failures following ec456ba9ca0a

2023-10-26 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-10-26T21:21:54-07:00 New Revision: 4ec9cda656cc2fde41d4a4415ae363d9a3290c80 URL: https://github.com/llvm/llvm-project/commit/4ec9cda656cc2fde41d4a4415ae363d9a3290c80 DIFF: https://github.com/llvm/llvm-project/commit/4ec9cda656cc2fde41d4a4415ae363d9a3290c80.

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,146 @@ +//===-- WatchpointResourceList.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -266,33 +268,73 @@ void Watchpoint::Dump(Stream *s) const { // If prefix is nullptr, we display the watch id and ignore the prefix // altogether. -void Watchpoint::DumpSnapshots(Stream *s, const char *prefix) const { - if (!prefix) { -s->Printf("\nWatchpoint %u hit:",

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,97 @@ +//===-- WatchpointResource.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -331,6 +373,16 @@ void Watchpoint::DumpWithLevel(Stream *s, bool Watchpoint::IsEnabled() const { return m_enabled; } +uint32_t Watchpoint::GetHardwareIndex() const { + if (IsEnabled()) +return m_target.GetProcessSP() +->GetWatchpointResourceList() +.Fi

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,154 @@ +//===-- WatchpointResourceList.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,146 @@ +//===-- WatchpointResourceList.h *- C++ -*-===// JDevlieghere wrote: Do we really need this class? It looks like a pretty trivial wrapper around a vector and a mutex. How much overlap is there with the `Breakpo

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-26 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,97 @@ +//===-- WatchpointResource.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/70392 >From 836bafbf3956750c99d38814a4a0a445f9136141 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 26 Oct 2023 16:35:53 -0700 Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for Scri

[Lldb-commits] [lldb] [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/70392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/70392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/70392 >From 7366abec305c6f53d3906b54c86f0dabe84ef01e Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 26 Oct 2023 16:35:53 -0700 Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for Scri

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/70392 >From 76f655166b36928c1fe10c3124025c50d6eb1ceb Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Thu, 26 Oct 2023 16:30:20 -0700 Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for Scri

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #70392)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/70392 This patch changes the way plugin objects used with Scripted Interfaces are created. Instead of implementing a different SWIG method to create the object for every scripted interface, this patch makes the

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

2023-10-26 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGec456ba9ca0a: [lldb] Add OperatingSystem base class to the lldb python module (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ h

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

2023-10-26 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a1e8783586e: [lldb] Introduce OperatingSystem{,Python}Interface and make use it (authored by mib). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 7a1e878 - [lldb] Introduce OperatingSystem{, Python}Interface and make use it

2023-10-26 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-10-26T15:12:22-07:00 New Revision: 7a1e8783586ecc90ee15f12c7b76799313bb32e8 URL: https://github.com/llvm/llvm-project/commit/7a1e8783586ecc90ee15f12c7b76799313bb32e8 DIFF: https://github.com/llvm/llvm-project/commit/7a1e8783586ecc90ee15f12c7b76799313bb32e8.

[Lldb-commits] [lldb] ec456ba - [lldb] Add OperatingSystem base class to the lldb python module

2023-10-26 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-10-26T15:12:22-07:00 New Revision: ec456ba9ca0a097da63daafbb031cb2024f5513a URL: https://github.com/llvm/llvm-project/commit/ec456ba9ca0a097da63daafbb031cb2024f5513a DIFF: https://github.com/llvm/llvm-project/commit/ec456ba9ca0a097da63daafbb031cb2024f5513a.

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

2023-10-26 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D159314#4655289 , @bulbazord wrote: > Ok, makes sense to me. Since this is a refactor, I assume that the current > test suite should be enough to cover this change? @bulbazord yes! CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-26 Thread via lldb-commits
jimingham wrote: Is there a reason this is DidLoadCore only has a non-trivial implementation for Mach? The generic and Mach parts of this are fine, so if there's a reason why this isn't needed for the other platform's core files, then this LGTM as well. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-26 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Yes this looks good to me. I originally had a little concern about changing the ordering of how we call the methods in the corefile process plugins, but I don't think that's going to be an issue for them. https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-26 Thread Alex Langford via lldb-commits
@@ -610,7 +610,7 @@ NativeRegisterContextLinux_arm64::CacheAllRegisters(uint32_t &cached_size) { return error; // Here this means, does the system have ZA, not whether it is active. bulbazord wrote: You could probably remove this comment https://githu

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/70303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM 😃 https://github.com/llvm/llvm-project/pull/70303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-10-26 Thread Erich Keane via lldb-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/5] [OpenACC] Initial commit for OpenACC Support This is the ini

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make use it

2023-10-26 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, makes sense to me. Since this is a refactor, I assume that the current test suite should be enough to cover this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159314

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-10-26 Thread Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
bolshakov-a added a comment. Sorry, but I don't know what remains to be done here. It seems that the only important question is about ABI, but I've already answered that the changes under discussion seem to be already fixed in the Itanium ABI document. CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-10-26 Thread Aaron Ballman via Phabricator via lldb-commits
aaron.ballman added a comment. In D140996#4646880 , @cor3ntin wrote: > It would be nice to figure out a plan for this PR in the next few weeks, > before we get kicked out of Phab! Agreed -- @bolshakov-a are you still planning to actively work on this pa

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch is a follow-up to db223b7f01f7. Similarly to it, it changes the timing of binary image loading for the ProcessMachCore plugin. This issue came up after getting reports of scripting resou

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/70351 This patch is a follow-up to db223b7f01f7. Similarly to it, it changes the timing of binary image loading for the ProcessMachCore plugin. This issue came up after getting reports of scripting resources that

[Lldb-commits] [lldb] 45ccc16 - [lldb][test][Windows] XFAIL IR memory map test

2023-10-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-10-26T16:17:14Z New Revision: 45ccc1666c723e11d7b0148b2ef5c37c7a36e916 URL: https://github.com/llvm/llvm-project/commit/45ccc1666c723e11d7b0148b2ef5c37c7a36e916 DIFF: https://github.com/llvm/llvm-project/commit/45ccc1666c723e11d7b0148b2ef5c37c7a36e916.diff LOG

[Lldb-commits] [lldb] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/70341 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Diagnose use of VLAs in a coroutine (PR #70341)

2023-10-26 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/70341 >From f068b471efa81d60d1d6e2c98da56be58958a015 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Thu, 26 Oct 2023 10:53:06 -0400 Subject: [PATCH 1/2] Diagnose use of VLAs in a coroutine Fixes https://githu

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

2023-10-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: Never mind, this could have been the result of using an incompatible Python version. I'll get a stacktrace with one I know is used on the bot. https://github.com/llvm/llvm-project/pull/68052 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] 53096f9 - [lldb] Try to fix build after d1556e5efbf0

2023-10-26 Thread Nico Weber via lldb-commits
Author: Nico Weber Date: 2023-10-26T07:37:42-07:00 New Revision: 53096f910ca874cf446417d0bf551c5d63e917b2 URL: https://github.com/llvm/llvm-project/commit/53096f910ca874cf446417d0bf551c5d63e917b2 DIFF: https://github.com/llvm/llvm-project/commit/53096f910ca874cf446417d0bf551c5d63e917b2.diff LO

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

2023-10-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: Somehow it is getting to: ``` virtual llvm::Expected CreatePluginObject(llvm::StringRef class_name, ExecutionContext &exe_ctx, StructuredData::DictionarySP args_sp, StructuredData::Generic *script_obj = nullptr) { llvm_unreach

[Lldb-commits] [lldb] [lldb/Interpreter] Make ScriptedInterface Object creation more generic (PR #68052)

2023-10-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: We still have a failure on Windows after the follow ups: ``` # .---command stderr # | Cannot create an instance of the ScriptedProcessInterface! # | UNREACHABLE executed at C:\Users\tcwg\david.spickett\llvm-project\lldb\include\lldb/Interpreter/Interfaces/Scripte

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Can you please confirm weather the test cases good for now and the future > plan looks okay? ;) Sounds good but see my comment about substrings vs. regex. If you go and special case all the characters you're gonna end up reinventing a regex engine, but you don't need to

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-26 Thread via lldb-commits
taalhaataahir0102 wrote: Hi David, I thought writing a few simple and very basic test cases will be better before updating the `printRed` function so that while updating the `printRed` function it easier and quicker for us to test :) We've written 2 test cases for colorized output search in `

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-26 Thread David Spickett via lldb-commits
@@ -0,0 +1,23 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t +# RUN: %lldb %t -b -o 'image lookup -r -s ma' | FileCheck %s + +# CHECK: 3 symbols match the regular expression 'ma' in {{.*}} +# The [[ confuses FileCheck so regex match it. +# CHECK-NE

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-26 Thread David Spickett via lldb-commits
@@ -0,0 +1,23 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t +# RUN: %lldb %t -b -o 'image lookup -r -s ma' | FileCheck %s + +# CHECK: 3 symbols match the regular expression 'ma' in {{.*}} +# The [[ confuses FileCheck so regex match it. +# CHECK-NE

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-26 Thread David Spickett via lldb-commits
@@ -0,0 +1,23 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t +# RUN: %lldb %t -b -o 'image lookup -r -s ma' | FileCheck %s DavidSpickett wrote: I should have brought this up earlier but the way you're coloring the output doesn't

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

2023-10-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70205 >From 80e01960f247ab9ee06daa59d9c033fda5fc3978 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 3 Oct 2023 13:24:39 +0100 Subject: [PATCH 1/4] [lldb][AArch64] Add SME2's ZT0 register SME2 is docume

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

2023-10-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 23d6a6dfc1bc6e79bdcc48a59a0698a5b79262e9 3ed10ca4d37abce5114fe22110b587a0c78d2d0a --

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

2023-10-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70205 >From 80e01960f247ab9ee06daa59d9c033fda5fc3978 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 3 Oct 2023 13:24:39 +0100 Subject: [PATCH 1/3] [lldb][AArch64] Add SME2's ZT0 register SME2 is docume

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

2023-10-26 Thread David Spickett via lldb-commits
@@ -625,6 +662,18 @@ NativeRegisterContextLinux_arm64::CacheAllRegisters(uint32_t &cached_size) { error = ReadZA(); if (error.Fail()) return error; + +// We will only be restoring ZT data if ZA is active. As writing to an +// inactive ZT enables ZA, which

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes For most register sets, if it was enabled this meant you could use it, it was present in the process. There was no present but turned off state. So "enabled" made sense. Then ZA came along (and soon

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/70303 For most register sets, if it was enabled this meant you could use it, it was present in the process. There was no present but turned off state. So "enabled" made sense. Then ZA came along (and soon to be

[Lldb-commits] [lldb] [lldb][AArch64] Add SME2's ZT0 register (PR #70205)

2023-10-26 Thread David Spickett via lldb-commits
@@ -625,6 +662,18 @@ NativeRegisterContextLinux_arm64::CacheAllRegisters(uint32_t &cached_size) { error = ReadZA(); if (error.Fail()) return error; + +// We will only be restoring ZT data if ZA is active. As writing to an +// inactive ZT enables ZA, which

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-10-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes The contents of which are mostly SPSR_EL1 as shown in the Arm manual, with a few adjustments for things Linux says userspace shouldn't concern itself with. ``` (lldb) register read cpsr cpsr = 0x8

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-10-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/70300 The contents of which are mostly SPSR_EL1 as shown in the Arm manual, with a few adjustments for things Linux says userspace shouldn't concern itself with. ``` (lldb) register read cpsr cpsr = 0x800010

[Lldb-commits] [lldb] [lldb][lldb-server] Enable sending RegisterFlags as XML (PR #69951)

2023-10-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/69951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d1556e5 - [lldb][lldb-server] Enable sending RegisterFlags as XML (#69951)

2023-10-26 Thread via lldb-commits
Author: David Spickett Date: 2023-10-26T08:33:30+01:00 New Revision: d1556e5efbf0cb671c0f6e403fc1eaf9153f8713 URL: https://github.com/llvm/llvm-project/commit/d1556e5efbf0cb671c0f6e403fc1eaf9153f8713 DIFF: https://github.com/llvm/llvm-project/commit/d1556e5efbf0cb671c0f6e403fc1eaf9153f8713.diff