[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/79662 >From 7cfed8b3440d9257598fe94e02adc4d926692850 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jan 2024 22:47:15 + Subject: [PATCH] [lldb] checks beforehand if lldb can trace/attach a process on

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/79662 >From 746a6959e270b086184ce095b11eb4df691dc4c9 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jan 2024 22:47:15 + Subject: [PATCH] [lldb] checks beforehand if lldb can trace/attach a process on

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Alex Langford via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, +

[Lldb-commits] [lldb] [lldb] Remove obsolete signBinary helper (PR #79656)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/79656 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7595287 - [lldb] Remove obsolete signBinary helper (#79656)

2024-01-26 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-26T20:37:44-08:00 New Revision: 75952873036fc9989fcf12c526d1a2deaeef596a URL: https://github.com/llvm/llvm-project/commit/75952873036fc9989fcf12c526d1a2deaeef596a DIFF:

[Lldb-commits] [flang] [compiler-rt] [llvm] [clang-tools-extra] [clang] [lld] [libcxxabi] [lldb] [mlir] [libcxx] [libc] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

2024-01-26 Thread Kai Sasaki via lldb-commits
https://github.com/Lewuathe closed https://github.com/llvm/llvm-project/pull/76316 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Ed Maste via lldb-commits
emaste wrote: Thanks for picking this up -- I was starting to take a look but was sidetracked with a lot of yak shaving. https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Ed Maste via lldb-commits
@@ -48,14 +48,36 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, + ,

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Ed Maste via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, +

[Lldb-commits] [libcxx] [clang-tools-extra] [llvm] [clang] [libc] [lld] [lldb] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via lldb-commits
RamaMalladiAWS wrote: Unable to get Windows build target machine allocated. Will reattempt another submission. https://github.com/llvm/llvm-project/pull/79655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [libc] [lld] [lldb] [libcxx] [llvm] [clang] [clang-tools-extra] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via lldb-commits
https://github.com/RamaMalladiAWS closed https://github.com/llvm/llvm-project/pull/79655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [libcxx] [clang-tools-extra] [lldb] [llvm] [lld] [libc] [clang] intrinsic to generate a bfi instruction (PR #79655)

2024-01-26 Thread Rama Malladi via lldb-commits
https://github.com/RamaMalladiAWS updated https://github.com/llvm/llvm-project/pull/79655 >From 96aba7076392fb7f7479ec3a313ced5cfb714f81 Mon Sep 17 00:00:00 2001 From: Ubuntu Date: Fri, 26 Jan 2024 18:56:32 + Subject: [PATCH 1/2] intrinsic to generate a bfi instruction ---

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [flang] [mlir] [llvm] [openmp] [lldb] [mlir][Vector] Add patterns for efficient i4 -> i8 conversion emulation (PR #79494)

2024-01-26 Thread Diego Caballero via lldb-commits
dcaballe wrote: Thanks for the info! I think making the interleave op at Vector level available to fixed vectors would also make sense. There is a point in knowing that a shuffle is actually implementing an interleave pattern. I guess we should also be fine with this LLVM limitations for now:

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -0,0 +1,315 @@ +""" +This module implements a couple of utility classes to make writing +lldb parsed commands more Pythonic. +The way to use it is to make a class for you command that inherits from ParsedCommandBase. +That will make an LLDBOVParser which you will use for your

[Lldb-commits] [flang] [lldb] [clang] [libcxxabi] [libc] [llvm] [compiler-rt] [lld] [clang-tools-extra] [libcxx] [llvm] Set emulated-tls by default for x86_64-windows-gnu target (PR #79542)

2024-01-26 Thread via lldb-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79542 >From 1039a36b2891f72192e77f2ef96736b1ab4315d8 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Thu, 25 Jan 2024 21:47:43 -0500 Subject: [PATCH] [llvm] set emulated-tls by default for MinGW x86_64-windows-gnu

[Lldb-commits] [mlir] [lldb] [compiler-rt] [lld] [llvm] [libc] [clang-tools-extra] [clang] [libcxx] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-26 Thread via lldb-commits
https://github.com/trcrsired closed https://github.com/llvm/llvm-project/pull/77216 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/79662 >From 7fccec625677e8cabe8c69ac2651c37716dc30bf Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jan 2024 22:47:15 + Subject: [PATCH] [lldb] checks beforehand if lldb can trace/attach a process on

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; devnexen wrote: true https://github.com/llvm/llvm-project/pull/79662 ___

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, +

[Lldb-commits] [libcxx] [libunwind] [lldb] [clang] [llvm] [libc] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via lldb-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 39bc0171e7c07e367446dd1abdc56fd918013a9d Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears

[Lldb-commits] [lldb] [lldb] Remove obsolete signBinary helper (PR #79656)

2024-01-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me. https://github.com/llvm/llvm-project/pull/79656 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Alex Langford via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, +

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Alex Langford via lldb-commits
@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; bulbazord wrote: Suggestion: You can remove this and just return {} below. https://github.com/llvm/llvm-project/pull/79662

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc] [libcxx] [clang] [llvm] [libunwind] [libunwind] Fix build for wasm (PR #79667)

2024-01-26 Thread via lldb-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 39bc0171e7c07e367446dd1abdc56fd918013a9d Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8f1d94aaea5c18b83cd3b0df3be3a48ef1d3833d 3b490d6ef73c7ab3e8e1985a2cb25bb72a2c --

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/79533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/79533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData { GetAsStructuredData(const Event *event_ptr); uint64_t GetID() const { return m_id; } - bool IsFinite() const { return m_total != UINT64_MAX; } + bool IsFinite() const { return m_total != 1; }

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 9274bcd897cd3ecdb3a842bc72ee660ba335aa57 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/3] [lldb][progress][NFC] Add unit test for progress

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread via lldb-commits
jimingham wrote: This is fine because the stl_summary_flags has skip pointers and skip references false. This might be an observable change, because this formatter would have matched a reference to one of the types, but if the actual type was a pointer to a reference, etc, then we would also

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/79624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 80bfac4 - [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (#79624)

2024-01-26 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-26T15:18:43-08:00 New Revision: 80bfac4327b6fb94cb9bf44eeb0d032799b9d418 URL: https://github.com/llvm/llvm-project/commit/80bfac4327b6fb94cb9bf44eeb0d032799b9d418 DIFF:

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/79649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 33860b2 - [lldb] Streamline ConstString -> std::string conversion (NFC) (#79649)

2024-01-26 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-26T15:04:11-08:00 New Revision: 33860b2f61a8a74141ae76ecd54742f9cfeb0d03 URL: https://github.com/llvm/llvm-project/commit/33860b2f61a8a74141ae76ecd54742f9cfeb0d03 DIFF:

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/79662 >From 52618e6e6e028ea4a65728eda0c877dce176ccfa Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jan 2024 22:47:15 + Subject: [PATCH] [lldb] checks beforehand if lldb can trace/attach a process on

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e4afffbe8cc31278a9006712e7323d49eae9dbb6 492521e66288a497bf5b4a4a8ce554dffeb35727 --

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David CARLIER (devnexen) Changes before having the generic EINVAL message, we check if the `security.bsd.unprivileged_proc_debug` allows process debugging. close #79634 --- Full diff: https://github.com/llvm/llvm-project/pull/79662.diff

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
@@ -192,6 +198,9 @@ class ConstString { return llvm::StringRef(m_string, GetLength()); } + /// Get the string value as a std::string + std::string GetString() const { return std::string(m_string, GetLength()); } JDevlieghere wrote: It's not

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

2024-01-26 Thread David CARLIER via lldb-commits
https://github.com/devnexen created https://github.com/llvm/llvm-project/pull/79662 before having the generic EINVAL message, we check if the `security.bsd.unprivileged_proc_debug` allows process debugging. close #79634 >From 492521e66288a497bf5b4a4a8ce554dffeb35727 Mon Sep 17 00:00:00 2001

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/79649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -192,6 +198,9 @@ class ConstString { return llvm::StringRef(m_string, GetLength()); } + /// Get the string value as a std::string + std::string GetString() const { return std::string(m_string, GetLength()); } felipepiovezan wrote: why is this

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/79649 >From b0abae7ac1208321a4a7033bcc456dba645b47bf Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 26 Jan 2024 14:35:52 -0800 Subject: [PATCH] [lldb] Streamline ConstString -> std::string conversion

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/79644 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 074630e - [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (#79644)

2024-01-26 Thread via lldb-commits
Author: Dave Lee Date: 2024-01-26T14:28:39-08:00 New Revision: 074630e8af94d839f6baf6378d7ed3d7a6d2753c URL: https://github.com/llvm/llvm-project/commit/074630e8af94d839f6baf6378d7ed3d7a6d2753c DIFF: https://github.com/llvm/llvm-project/commit/074630e8af94d839f6baf6378d7ed3d7a6d2753c.diff

[Lldb-commits] [clang-tools-extra] [lldb] [openmp] [compiler-rt] [libclc] [flang] [mlir] [llvm] [libc] [libcxx] [lld] [clang] [libc++][memory] P1132R8: `out_ptr` - a scalable output pointer abstractio

2024-01-26 Thread Louis Dionne via lldb-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/73618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove obsolete signBinary helper (PR #79656)

2024-01-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes On Darwin, the Makefile already (ad-hoc) signs everything it builds. There's also no need to use lldb_codesign for this. --- Full diff: https://github.com/llvm/llvm-project/pull/79656.diff 8

[Lldb-commits] [lldb] [lldb] Remove obsolete signBinary helper (PR #79656)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/79656 On Darwin, the Makefile already (ad-hoc) signs everything it builds. There's also no need to use lldb_codesign for this. >From 80d68ab889989ddae906af3b2042158a12a0ca46 Mon Sep 17 00:00:00 2001 From: Jonas

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/79649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/79649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [mlir] [clang] [libcxxabi] [lld] [clang-tools-extra] [libc] [llvm] [flang] [lldb] [compiler-rt] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

2024-01-26 Thread Kai Sasaki via lldb-commits
https://github.com/Lewuathe updated https://github.com/llvm/llvm-project/pull/76316 >From a5810363e546da073543cb2d62cceb956c46b2e6 Mon Sep 17 00:00:00 2001 From: Kai Sasaki Date: Fri, 15 Dec 2023 15:53:54 +0900 Subject: [PATCH 1/2] [mlir][complex] Prevent underflow in complex.abs ---

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,105 @@ +#include "Plugins/Platform/MacOSX/PlatformMacOSX.h" +#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Progress.h" +#include "lldb/Host/FileSystem.h" +#include "lldb/Host/HostInfo.h" +#include

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 84be954cb26ebde58d4ddd2255dfd99904d9ae1b fd1938e02a4e0394190d90792933e81fce7fc329 --

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Make it easier to go from a ConstString to a std::string without having to go through a C-String or a llvm::StringRef. I made the conversion operator explicit as this is a relatively expensive

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
@@ -776,6 +776,10 @@ std::optional SymbolLocatorDebugSymbols::LocateExecutableSymbolFile( exec_fspec ? exec_fspec->GetFilename().AsCString("") : "", arch ? arch->GetArchitectureName() : "", (const void *)uuid); + Progress progress( + "Locating external

[Lldb-commits] [lldb] [lldb] Streamline ConstString -> std::string conversion (NFC) (PR #79649)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/79649 Make it easier to go from a ConstString to a std::string without having to go through a C-String or a llvm::StringRef. I made the conversion operator explicit as this is a relatively expensive operations

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [lld] [libc] [libunwind] [clang-tools-extra] [compiler-rt] [lldb] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

2024-01-26 Thread Hristo Hristov via lldb-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/79032 >From e03452fda84a5284420bba1913299b68caabb6cd Mon Sep 17 00:00:00 2001 From: Zingam Date: Mon, 22 Jan 2024 20:35:00 +0200 Subject: [PATCH 1/6] Revert "Revert "[libc++][format] P2637R3: Member `visit`

[Lldb-commits] [llvm] [lld] [mlir] [clang-tools-extra] [lldb] [libcxx] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: None (srcarroll) Changes As far as I am aware, there is no simple way to match on elementwise ops. I propose to add an `elementwise` criteria to the `match.structured.body` op. Although my only hesitation is that elementwise is not only

[Lldb-commits] [llvm] [lld] [mlir] [clang-tools-extra] [lldb] [libcxx] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll ready_for_review https://github.com/llvm/llvm-project/pull/79626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body ---

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll edited https://github.com/llvm/llvm-project/pull/79626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body ---

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/79624 >From 7979269a57fc553a7b010a36b9c75bf570adf674 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 26 Jan 2024 09:34:11 -0800 Subject: [PATCH 1/2] [lldb] Fix progress reporting for

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/79644 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/2] Add elementwise criteria to match.structured.body ---

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79644 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH] Add elementwise criteria to match.structured.body ---

[Lldb-commits] [mlir] [clang] [llvm] [libcxx] [lld] [clang-tools-extra] [lldb] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread lorenzo chelini via lldb-commits
chelini wrote: Is it ready for review? Is marked as "draft". https://github.com/llvm/llvm-project/pull/79626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -831,6 +831,37 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject( return true; } +bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallParsedCommandObject( +PyObject *implementor, lldb::DebuggerSP debugger,

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread Dave Lee via lldb-commits
kastiglione wrote: Because of clang-format, the diff obscures the fact that this change only deletes `(( )?&)?` from these strings. There are no other changes. https://github.com/llvm/llvm-project/pull/79644 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes The `(( )?)?` appears to match types which are references. However lldb can load the correct data formatters without having to pattern match against a `` suffix. The suffix may have been needed at one

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Adrian Prantl via lldb-commits
@@ -1050,28 +1054,25 @@ bool SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile( const std::string file_path_str = file_spec_ptr ? file_spec_ptr->GetPath() : ""; - Log *log = GetLog(LLDBLog::Host); + if (uuid_str.empty() && file_path_str.empty()) +return

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Adrian Prantl via lldb-commits
@@ -776,6 +776,10 @@ std::optional SymbolLocatorDebugSymbols::LocateExecutableSymbolFile( exec_fspec ? exec_fspec->GetFilename().AsCString("") : "", arch ? arch->GetArchitectureName() : "", (const void *)uuid); + Progress progress( + "Locating external

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/79624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/79624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unnecessary suffix from libc++ type name patterns (NFC) (PR #79644)

2024-01-26 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/79644 The `(( )?&)?` appears to match types which are references. However lldb can load the correct data formatters without having to pattern match against a `&` suffix. The suffix may have been needed at one

[Lldb-commits] [flang] [lldb] [lld] [clang-tools-extra] [libunwind] [llvm] [mlir] [compiler-rt] [libcxx] [clang] [libc] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

2024-01-26 Thread Hristo Hristov via lldb-commits
Zingam wrote: @petrhosek According to the log, the tests in this patch pass. Could you please try again. I'll wait a while and if there is not negative feedback I'll reland the patch. >

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
@@ -776,6 +776,10 @@ std::optional SymbolLocatorDebugSymbols::LocateExecutableSymbolFile( exec_fspec ? exec_fspec->GetFilename().AsCString("") : "", arch ? arch->GetArchitectureName() : "", (const void *)uuid); + Progress progress( + "Locating external

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -831,6 +831,37 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject( return true; } +bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallParsedCommandObject( +PyObject *implementor, lldb::DebuggerSP debugger,

[Lldb-commits] [lldb] [lldb] Fix progress reporting for SymbolLocatorDebugSymbols (PR #79624)

2024-01-26 Thread Greg Clayton via lldb-commits
@@ -776,6 +776,10 @@ std::optional SymbolLocatorDebugSymbols::LocateExecutableSymbolFile( exec_fspec ? exec_fspec->GetFilename().AsCString("") : "", arch ? arch->GetArchitectureName() : "", (const void *)uuid); + Progress progress( + "Locating external

[Lldb-commits] [flang] [lldb] [lld] [clang-tools-extra] [libunwind] [llvm] [mlir] [compiler-rt] [libcxx] [clang] [libc] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

2024-01-26 Thread Hristo Hristov via lldb-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/79032 >From e03452fda84a5284420bba1913299b68caabb6cd Mon Sep 17 00:00:00 2001 From: Zingam Date: Mon, 22 Jan 2024 20:35:00 +0200 Subject: [PATCH 1/6] Revert "Revert "[libc++][format] P2637R3: Member `visit`

[Lldb-commits] [clang] [libcxx] [flang] [lld] [libunwind] [libc] [compiler-rt] [lldb] [clang-tools-extra] [llvm] [mlir] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

2024-01-26 Thread Hristo Hristov via lldb-commits
Zingam wrote: @petrhosek It is not related. It was supposedly fixed by this: https://github.com/llvm/llvm-project/pull/79619 I've been observing the chromium Windows CI failing for a while. Let's see if the above patch fixes it. I'll rebase now this one now.

[Lldb-commits] [lldb] [lldb] Fix a crash when using .dwp files and make type lookup reliable with the index cache (PR #79544)

2024-01-26 Thread Greg Clayton via lldb-commits
clayborg wrote: > I'm not following all of this, but it appears to be based on the premise that > it's OK that sometimes split units inside a DWP file are parsed before their > skeleton unit? Why is that OK/when/why/where is that happening? When we have accelerator tables from lldb index

[Lldb-commits] [libc] [llvm] [clang-tools-extra] [flang] [libunwind] [lld] [lldb] [mlir] [libcxx] [compiler-rt] [clang] Reland: [libc++][format] P2637R3: Member visit (std::basic_format_arg) #76449 (P

2024-01-26 Thread Petr Hosek via lldb-commits
petrhosek wrote: I tried this branch on our Windows builders although I'm not sure if it's related or not to this patch: ``` # COMPILED WITH C:/b/s/w/ir/x/w/llvm_build/./bin/clang-cl.exe C:\b\s\w\ir\x\w\github-H-G-Hristov-llvm-project\libcxx\test\libcxx\fuzzing\random.pass.cpp

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -831,6 +831,37 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject( return true; } +bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallParsedCommandObject( +PyObject *implementor, lldb::DebuggerSP debugger,

[Lldb-commits] [clang-tools-extra] [libcxx] [clang] [lld] [lldb] [llvm] [mlir] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-26 Thread via lldb-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH] Add elementwise criteria to match.structured.body ---

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,105 @@ +#include "Plugins/Platform/MacOSX/PlatformMacOSX.h" +#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Progress.h" +#include "lldb/Host/FileSystem.h" +#include "lldb/Host/HostInfo.h" +#include

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,105 @@ +#include "Plugins/Platform/MacOSX/PlatformMacOSX.h" +#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Progress.h" +#include "lldb/Host/FileSystem.h" +#include "lldb/Host/HostInfo.h" +#include

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,105 @@ +#include "Plugins/Platform/MacOSX/PlatformMacOSX.h" +#include "Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Progress.h" +#include "lldb/Host/FileSystem.h" +#include "lldb/Host/HostInfo.h" +#include

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: It is great to have unit tests for this. I remember with your previous patch we caught an issue where the completed event might not be delivered, or it would be delivered without the values being set correctly, so this will be great to be able to catch

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/79533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2024-01-26 Thread via lldb-commits
@@ -831,6 +831,37 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommandObject( return true; } +bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallParsedCommandObject( +PyObject *implementor, lldb::DebuggerSP debugger,

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 9274bcd897cd3ecdb3a842bc72ee660ba335aa57 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/2] [lldb][progress][NFC] Add unit test for progress

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > This is only testing the `Progress` class constructor behavior. Could you > check that the `Progress::Increment` method works as expected ? While it would be nice to have full test coverage, the goal was to cover the existing behavior which we'll modify/extend to

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,105 @@ +#include "Plugins/Platform/MacOSX/PlatformMacOSX.h" chelcassanova wrote: Will do! I told myself I'd add it at the end then I fully forgot to do that  https://github.com/llvm/llvm-project/pull/79533

[Lldb-commits] [lldb] 02d3a79 - [lldb][NFCI] Remove EventData* parameter from BroadcastEventIfUnique (#79045)

2024-01-26 Thread via lldb-commits
Author: Alex Langford Date: 2024-01-26T10:40:33-08:00 New Revision: 02d3a799e7eb2997950d6a288a08a5e51ff0ff59 URL: https://github.com/llvm/llvm-project/commit/02d3a799e7eb2997950d6a288a08a5e51ff0ff59 DIFF: https://github.com/llvm/llvm-project/commit/02d3a799e7eb2997950d6a288a08a5e51ff0ff59.diff

  1   2   >