https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/81067
>From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 7 Feb 2024 16:43:50 -0800
Subject: [PATCH 1/4] Add more ways to find the .dwp file.
When using split DWARF
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c13e271a38363d354294e2af1651470bed8facb3
9d58f41457fc2c9e54b1409c64f3028fdaededf1 --
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/81067
>From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 7 Feb 2024 16:43:50 -0800
Subject: [PATCH 1/3] Add more ways to find the .dwp file.
When using split DWARF
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/81067
>From 3c2f6039cf0e253d78b5193098b311028daaea72 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 7 Feb 2024 16:43:50 -0800
Subject: [PATCH 1/2] Add more ways to find the .dwp file.
When using split DWARF
clayborg wrote:
> FWIW, I think we should be opinionated (& consistent with whatever gdb does,
> if it has some precedent here - if it is less opinionated, then maybe we have
> to be accepting) when it comes to whether x.debug goes with x.dwp or
> x.debug.dwp - we shouldn't support both
dwblaikie wrote:
> If the DWO ID is just a hash of the file path or something that isn't
> guaranteed to be unique with each new build, then we need the UUID in the
> .dwp file.
Nah, the DWO ID, as per spec, is a semantic hash of the DWARF contents. It
should change, generally, if any part
clayborg wrote:
> > > Will this now work with .dwp files not having UUID?
> >
> >
> > No. If binairies have UUIDs (GNU build IDs), they need to match right now.
> > That is larger fix that involves adding a "enum UUIDFlavor" to the UUIDs so
> > we can ensure we aren't comparing two different
jimingham wrote:
The way the current FormatEntity strings work, the first `%` says "formatter
coming next" then say `S` is "the kind of formatter" (in this case "return
summary instead of value". So in your case, like:
${var%%1x}
The "kind of formatter" is "%" which seems like a
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kastiglione wrote:
Note that the implementation here is a draft for illustration. I am first
interested in high level agreement that allowing custom printf formatting of
variables is good.
https://github.com/llvm/llvm-project/pull/81196
___
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81196.diff
1 Files Affected:
- (modified) lldb/source/Core/FormatEntity.cpp (+23-2)
``diff
diff --git
https://github.com/kastiglione converted_to_draft
https://github.com/llvm/llvm-project/pull/81196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/81196
None
>From 81a2034ff2b41e30a1f5b82c86b4d5d4c429ed52 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 8 Feb 2024 13:59:12 -0800
Subject: [PATCH] [lldb] Support custom printf formatting for variables
---
@@ -12,6 +12,7 @@
#include "lldb/Utility/ConstString.h"
#include "lldb/lldb-types.h"
#include
+#include
chelcassanova wrote:
I shouldn't need a sorted map so I'll go with StringMap for the updated patch
with the class that will handle the progress report
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
@@ -12,6 +12,7 @@
#include "lldb/Utility/ConstString.h"
#include "lldb/lldb-types.h"
#include
+#include
adrian-prantl wrote:
Unless you need the sorted iteration property you probably want to use
something more efficient instead.
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
Author: Jonas Devlieghere
Date: 2024-02-08T12:39:04-08:00
New Revision: 5f4b40c90a51248b097de7b5bc89c6976d4c3298
URL:
https://github.com/llvm/llvm-project/commit/5f4b40c90a51248b097de7b5bc89c6976d4c3298
DIFF:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Reverts llvm/llvm-project#80890
---
Full diff: https://github.com/llvm/llvm-project/pull/81182.diff
6 Files Affected:
- (modified) lldb/include/lldb/Core/ModuleList.h (+1-22)
- (modified)
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/81182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-08T11:50:53-08:00
New Revision: 705fcd4e0addee6e9e13541dbcbc81cec9748a83
URL:
https://github.com/llvm/llvm-project/commit/705fcd4e0addee6e9e13541dbcbc81cec9748a83
DIFF:
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/81182
Reverts llvm/llvm-project#80890
>From 63b2f16bdf812613d368304be453a44c2a1f8fe3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 8 Feb 2024 11:50:28 -0800
Subject: [PATCH] Revert "[lldb] Expand
nico wrote:
This doesn't build on Linux: http://45.33.8.238/linux/130329/step_4.txt
Please take a look and revert for now if it takes a while to fix.
(Looks like you added a definition on non apple; maybe the declaration is just
still missing)
https://github.com/llvm/llvm-project/pull/80890
felipepiovezan wrote:
Any other comments here? I would like to land this once the YAML review is
unblocked
https://github.com/llvm/llvm-project/pull/79932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-02-08T11:24:07-08:00
New Revision: 74fc16227b84e22706d2c5e376287f560b9e
URL:
https://github.com/llvm/llvm-project/commit/74fc16227b84e22706d2c5e376287f560b9e
DIFF:
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> @clayborg The idea behind the feature is to get symbols for things that are
> relevant to the user. Right now, that's only hooked up for images that appear
> in the stack trace, but there are certainly other places this would be
> useful. So yeah, I absolutely expect this to
JDevlieghere wrote:
Rebased & renamed the property to `symbols.auto-download`. I think all the
review comments have been addressed. The only oustanding question is if
@clayborg wants to have an additional setting for
`symbols.auto-download-stack-symbols`.
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/80890
>From 8846fb6cdb83b0364238bd74a99e97c1dba604a2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 Feb 2024 16:25:37 -0800
Subject: [PATCH] [lldb] Expand background symbol lookup
LLDB has a
clayborg wrote:
> The discussions happening here are talking about 2 major things, how to do
> the bookkeeping of the map that keeps track of progress reports and where to
> do that bookkeeping. I think it makes sense to split up this work into
> smaller patches as such:
>
> 1. Since it's
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-02-08T10:33:37-08:00
New Revision: ab4a793e8bc78f50f9f104c9c732e2dd91bf70a2
URL:
https://github.com/llvm/llvm-project/commit/ab4a793e8bc78f50f9f104c9c732e2dd91bf70a2
DIFF:
https://github.com/JDevlieghere approved this pull request.
This doesn't do much by itself but based on the discussion in #81026 we have
consensus on this part. LGTM.
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit adds a new broadcast bit to the debugger. When in use, it will be
listened to for progress events that will be delivered and kept track of by
category as opposed to the current
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/81169
This commit adds a new broadcast bit to the debugger. When in use, it will be
listened to for progress events that will be delivered and kept track of by
category as opposed to the current behaviour of
chelcassanova wrote:
The discussions happening here are talking about 2 major things, how to do the
bookkeeping of the map that keeps track of progress reports and where to do
that bookkeeping. I think it makes sense to split up this work into smaller
patches as such:
1. Since it's best to
dwblaikie wrote:
FWIW, I think we should be opinionated (& consistent with whatever gdb does, if
it has some precedent here - if it is less opinionated, then maybe we have to
be accepting) when it comes to whether x.debug goes with x.dwp or x.debug.dwp -
we shouldn't support both unless
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/81018
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-02-08T09:32:12-08:00
New Revision: af97edff70b0d9cb89729dc0d8af1d1ea101686e
URL:
https://github.com/llvm/llvm-project/commit/af97edff70b0d9cb89729dc0d8af1d1ea101686e
DIFF:
https://github.com/llvm/llvm-project/commit/af97edff70b0d9cb89729dc0d8af1d1ea101686e.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/81078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-02-08T09:16:12-08:00
New Revision: f219cda7bd43696792ca4668ca5a9fbf55a9f09f
URL:
https://github.com/llvm/llvm-project/commit/f219cda7bd43696792ca4668ca5a9fbf55a9f09f
DIFF:
https://github.com/llvm/llvm-project/commit/f219cda7bd43696792ca4668ca5a9fbf55a9f09f.diff
Author: Adrian Prantl
Date: 2024-02-08T09:03:47-08:00
New Revision: 750981f1a2c6069cded709b75cc87d7abd05277a
URL:
https://github.com/llvm/llvm-project/commit/750981f1a2c6069cded709b75cc87d7abd05277a
DIFF:
https://github.com/llvm/llvm-project/commit/750981f1a2c6069cded709b75cc87d7abd05277a.diff
https://github.com/adrian-prantl approved this pull request.
If we switched to a streamstring or a raw_svector_ostream we could avoid having
to deal with the printf specifiers altogether...
https://github.com/llvm/llvm-project/pull/81078
___
@@ -69,6 +83,19 @@
// RUN: -o "statistics dump" \
// RUN: %t.dwarf4 -b | FileCheck %s -check-prefix=CACHED
+// Make sure that if we load the "%t.dwarf4.debug" file, that we can find and
+// load the .dwo file from the .dwp when it is "%t.dwarf4.dwp"
+// RUN: %lldb
@@ -4349,26 +4349,53 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr ::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+// Create a list of files to try and append .dwp to
@@ -4349,26 +4349,53 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr ::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+// Create a list of files to try and append .dwp to
+FileSpecList symfiles;
+
@@ -4349,26 +4349,53 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr ::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+// Create a list of files to try and append .dwp to
+FileSpecList symfiles;
+
@@ -118,7 +118,13 @@ SymbolVendorMacOSX::CreateInstance(const lldb::ModuleSP
_sp,
FileSpec dsym_fspec(module_sp->GetSymbolFileFileSpec());
ObjectFileSP dsym_objfile_sp;
-if (!dsym_fspec) {
+// On Darwin, we store the debug information either in object files,
@@ -118,7 +118,13 @@ SymbolVendorMacOSX::CreateInstance(const lldb::ModuleSP
_sp,
FileSpec dsym_fspec(module_sp->GetSymbolFileFileSpec());
ObjectFileSP dsym_objfile_sp;
-if (!dsym_fspec) {
+// On Darwin, we store the debug information either in object files,
chelcassanova wrote:
I'll start with this by changing this so that bookkeeping is done with the new
bit instead of being done in the constructor for `Progress`.
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/80609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,140 @@
+//===-- LibCxxValarray.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/80167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-02-08T11:09:45Z
New Revision: d7fb94b6daa643a764e9a756bc544f26c248dafd
URL:
https://github.com/llvm/llvm-project/commit/d7fb94b6daa643a764e9a756bc544f26c248dafd
DIFF:
https://github.com/llvm/llvm-project/commit/d7fb94b6daa643a764e9a756bc544f26c248dafd.diff
LOG:
60 matches
Mail list logo
