[Lldb-commits] [lldb] [lldb] [debugserver] Handle interrupted reads correctly (PR #84872)

2024-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The first half of this patch is a long-standing annoyance, if I attach to debugserver with lldb while it is waiting for an lldb connection, the syscall is interrupted and it doesn't retry, debugserver

[Lldb-commits] [lldb] [lldb] [debugserver] Handle interrupted reads correctly (PR #84872)

2024-03-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/84872 The first half of this patch is a long-standing annoyance, if I attach to debugserver with lldb while it is waiting for an lldb connection, the syscall is interrupted and it doesn't retry, debugserver

[Lldb-commits] [lldb] [lldb] Fix build break on windows (PR #84863)

2024-03-11 Thread Luke Weiler via lldb-commits
https://github.com/lwmaia edited https://github.com/llvm/llvm-project/pull/84863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix build break on windows (PR #84863)

2024-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Luke Weiler (lwmaia) Changes This is a one line fix for a Windows specific (I believe) build break. The build failure looks like this: `D:\a\_work\1\s\lldb\source\Symbol\Symtab.cpp(128): error C2440: 'function-style-cast': cannot convert

[Lldb-commits] [lldb] Fix build break on windows (PR #84863)

2024-03-11 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[Lldb-commits] [lldb] Fix build break on windows (PR #84863)

2024-03-11 Thread Luke Weiler via lldb-commits
https://github.com/lwmaia created https://github.com/llvm/llvm-project/pull/84863 This is a one line fix for a Windows specific (I believe) build break. The build failure looks like this: `D:\a\_work\1\s\lldb\source\Symbol\Symtab.cpp(128): error C2440: '': cannot convert from

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/84860 >From b5e04eb49c89c8c654305c6ba5db5e2f237bccec Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 11 Mar 2024 11:23:59 -0700 Subject: [PATCH 1/2] [lldb][test] Add `pexpect` category for tests that

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
@@ -914,6 +914,25 @@ def checkForkVForkSupport(): configuration.skip_categories.append("fork") +def checkPexpectSupport(): +from lldbsuite.test import lldbplatformutil + +platform = lldbplatformutil.getPlatform() + +# llvm.org/pr22274: need a pexpect

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2a3f27cce8983e5d6871b9ebb8f5e9dd91884f0c...b5e04eb49c89c8c654305c6ba5db5e2f237bccec

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes Instead of directly annotating pexpect-based tests with `@skipIfWindows`, we can tag them with a new `pexpect` category. We still automatically skip windows behavior by adding `pexpect` to the skip

[Lldb-commits] [lldb] [lldb][test] Add `pexpect` category for tests that `import pexpect` (PR #84860)

2024-03-11 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/84860 Instead of directly annotating pexpect-based tests with `@skipIfWindows`, we can tag them with a new `pexpect` category. We still automatically skip windows behavior by adding `pexpect` to the skip category

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,164 @@ +//===-- AlarmTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,164 @@ +//===-- AlarmTest.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Chelsea Cassanova via lldb-commits
@@ -210,3 +211,37 @@ TEST_F(ProgressReportTest, TestOverlappingEvents) { // initial report. EXPECT_EQ(data->GetID(), expected_progress_id); } + +TEST_F(ProgressReportTest, TestProgressManagerDisjointReports) { + ListenerSP listener_sp = +

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,88 @@ +//===-- Alarm.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/84854 >From 3aae84b8caaf904c11b1dab620893620a0fa1c85 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 5 Mar 2024 22:57:43 -0800 Subject: [PATCH 1/2] [lldb] Add an Alarm class Add an Alarm class which

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This implements coalescing of progress events using a timeout, as discussed in the RFC on Discourse [1]. This PR consists of two commits which, depending on the feedback, I may split up into two

[Lldb-commits] [lldb] [lldb] Implement coalescing of disjoint progress events (PR #84854)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/84854 This implements coalescing of progress events using a timeout, as discussed in the RFC on Discourse [1]. This PR consists of two commits which, depending on the feedback, I may split up into two PRs. For

[Lldb-commits] [lldb] Make ValueObject::Cast work for casts from smaller to larger structs in the cases where this currently can work. (PR #84588)

2024-03-11 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/84588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3707c54 - Make ValueObject::Cast work for casts from smaller to larger structs in the cases where this currently can work. (#84588)

2024-03-11 Thread via lldb-commits
Author: jimingham Date: 2024-03-11T14:13:37-07:00 New Revision: 3707c540d23a5684a1c37b0f7e41c1d8ed7f1f8a URL: https://github.com/llvm/llvm-project/commit/3707c540d23a5684a1c37b0f7e41c1d8ed7f1f8a DIFF: https://github.com/llvm/llvm-project/commit/3707c540d23a5684a1c37b0f7e41c1d8ed7f1f8a.diff

[Lldb-commits] [lldb] Report back errors in GetNumChildren() (PR #84265)

2024-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/84265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6462ead - Report back errors in GetNumChildren() (#84265)

2024-03-11 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-03-11T13:04:56-07:00 New Revision: 6462eadbd316aed1b1074ed73bcaf1698886bba1 URL: https://github.com/llvm/llvm-project/commit/6462eadbd316aed1b1074ed73bcaf1698886bba1 DIFF: https://github.com/llvm/llvm-project/commit/6462eadbd316aed1b1074ed73bcaf1698886bba1.diff

[Lldb-commits] [lldb] Report back errors in GetNumChildren() (PR #84265)

2024-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/84265 >From 18812772780abee17dd106e0e8f8c78ab8d4dbf1 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 8 Mar 2024 14:46:13 -0800 Subject: [PATCH] Report back errors in GetNumChildren() This is a

[Lldb-commits] [lldb] Turn off instruction flow control annotations by default (PR #84607)

2024-03-11 Thread via lldb-commits
PiJoules wrote: Hi, I suspect this led to the test failure we're seeing at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8753741062398610017/overview. ``` Script: -- /b/s/w/ir/x/w/lldb_install/python3/bin/python3

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/84583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 08a9207 - [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (#84583)

2024-03-11 Thread via lldb-commits
Author: Usama Hameed Date: 2024-03-11T11:57:53-07:00 New Revision: 08a9207f947b8b022d70f8ee7eeeda7acc6aac76 URL: https://github.com/llvm/llvm-project/commit/08a9207f947b8b022d70f8ee7eeeda7acc6aac76 DIFF: https://github.com/llvm/llvm-project/commit/08a9207f947b8b022d70f8ee7eeeda7acc6aac76.diff

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/84583 >From 3b16e506778ce0a869e19b41d13836b4c3cf26ca Mon Sep 17 00:00:00 2001 From: usama Date: Mon, 11 Mar 2024 11:39:24 -0700 Subject: [PATCH] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report`

[Lldb-commits] [lldb] Turn off instruction flow control annotations by default (PR #84607)

2024-03-11 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/84607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bdbad0d - Turn off instruction flow control annotations by default (#84607)

2024-03-11 Thread via lldb-commits
Author: Jason Molenda Date: 2024-03-11T10:21:07-07:00 New Revision: bdbad0d07bb600301cb324e87a6be37ca4af591a URL: https://github.com/llvm/llvm-project/commit/bdbad0d07bb600301cb324e87a6be37ca4af591a DIFF: https://github.com/llvm/llvm-project/commit/bdbad0d07bb600301cb324e87a6be37ca4af591a.diff

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread Daniil Kovalev via lldb-commits
kovdan01 wrote: > As this plugin seems related to backtrace perhaps the test should at least > run `bt` and check for the first line of the output. I had similar thoughts, but I'm not sure if placing the test in `lldb/test/Shell/Commands` as `command-backtrace-missing-x86.test` is a nice

[Lldb-commits] [lldb] Turn off instruction flow control annotations by default (PR #84607)

2024-03-11 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/84607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread Daniil Kovalev via lldb-commits
@@ -0,0 +1,10 @@ +# UNSUPPORTED: x86 kovdan01 wrote: Yes, I've checked that with `X86` in `LLVM_TARGETS_TO_BUILD`, the test becomes unsupported. So, it looks like it's currently OK https://github.com/llvm/llvm-project/pull/82603

[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)

2024-03-11 Thread via lldb-commits
github-actions[bot] wrote: @karzanWang Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/84154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 501bc10 - [lldb] Save the edited line before clearing it in Editline::PrintAsync (#84154)

2024-03-11 Thread via lldb-commits
Author: karzan Date: 2024-03-11T10:07:12-07:00 New Revision: 501bc101c04675969ab673b247f2a58fa72bd09e URL: https://github.com/llvm/llvm-project/commit/501bc101c04675969ab673b247f2a58fa72bd09e DIFF: https://github.com/llvm/llvm-project/commit/501bc101c04675969ab673b247f2a58fa72bd09e.diff LOG:

[Lldb-commits] [lldb] [lldb] Save the edited line before clearing it in Editline::PrintAsync (PR #84154)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Coincidentally, I ran into the same issue a few weeks ago when I was messing around with a different way of displaying the progress reports. LGTM! https://github.com/llvm/llvm-project/pull/84154

[Lldb-commits] [lldb] Report back errors in GetNumChildren() (PR #84265)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/84265 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make ValueObject::Cast work for casts from smaller to larger structs in the cases where this currently can work. (PR #84588)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/84588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][doc] Updates build instructions. (PR #84630)

2024-03-11 Thread Mark de Wever via lldb-commits
mordante wrote: > Looks good. I see the PR test for "Test documentation build" is failing, but > that's an issue with the bot and pexpect. Is this a known issue and is somebody already working on fixing this? https://github.com/llvm/llvm-project/pull/84630

[Lldb-commits] [lldb] Turn off instruction flow control annotations by default (PR #84607)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/84607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/84583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][doc] Updates build instructions. (PR #84630)

2024-03-11 Thread Mark de Wever via lldb-commits
https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/84630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9a9aa41 - [LLDB][doc] Updates build instructions. (#84630)

2024-03-11 Thread via lldb-commits
Author: Mark de Wever Date: 2024-03-11T17:45:48+01:00 New Revision: 9a9aa41dea83039154601082b1aa2c56e35a5a17 URL: https://github.com/llvm/llvm-project/commit/9a9aa41dea83039154601082b1aa2c56e35a5a17 DIFF: https://github.com/llvm/llvm-project/commit/9a9aa41dea83039154601082b1aa2c56e35a5a17.diff

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,10 @@ +# UNSUPPORTED: x86 DavidSpickett wrote: Actually, I'm wrong. We get the configured targets from llvm-config and I think that adds "X86" as a feature, target- is about what the default triple of llvm is.

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,10 @@ +# UNSUPPORTED: x86 DavidSpickett wrote: This should be: ``` UNSUPPORTED: target-x86_64 ``` Which I'm pretty sure is lldb's equivalent of `x86-registered-target`. Which is whether the lldb has that target built into it, vs. whether it's running

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread David Spickett via lldb-commits
DavidSpickett wrote: The spirit of the test is fine but I think we can avoid adding another core file. As this plugin seems related to backtrace perhaps the test should at least run `bt` and check for the first line of the output. Which means we can justify putting the test in

[Lldb-commits] [lldb] [lldb] Fix nullptr dereference on running x86 binary with x86-disabled llvm (PR #82603)

2024-03-11 Thread Daniil Kovalev via lldb-commits
kovdan01 wrote: > Can this code be hit when using an x86 core file? Then you could write a > shell test thatis `UNSUPPORTED: x86-registered-target` (whatever the proper > syntax is) and assert that it does not crash. @DavidSpickett The issue is present when loading an x86 core files via `lldb

[Lldb-commits] [lldb] e77f5fe - [lldb][Docs] Add libxml2 to apt install command

2024-03-11 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-03-11T11:41:56Z New Revision: e77f5fe889909df3508fd929f2636a0ac211877a URL: https://github.com/llvm/llvm-project/commit/e77f5fe889909df3508fd929f2636a0ac211877a DIFF: https://github.com/llvm/llvm-project/commit/e77f5fe889909df3508fd929f2636a0ac211877a.diff