compnerd wrote:
Philosophically, I agree with this change. Enshrining the information about the
line endings into the SCM tool makes sense.
I think that the concern that I have is that do we have sufficient testing for
supporting line-ending dependent behaviour in the compiler? Additionally,
kevinfrei wrote:
> I have such a system and have dug into the DebugInfoD "space" recently and
> would be more than willing (eager, even) to help! If you are on the Discord
> server, we can message and find a way to collaborate (I am hawkinsw).
Just joined. I can sort of use Discord (I mentor
https://github.com/bulbazord requested changes to this pull request.
Could you add a test for these new methods in
`unittests/Utility/ScalarTest.cpp`?
https://github.com/llvm/llvm-project/pull/86862
___
lldb-commits mailing list
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-27T16:37:00-07:00
New Revision: b76fd1eddbafaa02a533245d574048c5ad9e38fa
URL:
https://github.com/llvm/llvm-project/commit/b76fd1eddbafaa02a533245d574048c5ad9e38fa
DIFF:
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/86888
>From 793f6332ddf9059d999a7236770363e226ef8dd4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 27 Mar 2024 16:05:21 -0700
Subject: [PATCH] [lldb] Avoid deadlock by unlocking before invoking
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Avoid deadlocks in the Alarm class by releasing the lock before invoking
callbacks. This deadlock manifested itself in the ProgressManager:
1. On the main thread, the ProgressManager acquires its
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/86888
Avoid deadlocks in the Alarm class by releasing the lock before invoking
callbacks. This deadlock manifested itself in the ProgressManager:
1. On the main thread, the ProgressManager acquires its lock in
https://github.com/JDevlieghere ready_for_review
https://github.com/llvm/llvm-project/pull/86888
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -101,7 +101,7 @@ def extract_result_types(comment):
def strip_doxygen(comment):
-"""Returns the given comment without \-escaped words."""
+"""Returns the given comment without \\-escaped words."""
ellishg wrote:
I see lots of changes to comment
jimingham wrote:
> @jimingham, thanks for detailed comment.
>
> "Step in targets" or "Step Into Specific" is an IDE feature that works in two
> steps:
>
> 1. Show a list of call sites before stepping to allow users specify which
> call to step into
> 2. Perform step into with user choosing
jeffreytan81 wrote:
@jimingham, thanks for detailed comment.
"Step in targets" or "Step Into Specific" is an IDE feature that works in two
steps:
1. Show a list of call sites before stepping to allow users specify which call
to step into
2. Perform step into with user choosing call site
@@ -3180,14 +3180,153 @@ void request_stepIn(const llvm::json::Object )
{
llvm::json::Object response;
FillResponse(request, response);
auto arguments = request.getObject("arguments");
+
+ std::string step_in_target;
+ uint64_t target_id = GetUnsigned(arguments,
@@ -29,6 +29,9 @@ class LLDB_API SBLineEntry {
lldb::SBAddress GetEndAddress() const;
+ lldb::SBAddress
+ GetSameLineContiguousAddressRangeEnd(bool include_inlined_functions) const;
+
jeffreytan81 wrote:
@clayborg, right, I know I can do that but I did
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-03-27T13:59:35-07:00
New Revision: c7d947f5e6c966bdba4db26097c3b433fcbe7841
URL:
https://github.com/llvm/llvm-project/commit/c7d947f5e6c966bdba4db26097c3b433fcbe7841
DIFF:
https://github.com/llvm/llvm-project/commit/c7d947f5e6c966bdba4db26097c3b433fcbe7841.diff
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/86862
>From 03ef6db02f49ab4cc4f63b32553015b4f3801b5b Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Wed, 27 Mar 2024 10:09:45 -0700
Subject: [PATCH 1/2] [LLDB] Add APFloat helper functions to Scalar class.
This
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dcd0f2b6103072b74b446c2d1e9ecec60001a28c
03ef6db02f49ab4cc4f63b32553015b4f3801b5b --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
This adds the ability to create a Scalar from an APFloat, and to create an
APFloat from an APSInt or another APFloat.
---
Full diff: https://github.com/llvm/llvm-project/pull/86862.diff
2 Files Affected:
-
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/86862
This adds the ability to create a Scalar from an APFloat, and to create an
APFloat from an APSInt or another APFloat.
>From 03ef6db02f49ab4cc4f63b32553015b4f3801b5b Mon Sep 17 00:00:00 2001
From: Caroline Tice
https://github.com/kastiglione commented:
lldb/package looks good, thanks.
lldb/examples I trust
lldb/test I or someone else will look at soon.
https://github.com/llvm/llvm-project/pull/86806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -1517,7 +1517,7 @@ def buildLibrary(self, sources, lib_name):
"DYLIB_NAME": lib_name,
"CFLAGS_EXTRAS": "%s -I%s "
% (stdflag, os.path.join(os.environ["LLDB_SRC"], "include")),
-"LD_EXTRAS": "-shared
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/86806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/86772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/86772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AngryLoki wrote:
But automatic replacement is not possible, because `"\n" != r"\n"`. But I
checked carefully that all changed places with `\n` and `\t` are regexps, and
in regexps it is semantically the same.
```
>>> '\n' in 'test \n test'
True
>>> r'\n' in
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/86605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3154,7 +3154,7 @@
AppleObjCRuntimeV2::TaggedPointerVendorExtended::GetClassDescriptor(
<< m_objc_debug_taggedpointer_ext_payload_lshift)
>>
m_objc_debug_taggedpointer_ext_payload_rshift);
int64_t
fmayer wrote:
LGTM, verified the two strings are the same
```
>>> r"^(.*) \(in (.*)\) \((.*:\d*)\)$" == "^(.*) \(in (.*)\) \((.*:\d*)\)$"
True
>>> "^( *#([0-9]+) *)(0x[0-9a-f]+) *(?:in *.+)? *\((.*)\+(0x[0-9a-f]+)\)" ==
>>> r"^( *#([0-9]+) *)(0x[0-9a-f]+)
Author: Jason Molenda
Date: 2024-03-27T09:25:46-07:00
New Revision: 6a0ec8e25cba9d398cf525889c53835cf40247a3
URL:
https://github.com/llvm/llvm-project/commit/6a0ec8e25cba9d398cf525889c53835cf40247a3
DIFF:
https://github.com/llvm/llvm-project/commit/6a0ec8e25cba9d398cf525889c53835cf40247a3.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hawkinsw wrote:
> The previous diff (and it's subsequent fix) were reverted as the tests didn't
> work properly on the AArch64 & ARM LLDB buildbots. I made a couple more minor
> changes to tests (from @clayborg's feedback) and disabled them for non
> Linux-x86(_64) builds, as I don't have the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kevin Frei (kevinfrei)
Changes
The previous diff (and it's subsequent fix) were reverted as the tests didn't
work properly on the AArch64 ARM LLDB buildbots. I made a couple more
minor changes to tests (from @clayborg's feedback) and
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/86812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/86812
>From 5e3a35bb69b0bd6c3950deaba35a78c085bc5728 Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Mon, 25 Mar 2024 08:23:47 -0700
Subject: [PATCH 1/4] Trying to deal with Linux AArch64 test failures :/
---
https://github.com/kevinfrei edited
https://github.com/llvm/llvm-project/pull/86812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/86812
> The previous diff (and it's subsequent fix) were reverted as the tests didn't
> work properly on the AArch64 & ARM LLDB buildbots. I made a couple more minor
> changes to tests (from @clayborg's feedback)
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
e82765bf07a978674c0e75c8b2e20f154ae24a4c...c7d6289573379be760ca9d691d62e0f87ba0ee8a
https://github.com/ldionne approved this pull request.
Libc++ parts LGTM.
https://github.com/llvm/llvm-project/pull/86806
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/86568
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-03-27T10:33:25-04:00
New Revision: 9f84594e4ef87a50d1599814ba99fb735da76826
URL:
https://github.com/llvm/llvm-project/commit/9f84594e4ef87a50d1599814ba99fb735da76826
DIFF:
https://github.com/llvm/llvm-project/commit/9f84594e4ef87a50d1599814ba99fb735da76826.diff
llvmbot wrote:
@llvm/pr-subscribers-libcxx
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-mlir
Author: None (AngryLoki)
Changes
This fixes "SyntaxWarning: invalid escape sequence" and "SyntaxWarning: "is"
with 'int' literal",
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
Author: Felipe de Azevedo Piovezan
Date: 2024-03-27T07:02:12-07:00
New Revision: 2cb7ea1553a5c7be81bee4ed3c51b7727b9d2ee8
URL:
https://github.com/llvm/llvm-project/commit/2cb7ea1553a5c7be81bee4ed3c51b7727b9d2ee8
DIFF:
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/86740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/86770
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
50 matches
Mail list logo
