[Lldb-commits] [lldb] 41dc04e - [lldb] Add swig doc for SBProcess address mask methods

2024-04-08 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2024-04-08T18:56:39-07:00 New Revision: 41dc04e5283adef9979cad2b126ab3e6c156034a URL: https://github.com/llvm/llvm-project/commit/41dc04e5283adef9979cad2b126ab3e6c156034a DIFF: https://github.com/llvm/llvm-project/commit/41dc04e5283adef9979cad2b126ab3e6c156034a.diff

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

2024-04-08 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/88073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e35fb3f - [lldb] [NFC] Fix swig docstring annotations (#88073)

2024-04-08 Thread via lldb-commits
Author: Jason Molenda Date: 2024-04-08T17:57:35-07:00 New Revision: e35fb3fb8bfcb732ace3738f9589989b3fac1508 URL: https://github.com/llvm/llvm-project/commit/e35fb3fb8bfcb732ace3738f9589989b3fac1508 DIFF: https://github.com/llvm/llvm-project/commit/e35fb3fb8bfcb732ace3738f9589989b3fac1508.diff

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

2024-04-08 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Good catch, that matches the [documentation](https://www.swig.org/Doc4.0/Python.html#Python_nn70). LGTM! https://github.com/llvm/llvm-project/pull/88073 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

2024-04-08 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: An example of the difference in the output this makes for `script help (lldb.SBProcess)`. Old: ``` | PutSTDIN(self, src) | Writes data into the current process's stdin. API client specifies a Python | string as the only argument. ``` new: ``` |

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

2024-04-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes Some of the SB API method description docstrings for swing are annotated as `%feature("autodoc")` - but `"autodoc"` annotations are only to substitute a string showing the arguments and return

[Lldb-commits] [lldb] [lldb] [NFC] Fix swig docstring annotations (PR #88073)

2024-04-08 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/88073 Some of the SB API method description docstrings for swing are annotated as `%feature("autodoc")` - but `"autodoc"` annotations are only to substitute a string showing the arguments and return variables -

[Lldb-commits] [lldb] [lldb][sbdebugger] Match progress category enum bit in Debugger.h (PR #87409)

2024-04-08 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/87409 >From 7561d03d775822f789a61a5b827dfa04b29b57b2 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 2 Apr 2024 13:22:15 -0700 Subject: [PATCH 1/2] [lldb][sbdebugger] Match progress category enum bit

[Lldb-commits] [lldb] [lldb][TypeSynthetic][NFC] Make SyntheticChildrenFrontend::Update() return an enum (PR #80167)

2024-04-08 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @Michael137 I'm a little late to the party but I just noticed that `ChildCacheState` is the only `enum class` in `lldb-enumerations.h`. Is that intentional? Is there a reason this cannot be a old-school enum like everything else in that file? I don't feel super strongly

[Lldb-commits] [lldb] Fix error in unrecognized register name handling for "SBFrame.register" (PR #88047)

2024-04-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 5b959310b0fae723bd119ed8815bf1cb1a8c67d4...d1336d9f8877c45dfd9a427eaa900f5208153de1

[Lldb-commits] [lldb] Fix error in unrecognized register name handling for "SBFrame.register" (PR #88047)

2024-04-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The code returned lldb.SBValue() when you passed in an unrecognized variable name. But referring to "lldb" is apparently not legal within the module. I changed this to just return SBValue(), but then this

[Lldb-commits] [lldb] Fix error in unrecognized register name handling for "SBFrame.register" (PR #88047)

2024-04-08 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/88047 The code returned lldb.SBValue() when you passed in an unrecognized variable name. But referring to "lldb" is apparently not legal within the module. I changed this to just return SBValue(), but then this

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
cmtice wrote: I think I've addressed all the review comments for GetValueAsAPSInt, GetValueAsAPFloat, GetValueAsBool, UpdateIntegerValue (not SetValueFromInteger) and GetLoadAddress. I apologize if I missed anything. Please take another look at those functions. I'm still working on fixing

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/2] [LLDB] Add more helper functions to ValueObject class.

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-04-08 Thread via lldb-commits
@@ -36,9 +36,7 @@ DAP::DAP() {{"cpp_catch", "C++ Catch", lldb::eLanguageTypeC_plus_plus}, {"cpp_throw", "C++ Throw", lldb::eLanguageTypeC_plus_plus}, {"objc_catch", "Objective-C Catch", lldb::eLanguageTypeObjC}, - {"objc_throw",

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-08 Thread James Henderson via lldb-commits
https://github.com/jh7370 commented: As I think I mentioned in the original RFC, I'm not convinced the core functionality for this belongs in LLDB. In my view, LLDB is a client that should make use of a common telemetry library that can be used by other parts of the wider LLVM toolchain, or

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-08 Thread James Henderson via lldb-commits
@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-08 Thread James Henderson via lldb-commits
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/87815 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RFC][LLDB] Telemetry in LLDB (PR #87815)

2024-04-08 Thread James Henderson via lldb-commits
@@ -0,0 +1,237 @@ +#ifndef LLDB_CORE_TELEMETRY_H +#define LLDB_CORE_TELEMETRY_H + +#include +#include +#include +#include +#include + +#include "lldb/Interpreter/CommandReturnObject.h" +#include "lldb/Utility/StructuredData.h" +#include "lldb/lldb-forward.h" +#include

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::APSInt ValueObject::GetValueAsAPSInt() { + lldb::TargetSP target = GetTargetSP(); + uint64_t byte_size = 0; + if (auto temp =

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::APSInt ValueObject::GetValueAsAPSInt() { + lldb::TargetSP target = GetTargetSP(); + uint64_t byte_size = 0; + if (auto temp =

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::APSInt ValueObject::GetValueAsAPSInt() { + lldb::TargetSP target = GetTargetSP(); + uint64_t byte_size = 0; + if (auto temp =

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-08 Thread via lldb-commits
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t fail_value, bool *success) { return fail_value; } +llvm::APSInt ValueObject::GetValueAsAPSInt() { + lldb::TargetSP target = GetTargetSP(); + uint64_t byte_size = 0; + if (auto temp =